All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	tony.luck@gmail.com, Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] build error: allnoconfig fails on mincore/swapper_space
Date: Wed, 14 Feb 2007 20:10:14 +1100	[thread overview]
Message-ID: <45D2D1F6.1020303@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0702140727180.4224@blonde.wat.veritas.com>

Hugh Dickins wrote:
> On Wed, 14 Feb 2007, Nick Piggin wrote:
> 
>>Can't you have migration without swap?
> 
> 
> Yes: but then the only swap entry it can find (short of page
> table corruption, which isn't really the focus of mincore)
> is a migration entry, isn't it?

Just doesn't seem logical to have CONFIG_SWAP ifdef cover the
whole thing, regardless that it produces the desired result.

I'm going to submit a fixup patch to Linus covering all this
stuff, after making a more comprehensive test case (yes I
actually did test this patch with a few different cases before
submitting it, so I must have been unlucky with uninitialised
data).

If he wants to apply it rather than back out the patch entirely,
its up to him.

I don't think there is any reason to panic. I did completely
forget the result vector, but AFAIKS that's the only real bug
in it.

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	tony.luck@gmail.com, Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] build error: allnoconfig fails on mincore/swapper_space
Date: Wed, 14 Feb 2007 20:10:14 +1100	[thread overview]
Message-ID: <45D2D1F6.1020303@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0702140727180.4224@blonde.wat.veritas.com>

Hugh Dickins wrote:
> On Wed, 14 Feb 2007, Nick Piggin wrote:
> 
>>Can't you have migration without swap?
> 
> 
> Yes: but then the only swap entry it can find (short of page
> table corruption, which isn't really the focus of mincore)
> is a migration entry, isn't it?

Just doesn't seem logical to have CONFIG_SWAP ifdef cover the
whole thing, regardless that it produces the desired result.

I'm going to submit a fixup patch to Linus covering all this
stuff, after making a more comprehensive test case (yes I
actually did test this patch with a few different cases before
submitting it, so I must have been unlucky with uninitialised
data).

If he wants to apply it rather than back out the patch entirely,
its up to him.

I don't think there is any reason to panic. I did completely
forget the result vector, but AFAIKS that's the only real bug
in it.

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-02-14  9:10 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-12 22:50 build error: allnoconfig fails on mincore/swapper_space Randy Dunlap
2007-02-12 22:50 ` Randy Dunlap
2007-02-12 23:08 ` Andrew Morton
2007-02-12 23:08   ` Andrew Morton
2007-02-12 23:06   ` Randy Dunlap
2007-02-13  0:26     ` Tony Luck
2007-02-13  0:26       ` Tony Luck
2007-02-13  2:48   ` Nick Piggin
2007-02-13  2:48     ` Nick Piggin
2007-02-13 20:12     ` [patch] " Randy Dunlap
2007-02-13 20:12       ` Randy Dunlap
2007-02-13 22:40       ` Hugh Dickins
2007-02-13 22:40         ` Hugh Dickins
2007-02-13 22:49         ` Randy Dunlap
2007-02-13 22:49           ` Randy Dunlap
2007-02-14  0:19           ` Hugh Dickins
2007-02-14  0:19             ` Hugh Dickins
2007-02-14  1:33             ` Nick Piggin
2007-02-14  1:33               ` Nick Piggin
2007-02-14  7:31               ` Hugh Dickins
2007-02-14  7:31                 ` Hugh Dickins
2007-02-14  9:10                 ` Nick Piggin [this message]
2007-02-14  9:10                   ` Nick Piggin
2007-02-14 19:02               ` Christoph Lameter
2007-02-14 19:02                 ` Christoph Lameter
2007-02-15 16:55             ` Randy Dunlap
2007-02-15 16:55               ` Randy Dunlap
2007-02-15 17:58               ` Linus Torvalds
2007-02-15 17:58                 ` Linus Torvalds
2007-02-15 18:16                 ` Jeff Garzik
2007-02-15 18:16                   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D2D1F6.1020303@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=randy.dunlap@oracle.com \
    --cc=tony.luck@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.