All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/3] xen: drop preempt_count() for non-debug builds
Date: Wed, 22 May 2019 11:39:51 +0100	[thread overview]
Message-ID: <45de0f3d-96cd-aa06-635e-5f825a63eff2@citrix.com> (raw)
In-Reply-To: <5CE521ED02000078002314AA@prv1-mh.provo.novell.com>

On 22/05/2019 11:18, Jan Beulich wrote:
>>>> On 22.05.19 at 12:00, <andrew.cooper3@citrix.com> wrote:
>> On 22/05/2019 10:45, Juergen Gross wrote:
>>> preempt_count() and the associated per-cpu variable __preempt_count
>>> are tested in debug build only. So drop them for non-debug builds.
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> I'd be tempted to fold patches 2 and 3 together, because they are both
>> the same change, and it would reduce the churn.
>>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>, ideally with the
>> two folded into one.
> I'm a little surprised by this: Wasn't it you who generally
> wanted what ASSERT() expands to (controlled by NDEBUG)
> be independent of CONFIG_DEBUG, at some point down
> the road?

In some ideal world yes, but what is rather more important is actually
having optimisation control unrelated to NDEBUG.

> Aren't you even having ASSERT()s enabled in
> release builds of XenServer, or am I misremembering? If so
> patch 3 would move us in the wrong direction.

We build and ship a debug and a release hypervisor.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH 2/3] xen: drop preempt_count() for non-debug builds
Date: Wed, 22 May 2019 11:39:51 +0100	[thread overview]
Message-ID: <45de0f3d-96cd-aa06-635e-5f825a63eff2@citrix.com> (raw)
Message-ID: <20190522103951.DcArNPKBas3BnFDrTARM9UKYpfn-57kjTlm3aYYoczQ@z> (raw)
In-Reply-To: <5CE521ED02000078002314AA@prv1-mh.provo.novell.com>

On 22/05/2019 11:18, Jan Beulich wrote:
>>>> On 22.05.19 at 12:00, <andrew.cooper3@citrix.com> wrote:
>> On 22/05/2019 10:45, Juergen Gross wrote:
>>> preempt_count() and the associated per-cpu variable __preempt_count
>>> are tested in debug build only. So drop them for non-debug builds.
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> I'd be tempted to fold patches 2 and 3 together, because they are both
>> the same change, and it would reduce the churn.
>>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>, ideally with the
>> two folded into one.
> I'm a little surprised by this: Wasn't it you who generally
> wanted what ASSERT() expands to (controlled by NDEBUG)
> be independent of CONFIG_DEBUG, at some point down
> the road?

In some ideal world yes, but what is rather more important is actually
having optimisation control unrelated to NDEBUG.

> Aren't you even having ASSERT()s enabled in
> release builds of XenServer, or am I misremembering? If so
> patch 3 would move us in the wrong direction.

We build and ship a debug and a release hypervisor.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-05-22 10:40 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22  9:45 [PATCH 0/3] tune preempt_[dis|en]able() Juergen Gross
2019-05-22  9:45 ` [Xen-devel] " Juergen Gross
2019-05-22  9:45 ` [PATCH 1/3] xen: drop in_atomic() Juergen Gross
2019-05-22  9:45   ` [Xen-devel] " Juergen Gross
2019-05-22  9:58   ` Andrew Cooper
2019-05-22  9:58     ` [Xen-devel] " Andrew Cooper
2019-05-22 10:10   ` Jan Beulich
2019-05-22 10:10     ` [Xen-devel] " Jan Beulich
2019-05-24  5:41     ` Juergen Gross
2019-05-24  5:41       ` [Xen-devel] " Juergen Gross
2019-05-24  6:38       ` Jan Beulich
2019-05-24  6:38         ` [Xen-devel] " Jan Beulich
2019-05-24  8:34         ` Juergen Gross
2019-05-24  8:34           ` [Xen-devel] " Juergen Gross
2019-05-24  8:39           ` Jan Beulich
2019-05-24  8:39             ` [Xen-devel] " Jan Beulich
2019-05-24 12:30             ` Andrew Cooper
2019-05-24 12:30               ` [Xen-devel] " Andrew Cooper
2019-05-24 12:35               ` Jan Beulich
2019-05-24 12:35                 ` [Xen-devel] " Jan Beulich
     [not found]   ` <5CE52014020000780023147E@suse.com>
2019-05-22 10:19     ` Juergen Gross
2019-05-22 10:19       ` [Xen-devel] " Juergen Gross
2019-05-22 12:34       ` Jan Beulich
2019-05-22 12:34         ` [Xen-devel] " Jan Beulich
2019-05-22  9:45 ` [PATCH 2/3] xen: drop preempt_count() for non-debug builds Juergen Gross
2019-05-22  9:45   ` [Xen-devel] " Juergen Gross
2019-05-22 10:00   ` Andrew Cooper
2019-05-22 10:00     ` [Xen-devel] " Andrew Cooper
2019-05-22 10:17     ` Juergen Gross
2019-05-22 10:17       ` [Xen-devel] " Juergen Gross
2019-05-22 10:18     ` Jan Beulich
2019-05-22 10:18       ` [Xen-devel] " Jan Beulich
2019-05-22 10:39       ` Andrew Cooper [this message]
2019-05-22 10:39         ` Andrew Cooper
2019-05-22 10:12   ` Jan Beulich
2019-05-22 10:12     ` [Xen-devel] " Jan Beulich
     [not found]   ` <5CE5207A0200007800231481@suse.com>
2019-05-22 10:17     ` Juergen Gross
2019-05-22 10:17       ` [Xen-devel] " Juergen Gross
2019-05-22  9:45 ` [PATCH 3/3] xen: build common/preempt.c only with CONFIG_DEBUG Juergen Gross
2019-05-22  9:45   ` [Xen-devel] " Juergen Gross
2019-05-22 10:20 [PATCH 2/3] xen: drop preempt_count() for non-debug builds Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45de0f3d-96cd-aa06-635e-5f825a63eff2@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=jgross@suse.com \
    --cc=julien.grall@arm.com \
    --cc=konrad.wilk@oracle.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.