All of lore.kernel.org
 help / color / mirror / Atom feed
* [groeck-staging:watchdog-next 25/28] drivers/watchdog/da9063_wdt.c:177:15: error: implicit declaration of function 'i2c_smbus_write_byte_data'
@ 2021-11-29 12:24 ` kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-11-29 12:24 UTC (permalink / raw)
  To: Yunus Bas
  Cc: kbuild-all, linux-hwmon, Guenter Roeck, Andrej Picej, Adam Thomson

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git watchdog-next
head:   293903b9dfe43520f01374dc1661be11d6838c49
commit: 5ea29919c29413c984f4ba3e04a6679d306e7a6e [25/28] watchdog: da9063: use atomic safe i2c transfer in reset handler
config: csky-randconfig-r032-20211128 (https://download.01.org/0day-ci/archive/20211129/202111292050.cwhXdxtQ-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?id=5ea29919c29413c984f4ba3e04a6679d306e7a6e
        git remote add groeck-staging https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
        git fetch --no-tags groeck-staging watchdog-next
        git checkout 5ea29919c29413c984f4ba3e04a6679d306e7a6e
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/watchdog/da9063_wdt.c: In function 'da9063_wdt_restart':
>> drivers/watchdog/da9063_wdt.c:177:15: error: implicit declaration of function 'i2c_smbus_write_byte_data' [-Werror=implicit-function-declaration]
     177 |         ret = i2c_smbus_write_byte_data(client, DA9063_REG_CONTROL_F,
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/i2c_smbus_write_byte_data +177 drivers/watchdog/da9063_wdt.c

   168	
   169	static int da9063_wdt_restart(struct watchdog_device *wdd, unsigned long action,
   170				      void *data)
   171	{
   172		struct da9063 *da9063 = watchdog_get_drvdata(wdd);
   173		struct i2c_client *client = to_i2c_client(da9063->dev);
   174		int ret;
   175	
   176		/* Don't use regmap because it is not atomic safe */
 > 177		ret = i2c_smbus_write_byte_data(client, DA9063_REG_CONTROL_F,
   178						DA9063_SHUTDOWN);
   179		if (ret < 0)
   180			dev_alert(da9063->dev, "Failed to shutdown (err = %d)\n",
   181				  ret);
   182	
   183		/* wait for reset to assert... */
   184		mdelay(500);
   185	
   186		return ret;
   187	}
   188	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [groeck-staging:watchdog-next 25/28] drivers/watchdog/da9063_wdt.c:177:15: error: implicit declaration of function 'i2c_smbus_write_byte_data'
@ 2021-11-29 12:24 ` kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-11-29 12:24 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2617 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git watchdog-next
head:   293903b9dfe43520f01374dc1661be11d6838c49
commit: 5ea29919c29413c984f4ba3e04a6679d306e7a6e [25/28] watchdog: da9063: use atomic safe i2c transfer in reset handler
config: csky-randconfig-r032-20211128 (https://download.01.org/0day-ci/archive/20211129/202111292050.cwhXdxtQ-lkp(a)intel.com/config)
compiler: csky-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?id=5ea29919c29413c984f4ba3e04a6679d306e7a6e
        git remote add groeck-staging https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
        git fetch --no-tags groeck-staging watchdog-next
        git checkout 5ea29919c29413c984f4ba3e04a6679d306e7a6e
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/watchdog/da9063_wdt.c: In function 'da9063_wdt_restart':
>> drivers/watchdog/da9063_wdt.c:177:15: error: implicit declaration of function 'i2c_smbus_write_byte_data' [-Werror=implicit-function-declaration]
     177 |         ret = i2c_smbus_write_byte_data(client, DA9063_REG_CONTROL_F,
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/i2c_smbus_write_byte_data +177 drivers/watchdog/da9063_wdt.c

   168	
   169	static int da9063_wdt_restart(struct watchdog_device *wdd, unsigned long action,
   170				      void *data)
   171	{
   172		struct da9063 *da9063 = watchdog_get_drvdata(wdd);
   173		struct i2c_client *client = to_i2c_client(da9063->dev);
   174		int ret;
   175	
   176		/* Don't use regmap because it is not atomic safe */
 > 177		ret = i2c_smbus_write_byte_data(client, DA9063_REG_CONTROL_F,
   178						DA9063_SHUTDOWN);
   179		if (ret < 0)
   180			dev_alert(da9063->dev, "Failed to shutdown (err = %d)\n",
   181				  ret);
   182	
   183		/* wait for reset to assert... */
   184		mdelay(500);
   185	
   186		return ret;
   187	}
   188	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [groeck-staging:watchdog-next 25/28] drivers/watchdog/da9063_wdt.c:177:15: error: implicit declaration of function 'i2c_smbus_write_byte_data'
  2021-11-29 12:24 ` kernel test robot
@ 2021-11-29 13:20   ` Andrej Picej
  -1 siblings, 0 replies; 4+ messages in thread
From: Andrej Picej @ 2021-11-29 13:20 UTC (permalink / raw)
  To: kernel test robot, Yunus Bas
  Cc: kbuild-all, linux-hwmon, Guenter Roeck, Adam Thomson

Hi

On 29. 11. 21 13:24, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git watchdog-next
> head:   293903b9dfe43520f01374dc1661be11d6838c49
> commit: 5ea29919c29413c984f4ba3e04a6679d306e7a6e [25/28] watchdog: da9063: use atomic safe i2c transfer in reset handler
> config: csky-randconfig-r032-20211128 (https://download.01.org/0day-ci/archive/20211129/202111292050.cwhXdxtQ-lkp@intel.com/config)
> compiler: csky-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?id=5ea29919c29413c984f4ba3e04a6679d306e7a6e
>          git remote add groeck-staging https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
>          git fetch --no-tags groeck-staging watchdog-next
>          git checkout 5ea29919c29413c984f4ba3e04a6679d306e7a6e
>          # save the config file to linux build tree
>          mkdir build_dir
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash drivers/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>     drivers/watchdog/da9063_wdt.c: In function 'da9063_wdt_restart':
>>> drivers/watchdog/da9063_wdt.c:177:15: error: implicit declaration of function 'i2c_smbus_write_byte_data' [-Werror=implicit-function-declaration]
>       177 |         ret = i2c_smbus_write_byte_data(client, DA9063_REG_CONTROL_F,
>           |               ^~~~~~~~~~~~~~~~~~~~~~~~~
>     cc1: some warnings being treated as errors
> 
> 
> vim +/i2c_smbus_write_byte_data +177 drivers/watchdog/da9063_wdt.c
> 
>     168	
>     169	static int da9063_wdt_restart(struct watchdog_device *wdd, unsigned long action,
>     170				      void *data)
>     171	{
>     172		struct da9063 *da9063 = watchdog_get_drvdata(wdd);
>     173		struct i2c_client *client = to_i2c_client(da9063->dev);
>     174		int ret;
>     175	
>     176		/* Don't use regmap because it is not atomic safe */
>   > 177		ret = i2c_smbus_write_byte_data(client, DA9063_REG_CONTROL_F,
>     178						DA9063_SHUTDOWN);
>     179		if (ret < 0)
>     180			dev_alert(da9063->dev, "Failed to shutdown (err = %d)\n",
>     181				  ret);
>     182	
>     183		/* wait for reset to assert... */
>     184		mdelay(500);
>     185	
>     186		return ret;
>     187	}
>     188	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> 

This should be fixed if we add hard dependency to I2C. Just like 
44144c809e39 ("watchdog: da9062: Add dependency on I2C") fixes the 
057b52b4b3d58 ("watchdog: da9062: make restart handler atomic safe") on 
the da9062.

I will create a patch and submit it if that's OK.

Sorry for not noticing this problem before submitting the initial patch.

BR,
Andrej

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [groeck-staging:watchdog-next 25/28] drivers/watchdog/da9063_wdt.c:177:15: error: implicit declaration of function 'i2c_smbus_write_byte_data'
@ 2021-11-29 13:20   ` Andrej Picej
  0 siblings, 0 replies; 4+ messages in thread
From: Andrej Picej @ 2021-11-29 13:20 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3186 bytes --]

Hi

On 29. 11. 21 13:24, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git watchdog-next
> head:   293903b9dfe43520f01374dc1661be11d6838c49
> commit: 5ea29919c29413c984f4ba3e04a6679d306e7a6e [25/28] watchdog: da9063: use atomic safe i2c transfer in reset handler
> config: csky-randconfig-r032-20211128 (https://download.01.org/0day-ci/archive/20211129/202111292050.cwhXdxtQ-lkp(a)intel.com/config)
> compiler: csky-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?id=5ea29919c29413c984f4ba3e04a6679d306e7a6e
>          git remote add groeck-staging https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
>          git fetch --no-tags groeck-staging watchdog-next
>          git checkout 5ea29919c29413c984f4ba3e04a6679d306e7a6e
>          # save the config file to linux build tree
>          mkdir build_dir
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=csky SHELL=/bin/bash drivers/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>     drivers/watchdog/da9063_wdt.c: In function 'da9063_wdt_restart':
>>> drivers/watchdog/da9063_wdt.c:177:15: error: implicit declaration of function 'i2c_smbus_write_byte_data' [-Werror=implicit-function-declaration]
>       177 |         ret = i2c_smbus_write_byte_data(client, DA9063_REG_CONTROL_F,
>           |               ^~~~~~~~~~~~~~~~~~~~~~~~~
>     cc1: some warnings being treated as errors
> 
> 
> vim +/i2c_smbus_write_byte_data +177 drivers/watchdog/da9063_wdt.c
> 
>     168	
>     169	static int da9063_wdt_restart(struct watchdog_device *wdd, unsigned long action,
>     170				      void *data)
>     171	{
>     172		struct da9063 *da9063 = watchdog_get_drvdata(wdd);
>     173		struct i2c_client *client = to_i2c_client(da9063->dev);
>     174		int ret;
>     175	
>     176		/* Don't use regmap because it is not atomic safe */
>   > 177		ret = i2c_smbus_write_byte_data(client, DA9063_REG_CONTROL_F,
>     178						DA9063_SHUTDOWN);
>     179		if (ret < 0)
>     180			dev_alert(da9063->dev, "Failed to shutdown (err = %d)\n",
>     181				  ret);
>     182	
>     183		/* wait for reset to assert... */
>     184		mdelay(500);
>     185	
>     186		return ret;
>     187	}
>     188	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
> 

This should be fixed if we add hard dependency to I2C. Just like 
44144c809e39 ("watchdog: da9062: Add dependency on I2C") fixes the 
057b52b4b3d58 ("watchdog: da9062: make restart handler atomic safe") on 
the da9062.

I will create a patch and submit it if that's OK.

Sorry for not noticing this problem before submitting the initial patch.

BR,
Andrej

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-29 14:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-29 12:24 [groeck-staging:watchdog-next 25/28] drivers/watchdog/da9063_wdt.c:177:15: error: implicit declaration of function 'i2c_smbus_write_byte_data' kernel test robot
2021-11-29 12:24 ` kernel test robot
2021-11-29 13:20 ` Andrej Picej
2021-11-29 13:20   ` Andrej Picej

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.