All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Stephen Boyd <swboyd@chromium.org>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH v7 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml
Date: Thu, 22 Sep 2022 13:41:58 +0200	[thread overview]
Message-ID: <4841c705-0944-9e94-1ade-47ad2f462303@linaro.org> (raw)
In-Reply-To: <CAA8EJppRdrfy5vPuLxH0+=DAELdadK4h6X0xmHA01rySoBFN7g@mail.gmail.com>

On 22/09/2022 09:50, Dmitry Baryshkov wrote:
> On Thu, 22 Sept 2022 at 10:02, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 15/09/2022 15:37, Dmitry Baryshkov wrote:
>>> Move properties common to all DPU DT nodes to the dpu-common.yaml.
>>>
>>> Note, this removes description of individual DPU port@ nodes. However
>>> such definitions add no additional value. The reg values do not
>>> correspond to hardware INTF indices. The driver discovers and binds
>>> these ports not paying any care for the order of these items. Thus just
>>> leave the reference to graph.yaml#/properties/ports and the description.
>>
>> This is okay, but you loose required:ports@[01].
> 
> This is fine for me. The ports do not have 1:1 correspondence to
> intfs. Usually platforms add ports as new sinks are added. For example
> a platform can start with a single DSI node and later get second DSI,
> DP, eDP, etc. as they are receiving support/required by end-user
> devices.

Then at least port@0 would be required. Node without ports does not look
correct.

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Rob Herring <robh+dt@kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Andy Gross <agross@kernel.org>,
	dri-devel@lists.freedesktop.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	freedreno@lists.freedesktop.org, Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v7 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml
Date: Thu, 22 Sep 2022 13:41:58 +0200	[thread overview]
Message-ID: <4841c705-0944-9e94-1ade-47ad2f462303@linaro.org> (raw)
In-Reply-To: <CAA8EJppRdrfy5vPuLxH0+=DAELdadK4h6X0xmHA01rySoBFN7g@mail.gmail.com>

On 22/09/2022 09:50, Dmitry Baryshkov wrote:
> On Thu, 22 Sept 2022 at 10:02, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 15/09/2022 15:37, Dmitry Baryshkov wrote:
>>> Move properties common to all DPU DT nodes to the dpu-common.yaml.
>>>
>>> Note, this removes description of individual DPU port@ nodes. However
>>> such definitions add no additional value. The reg values do not
>>> correspond to hardware INTF indices. The driver discovers and binds
>>> these ports not paying any care for the order of these items. Thus just
>>> leave the reference to graph.yaml#/properties/ports and the description.
>>
>> This is okay, but you loose required:ports@[01].
> 
> This is fine for me. The ports do not have 1:1 correspondence to
> intfs. Usually platforms add ports as new sinks are added. For example
> a platform can start with a single DSI node and later get second DSI,
> DP, eDP, etc. as they are receiving support/required by end-user
> devices.

Then at least port@0 would be required. Node without ports does not look
correct.

Best regards,
Krzysztof


  reply	other threads:[~2022-09-22 11:42 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 13:37 [PATCH v7 00/12] dt-bindings: display/msm: rework MDSS and DPU bindings Dmitry Baryshkov
2022-09-15 13:37 ` Dmitry Baryshkov
2022-09-15 13:37 ` [PATCH v7 01/12] dt-bindings: display/msm: split qcom,mdss bindings Dmitry Baryshkov
2022-09-15 13:37   ` Dmitry Baryshkov
2022-09-15 13:37 ` [PATCH v7 02/12] dt-bindings: display/msm: add gcc-bus clock to dpu-smd845 Dmitry Baryshkov
2022-09-15 13:37   ` Dmitry Baryshkov
2022-09-15 13:37 ` [PATCH v7 03/12] dt-bindings: display/msm: add interconnects property to qcom,mdss-smd845 Dmitry Baryshkov
2022-09-15 13:37   ` [PATCH v7 03/12] dt-bindings: display/msm: add interconnects property to qcom, mdss-smd845 Dmitry Baryshkov
2022-09-22  7:00   ` [PATCH v7 03/12] dt-bindings: display/msm: add interconnects property to qcom,mdss-smd845 Krzysztof Kozlowski
2022-09-22  7:00     ` Krzysztof Kozlowski
2022-09-15 13:37 ` [PATCH v7 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml Dmitry Baryshkov
2022-09-15 13:37   ` Dmitry Baryshkov
2022-09-22  7:02   ` Krzysztof Kozlowski
2022-09-22  7:02     ` Krzysztof Kozlowski
2022-09-22  7:50     ` Dmitry Baryshkov
2022-09-22  7:50       ` Dmitry Baryshkov
2022-09-22 11:41       ` Krzysztof Kozlowski [this message]
2022-09-22 11:41         ` Krzysztof Kozlowski
2022-09-15 13:37 ` [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml Dmitry Baryshkov
2022-09-15 13:37   ` Dmitry Baryshkov
2022-09-22  7:04   ` Krzysztof Kozlowski
2022-09-22  7:04     ` Krzysztof Kozlowski
2022-09-22 11:46     ` Dmitry Baryshkov
2022-09-22 11:46       ` Dmitry Baryshkov
2022-09-22 12:28       ` Krzysztof Kozlowski
2022-09-22 12:28         ` Krzysztof Kozlowski
2022-09-23 20:32         ` Dmitry Baryshkov
2022-09-23 20:32           ` Dmitry Baryshkov
2022-10-03  7:55           ` Krzysztof Kozlowski
2022-10-03  7:55             ` Krzysztof Kozlowski
2022-09-22  7:05   ` Krzysztof Kozlowski
2022-09-22  7:05     ` Krzysztof Kozlowski
2022-09-22  7:53     ` Dmitry Baryshkov
2022-09-22  7:53       ` Dmitry Baryshkov
2022-09-22 11:43       ` Krzysztof Kozlowski
2022-09-22 11:43         ` Krzysztof Kozlowski
2022-09-22 11:47         ` Dmitry Baryshkov
2022-09-22 11:47           ` Dmitry Baryshkov
2022-09-22 12:27           ` Krzysztof Kozlowski
2022-09-22 12:27             ` Krzysztof Kozlowski
2022-09-15 13:37 ` [PATCH v7 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts Dmitry Baryshkov
2022-09-15 13:37   ` Dmitry Baryshkov
2022-09-22  7:08   ` Krzysztof Kozlowski
2022-09-22  7:08     ` Krzysztof Kozlowski
2022-09-22 10:30     ` Dmitry Baryshkov
2022-09-22 10:30       ` Dmitry Baryshkov
2022-09-22 12:19       ` Krzysztof Kozlowski
2022-09-22 12:19         ` Krzysztof Kozlowski
2022-09-15 13:37 ` [PATCH v7 07/12] dt-bindings: display/msm: split dpu-sc7280 " Dmitry Baryshkov
2022-09-15 13:37   ` Dmitry Baryshkov
2022-09-15 13:37 ` [PATCH v7 08/12] dt-bindings: display/msm: split dpu-sdm845 " Dmitry Baryshkov
2022-09-15 13:37   ` Dmitry Baryshkov
2022-09-15 13:37 ` [PATCH v7 09/12] dt-bindings: display/msm: split dpu-msm8998 " Dmitry Baryshkov
2022-09-15 13:37   ` Dmitry Baryshkov
2022-09-15 13:37 ` [PATCH v7 10/12] dt-bindings: display/msm: split dpu-qcm2290 " Dmitry Baryshkov
2022-09-15 13:37   ` Dmitry Baryshkov
2022-09-15 13:37 ` [PATCH v7 11/12] dt-bindings: display/msm: add missing device nodes to mdss-* schemas Dmitry Baryshkov
2022-09-15 13:37   ` Dmitry Baryshkov
2022-09-22  7:09   ` Krzysztof Kozlowski
2022-09-22  7:09     ` Krzysztof Kozlowski
2022-09-15 13:37 ` [PATCH v7 12/12] dt-bindings: display/msm: add support for the display on SM8250 Dmitry Baryshkov
2022-09-15 13:37   ` Dmitry Baryshkov
2022-09-22  7:10   ` Krzysztof Kozlowski
2022-09-22  7:10     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4841c705-0944-9e94-1ade-47ad2f462303@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=airlied@linux.ie \
    --cc=andersson@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.