* [Qemu-devel] [PATCH] Incorrect MBAR offset for an5206 UART2 output port bit set
@ 2009-06-12 20:51 Evan Goldenberg
2009-06-13 22:15 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Evan Goldenberg @ 2009-06-12 20:51 UTC (permalink / raw)
To: qemu-devel
The MBAR offset for the UART2 output port bit set function on the
an5206 board, though unimplemented, is incorrectly defined as 0x1c8.
The correct offset used by the hardware for this function is 0x1b8.
This typo causes QEMU to crash whenever attempts to access use UART2
are made:
qemu: fatal: Bad MBAR write offset 0x1b8
The following patch resolves this issue.
diff --git a/hw/mcf5206.c b/hw/mcf5206.c
index b570376..8bf11a4 100644
--- a/hw/mcf5206.c
+++ b/hw/mcf5206.c
@@ -341,7 +341,7 @@ static void m5206_mbar_write(m5206_mbar_state *s,
uint32_t offset,
case 0x170:
s->uivr[0] = value;
break;
- case 0x178: case 0x17c: case 0x1c8: case 0x1bc:
+ case 0x178: case 0x17c: case 0x1b8: case 0x1bc:
/* Not implemented: UART Output port bits. */
break;
case 0x1b0:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] Incorrect MBAR offset for an5206 UART2 output port bit set
2009-06-12 20:51 [Qemu-devel] [PATCH] Incorrect MBAR offset for an5206 UART2 output port bit set Evan Goldenberg
@ 2009-06-13 22:15 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2009-06-13 22:15 UTC (permalink / raw)
To: Evan Goldenberg; +Cc: qemu-devel
Evan Goldenberg wrote:
> The MBAR offset for the UART2 output port bit set function on the
> an5206 board, though unimplemented, is incorrectly defined as 0x1c8.
> The correct offset used by the hardware for this function is 0x1b8.
> This typo causes QEMU to crash whenever attempts to access use UART2
> are made:
>
> qemu: fatal: Bad MBAR write offset 0x1b8
>
> The following patch resolves this issue.
>
> diff --git a/hw/mcf5206.c b/hw/mcf5206.c
> index b570376..8bf11a4 100644
> --- a/hw/mcf5206.c
> +++ b/hw/mcf5206.c
> @@ -341,7 +341,7 @@ static void m5206_mbar_write(m5206_mbar_state *s,
> uint32_t offset,
>
This is whitespace damaged.
> case 0x170:
> s->uivr[0] = value;
> break;
> - case 0x178: case 0x17c: case 0x1c8: case 0x1bc:
> + case 0x178: case 0x17c: case 0x1b8: case 0x1bc:
> /* Not implemented: UART Output port bits. */
> break;
> case 0x1b0:
>
>
>
>
--
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-13 22:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-12 20:51 [Qemu-devel] [PATCH] Incorrect MBAR offset for an5206 UART2 output port bit set Evan Goldenberg
2009-06-13 22:15 ` Anthony Liguori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.