* [PATCH] x86: use zalloc_cpumask_var for mce_devinitialized
@ 2009-06-17 21:42 Yinghai Lu
2009-06-17 21:43 ` [PATCH] x86: mce fix type Yinghai Lu
2009-06-17 23:21 ` [PATCH] x86: use zalloc_cpumask_var for mce_dev_initialized -v2 Yinghai Lu
0 siblings, 2 replies; 5+ messages in thread
From: Yinghai Lu @ 2009-06-17 21:42 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner, H. Peter Anvin, Rusty Russell,
Andrew Morton
Cc: linux-kernel
to make MAXSMP happy
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/x86/kernel/cpu/mcheck/mce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/arch/x86/kernel/cpu/mcheck/mce.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/cpu/mcheck/mce.c
+++ linux-2.6/arch/x86/kernel/cpu/mcheck/mce.c
@@ -1969,7 +1969,7 @@ static __init int mce_init_device(void)
if (!mce_available(&boot_cpu_data))
return -EIO;
- alloc_cpumask_var(&mce_dev_initialized, GFP_KERNEL);
+ zalloc_cpumask_var(&mce_dev_initialized, GFP_KERNEL);
err = mce_init_banks();
if (err)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] x86: mce fix type
2009-06-17 21:42 [PATCH] x86: use zalloc_cpumask_var for mce_devinitialized Yinghai Lu
@ 2009-06-17 21:43 ` Yinghai Lu
2009-06-18 1:56 ` Hidetoshi Seto
2009-06-17 23:21 ` [PATCH] x86: use zalloc_cpumask_var for mce_dev_initialized -v2 Yinghai Lu
1 sibling, 1 reply; 5+ messages in thread
From: Yinghai Lu @ 2009-06-17 21:43 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner, H. Peter Anvin, Rusty Russell,
Andrew Morton
Cc: linux-kernel
can not have two ignore_ce
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/x86/kernel/cpu/mcheck/mce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/arch/x86/kernel/cpu/mcheck/mce.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/cpu/mcheck/mce.c
+++ linux-2.6/arch/x86/kernel/cpu/mcheck/mce.c
@@ -1777,7 +1777,7 @@ static struct sysdev_ext_attribute attr_
};
static struct sysdev_ext_attribute attr_cmci_disabled = {
- _SYSDEV_ATTR(ignore_ce, 0644, sysdev_show_int, set_cmci_disabled),
+ _SYSDEV_ATTR(cmci_disabled, 0644, sysdev_show_int, set_cmci_disabled),
&mce_cmci_disabled
};
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] x86: use zalloc_cpumask_var for mce_dev_initialized -v2
2009-06-17 21:42 [PATCH] x86: use zalloc_cpumask_var for mce_devinitialized Yinghai Lu
2009-06-17 21:43 ` [PATCH] x86: mce fix type Yinghai Lu
@ 2009-06-17 23:21 ` Yinghai Lu
2009-06-18 1:59 ` Hidetoshi Seto
1 sibling, 1 reply; 5+ messages in thread
From: Yinghai Lu @ 2009-06-17 23:21 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner, H. Peter Anvin, Rusty Russell,
Andrew Morton
Cc: linux-kernel
need to get cleared cpu_mask about if mce device is initialized.
esp when MAXSMP is used.
used zalloc_... instead
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: stable@kernel.org
---
arch/x86/kernel/cpu/mcheck/mce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/arch/x86/kernel/cpu/mcheck/mce.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/cpu/mcheck/mce.c
+++ linux-2.6/arch/x86/kernel/cpu/mcheck/mce.c
@@ -1969,7 +1969,7 @@ static __init int mce_init_device(void)
if (!mce_available(&boot_cpu_data))
return -EIO;
- alloc_cpumask_var(&mce_dev_initialized, GFP_KERNEL);
+ zalloc_cpumask_var(&mce_dev_initialized, GFP_KERNEL);
err = mce_init_banks();
if (err)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86: mce fix type
2009-06-17 21:43 ` [PATCH] x86: mce fix type Yinghai Lu
@ 2009-06-18 1:56 ` Hidetoshi Seto
0 siblings, 0 replies; 5+ messages in thread
From: Hidetoshi Seto @ 2009-06-18 1:56 UTC (permalink / raw)
To: Yinghai Lu
Cc: Ingo Molnar, Thomas Gleixner, H. Peter Anvin, Rusty Russell,
Andrew Morton, linux-kernel
Yinghai Lu wrote:
> can not have two ignore_ce
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Thank you for finding it!
Acked-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86: use zalloc_cpumask_var for mce_dev_initialized -v2
2009-06-17 23:21 ` [PATCH] x86: use zalloc_cpumask_var for mce_dev_initialized -v2 Yinghai Lu
@ 2009-06-18 1:59 ` Hidetoshi Seto
0 siblings, 0 replies; 5+ messages in thread
From: Hidetoshi Seto @ 2009-06-18 1:59 UTC (permalink / raw)
To: Yinghai Lu
Cc: Ingo Molnar, Thomas Gleixner, H. Peter Anvin, Rusty Russell,
Andrew Morton, linux-kernel
Yinghai Lu wrote:
> need to get cleared cpu_mask about if mce device is initialized.
> esp when MAXSMP is used.
>
> used zalloc_... instead
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> Cc: stable@kernel.org
Good catch!
Reviewed-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-06-18 1:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-17 21:42 [PATCH] x86: use zalloc_cpumask_var for mce_devinitialized Yinghai Lu
2009-06-17 21:43 ` [PATCH] x86: mce fix type Yinghai Lu
2009-06-18 1:56 ` Hidetoshi Seto
2009-06-17 23:21 ` [PATCH] x86: use zalloc_cpumask_var for mce_dev_initialized -v2 Yinghai Lu
2009-06-18 1:59 ` Hidetoshi Seto
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.