* [PATCH] powerpc/ps3: Use pr_devel() in ps3/mm.c
@ 2009-06-23 1:56 Michael Ellerman
2009-06-23 16:53 ` Geoff Levand
0 siblings, 1 reply; 3+ messages in thread
From: Michael Ellerman @ 2009-06-23 1:56 UTC (permalink / raw)
To: linuxppc-dev
The non-debug case in ps3/mm.c uses pr_debug(), so that the compiler
still does type checks etc. and doesn't complain about unused
variables in the non-debug case.
However with DEBUG=n and CONFIG_DYNAMIC_DEBUG=y there's still code
generated for those pr_debugs().
size before:
text data bss dec hex filename
17553 4112 88 21753 54f9 arch/powerpc/platforms/ps3/mm.o
size after:
text data bss dec hex filename
7377 776 88 8241 2031 arch/powerpc/platforms/ps3/mm.o
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
arch/powerpc/platforms/ps3/mm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/platforms/ps3/mm.c b/arch/powerpc/platforms/ps3/mm.c
index 846eb8b..68f1397 100644
--- a/arch/powerpc/platforms/ps3/mm.c
+++ b/arch/powerpc/platforms/ps3/mm.c
@@ -34,7 +34,7 @@
#if defined(DEBUG)
#define DBG udbg_printf
#else
-#define DBG pr_debug
+#define DBG pr_devel
#endif
enum {
--
1.6.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/ps3: Use pr_devel() in ps3/mm.c
2009-06-23 1:56 [PATCH] powerpc/ps3: Use pr_devel() in ps3/mm.c Michael Ellerman
@ 2009-06-23 16:53 ` Geoff Levand
2009-06-24 0:55 ` Michael Ellerman
0 siblings, 1 reply; 3+ messages in thread
From: Geoff Levand @ 2009-06-23 16:53 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev
On 06/22/2009 06:56 PM, Michael Ellerman wrote:
> The non-debug case in ps3/mm.c uses pr_debug(), so that the compiler
> still does type checks etc. and doesn't complain about unused
> variables in the non-debug case.
>
> However with DEBUG=n and CONFIG_DYNAMIC_DEBUG=y there's still code
> generated for those pr_debugs().
>
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
> ---
> arch/powerpc/platforms/ps3/mm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Looks good, thanks. I put it on the todo list to go through
the the remaining PS3 code to check for the same.
Acked-by: Geoff Levand <geoffrey.levand@am.sony.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/ps3: Use pr_devel() in ps3/mm.c
2009-06-23 16:53 ` Geoff Levand
@ 2009-06-24 0:55 ` Michael Ellerman
0 siblings, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2009-06-24 0:55 UTC (permalink / raw)
To: Geoff Levand; +Cc: linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
On Tue, 2009-06-23 at 09:53 -0700, Geoff Levand wrote:
> On 06/22/2009 06:56 PM, Michael Ellerman wrote:
> > The non-debug case in ps3/mm.c uses pr_debug(), so that the compiler
> > still does type checks etc. and doesn't complain about unused
> > variables in the non-debug case.
> >
> > However with DEBUG=n and CONFIG_DYNAMIC_DEBUG=y there's still code
> > generated for those pr_debugs().
> >
> > Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
> > ---
> > arch/powerpc/platforms/ps3/mm.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Looks good, thanks. I put it on the todo list to go through
> the the remaining PS3 code to check for the same.
Cool, I've been slowly going through as I have time but I'll leave ps3
to you. I see ~270 uses in 9 files.
There are places where being able to dynamically enable the debug is
useful, but there are plenty where it's not also.
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-24 0:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-23 1:56 [PATCH] powerpc/ps3: Use pr_devel() in ps3/mm.c Michael Ellerman
2009-06-23 16:53 ` Geoff Levand
2009-06-24 0:55 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.