Re: [PATCH -tip -v11 11/11] tracing: Add kprobes event profiling interface

From: Masami Hiramatsu <mhiramat@redhat.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
	lkml <linux-kernel@vger.kernel.org>,
	systemtap <systemtap@sources.redhat.com>,
	kvm <kvm@vger.kernel.org>,
	DLE <dle-develop@lists.sourceforge.net>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Christoph Hellwig <hch@infradead.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Tom Zanussi <tzanussi@gmail.com>
Subject: Re: [PATCH -tip -v11 11/11] tracing: Add kprobes event profiling interface
Date: Fri, 10 Jul 2009 15:59:22 -0400	[thread overview]
Message-ID: <4A579D9A.1010306@redhat.com> (raw)
In-Reply-To: <4A56E3D8.3010806@cn.fujitsu.com>

Hi,

Li Zefan wrote:
>> +Event Profiling
>> +---------------
>> + You can check the total number of probe hits and probe miss-hits via
>> +/sys/kernel/debug/tracing/kprobe_profile.
>> + The fist column is event name, the second is the number of probe hits,
> 
> s/fist/first

Oops, fixed.

> 
>> +the third is the number of probe miss-hits.
>> +
>> +
> ...
>> +/* Probes profiling interfaces */
>> +static int profile_seq_show(struct seq_file *m, void *v)
>> +{
>> +	struct trace_probe *tp = v;
>> +
>> +	if (tp == NULL)
>> +		return 0;
>> +
> 
> tp will never be NULL, which is guaranteed by seq_file

OK, fixed.

>> +	seq_printf(m, "%s", tp->call.name);
>> +
>> +	seq_printf(m, "\t%8lu %8lu\n", tp->nhits,
>> +		   probe_is_return(tp) ? tp->rp.kp.nmissed : tp->kp.nmissed);
>> +
>> +	return 0;
>> +}

Thank you for review!

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com