* [PATCH] external-toolchain: Really accept toolchains built by meta-toolchain.bb
@ 2009-11-22 14:45 Bernhard Kaindl
2009-11-23 15:26 ` Chris Conroy
0 siblings, 1 reply; 5+ messages in thread
From: Bernhard Kaindl @ 2009-11-22 14:45 UTC (permalink / raw)
To: openembedded-devel
external-toolchain-generic,
external-toolchain:
* The current external-toolchain recipes which are documented to accept
toolchains built by meta-toolchain actually do not accept such because
they expect ${prefix}/package-status to exist which is provieded by
the poky toolchains but not the current OE meta-toolchain package.
Fix this by also looking for ${prefix}/usr/lib/opkg/status, which is the
package-status file of the OE meta-toolchain package.
* Also change the error message which is shown when neither file is found
more explicit.
Cc: Denys Dmytriyenko <denis@denix.org>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@gmx.net>
external-toolchain-generic.bb | 4 ++--
external-toolchain.bb | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/recipes/meta/external-toolchain-generic.bb b/recipes/meta/external-toolchain-generic.bb
index 73f823f..13c2392 100644
--- a/recipes/meta/external-toolchain-generic.bb
+++ b/recipes/meta/external-toolchain-generic.bb
@@ -22,8 +22,8 @@ PR = "r2"
inherit sdk
do_stage() {
- if [ ! -e ${prefix}/package-status ]; then
- echo "The external toolchain could not be found in ${prefix}!"
+ if [ ! -e ${prefix}/package-status -a ! -e ${prefix}/usr/lib/opkg/status ]; then
+ echo "The package status file of the external toolchain could not be found in ${prefix}!"
exit 1
fi
diff --git a/recipes/meta/external-toolchain.bb b/recipes/meta/external-toolchain.bb
index 4c70054..21b5e32 100644
--- a/recipes/meta/external-toolchain.bb
+++ b/recipes/meta/external-toolchain.bb
@@ -21,8 +21,8 @@ PR = "r2"
inherit sdk
do_stage() {
- if [ ! -e ${prefix}/package-status ]; then
- echo "The external toolchain could not be found in ${prefix}!"
+ if [ ! -e ${prefix}/package-status -a ! -e ${prefix}/usr/lib/opkg/status ]; then
+ echo "The package status file of the external toolchain could not be found in ${prefix}!"
exit 1
fi
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] external-toolchain: Really accept toolchains built by meta-toolchain.bb
2009-11-22 14:45 [PATCH] external-toolchain: Really accept toolchains built by meta-toolchain.bb Bernhard Kaindl
@ 2009-11-23 15:26 ` Chris Conroy
2009-11-23 17:19 ` Chris Simmonds
0 siblings, 1 reply; 5+ messages in thread
From: Chris Conroy @ 2009-11-23 15:26 UTC (permalink / raw)
To: openembedded-devel
On Sun, 2009-11-22 at 15:45 +0100, Bernhard Kaindl wrote:
> external-toolchain-generic,
> external-toolchain:
>
> * The current external-toolchain recipes which are documented to accept
> toolchains built by meta-toolchain actually do not accept such because
> they expect ${prefix}/package-status to exist which is provieded by
> the poky toolchains but not the current OE meta-toolchain package.
>
> Fix this by also looking for ${prefix}/usr/lib/opkg/status, which is the
> package-status file of the OE meta-toolchain package.
>
> * Also change the error message which is shown when neither file is found
> more explicit.
What about changing the meta-toolchain to generate the environment-setup
script? While it's not important to have the script for normal building
of packages, I've found it helpful to be able to do a quick compile of a
test program here or there. Though, I understand that it might be
dangerous since some folks might think the environment-setup creates an
an entire cross building platform for them when they really want to stay
inside OE....
--Chris
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] external-toolchain: Really accept toolchains built by meta-toolchain.bb
2009-11-23 15:26 ` Chris Conroy
@ 2009-11-23 17:19 ` Chris Simmonds
2009-11-23 18:31 ` Chris Conroy
0 siblings, 1 reply; 5+ messages in thread
From: Chris Simmonds @ 2009-11-23 17:19 UTC (permalink / raw)
To: openembedded-devel
Chris Conroy wrote:
> On Sun, 2009-11-22 at 15:45 +0100, Bernhard Kaindl wrote:
>> external-toolchain-generic,
>> external-toolchain:
>>
>> * The current external-toolchain recipes which are documented to accept
>> toolchains built by meta-toolchain actually do not accept such because
>> they expect ${prefix}/package-status to exist which is provieded by
>> the poky toolchains but not the current OE meta-toolchain package.
>>
>> Fix this by also looking for ${prefix}/usr/lib/opkg/status, which is the
>> package-status file of the OE meta-toolchain package.
>>
>> * Also change the error message which is shown when neither file is found
>> more explicit.
>
> What about changing the meta-toolchain to generate the environment-setup
> script? While it's not important to have the script for normal building
> of packages, I've found it helpful to be able to do a quick compile of a
> test program here or there. Though, I understand that it might be
> dangerous since some folks might think the environment-setup creates an
> an entire cross building platform for them when they really want to stay
> inside OE....
>
> --Chris
meta-toolchain does generate environment-setup and so far as I am aware
it works fine as a stand-alone toolchain. Is there some reason why I
should not be using it as such?
Chris S.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] external-toolchain: Really accept toolchains built by meta-toolchain.bb
2009-11-23 17:19 ` Chris Simmonds
@ 2009-11-23 18:31 ` Chris Conroy
2009-11-23 19:24 ` Chris Simmonds
0 siblings, 1 reply; 5+ messages in thread
From: Chris Conroy @ 2009-11-23 18:31 UTC (permalink / raw)
To: openembedded-devel
On Mon, 2009-11-23 at 17:19 +0000, Chris Simmonds wrote:
> meta-toolchain does generate environment-setup and so far as I am aware
> it works fine as a stand-alone toolchain. Is there some reason why I
> should not be using it as such?
>
> Chris S.
It's fine as just a standalone toolchain. It's just not a "Build
Platform." Meaning, you can't just source it and get all the other
things that OE gives you. This is perhaps too obvious to even warrant
mentioning.
I misinterpreted the original patch since I was comparing against my
local tree, where we've modified to check for environment-setup rather
than package-status (simply as a sanity check for the setting of
${prefix}, so you can safely disregard my previous posting.
--Chris
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] external-toolchain: Really accept toolchains built by meta-toolchain.bb
2009-11-23 18:31 ` Chris Conroy
@ 2009-11-23 19:24 ` Chris Simmonds
0 siblings, 0 replies; 5+ messages in thread
From: Chris Simmonds @ 2009-11-23 19:24 UTC (permalink / raw)
To: openembedded-devel
Chris Conroy wrote:
> On Mon, 2009-11-23 at 17:19 +0000, Chris Simmonds wrote:
>> meta-toolchain does generate environment-setup and so far as I am aware
>> it works fine as a stand-alone toolchain. Is there some reason why I
>> should not be using it as such?
>>
>> Chris S.
>
> It's fine as just a standalone toolchain. It's just not a "Build
> Platform." Meaning, you can't just source it and get all the other
> things that OE gives you. This is perhaps too obvious to even warrant
> mentioning.
>
> I misinterpreted the original patch since I was comparing against my
> local tree, where we've modified to check for environment-setup rather
> than package-status (simply as a sanity check for the setting of
> ${prefix}, so you can safely disregard my previous posting.
>
Phew! Thanks for the clarification.
Chris S.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-11-23 19:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-22 14:45 [PATCH] external-toolchain: Really accept toolchains built by meta-toolchain.bb Bernhard Kaindl
2009-11-23 15:26 ` Chris Conroy
2009-11-23 17:19 ` Chris Simmonds
2009-11-23 18:31 ` Chris Conroy
2009-11-23 19:24 ` Chris Simmonds
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.