From: Anthony Liguori <anthony@codemonkey.ws> To: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> Cc: joro@8bytes.org, paul@codesourcery.com, blauwirbel@gmail.com, avi@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org Subject: Re: [PATCH 0/7] AMD IOMMU emulation patches v3 Date: Sun, 15 Aug 2010 20:47:46 -0500 [thread overview] Message-ID: <4C6898C2.9050104@codemonkey.ws> (raw) In-Reply-To: <1281900442-29971-1-git-send-email-eduard.munteanu@linux360.ro> On 08/15/2010 02:27 PM, Eduard - Gabriel Munteanu wrote: > Hi, > > Please have a look at these and merge if you wish. I hope I've addressed the > issues people have raised. > It's looking pretty good so far. I'm very happy with the modifications to the PCI layer. It looks like given the helpers that you've added, converting the PCI devices is more or less programmatic. IOW, it just requires an appropriate sed. I'd rather see an all-at-once conversion of the PCI devices than just convert over a couple functions. In fact, we can go a step further after that and start poisoning symbols to prevent the wrong interfaces from being used. Regards, Anthony Liguori > Some changes from the previous RFC: > - included and updated the other two device patches > - moved map registration and invalidation management into PCI code > - AMD IOMMU emulation is always enabled (no more configure options) > - cleaned up code, I now use typedefs as suggested > - event logging cleanups > > BTW, the change to pci_regs.h is properly aligned but the original file contains > tabs. > > > Cheers, > Eduard > > Eduard - Gabriel Munteanu (7): > pci: add range_covers_range() > pci: memory access API and IOMMU support > AMD IOMMU emulation > ide: use the PCI memory access interface > rtl8139: use the PCI memory access interface > eepro100: use the PCI memory access interface > ac97: use the PCI memory access interface > > Makefile.target | 2 + > dma-helpers.c | 46 ++++- > dma.h | 21 ++- > hw/ac97.c | 6 +- > hw/amd_iommu.c | 688 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > hw/eepro100.c | 78 ++++--- > hw/ide/core.c | 15 +- > hw/ide/internal.h | 39 +++ > hw/ide/pci.c | 7 + > hw/pc.c | 2 + > hw/pci.c | 197 +++++++++++++++- > hw/pci.h | 84 +++++++ > hw/pci_ids.h | 2 + > hw/pci_regs.h | 1 + > hw/rtl8139.c | 99 +++++---- > qemu-common.h | 1 + > 16 files changed, 1191 insertions(+), 97 deletions(-) > create mode 100644 hw/amd_iommu.c > >
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws> To: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> Cc: kvm@vger.kernel.org, joro@8bytes.org, qemu-devel@nongnu.org, blauwirbel@gmail.com, paul@codesourcery.com, avi@redhat.com Subject: [Qemu-devel] Re: [PATCH 0/7] AMD IOMMU emulation patches v3 Date: Sun, 15 Aug 2010 20:47:46 -0500 [thread overview] Message-ID: <4C6898C2.9050104@codemonkey.ws> (raw) In-Reply-To: <1281900442-29971-1-git-send-email-eduard.munteanu@linux360.ro> On 08/15/2010 02:27 PM, Eduard - Gabriel Munteanu wrote: > Hi, > > Please have a look at these and merge if you wish. I hope I've addressed the > issues people have raised. > It's looking pretty good so far. I'm very happy with the modifications to the PCI layer. It looks like given the helpers that you've added, converting the PCI devices is more or less programmatic. IOW, it just requires an appropriate sed. I'd rather see an all-at-once conversion of the PCI devices than just convert over a couple functions. In fact, we can go a step further after that and start poisoning symbols to prevent the wrong interfaces from being used. Regards, Anthony Liguori > Some changes from the previous RFC: > - included and updated the other two device patches > - moved map registration and invalidation management into PCI code > - AMD IOMMU emulation is always enabled (no more configure options) > - cleaned up code, I now use typedefs as suggested > - event logging cleanups > > BTW, the change to pci_regs.h is properly aligned but the original file contains > tabs. > > > Cheers, > Eduard > > Eduard - Gabriel Munteanu (7): > pci: add range_covers_range() > pci: memory access API and IOMMU support > AMD IOMMU emulation > ide: use the PCI memory access interface > rtl8139: use the PCI memory access interface > eepro100: use the PCI memory access interface > ac97: use the PCI memory access interface > > Makefile.target | 2 + > dma-helpers.c | 46 ++++- > dma.h | 21 ++- > hw/ac97.c | 6 +- > hw/amd_iommu.c | 688 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > hw/eepro100.c | 78 ++++--- > hw/ide/core.c | 15 +- > hw/ide/internal.h | 39 +++ > hw/ide/pci.c | 7 + > hw/pc.c | 2 + > hw/pci.c | 197 +++++++++++++++- > hw/pci.h | 84 +++++++ > hw/pci_ids.h | 2 + > hw/pci_regs.h | 1 + > hw/rtl8139.c | 99 +++++---- > qemu-common.h | 1 + > 16 files changed, 1191 insertions(+), 97 deletions(-) > create mode 100644 hw/amd_iommu.c > >
next prev parent reply other threads:[~2010-08-16 1:47 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-08-15 19:27 [PATCH 0/7] AMD IOMMU emulation patches v3 Eduard - Gabriel Munteanu 2010-08-15 19:27 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-15 19:27 ` [PATCH 1/7] pci: add range_covers_range() Eduard - Gabriel Munteanu 2010-08-15 19:27 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-18 4:39 ` Isaku Yamahata 2010-08-18 4:39 ` Isaku Yamahata 2010-08-15 19:27 ` [PATCH 2/7] pci: memory access API and IOMMU support Eduard - Gabriel Munteanu 2010-08-15 19:27 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-18 5:02 ` Isaku Yamahata 2010-08-18 5:02 ` Isaku Yamahata 2010-08-15 19:27 ` [PATCH 3/7] AMD IOMMU emulation Eduard - Gabriel Munteanu 2010-08-15 19:27 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-16 17:57 ` Blue Swirl 2010-08-16 17:57 ` [Qemu-devel] " Blue Swirl 2010-08-15 19:27 ` [PATCH 4/7] ide: use the PCI memory access interface Eduard - Gabriel Munteanu 2010-08-15 19:27 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-15 19:27 ` [PATCH 5/7] rtl8139: " Eduard - Gabriel Munteanu 2010-08-15 19:27 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-15 19:27 ` [PATCH 6/7] eepro100: " Eduard - Gabriel Munteanu 2010-08-15 19:27 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-15 19:27 ` [PATCH 7/7] ac97: " Eduard - Gabriel Munteanu 2010-08-15 19:27 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-15 20:42 ` malc 2010-08-15 20:42 ` malc 2010-08-16 1:47 ` Anthony Liguori [this message] 2010-08-16 1:47 ` [Qemu-devel] Re: [PATCH 0/7] AMD IOMMU emulation patches v3 Anthony Liguori
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4C6898C2.9050104@codemonkey.ws \ --to=anthony@codemonkey.ws \ --cc=avi@redhat.com \ --cc=blauwirbel@gmail.com \ --cc=eduard.munteanu@linux360.ro \ --cc=joro@8bytes.org \ --cc=kvm@vger.kernel.org \ --cc=paul@codesourcery.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.