From: Eric Sandeen <sandeen@redhat.com> To: Linus Torvalds <torvalds@linux-foundation.org> Cc: "Ted Ts'o" <tytso@mit.edu>, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] Date: Fri, 11 Feb 2011 19:41:41 -0600 [thread overview] Message-ID: <4D55E555.9050409@redhat.com> (raw) In-Reply-To: <AANLkTineDxntR0ZTXdgXrc6qx6pATTORgOwFR5+w5MLN@mail.gmail.com> On 2/11/11 6:33 PM, Linus Torvalds wrote: > On Fri, Feb 11, 2011 at 5:40 AM, Ted Ts'o <tytso@mit.edu> wrote: >> >> Please pull from: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git for_linus >> >> to get regression and bug fixes for 2.6.38. >> >> Eric Sandeen (3): >> ext4: serialize unaligned asynchronous DIO > > This is a completely disgusting patch, and it causes warnings like this: > fs/ext4/file.c: In function ‘ext4_aiodio_wait’: > fs/ext4/file.c:60:44: warning: cast from pointer to integer of different size > > because that disgusting patch does things like > > #define ext4_aio_mutex(v) (&ext4__aio_mutex[((unsigned)v) % EXT4_WQ_HASH_SZ]) Well crap, the patch I sent Ted did not cause warnings. OTOH, I eyeballed his changes to my patch and said OK. Didn't test-build it though. Sorry about that. Will see what's going on here... -Eric > which is just terminally broken. > > It's terminally broken for multiple reasons, too. It's not just "oh, a > warning". It's a case of "oh, THAT CODE IS UTTER CRAP". The warning > was just the lucky reason I noticed the totally unacceptable code. > > Dammit, don't send sh*t to me this late in the release cycle. This > clearly went through _zero_ quality control. > > Linus > > PS. If people don't understand why that code is utter crap, let me > give you a hint: macro argument expansion vs operator precedence. > > PPS. And btw, the warning is unacceptable too. Cast the thing to > "unsigned long" (or uintptr_t, but quite frankly, in the kernel I'd > suggest "unsigned long" rather than the more obscure standard types) > after you've fixed the macro argument problem. > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@redhat.com> To: Linus Torvalds <torvalds@linux-foundation.org> Cc: "Ted Ts'o" <tytso@mit.edu>, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] Date: Fri, 11 Feb 2011 19:41:41 -0600 [thread overview] Message-ID: <4D55E555.9050409@redhat.com> (raw) In-Reply-To: <AANLkTineDxntR0ZTXdgXrc6qx6pATTORgOwFR5+w5MLN@mail.gmail.com> On 2/11/11 6:33 PM, Linus Torvalds wrote: > On Fri, Feb 11, 2011 at 5:40 AM, Ted Ts'o <tytso@mit.edu> wrote: >> >> Please pull from: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git for_linus >> >> to get regression and bug fixes for 2.6.38. >> >> Eric Sandeen (3): >> ext4: serialize unaligned asynchronous DIO > > This is a completely disgusting patch, and it causes warnings like this: > fs/ext4/file.c: In function ‘ext4_aiodio_wait’: > fs/ext4/file.c:60:44: warning: cast from pointer to integer of different size > > because that disgusting patch does things like > > #define ext4_aio_mutex(v) (&ext4__aio_mutex[((unsigned)v) % EXT4_WQ_HASH_SZ]) Well crap, the patch I sent Ted did not cause warnings. OTOH, I eyeballed his changes to my patch and said OK. Didn't test-build it though. Sorry about that. Will see what's going on here... -Eric > which is just terminally broken. > > It's terminally broken for multiple reasons, too. It's not just "oh, a > warning". It's a case of "oh, THAT CODE IS UTTER CRAP". The warning > was just the lucky reason I noticed the totally unacceptable code. > > Dammit, don't send sh*t to me this late in the release cycle. This > clearly went through _zero_ quality control. > > Linus > > PS. If people don't understand why that code is utter crap, let me > give you a hint: macro argument expansion vs operator precedence. > > PPS. And btw, the warning is unacceptable too. Cast the thing to > "unsigned long" (or uintptr_t, but quite frankly, in the kernel I'd > suggest "unsigned long" rather than the more obscure standard types) > after you've fixed the macro argument problem. > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-02-12 1:42 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-11 13:40 [GIT PULL] Ted Ts'o 2011-02-12 0:33 ` Linus Torvalds 2011-02-12 0:33 ` Linus Torvalds 2011-02-12 1:41 ` Eric Sandeen [this message] 2011-02-12 1:41 ` Eric Sandeen 2011-02-12 13:28 ` Ted Ts'o -- strict thread matches above, loose matches on Subject: below -- 2022-08-09 13:27 David Howells 2022-08-09 17:29 ` pr-tracker-bot 2022-06-03 19:20 Eric W. Biederman 2022-06-03 23:25 ` pr-tracker-bot 2021-12-23 19:55 Eric W. Biederman 2021-12-23 19:55 ` Eric W. Biederman 2019-02-11 20:48 Kevin Hilman 2019-02-11 20:48 ` Kevin Hilman 2019-02-11 20:56 ` Kevin Hilman 2019-02-11 20:56 ` Kevin Hilman 2018-05-08 13:38 Frederic Weisbecker 2016-04-12 18:34 David Howells 2015-07-15 11:51 Tero Kristo 2015-07-15 21:05 ` Stephen Boyd 2012-06-18 20:48 Roland Stigge 2012-06-30 23:29 ` Olof Johansson 2012-07-01 15:40 ` Roland Stigge 2012-07-02 16:25 ` Olof Johansson 2012-04-10 19:05 Stephen Warren 2012-04-10 21:29 ` Mark Brown 2012-03-13 4:56 [git pull] Jesse Barnes 2011-12-19 11:29 [GIT PULL] Sascha Hauer 2011-12-20 5:33 ` Olof Johansson 2010-09-10 12:52 Nicolas Ferre 2010-09-10 12:52 ` Nicolas Ferre 2010-09-10 13:16 ` Jean-Christophe PLAGNIOL-VILLARD 2010-09-10 13:16 ` Jean-Christophe PLAGNIOL-VILLARD 2010-03-03 3:09 Frederic Weisbecker 2007-10-23 9:43 Haavard Skinnemoen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4D55E555.9050409@redhat.com \ --to=sandeen@redhat.com \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=torvalds@linux-foundation.org \ --cc=tytso@mit.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.