All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mpc8315e-rdb: Set TARGET_FPU correct
@ 2011-07-15  4:56 Kumar Gala
  2011-07-15  5:31 ` Bruce Ashfield
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Kumar Gala @ 2011-07-15  4:56 UTC (permalink / raw)
  To: yocto

The MPC8315E has a e300c3 core in it with 'classic' or normal PPC
floating point.

'SPE' floating point is what exists on the e500v2 core.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 meta-yocto/conf/machine/mpc8315e-rdb.conf |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta-yocto/conf/machine/mpc8315e-rdb.conf b/meta-yocto/conf/machine/mpc8315e-rdb.conf
index 095d113..3f946a0 100644
--- a/meta-yocto/conf/machine/mpc8315e-rdb.conf
+++ b/meta-yocto/conf/machine/mpc8315e-rdb.conf
@@ -2,7 +2,7 @@
 #@DESCRIPTION: Machine configuration for running 
 
 TARGET_ARCH = "powerpc"
-TARGET_FPU = "spe"
+TARGET_FPU = "hard"
 
 require conf/machine/include/tune-ppc603e.inc
 
-- 
1.7.3.4



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] mpc8315e-rdb: Set TARGET_FPU correct
  2011-07-15  4:56 [PATCH] mpc8315e-rdb: Set TARGET_FPU correct Kumar Gala
@ 2011-07-15  5:31 ` Bruce Ashfield
  2011-07-15 12:29   ` Kumar Gala
  2011-07-21  2:53   ` Kumar Gala
  2011-07-22 13:54 ` Kumar Gala
  2011-07-22 16:13 ` Saul Wold
  2 siblings, 2 replies; 8+ messages in thread
From: Bruce Ashfield @ 2011-07-15  5:31 UTC (permalink / raw)
  To: Kumar Gala; +Cc: yocto

On 11-07-15 12:56 AM, Kumar Gala wrote:
> The MPC8315E has a e300c3 core in it with 'classic' or normal PPC
> floating point.
>
> 'SPE' floating point is what exists on the e500v2 core.

Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>

Been meaning to change this for a while, the good news, is that
the setting doesn't make any difference at the moment :)

Cheers,

Bruce

>
> Signed-off-by: Kumar Gala<galak@kernel.crashing.org>
> ---
>   meta-yocto/conf/machine/mpc8315e-rdb.conf |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta-yocto/conf/machine/mpc8315e-rdb.conf b/meta-yocto/conf/machine/mpc8315e-rdb.conf
> index 095d113..3f946a0 100644
> --- a/meta-yocto/conf/machine/mpc8315e-rdb.conf
> +++ b/meta-yocto/conf/machine/mpc8315e-rdb.conf
> @@ -2,7 +2,7 @@
>   #@DESCRIPTION: Machine configuration for running
>
>   TARGET_ARCH = "powerpc"
> -TARGET_FPU = "spe"
> +TARGET_FPU = "hard"
>
>   require conf/machine/include/tune-ppc603e.inc
>



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] mpc8315e-rdb: Set TARGET_FPU correct
  2011-07-15  5:31 ` Bruce Ashfield
@ 2011-07-15 12:29   ` Kumar Gala
  2011-07-15 13:22     ` Bruce Ashfield
  2011-07-21  2:53   ` Kumar Gala
  1 sibling, 1 reply; 8+ messages in thread
From: Kumar Gala @ 2011-07-15 12:29 UTC (permalink / raw)
  To: Bruce Ashfield; +Cc: yocto


On Jul 15, 2011, at 12:31 AM, Bruce Ashfield wrote:

> On 11-07-15 12:56 AM, Kumar Gala wrote:
>> The MPC8315E has a e300c3 core in it with 'classic' or normal PPC
>> floating point.
>> 
>> 'SPE' floating point is what exists on the e500v2 core.
> 
> Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> 
> Been meaning to change this for a while, the good news, is that
> the setting doesn't make any difference at the moment :)
> 
> Cheers,
> 
> Bruce

True, I want to use this for configure toolchain properly:

I'm looking at doing the following for when SPE is set:

diff --git a/meta/recipes-devtools/gcc/gcc-common.inc b/meta/recipes-devtools/gcc/gcc-common.inc
index 7bf036c..409ad01 100644
--- a/meta/recipes-devtools/gcc/gcc-common.inc
+++ b/meta/recipes-devtools/gcc/gcc-common.inc
@@ -12,6 +12,8 @@ FILESDIR = "${@os.path.dirname(bb.data.getVar('FILE',d,1))}/gcc-${PV}"
 def get_gcc_fpu_setting(bb, d):
     if bb.data.getVar('TARGET_FPU', d, 1) in [ 'soft' ]:
         return "--with-float=soft"
+    if bb.data.getVar('TARGET_FPU', d, 1) in [ 'spe' ]:
+        return "--enable-e500_double"
     return ""



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] mpc8315e-rdb: Set TARGET_FPU correct
  2011-07-15 12:29   ` Kumar Gala
@ 2011-07-15 13:22     ` Bruce Ashfield
  0 siblings, 0 replies; 8+ messages in thread
From: Bruce Ashfield @ 2011-07-15 13:22 UTC (permalink / raw)
  To: Kumar Gala; +Cc: yocto

On 07/15/11 08:29, Kumar Gala wrote:
>
> On Jul 15, 2011, at 12:31 AM, Bruce Ashfield wrote:
>
>> On 11-07-15 12:56 AM, Kumar Gala wrote:
>>> The MPC8315E has a e300c3 core in it with 'classic' or normal PPC
>>> floating point.
>>>
>>> 'SPE' floating point is what exists on the e500v2 core.
>>
>> Acked-by: Bruce Ashfield<bruce.ashfield@windriver.com>
>>
>> Been meaning to change this for a while, the good news, is that
>> the setting doesn't make any difference at the moment :)
>>
>> Cheers,
>>
>> Bruce
>
> True, I want to use this for configure toolchain properly:
>
> I'm looking at doing the following for when SPE is set:

Definitely. It was simply good fortune that it hadn't been
used yet. And when something like you are doing arrives, we
want to have it right. Just to have it right, is a good enough
reason!

Cheers,

Bruce



>
> diff --git a/meta/recipes-devtools/gcc/gcc-common.inc b/meta/recipes-devtools/gcc/gcc-common.inc
> index 7bf036c..409ad01 100644
> --- a/meta/recipes-devtools/gcc/gcc-common.inc
> +++ b/meta/recipes-devtools/gcc/gcc-common.inc
> @@ -12,6 +12,8 @@ FILESDIR = "${@os.path.dirname(bb.data.getVar('FILE',d,1))}/gcc-${PV}"
>   def get_gcc_fpu_setting(bb, d):
>       if bb.data.getVar('TARGET_FPU', d, 1) in [ 'soft' ]:
>           return "--with-float=soft"
> +    if bb.data.getVar('TARGET_FPU', d, 1) in [ 'spe' ]:
> +        return "--enable-e500_double"
>       return ""
>



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] mpc8315e-rdb: Set TARGET_FPU correct
  2011-07-15  5:31 ` Bruce Ashfield
  2011-07-15 12:29   ` Kumar Gala
@ 2011-07-21  2:53   ` Kumar Gala
  1 sibling, 0 replies; 8+ messages in thread
From: Kumar Gala @ 2011-07-21  2:53 UTC (permalink / raw)
  To: Richard Purdie; +Cc: Yocto discussion list


On Jul 15, 2011, at 12:31 AM, Bruce Ashfield wrote:

> On 11-07-15 12:56 AM, Kumar Gala wrote:
>> The MPC8315E has a e300c3 core in it with 'classic' or normal PPC
>> floating point.
>> 
>> 'SPE' floating point is what exists on the e500v2 core.
> 
> Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> 
> Been meaning to change this for a while, the good news, is that
> the setting doesn't make any difference at the moment :)
> 
> Cheers,
> 
> Bruce

ping, this seems to have gotten lost w/regards to getting applied

- k

>> Signed-off-by: Kumar Gala<galak@kernel.crashing.org>
>> ---
>>  meta-yocto/conf/machine/mpc8315e-rdb.conf |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/meta-yocto/conf/machine/mpc8315e-rdb.conf b/meta-yocto/conf/machine/mpc8315e-rdb.conf
>> index 095d113..3f946a0 100644
>> --- a/meta-yocto/conf/machine/mpc8315e-rdb.conf
>> +++ b/meta-yocto/conf/machine/mpc8315e-rdb.conf
>> @@ -2,7 +2,7 @@
>>  #@DESCRIPTION: Machine configuration for running
>> 
>>  TARGET_ARCH = "powerpc"
>> -TARGET_FPU = "spe"
>> +TARGET_FPU = "hard"
>> 
>>  require conf/machine/include/tune-ppc603e.inc
>> 



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] mpc8315e-rdb: Set TARGET_FPU correct
  2011-07-15  4:56 [PATCH] mpc8315e-rdb: Set TARGET_FPU correct Kumar Gala
  2011-07-15  5:31 ` Bruce Ashfield
@ 2011-07-22 13:54 ` Kumar Gala
  2011-07-22 16:13 ` Saul Wold
  2 siblings, 0 replies; 8+ messages in thread
From: Kumar Gala @ 2011-07-22 13:54 UTC (permalink / raw)
  To: Richard Purdie; +Cc: Yocto discussion list


On Jul 14, 2011, at 11:56 PM, Kumar Gala wrote:

> The MPC8315E has a e300c3 core in it with 'classic' or normal PPC
> floating point.
> 
> 'SPE' floating point is what exists on the e500v2 core.
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> meta-yocto/conf/machine/mpc8315e-rdb.conf |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

Richard,

ping.  Bruce has ack'd this.

https://lists.yoctoproject.org/pipermail/yocto/2011-July/001915.html

- k

> 
> diff --git a/meta-yocto/conf/machine/mpc8315e-rdb.conf b/meta-yocto/conf/machine/mpc8315e-rdb.conf
> index 095d113..3f946a0 100644
> --- a/meta-yocto/conf/machine/mpc8315e-rdb.conf
> +++ b/meta-yocto/conf/machine/mpc8315e-rdb.conf
> @@ -2,7 +2,7 @@
> #@DESCRIPTION: Machine configuration for running 
> 
> TARGET_ARCH = "powerpc"
> -TARGET_FPU = "spe"
> +TARGET_FPU = "hard"
> 
> require conf/machine/include/tune-ppc603e.inc
> 
> -- 
> 1.7.3.4
> 
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] mpc8315e-rdb: Set TARGET_FPU correct
  2011-07-15  4:56 [PATCH] mpc8315e-rdb: Set TARGET_FPU correct Kumar Gala
  2011-07-15  5:31 ` Bruce Ashfield
  2011-07-22 13:54 ` Kumar Gala
@ 2011-07-22 16:13 ` Saul Wold
  2011-07-22 16:19   ` Gary Thomas
  2 siblings, 1 reply; 8+ messages in thread
From: Saul Wold @ 2011-07-22 16:13 UTC (permalink / raw)
  To: Kumar Gala; +Cc: yocto

On 07/14/2011 09:56 PM, Kumar Gala wrote:
> The MPC8315E has a e300c3 core in it with 'classic' or normal PPC
> floating point.
>
> 'SPE' floating point is what exists on the e500v2 core.
>
> Signed-off-by: Kumar Gala<galak@kernel.crashing.org>
> ---
>   meta-yocto/conf/machine/mpc8315e-rdb.conf |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta-yocto/conf/machine/mpc8315e-rdb.conf b/meta-yocto/conf/machine/mpc8315e-rdb.conf
> index 095d113..3f946a0 100644
> --- a/meta-yocto/conf/machine/mpc8315e-rdb.conf
> +++ b/meta-yocto/conf/machine/mpc8315e-rdb.conf
> @@ -2,7 +2,7 @@
>   #@DESCRIPTION: Machine configuration for running
>
>   TARGET_ARCH = "powerpc"
> -TARGET_FPU = "spe"
> +TARGET_FPU = "hard"
>
>   require conf/machine/include/tune-ppc603e.inc
>

Pulled into Yocto/Master

Thanks
	Sau!


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] mpc8315e-rdb: Set TARGET_FPU correct
  2011-07-22 16:13 ` Saul Wold
@ 2011-07-22 16:19   ` Gary Thomas
  0 siblings, 0 replies; 8+ messages in thread
From: Gary Thomas @ 2011-07-22 16:19 UTC (permalink / raw)
  To: Saul Wold; +Cc: yocto

On 07/22/2011 10:13 AM, Saul Wold wrote:
> On 07/14/2011 09:56 PM, Kumar Gala wrote:
>> The MPC8315E has a e300c3 core in it with 'classic' or normal PPC
>> floating point.
>>
>> 'SPE' floating point is what exists on the e500v2 core.
>>
>> Signed-off-by: Kumar Gala<galak@kernel.crashing.org>
>> ---
>> meta-yocto/conf/machine/mpc8315e-rdb.conf | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta-yocto/conf/machine/mpc8315e-rdb.conf b/meta-yocto/conf/machine/mpc8315e-rdb.conf
>> index 095d113..3f946a0 100644
>> --- a/meta-yocto/conf/machine/mpc8315e-rdb.conf
>> +++ b/meta-yocto/conf/machine/mpc8315e-rdb.conf
>> @@ -2,7 +2,7 @@
>> #@DESCRIPTION: Machine configuration for running
>>
>> TARGET_ARCH = "powerpc"
>> -TARGET_FPU = "spe"
>> +TARGET_FPU = "hard"

This doesn't match the documentation:
   ./meta/conf/documentation.conf:TARGET_FPU[doc] = "Floating point option (mostly for FPU-less systems), can be 'soft' or empty
The file
   meta/classes/icecc.bbclass
seems to be the only place where TARGET_FPU="hard" means anything.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2011-07-22 16:19 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-15  4:56 [PATCH] mpc8315e-rdb: Set TARGET_FPU correct Kumar Gala
2011-07-15  5:31 ` Bruce Ashfield
2011-07-15 12:29   ` Kumar Gala
2011-07-15 13:22     ` Bruce Ashfield
2011-07-21  2:53   ` Kumar Gala
2011-07-22 13:54 ` Kumar Gala
2011-07-22 16:13 ` Saul Wold
2011-07-22 16:19   ` Gary Thomas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.