From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"w.sang@pengutronix.de" <w.sang@pengutronix.de>,
Dong Aisheng <b29396@freescale.com>, Liam Girdwood <lrg@ti.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/1] ASoC: soc-core: check rate for symmetry only when pcm is active
Date: Wed, 24 Aug 2011 20:54:55 +0200 [thread overview]
Message-ID: <4E5548FF.1030709@metafoo.de> (raw)
In-Reply-To: <20110824172703.GF16653@opensource.wolfsonmicro.com>
On 08/24/2011 07:27 PM, Mark Brown wrote:
> On Wed, Aug 24, 2011 at 07:05:35PM +0200, Lars-Peter Clausen wrote:
>
>> A more sensible solution would in my opinion be to save the current rate in the
>> dai struct itself and not in the pcm struct. Upon opening a stream check for
>> cpu and codec DAI whether they require symmetry. If they do and are active
>> constraint the rate to DAIs rate. This also ensures that if boths DAIs are
>> already active and are running at different rates there will be no valid rate
>> for the new stream.
>
> We need to store in all three places I think - the symmetry requirement
> can also come from the link itself. But generally this is what we're
> actually looking for, yes.
It should be sufficient to just store the rate for the cpu and codec DAI.
Though the rate constraint should be applied if either the DAI or the link
wants symmetric rates.
WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH v2 1/1] ASoC: soc-core: check rate for symmetry only when pcm is active
Date: Wed, 24 Aug 2011 20:54:55 +0200 [thread overview]
Message-ID: <4E5548FF.1030709@metafoo.de> (raw)
In-Reply-To: <20110824172703.GF16653@opensource.wolfsonmicro.com>
On 08/24/2011 07:27 PM, Mark Brown wrote:
> On Wed, Aug 24, 2011 at 07:05:35PM +0200, Lars-Peter Clausen wrote:
>
>> A more sensible solution would in my opinion be to save the current rate in the
>> dai struct itself and not in the pcm struct. Upon opening a stream check for
>> cpu and codec DAI whether they require symmetry. If they do and are active
>> constraint the rate to DAIs rate. This also ensures that if boths DAIs are
>> already active and are running at different rates there will be no valid rate
>> for the new stream.
>
> We need to store in all three places I think - the symmetry requirement
> can also come from the link itself. But generally this is what we're
> actually looking for, yes.
It should be sufficient to just store the rate for the cpu and codec DAI.
Though the rate constraint should be applied if either the DAI or the link
wants symmetric rates.
next prev parent reply other threads:[~2011-08-24 18:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 11:02 [PATCH v2 1/1] ASoC: soc-core: check rate for symmetry only when pcm is active Dong Aisheng
2011-08-24 11:02 ` Dong Aisheng
2011-08-24 16:03 ` Liam Girdwood
2011-08-24 16:03 ` Liam Girdwood
2011-08-24 17:05 ` Lars-Peter Clausen
2011-08-24 17:05 ` [alsa-devel] " Lars-Peter Clausen
2011-08-24 17:27 ` Mark Brown
2011-08-24 17:27 ` Mark Brown
2011-08-24 18:54 ` Lars-Peter Clausen [this message]
2011-08-24 18:54 ` Lars-Peter Clausen
2011-08-24 19:19 ` Mark Brown
2011-08-24 19:19 ` [alsa-devel] " Mark Brown
2011-08-26 9:16 ` Dong Aisheng-B29396
2011-08-26 9:16 ` [alsa-devel] " Dong Aisheng-B29396
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5548FF.1030709@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=b29396@freescale.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.