From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> To: Tejun Heo <tj@kernel.org> Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>, "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>, Michal Hocko <mhocko@suse.cz>, Johannes Weiner <hannes@cmpxchg.org>, Glauber Costa <glommer@parallels.com>, Hugh Dickins <hughd@google.com>, Andrew Morton <akpm@linux-foundation.org> Subject: Re: [PATCH 1/7] res_counter: add a function res_counter_move_parent(). Date: Wed, 18 Apr 2012 15:59:39 +0900 [thread overview] Message-ID: <4F8E665B.7050302@jp.fujitsu.com> (raw) In-Reply-To: <20120416221924.GB12421@google.com> (2012/04/17 7:19), Tejun Heo wrote: > On Thu, Apr 12, 2012 at 08:20:06PM +0900, KAMEZAWA Hiroyuki wrote: >> >> This function is used for moving accounting information to its >> parent in the hierarchy of res_counter. >> >> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> >> --- >> include/linux/res_counter.h | 3 +++ >> kernel/res_counter.c | 13 +++++++++++++ >> 2 files changed, 16 insertions(+), 0 deletions(-) >> >> diff --git a/include/linux/res_counter.h b/include/linux/res_counter.h >> index da81af0..8919d3c 100644 >> --- a/include/linux/res_counter.h >> +++ b/include/linux/res_counter.h >> @@ -135,6 +135,9 @@ int __must_check res_counter_charge_nofail(struct res_counter *counter, >> void res_counter_uncharge_locked(struct res_counter *counter, unsigned long val); >> void res_counter_uncharge(struct res_counter *counter, unsigned long val); >> >> +/* move resource to parent counter...i.e. just forget accounting in a child */ > > Can we drop this comment and > >> +void res_counter_move_parent(struct res_counter *counter, unsigned long val); >> >> +/* >> + * In hierarchical accounting, child's usage is accounted into ancestors. >> + * To move local usage to its parent, just forget current level usage. >> + */ > > make this one proper docbook function comment? > Sure. (I'll use Frederic's one.) Thanks, -Kame >> +void res_counter_move_parent(struct res_counter *counter, unsigned long val) >> +{ >> + unsigned long flags; >> + >> + BUG_ON(!counter->parent); > > And let's please do "if (WARN_ON(!counter->parent)) return;" instead. > > Thanks. > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" <linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>, "cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>, Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>, Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>, Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Subject: Re: [PATCH 1/7] res_counter: add a function res_counter_move_parent(). Date: Wed, 18 Apr 2012 15:59:39 +0900 [thread overview] Message-ID: <4F8E665B.7050302@jp.fujitsu.com> (raw) In-Reply-To: <20120416221924.GB12421-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> (2012/04/17 7:19), Tejun Heo wrote: > On Thu, Apr 12, 2012 at 08:20:06PM +0900, KAMEZAWA Hiroyuki wrote: >> >> This function is used for moving accounting information to its >> parent in the hierarchy of res_counter. >> >> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> >> --- >> include/linux/res_counter.h | 3 +++ >> kernel/res_counter.c | 13 +++++++++++++ >> 2 files changed, 16 insertions(+), 0 deletions(-) >> >> diff --git a/include/linux/res_counter.h b/include/linux/res_counter.h >> index da81af0..8919d3c 100644 >> --- a/include/linux/res_counter.h >> +++ b/include/linux/res_counter.h >> @@ -135,6 +135,9 @@ int __must_check res_counter_charge_nofail(struct res_counter *counter, >> void res_counter_uncharge_locked(struct res_counter *counter, unsigned long val); >> void res_counter_uncharge(struct res_counter *counter, unsigned long val); >> >> +/* move resource to parent counter...i.e. just forget accounting in a child */ > > Can we drop this comment and > >> +void res_counter_move_parent(struct res_counter *counter, unsigned long val); >> >> +/* >> + * In hierarchical accounting, child's usage is accounted into ancestors. >> + * To move local usage to its parent, just forget current level usage. >> + */ > > make this one proper docbook function comment? > Sure. (I'll use Frederic's one.) Thanks, -Kame >> +void res_counter_move_parent(struct res_counter *counter, unsigned long val) >> +{ >> + unsigned long flags; >> + >> + BUG_ON(!counter->parent); > > And let's please do "if (WARN_ON(!counter->parent)) return;" instead. > > Thanks. >
next prev parent reply other threads:[~2012-04-18 7:02 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-04-12 11:17 [PATCH v1 0/7] memcg remove pre_destroy KAMEZAWA Hiroyuki 2012-04-12 11:20 ` [PATCH 1/7] res_counter: add a function res_counter_move_parent() KAMEZAWA Hiroyuki 2012-04-12 11:20 ` KAMEZAWA Hiroyuki 2012-04-12 13:22 ` Glauber Costa 2012-04-12 14:30 ` Frederic Weisbecker 2012-04-13 0:57 ` KAMEZAWA Hiroyuki 2012-04-13 0:57 ` KAMEZAWA Hiroyuki 2012-04-13 1:04 ` Frederic Weisbecker 2012-04-13 1:04 ` Frederic Weisbecker 2012-04-13 1:05 ` KAMEZAWA Hiroyuki 2012-04-16 22:19 ` Tejun Heo 2012-04-16 22:19 ` Tejun Heo 2012-04-18 6:59 ` KAMEZAWA Hiroyuki [this message] 2012-04-18 6:59 ` KAMEZAWA Hiroyuki 2012-04-16 22:31 ` Tejun Heo 2012-04-18 7:04 ` KAMEZAWA Hiroyuki 2012-04-18 7:04 ` KAMEZAWA Hiroyuki 2012-04-18 17:03 ` Tejun Heo 2012-04-18 17:03 ` Tejun Heo 2012-04-12 11:21 ` [PATCH 2/7] memcg: move charge to parent only when necessary KAMEZAWA Hiroyuki 2012-04-12 11:21 ` KAMEZAWA Hiroyuki 2012-04-16 22:21 ` Tejun Heo 2012-04-16 22:21 ` Tejun Heo 2012-04-18 7:01 ` KAMEZAWA Hiroyuki 2012-04-18 7:01 ` KAMEZAWA Hiroyuki 2012-04-12 11:22 ` [PATCH 3/7] memcg: move charges to root at rmdir() KAMEZAWA Hiroyuki 2012-04-12 11:22 ` KAMEZAWA Hiroyuki 2012-04-16 22:30 ` Tejun Heo 2012-04-16 22:30 ` Tejun Heo 2012-04-18 7:02 ` KAMEZAWA Hiroyuki 2012-04-12 11:24 ` [PATCH 4/7] memcg: remove 'uncharge' argument from mem_cgroup_move_account() KAMEZAWA Hiroyuki 2012-04-12 11:24 ` KAMEZAWA Hiroyuki 2012-04-12 13:27 ` Glauber Costa 2012-04-13 1:01 ` KAMEZAWA Hiroyuki 2012-04-12 11:28 ` [PATCH 5/7] memcg: divide force_empty into 2 functions, avoid memory reclaim at rmdir KAMEZAWA Hiroyuki 2012-04-12 11:28 ` KAMEZAWA Hiroyuki 2012-04-12 13:33 ` Glauber Costa 2012-04-17 17:29 ` Ying Han 2012-04-18 7:14 ` KAMEZAWA Hiroyuki 2012-04-18 7:14 ` KAMEZAWA Hiroyuki 2012-04-12 11:30 ` [PATCH 6/7] memcg: remove pre_destroy() KAMEZAWA Hiroyuki 2012-04-12 11:30 ` KAMEZAWA Hiroyuki 2012-04-16 22:38 ` Tejun Heo 2012-04-18 7:12 ` KAMEZAWA Hiroyuki 2012-04-18 7:12 ` KAMEZAWA Hiroyuki 2012-04-17 17:47 ` Ying Han 2012-04-17 17:47 ` Ying Han 2012-04-12 11:31 ` [PATCH 7/7] memcg: remove drain_all_stock_sync KAMEZAWA Hiroyuki 2012-04-12 11:31 ` KAMEZAWA Hiroyuki 2012-04-12 13:35 ` Glauber Costa 2012-04-12 13:35 ` Glauber Costa 2012-04-12 13:20 ` [PATCH v1 0/7] memcg remove pre_destroy Glauber Costa 2012-04-12 13:20 ` Glauber Costa 2012-04-12 16:06 ` Tejun Heo 2012-04-12 16:06 ` Tejun Heo 2012-04-12 18:57 ` Aneesh Kumar K.V 2012-04-12 18:57 ` Aneesh Kumar K.V 2012-04-12 23:59 ` KAMEZAWA Hiroyuki 2012-04-13 8:50 ` Michal Hocko 2012-04-13 8:50 ` Michal Hocko 2012-04-13 22:19 ` Aneesh Kumar K.V 2012-04-13 22:19 ` Aneesh Kumar K.V 2012-04-16 22:41 ` Tejun Heo 2012-04-16 22:41 ` Tejun Heo 2012-04-17 17:35 ` Ying Han 2012-04-18 7:15 ` KAMEZAWA Hiroyuki 2012-04-18 7:15 ` KAMEZAWA Hiroyuki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4F8E665B.7050302@jp.fujitsu.com \ --to=kamezawa.hiroyu@jp.fujitsu.com \ --cc=akpm@linux-foundation.org \ --cc=cgroups@vger.kernel.org \ --cc=glommer@parallels.com \ --cc=hannes@cmpxchg.org \ --cc=hughd@google.com \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.cz \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.