* [PATCH] arm: davinci: pdctl next bit position incorrect
[not found] <1334745664-19275-1-git-send-email-m-karicheri2@ti.com>
@ 2012-04-18 20:23 ` Sekhar Nori
2012-04-19 10:45 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Sekhar Nori @ 2012-04-18 20:23 UTC (permalink / raw)
To: linux-arm-kernel
Hi Murali,
On 4/18/2012 4:11 PM, m-karicheri2 at ti.com wrote:
> From: Murali Karicheri <m-karicheri2@ti.com>
>
> The PDCTL NEXT bit is incorrectly set to bit 1 instead of bit 0. This
> patch fixes this issue
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Applying this for v3.5. Note that the "arm:" prefix in subject has to be
capitalized. I fixed it while comitting. Please take care next time on.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: davinci: pdctl next bit position incorrect
2012-04-18 20:23 ` [PATCH] arm: davinci: pdctl next bit position incorrect Sekhar Nori
@ 2012-04-19 10:45 ` Sergei Shtylyov
2012-04-19 16:52 ` Sekhar Nori
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2012-04-19 10:45 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 19-04-2012 0:23, Sekhar Nori wrote:
>> The PDCTL NEXT bit is incorrectly set to bit 1 instead of bit 0. This
>> patch fixes this issue
>> Signed-off-by: Murali Karicheri<m-karicheri2@ti.com>
> Applying this for v3.5.
But why not to 3.4? It concerns turning on DSP domain on DM644x.
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: davinci: pdctl next bit position incorrect
2012-04-19 10:45 ` Sergei Shtylyov
@ 2012-04-19 16:52 ` Sekhar Nori
2012-04-20 15:09 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Sekhar Nori @ 2012-04-19 16:52 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On 4/19/2012 4:15 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 19-04-2012 0:23, Sekhar Nori wrote:
>
>>> The PDCTL NEXT bit is incorrectly set to bit 1 instead of bit 0. This
>>> patch fixes this issue
>
>>> Signed-off-by: Murali Karicheri<m-karicheri2@ti.com>
>
>> Applying this for v3.5.
>
> But why not to 3.4? It concerns turning on DSP domain on DM644x.
Yes, but I think as you noted sometime before, no one is really
depending on kernel to turn on DSP domain on DM644x. Its probably being
done from U-Boot or ROM code. This is not a v3.4 regression either.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: davinci: pdctl next bit position incorrect
2012-04-19 16:52 ` Sekhar Nori
@ 2012-04-20 15:09 ` Sergei Shtylyov
2012-04-26 17:34 ` Sekhar Nori
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2012-04-20 15:09 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 04/19/2012 08:52 PM, Sekhar Nori wrote:
>>>> The PDCTL NEXT bit is incorrectly set to bit 1 instead of bit 0. This
>>>> patch fixes this issue
>>>> Signed-off-by: Murali Karicheri<m-karicheri2@ti.com>
>>> Applying this for v3.5.
>> But why not to 3.4? It concerns turning on DSP domain on DM644x.
> Yes, but I think as you noted sometime before, no one is really
> depending on kernel to turn on DSP domain on DM644x.
Looks like you're right (though I don't remember noting it :-).
> Its probably being
> done from U-Boot or ROM code. This is not a v3.4 regression either.
U-Boot does it only when DSPLINK support is not desired.
> Thanks,
> Sekhar
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: davinci: pdctl next bit position incorrect
2012-04-20 15:09 ` Sergei Shtylyov
@ 2012-04-26 17:34 ` Sekhar Nori
2012-04-27 10:12 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Sekhar Nori @ 2012-04-26 17:34 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On 4/20/2012 8:39 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 04/19/2012 08:52 PM, Sekhar Nori wrote:
>
>>>>> The PDCTL NEXT bit is incorrectly set to bit 1 instead of bit 0. This
>>>>> patch fixes this issue
>
>>>>> Signed-off-by: Murali Karicheri<m-karicheri2@ti.com>
>
>>>> Applying this for v3.5.
>
>>> But why not to 3.4? It concerns turning on DSP domain on DM644x.
>
>> Yes, but I think as you noted sometime before, no one is really
>> depending on kernel to turn on DSP domain on DM644x.
>
> Looks like you're right (though I don't remember noting it :-).
>
>> Its probably being
>> done from U-Boot or ROM code. This is not a v3.4 regression either.
>
> U-Boot does it only when DSPLINK support is not desired.
Okay. Since DSPLink existed long before this code to turn on domain was
introduced by Murali, it must be having its own private code to do this.
So, looks like this should not really be a regression for anyone.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: davinci: pdctl next bit position incorrect
2012-04-26 17:34 ` Sekhar Nori
@ 2012-04-27 10:12 ` Sergei Shtylyov
0 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2012-04-27 10:12 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 26-04-2012 21:34, Sekhar Nori wrote:
>> On 04/19/2012 08:52 PM, Sekhar Nori wrote:
>>>>>> The PDCTL NEXT bit is incorrectly set to bit 1 instead of bit 0. This
>>>>>> patch fixes this issue
>>>>>> Signed-off-by: Murali Karicheri<m-karicheri2@ti.com>
>>>>> Applying this for v3.5.
>>>> But why not to 3.4? It concerns turning on DSP domain on DM644x.
>>> Yes, but I think as you noted sometime before, no one is really
>>> depending on kernel to turn on DSP domain on DM644x.
>> Looks like you're right (though I don't remember noting it :-).
>>> Its probably being
>>> done from U-Boot or ROM code. This is not a v3.4 regression either.
>> U-Boot does it only when DSPLINK support is not desired.
> Okay. Since DSPLink existed long before this code to turn on domain was
> introduced by Murali,
The code to turn on DSP domain wasn't introduced by Murali, it was there
originally. Ah, you probably mean that the code was checking PDSTAT0, not
PDSTAT1 before doing the DSP domain switch?
> it must be having its own private code to do this.
> So, looks like this should not really be a regression for anyone.
It seems you're right.
> Thanks,
> Sekhar
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-04-27 10:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1334745664-19275-1-git-send-email-m-karicheri2@ti.com>
2012-04-18 20:23 ` [PATCH] arm: davinci: pdctl next bit position incorrect Sekhar Nori
2012-04-19 10:45 ` Sergei Shtylyov
2012-04-19 16:52 ` Sekhar Nori
2012-04-20 15:09 ` Sergei Shtylyov
2012-04-26 17:34 ` Sekhar Nori
2012-04-27 10:12 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.