Re: [PATCH 1/6] m88ds3103, montage dvb-s/s2 demodulator driver

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Hi Konstantin,

Em 27-04-2012 16:01, Konstantin Dimitrov escreveu:
> Mauro, your reasoning makes sense to me. so, let's split them and at
> least settle this part of the discussion - i will do as far as my
> spare time allows, as well make sure there are no some problems
> introduced after the split.

Thank you!

> also, in one email i've just sent in answer to Antti there is enough
> argument why such split, i.e. tuner-pass-through-mode is subject to
> discussion about CX24116 and TDA10071 drivers too. currently, majority
> of DVB-S2 demodulator drivers in the kernel are married to particular
> tuners and there is no split.

Besides the reasoning I gave you, having the tuner and the demod on separate
drivers help a lot code reviewers to check what's happening inside the code,
because the code on each driver becomes more coincide and the two different
functions become more decoupled, with reduces the code complexity. So, bugs
tend to be reduced and they're easier to fix, especially when someone need
to fix bad things at the dvb core.

Also, as almost all drivers are like that, it is easier to identify driver
patterns, especially when newer patches are adding extra functionality there.

Thanks!
Mauro