Re: [PATCH 1/3] m88brs2000 DVB-S frontend and tuner module.

[Malcolm Priestley <tvboxspy@gmail.com>]

On Thu, 2012-01-26 at 14:56 -0200, Mauro Carvalho Chehab wrote:
> Em 22-01-2012 08:38, Malcolm Priestley escreveu:
> > Support for m88brs2000 chip used in lmedm04 driver.
> > 
> > Note there are still lock problems.
> > 
> > Slow channel change due to the large block of registers sent in set_frontend.
> > 
> > Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> > ---
> 
> ...
> > +static int m88rs2000_set_property(struct dvb_frontend *fe,
> > +	struct dtv_property *p)
> > +{
> > +	dprintk("%s(..)\n", __func__);
> > +	return 0;
> > +}
> > +
> > +static int m88rs2000_get_property(struct dvb_frontend *fe,
> > +	struct dtv_property *p)
> > +{
> > +	dprintk("%s(..)\n", __func__);
> > +	return 0;
> > +}
> ...
> 
> Just don't implement set_property/get_property if you're not using them.
> 
> Except for that, the code looks ok on my eyes.
> 
Hi Mauro

This patch series is now on alpha due to hardware issues.

The hardware becomes completely unresponsive after a full transponder
scan on all systems.

Although, the hardware becomes fully usable again after a few days!?!

Some kind of memory storage?

So, for the time being this driver is not to go upstream.

Regards


Malcolm