From: Suman Anna <s-anna@ti.com> To: Jan Kiszka <jan.kiszka@siemens.com>, Nishanth Menon <nm@ti.com> Cc: Grygorii Strashko <grygorii.strashko@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, Kishon Vijay Abraham I <kishon@ti.com>, Lokesh Vutla <lokeshvutla@ti.com>, Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>, <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org> Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am65-main: Add ICSSG MDIO nodes Date: Fri, 28 May 2021 07:20:40 -0500 [thread overview] Message-ID: <4c429512-77c5-59f7-ac1d-9f6a51c693ab@ti.com> (raw) In-Reply-To: <00fbd9c1-ed43-822c-06bf-9642b5c03568@siemens.com> On 5/28/21 12:22 AM, Jan Kiszka wrote: > On 28.05.21 07:09, Jan Kiszka wrote: >> On 15.05.21 00:47, Suman Anna wrote: >>> From: Roger Quadros <rogerq@ti.com> >>> >>> The ICSSGs on K3 AM65x SoCs contain an MDIO controller that can >>> be used to control external PHYs associated with the Industrial >>> Ethernet peripherals within each ICSSG instance. The MDIO module >>> used within the ICSSG is similar to the MDIO Controller used >>> in TI Davinci SoCs. A bus frequency of 1 MHz is chosen for the >>> MDIO operations. >>> >>> The nodes are added and enabled in the common k3-am65-main.dtsi >>> file by default, and disabled in the existing AM65 board dts >>> files. These nodes need pinctrl lines, and so should be enabled >>> only on boards where they are actually wired and pinned out for >>> ICSSG Ethernet. Any new board dts file should disable these if >>> they are not sure. >>> >>> Signed-off-by: Roger Quadros <rogerq@ti.com> >>> [s-anna@ti.com: move the disabled status to board dts files] >>> Signed-off-by: Suman Anna <s-anna@ti.com> >>> --- >>> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 12 ++++++++ >>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 30 +++++++++++++++++++ >>> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 12 ++++++++ >>> 3 files changed, 54 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi >>> index de763ca9251c..63140eaba524 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi >>> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi >>> @@ -653,3 +653,15 @@ &pcie1_rc { >>> &pcie1_ep { >>> status = "disabled"; >>> }; >>> + >>> +&icssg0_mdio { >>> + status = "disabled"; >>> +}; >>> + >>> +&icssg1_mdio { >>> + status = "disabled"; >>> +}; >>> + >>> +&icssg2_mdio { >>> + status = "disabled"; >>> +}; >> >> We will need this here for PRU networking. What would be the impact of >> leaving it enabled already at this stage? >> > > Ah, now reading our backlog completely - there will be more coming in to > this file than not disabling icssg mdio (and that only for mdio0). So: Yeah, these will be enabled when the corresponding pinctrl pins are added, so will come alongside the icssg ethernet nodes in the future. > > Acked-by: Jan Kiszka <jan.kiszka@siemens.com> > > Jan > > PS: How far are we away from icssg-prueth? The last missing pieces from PRUSS foundation point of view are the PRUSS consumer API series, which need next versions to be posted upstream. I would say still couple of merge windows. regards Suman
WARNING: multiple messages have this Message-ID (diff)
From: Suman Anna <s-anna@ti.com> To: Jan Kiszka <jan.kiszka@siemens.com>, Nishanth Menon <nm@ti.com> Cc: Grygorii Strashko <grygorii.strashko@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>, Kishon Vijay Abraham I <kishon@ti.com>, Lokesh Vutla <lokeshvutla@ti.com>, Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>, <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org> Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am65-main: Add ICSSG MDIO nodes Date: Fri, 28 May 2021 07:20:40 -0500 [thread overview] Message-ID: <4c429512-77c5-59f7-ac1d-9f6a51c693ab@ti.com> (raw) In-Reply-To: <00fbd9c1-ed43-822c-06bf-9642b5c03568@siemens.com> On 5/28/21 12:22 AM, Jan Kiszka wrote: > On 28.05.21 07:09, Jan Kiszka wrote: >> On 15.05.21 00:47, Suman Anna wrote: >>> From: Roger Quadros <rogerq@ti.com> >>> >>> The ICSSGs on K3 AM65x SoCs contain an MDIO controller that can >>> be used to control external PHYs associated with the Industrial >>> Ethernet peripherals within each ICSSG instance. The MDIO module >>> used within the ICSSG is similar to the MDIO Controller used >>> in TI Davinci SoCs. A bus frequency of 1 MHz is chosen for the >>> MDIO operations. >>> >>> The nodes are added and enabled in the common k3-am65-main.dtsi >>> file by default, and disabled in the existing AM65 board dts >>> files. These nodes need pinctrl lines, and so should be enabled >>> only on boards where they are actually wired and pinned out for >>> ICSSG Ethernet. Any new board dts file should disable these if >>> they are not sure. >>> >>> Signed-off-by: Roger Quadros <rogerq@ti.com> >>> [s-anna@ti.com: move the disabled status to board dts files] >>> Signed-off-by: Suman Anna <s-anna@ti.com> >>> --- >>> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 12 ++++++++ >>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 30 +++++++++++++++++++ >>> .../arm64/boot/dts/ti/k3-am654-base-board.dts | 12 ++++++++ >>> 3 files changed, 54 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi >>> index de763ca9251c..63140eaba524 100644 >>> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi >>> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi >>> @@ -653,3 +653,15 @@ &pcie1_rc { >>> &pcie1_ep { >>> status = "disabled"; >>> }; >>> + >>> +&icssg0_mdio { >>> + status = "disabled"; >>> +}; >>> + >>> +&icssg1_mdio { >>> + status = "disabled"; >>> +}; >>> + >>> +&icssg2_mdio { >>> + status = "disabled"; >>> +}; >> >> We will need this here for PRU networking. What would be the impact of >> leaving it enabled already at this stage? >> > > Ah, now reading our backlog completely - there will be more coming in to > this file than not disabling icssg mdio (and that only for mdio0). So: Yeah, these will be enabled when the corresponding pinctrl pins are added, so will come alongside the icssg ethernet nodes in the future. > > Acked-by: Jan Kiszka <jan.kiszka@siemens.com> > > Jan > > PS: How far are we away from icssg-prueth? The last missing pieces from PRUSS foundation point of view are the PRUSS consumer API series, which need next versions to be posted upstream. I would say still couple of merge windows. regards Suman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-28 12:20 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-14 22:47 [PATCH 0/2] Add ICSSG MDIO nodes on AM65x & J721E SoCs Suman Anna 2021-05-14 22:47 ` Suman Anna 2021-05-14 22:47 ` [PATCH 1/2] arm64: dts: ti: k3-am65-main: Add ICSSG MDIO nodes Suman Anna 2021-05-14 22:47 ` Suman Anna 2021-05-27 15:12 ` Grygorii Strashko 2021-05-27 15:12 ` Grygorii Strashko 2021-05-28 5:09 ` Jan Kiszka 2021-05-28 5:09 ` Jan Kiszka 2021-05-28 5:22 ` Jan Kiszka 2021-05-28 5:22 ` Jan Kiszka 2021-05-28 12:20 ` Suman Anna [this message] 2021-05-28 12:20 ` Suman Anna 2021-05-14 22:47 ` [PATCH 2/2] arm64: dts: ti: k3-j721e-main: " Suman Anna 2021-05-14 22:47 ` Suman Anna 2021-05-27 15:13 ` Grygorii Strashko 2021-05-27 15:13 ` Grygorii Strashko 2021-05-14 22:58 ` [PATCH 0/2] Add ICSSG MDIO nodes on AM65x & J721E SoCs Grygorii Strashko 2021-05-14 22:58 ` Grygorii Strashko 2021-05-28 18:24 ` Nishanth Menon 2021-05-28 18:24 ` Nishanth Menon 2021-05-28 18:29 ` Suman Anna 2021-05-28 18:29 ` Suman Anna
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4c429512-77c5-59f7-ac1d-9f6a51c693ab@ti.com \ --to=s-anna@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=grygorii.strashko@ti.com \ --cc=grzegorz.jaszczyk@linaro.org \ --cc=jan.kiszka@siemens.com \ --cc=kishon@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=lokeshvutla@ti.com \ --cc=nm@ti.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.