[PATCH] tests: remove "make check-speed" in favor of "make bench"

[PATCH] tests: remove "make check-speed" in favor of "make bench"

[Paolo Bonzini]

"make check-speed" has been broken since the removal of ninja2make
last October.  It was just a backwards-compatibility alias for
"make bench-speed", which in turn is in principle a subset of
"make bench".  Advertise the latter and drop "make check-speed"
completely since no one has noticed.

Reported-by: Thomas Huth <thuth@redhat.com>
Supersedes: <20210310094936.1318317-1-thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/Makefile.include | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index d34254fb29..a181310d24 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -3,13 +3,13 @@
 .PHONY: check-help
 check-help:
 	@echo "Regression testing targets:"
-	@echo
 	@echo " $(MAKE) check                Run block, qapi-schema, unit, softfloat, qtest and decodetree tests"
+	@echo " $(MAKE) bench                Run speed tests"
 	@echo
+	@echo "Individual test suites:"
 	@echo " $(MAKE) check-qtest-TARGET   Run qtest tests for given target"
 	@echo " $(MAKE) check-qtest          Run qtest tests"
 	@echo " $(MAKE) check-unit           Run qobject tests"
-	@echo " $(MAKE) check-speed          Run qobject speed tests"
 	@echo " $(MAKE) check-qapi-schema    Run QAPI schema tests"
 	@echo " $(MAKE) check-block          Run block tests"
 ifneq ($(filter $(all-check-targets), check-softfloat),)
@@ -154,8 +154,4 @@ check-clean:
 
 clean: check-clean
 
-# For backwards compatibility
-
-check-speed: bench-speed
-
 endif
-- 
2.29.2

Re: [PATCH] tests: remove "make check-speed" in favor of "make bench"

[Thomas Huth]

On 10/03/2021 17.46, Paolo Bonzini wrote:
> "make check-speed" has been broken since the removal of ninja2make
> last October.  It was just a backwards-compatibility alias for
> "make bench-speed", which in turn is in principle a subset of
> "make bench".  Advertise the latter and drop "make check-speed"
> completely since no one has noticed.
> 
> Reported-by: Thomas Huth <thuth@redhat.com>
> Supersedes: <20210310094936.1318317-1-thuth@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   tests/Makefile.include | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH] tests: remove "make check-speed" in favor of "make bench"

[Willian Rampazzo]

On Wed, Mar 10, 2021 at 1:46 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> "make check-speed" has been broken since the removal of ninja2make
> last October.  It was just a backwards-compatibility alias for
> "make bench-speed", which in turn is in principle a subset of
> "make bench".  Advertise the latter and drop "make check-speed"
> completely since no one has noticed.
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Supersedes: <20210310094936.1318317-1-thuth@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/Makefile.include | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>

Re: [PATCH] tests: remove "make check-speed" in favor of "make bench"

[Thomas Huth]

On 10/03/2021 17.46, Paolo Bonzini wrote:
> "make check-speed" has been broken since the removal of ninja2make
> last October.  It was just a backwards-compatibility alias for
> "make bench-speed", which in turn is in principle a subset of
> "make bench".  Advertise the latter and drop "make check-speed"
> completely since no one has noticed.
> 
> Reported-by: Thomas Huth <thuth@redhat.com>
> Supersedes: <20210310094936.1318317-1-thuth@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   tests/Makefile.include | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)

Thanks, queued to my testing-next branch now:

  https://gitlab.com/thuth/qemu/-/commits/testing-next/

  Thomas