From: David Laight <David.Laight@ACULAB.COM> To: 'Jaegeuk Kim' <jaegeuk@kernel.org>, Eric Biggers <ebiggers@kernel.org> Cc: Daniel Rosenberg <drosen@google.com>, Chao Yu <chao@kernel.org>, "linux-f2fs-devel@lists.sourceforge.net" <linux-f2fs-devel@lists.sourceforge.net>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>, Gabriel Krisman Bertazi <krisman@collabora.com>, "kernel-team@android.com" <kernel-team@android.com>, "stable@vger.kernel.org" <stable@vger.kernel.org> Subject: RE: [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs Date: Fri, 4 Jun 2021 08:27:32 +0000 [thread overview] Message-ID: <4f56f2781fac4b8bac1a78b0fecc318d@AcuMS.aculab.com> (raw) In-Reply-To: <YLmv5Ykb3QUzDOlL@google.com> From: Jaegeuk Kim > Sent: 04 June 2021 05:45 ... > > > @@ -161,6 +161,9 @@ static ssize_t features_show(struct f2fs_attr *a, > > > if (f2fs_sb_has_compression(sbi)) > > > len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > > len ? ", " : "", "compression"); > > > + if (f2fs_sb_has_casefold(sbi) && f2fs_sb_has_encrypt(sbi)) > > > + len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > > + len ? ", " : "", "encrypted_casefold"); > > > len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > > len ? ", " : "", "pin_file"); > > > len += scnprintf(buf + len, PAGE_SIZE - len, "\n"); Looking at that pattern, why don't you just append "tag, " each time and then replace the final ", " with "\n" at the end. Although if I wanted to quickly parse that in (say) a shell script I wouldn't really want the ",". OTOH it is too late to change that. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
WARNING: multiple messages have this Message-ID (diff)
From: David Laight <David.Laight@ACULAB.COM> To: 'Jaegeuk Kim' <jaegeuk@kernel.org>, Eric Biggers <ebiggers@kernel.org> Cc: Daniel Rosenberg <drosen@google.com>, "kernel-team@android.com" <kernel-team@android.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "stable@vger.kernel.org" <stable@vger.kernel.org>, "linux-f2fs-devel@lists.sourceforge.net" <linux-f2fs-devel@lists.sourceforge.net>, "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>, Gabriel Krisman Bertazi <krisman@collabora.com> Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs Date: Fri, 4 Jun 2021 08:27:32 +0000 [thread overview] Message-ID: <4f56f2781fac4b8bac1a78b0fecc318d@AcuMS.aculab.com> (raw) In-Reply-To: <YLmv5Ykb3QUzDOlL@google.com> From: Jaegeuk Kim > Sent: 04 June 2021 05:45 ... > > > @@ -161,6 +161,9 @@ static ssize_t features_show(struct f2fs_attr *a, > > > if (f2fs_sb_has_compression(sbi)) > > > len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > > len ? ", " : "", "compression"); > > > + if (f2fs_sb_has_casefold(sbi) && f2fs_sb_has_encrypt(sbi)) > > > + len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > > + len ? ", " : "", "encrypted_casefold"); > > > len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > > len ? ", " : "", "pin_file"); > > > len += scnprintf(buf + len, PAGE_SIZE - len, "\n"); Looking at that pattern, why don't you just append "tag, " each time and then replace the final ", " with "\n" at the end. Although if I wanted to quickly parse that in (say) a shell script I wouldn't really want the ",". OTOH it is too late to change that. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-06-04 8:27 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-03 9:50 [PATCH v2 0/2] Fix up casefolding sysfs entries for F2FS Daniel Rosenberg 2021-06-03 9:50 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel 2021-06-03 9:50 ` [PATCH v2 1/2] f2fs: Show casefolding support only when supported Daniel Rosenberg 2021-06-03 9:50 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel 2021-06-03 18:20 ` Eric Biggers 2021-06-03 18:20 ` [f2fs-dev] " Eric Biggers 2021-06-04 23:46 ` Chao Yu 2021-06-04 23:46 ` [f2fs-dev] " Chao Yu 2021-06-03 9:50 ` [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs Daniel Rosenberg 2021-06-03 9:50 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel 2021-06-03 10:04 ` Greg KH 2021-06-03 10:04 ` [f2fs-dev] " Greg KH 2021-06-03 15:40 ` Jaegeuk Kim 2021-06-03 15:40 ` [f2fs-dev] " Jaegeuk Kim 2021-06-03 17:26 ` Greg KH 2021-06-03 17:26 ` [f2fs-dev] " Greg KH 2021-06-03 17:53 ` Jaegeuk Kim 2021-06-03 17:53 ` [f2fs-dev] " Jaegeuk Kim 2021-06-03 18:12 ` Greg KH 2021-06-03 18:12 ` [f2fs-dev] " Greg KH 2021-06-03 19:20 ` Jaegeuk Kim 2021-06-03 19:20 ` [f2fs-dev] " Jaegeuk Kim 2021-06-03 20:54 ` David Laight 2021-06-03 20:54 ` [f2fs-dev] " David Laight 2021-06-03 18:26 ` Eric Biggers 2021-06-03 18:26 ` [f2fs-dev] " Eric Biggers 2021-06-03 23:21 ` Eric Biggers 2021-06-03 23:21 ` [f2fs-dev] " Eric Biggers 2021-06-04 4:45 ` Jaegeuk Kim 2021-06-04 4:45 ` [f2fs-dev] " Jaegeuk Kim 2021-06-04 5:01 ` Eric Biggers 2021-06-04 5:01 ` [f2fs-dev] " Eric Biggers 2021-06-04 5:38 ` Jaegeuk Kim 2021-06-04 5:38 ` [f2fs-dev] " Jaegeuk Kim 2021-06-04 5:54 ` Daniel Rosenberg 2021-06-04 5:54 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel 2021-06-04 18:58 ` Theodore Ts'o 2021-06-04 18:58 ` [f2fs-dev] " Theodore Ts'o 2021-06-05 0:11 ` Chao Yu 2021-06-05 0:11 ` [f2fs-dev] " Chao Yu 2021-06-05 0:15 ` Jaegeuk Kim 2021-06-05 0:15 ` [f2fs-dev] " Jaegeuk Kim 2021-06-04 8:27 ` David Laight [this message] 2021-06-04 8:27 ` David Laight 2021-06-04 8:33 ` Greg KH 2021-06-04 8:33 ` [f2fs-dev] " Greg KH 2021-06-04 23:46 ` Chao Yu 2021-06-04 23:46 ` [f2fs-dev] " Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4f56f2781fac4b8bac1a78b0fecc318d@AcuMS.aculab.com \ --to=david.laight@aculab.com \ --cc=chao@kernel.org \ --cc=drosen@google.com \ --cc=ebiggers@kernel.org \ --cc=jaegeuk@kernel.org \ --cc=kernel-team@android.com \ --cc=krisman@collabora.com \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.