* [PATCH]->[PATCH v2] kgdb: Removed kmalloc returned value cast
@ 2013-03-10 22:39 ` Alex Grad
0 siblings, 0 replies; 6+ messages in thread
From: Alex Grad @ 2013-03-10 22:39 UTC (permalink / raw)
To: penberg
Cc: paulus, mikey, tiejun.chen, jason.wessel, sfr, linuxppc-dev,
linux-kernel, daniel.baluta, Alex Grad
While at it, check kmalloc return value.
Signed-off-by: Alex Grad <alex.grad@gmail.com>
---
arch/powerpc/kernel/kgdb.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
index 5ca82cd..9e81dd8 100644
--- a/arch/powerpc/kernel/kgdb.c
+++ b/arch/powerpc/kernel/kgdb.c
@@ -159,7 +159,10 @@ static int kgdb_singlestep(struct pt_regs *regs)
if (user_mode(regs))
return 0;
- backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct thread_info), GFP_KERNEL);
+ backup_current_thread_info = kmalloc(sizeof(struct thread_info), GFP_KERNEL);
+ if (!backup_current_thread_info)
+ return -ENOMEM;
+
/*
* On Book E and perhaps other processors, singlestep is handled on
* the critical exception stack. This causes current_thread_info()
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH]->[PATCH v2] kgdb: Removed kmalloc returned value cast
@ 2013-03-10 22:39 ` Alex Grad
0 siblings, 0 replies; 6+ messages in thread
From: Alex Grad @ 2013-03-10 22:39 UTC (permalink / raw)
To: penberg
Cc: sfr, mikey, daniel.baluta, linux-kernel, tiejun.chen, paulus,
Alex Grad, jason.wessel, linuxppc-dev
While at it, check kmalloc return value.
Signed-off-by: Alex Grad <alex.grad@gmail.com>
---
arch/powerpc/kernel/kgdb.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
index 5ca82cd..9e81dd8 100644
--- a/arch/powerpc/kernel/kgdb.c
+++ b/arch/powerpc/kernel/kgdb.c
@@ -159,7 +159,10 @@ static int kgdb_singlestep(struct pt_regs *regs)
if (user_mode(regs))
return 0;
- backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct thread_info), GFP_KERNEL);
+ backup_current_thread_info = kmalloc(sizeof(struct thread_info), GFP_KERNEL);
+ if (!backup_current_thread_info)
+ return -ENOMEM;
+
/*
* On Book E and perhaps other processors, singlestep is handled on
* the critical exception stack. This causes current_thread_info()
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH]->[PATCH v2] kgdb: Removed kmalloc returned value cast
2013-03-10 22:39 ` Alex Grad
@ 2013-03-11 1:33 ` tiejun.chen
-1 siblings, 0 replies; 6+ messages in thread
From: tiejun.chen @ 2013-03-11 1:33 UTC (permalink / raw)
To: Alex Grad, Benjamin Herrenschmidt, Jason Wessel
Cc: penberg, paulus, mikey, jason.wessel, sfr, linuxppc-dev,
linux-kernel, daniel.baluta
On 03/11/2013 06:39 AM, Alex Grad wrote:
> While at it, check kmalloc return value.
>
> Signed-off-by: Alex Grad <alex.grad@gmail.com>
> ---
> arch/powerpc/kernel/kgdb.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
> index 5ca82cd..9e81dd8 100644
> --- a/arch/powerpc/kernel/kgdb.c
> +++ b/arch/powerpc/kernel/kgdb.c
> @@ -159,7 +159,10 @@ static int kgdb_singlestep(struct pt_regs *regs)
> if (user_mode(regs))
> return 0;
>
> - backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct thread_info), GFP_KERNEL);
> + backup_current_thread_info = kmalloc(sizeof(struct thread_info), GFP_KERNEL);
> + if (!backup_current_thread_info)
> + return -ENOMEM;
I already send a kgdb patchset in "[v3][PATCH 6/6] powerpc/kgdb: remove copying
the thread_info" to remove these stuff since its unnecessary to copy current
thread_info now.
Tiejun
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH]->[PATCH v2] kgdb: Removed kmalloc returned value cast
@ 2013-03-11 1:33 ` tiejun.chen
0 siblings, 0 replies; 6+ messages in thread
From: tiejun.chen @ 2013-03-11 1:33 UTC (permalink / raw)
To: Alex Grad, Benjamin Herrenschmidt, Jason Wessel
Cc: sfr, mikey, daniel.baluta, linux-kernel, penberg, paulus,
jason.wessel, linuxppc-dev
On 03/11/2013 06:39 AM, Alex Grad wrote:
> While at it, check kmalloc return value.
>
> Signed-off-by: Alex Grad <alex.grad@gmail.com>
> ---
> arch/powerpc/kernel/kgdb.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
> index 5ca82cd..9e81dd8 100644
> --- a/arch/powerpc/kernel/kgdb.c
> +++ b/arch/powerpc/kernel/kgdb.c
> @@ -159,7 +159,10 @@ static int kgdb_singlestep(struct pt_regs *regs)
> if (user_mode(regs))
> return 0;
>
> - backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct thread_info), GFP_KERNEL);
> + backup_current_thread_info = kmalloc(sizeof(struct thread_info), GFP_KERNEL);
> + if (!backup_current_thread_info)
> + return -ENOMEM;
I already send a kgdb patchset in "[v3][PATCH 6/6] powerpc/kgdb: remove copying
the thread_info" to remove these stuff since its unnecessary to copy current
thread_info now.
Tiejun
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH]->[PATCH v2] kgdb: Removed kmalloc returned value cast
2013-03-11 1:33 ` tiejun.chen
@ 2013-03-11 10:14 ` tiejun.chen
-1 siblings, 0 replies; 6+ messages in thread
From: tiejun.chen @ 2013-03-11 10:14 UTC (permalink / raw)
To: Alex Grad, Benjamin Herrenschmidt, Jason Wessel
Cc: sfr, mikey, daniel.baluta, linux-kernel, penberg, paulus, linuxppc-dev
On 03/11/2013 09:33 AM, tiejun.chen wrote:
> On 03/11/2013 06:39 AM, Alex Grad wrote:
>> While at it, check kmalloc return value.
>>
>> Signed-off-by: Alex Grad <alex.grad@gmail.com>
>> ---
>> arch/powerpc/kernel/kgdb.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
>> index 5ca82cd..9e81dd8 100644
>> --- a/arch/powerpc/kernel/kgdb.c
>> +++ b/arch/powerpc/kernel/kgdb.c
>> @@ -159,7 +159,10 @@ static int kgdb_singlestep(struct pt_regs *regs)
>> if (user_mode(regs))
>> return 0;
>>
>> - backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct
>> thread_info), GFP_KERNEL);
>> + backup_current_thread_info = kmalloc(sizeof(struct thread_info),
>> GFP_KERNEL);
>> + if (!backup_current_thread_info)
>> + return -ENOMEM;
>
> I already send a kgdb patchset in "[v3][PATCH 6/6] powerpc/kgdb: remove copying
> the thread_info" to remove these stuff since its unnecessary to copy current
> thread_info now.
I guess that patchset needs to be reviewed with more time and I also think I can
leave this copying to be compatible for other platforms in the future, but we
really should fix this problem I introduced right now. So I'd like to fix this
with DEFINE_PER_CPU.
I send a patch, "powerpc/kgdb: use DEFINE_PER_CPU to allocate kgdb's
thread_info", so please take a look at if that version is fine to every one.
Any comments are appreciated.
BTW, I will update that kgdb patchset with this change to resend.
Tiejun
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH]->[PATCH v2] kgdb: Removed kmalloc returned value cast
@ 2013-03-11 10:14 ` tiejun.chen
0 siblings, 0 replies; 6+ messages in thread
From: tiejun.chen @ 2013-03-11 10:14 UTC (permalink / raw)
To: Alex Grad, Benjamin Herrenschmidt, Jason Wessel
Cc: sfr, mikey, daniel.baluta, linux-kernel, penberg, paulus, linuxppc-dev
On 03/11/2013 09:33 AM, tiejun.chen wrote:
> On 03/11/2013 06:39 AM, Alex Grad wrote:
>> While at it, check kmalloc return value.
>>
>> Signed-off-by: Alex Grad <alex.grad@gmail.com>
>> ---
>> arch/powerpc/kernel/kgdb.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
>> index 5ca82cd..9e81dd8 100644
>> --- a/arch/powerpc/kernel/kgdb.c
>> +++ b/arch/powerpc/kernel/kgdb.c
>> @@ -159,7 +159,10 @@ static int kgdb_singlestep(struct pt_regs *regs)
>> if (user_mode(regs))
>> return 0;
>>
>> - backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct
>> thread_info), GFP_KERNEL);
>> + backup_current_thread_info = kmalloc(sizeof(struct thread_info),
>> GFP_KERNEL);
>> + if (!backup_current_thread_info)
>> + return -ENOMEM;
>
> I already send a kgdb patchset in "[v3][PATCH 6/6] powerpc/kgdb: remove copying
> the thread_info" to remove these stuff since its unnecessary to copy current
> thread_info now.
I guess that patchset needs to be reviewed with more time and I also think I can
leave this copying to be compatible for other platforms in the future, but we
really should fix this problem I introduced right now. So I'd like to fix this
with DEFINE_PER_CPU.
I send a patch, "powerpc/kgdb: use DEFINE_PER_CPU to allocate kgdb's
thread_info", so please take a look at if that version is fine to every one.
Any comments are appreciated.
BTW, I will update that kgdb patchset with this change to resend.
Tiejun
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-03-11 10:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-10 22:39 [PATCH]->[PATCH v2] kgdb: Removed kmalloc returned value cast Alex Grad
2013-03-10 22:39 ` Alex Grad
2013-03-11 1:33 ` tiejun.chen
2013-03-11 1:33 ` tiejun.chen
2013-03-11 10:14 ` tiejun.chen
2013-03-11 10:14 ` tiejun.chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.