From: Stephen Warren <swarren@wwwdotorg.org> To: Wolfram Sang <wsa@the-dreams.de> Cc: Doug Anderson <dianders@chromium.org>, Kukjin Kim <kgene.kim@samsung.com>, Simon Glass <sjg@chromium.org>, Naveen Krishna Chatradhi <ch.naveen@samsung.com>, grant.likely@secretlab.ca, yuvaraj.cd@gmail.com, ben.dooks@codethink.co.uk, u.kleine-koenig@pengutronix.de, broonie@opensource.wolfsonmicro.com, girish.shivananjappa@linaro.org, bhushan.r@samsung.com, sreekumar.c@samsung.com, prashanth.g@samsung.com, olof@lixom.net, djkurtz@chromium.org, linux@roeck-us.net, Rob Herring <rob.herring@calxeda.com>, Rob Landley <rob@landley.net>, "Ben Dooks (embedded platforms)" <ben-linux@fluff.org>, Stephen Warren <swarren@nvidia.com>, Jean Delvare <khali@linux-fr.org>, Peter Korsgaard <peter.korsgaard@barco.com>, Guenter Roeck <guenter.roeck@ericsson.com>, devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH v5 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver Date: Tue, 16 Apr 2013 09:42:14 -0600 [thread overview] Message-ID: <516D7156.3050807@wwwdotorg.org> (raw) In-Reply-To: <20130416093633.GC16978@the-dreams.de> On 04/16/2013 03:36 AM, Wolfram Sang wrote: > Doug, > > On Tue, Apr 09, 2013 at 02:34:28PM -0700, Doug Anderson wrote: >> The i2c-arb-gpio-challenge driver implements an I2C arbitration scheme >> where masters need to claim the bus with a GPIO before they can start >> a transcation. This should generally only be used when standard I2C >> multimaster isn't appropriate for some reason (errata/bugs). >> >> This driver is based on code that Simon Glass added to the i2c-s3c2410 >> driver in the Chrome OS kernel 3.4 tree. The current incarnation as a >> mux driver is as suggested by Grant Likely. See >> <https://patchwork.kernel.org/patch/1877311/> for some history. >> diff --git a/Documentation/devicetree/bindings/i2c/i2c-arb-gpio-challenge.txt b/Documentation/devicetree/bindings/i2c/i2c-arb-gpio-challenge.txt >> +GPIO-based I2C Arbitration >> +========================== >> +This uses GPIO lines to arbitrate who is the master of an I2C bus in a >> +multimaster situation. > > "uses GPIO lines and a challange & response mechanism" or something like > that. There might be other GPIO based arbitrations in the future (though > I hope there won't). The existing text appears clearer to me; this document should spell out the exact details of the protocol in later paragraphs, so there's no need to try and spell it out here. >> +- their-claim-gpios: The GPIOs that the other sides use the claim the bus. >> + Note that some implementations may only support a single other master. > > Stronger? "Currently, only one other master is supported"? The DT binding documentation, which should be OS-/driver-agnostic, should describe the binding, not the implementation. The limitation that Linux imposes is OS-specific and hence should not be mentioned here as an absolute, or perhaps even at all.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> Cc: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, yuvaraj.cd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org, u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, girish.shivananjappa-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, bhushan.r-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, sreekumar.c-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, prashanth.g-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>, Rob Landley <rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org>, "Ben Dooks (embedded platforms)" <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>, Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>, Peter Korsgaard <peter.korsgaard-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org>, Guenter Roeck <guenter.roeck-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org>, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH v5 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver Date: Tue, 16 Apr 2013 09:42:14 -0600 [thread overview] Message-ID: <516D7156.3050807@wwwdotorg.org> (raw) In-Reply-To: <20130416093633.GC16978-z923LK4zBo2bacvFa/9K2g@public.gmane.org> On 04/16/2013 03:36 AM, Wolfram Sang wrote: > Doug, > > On Tue, Apr 09, 2013 at 02:34:28PM -0700, Doug Anderson wrote: >> The i2c-arb-gpio-challenge driver implements an I2C arbitration scheme >> where masters need to claim the bus with a GPIO before they can start >> a transcation. This should generally only be used when standard I2C >> multimaster isn't appropriate for some reason (errata/bugs). >> >> This driver is based on code that Simon Glass added to the i2c-s3c2410 >> driver in the Chrome OS kernel 3.4 tree. The current incarnation as a >> mux driver is as suggested by Grant Likely. See >> <https://patchwork.kernel.org/patch/1877311/> for some history. >> diff --git a/Documentation/devicetree/bindings/i2c/i2c-arb-gpio-challenge.txt b/Documentation/devicetree/bindings/i2c/i2c-arb-gpio-challenge.txt >> +GPIO-based I2C Arbitration >> +========================== >> +This uses GPIO lines to arbitrate who is the master of an I2C bus in a >> +multimaster situation. > > "uses GPIO lines and a challange & response mechanism" or something like > that. There might be other GPIO based arbitrations in the future (though > I hope there won't). The existing text appears clearer to me; this document should spell out the exact details of the protocol in later paragraphs, so there's no need to try and spell it out here. >> +- their-claim-gpios: The GPIOs that the other sides use the claim the bus. >> + Note that some implementations may only support a single other master. > > Stronger? "Currently, only one other master is supported"? The DT binding documentation, which should be OS-/driver-agnostic, should describe the binding, not the implementation. The limitation that Linux imposes is OS-specific and hence should not be mentioned here as an absolute, or perhaps even at all.
next prev parent reply other threads:[~2013-04-16 15:42 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-15 0:21 [PATCH v2 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver Doug Anderson 2013-02-15 0:21 ` [PATCH v2 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson 2013-02-15 0:21 ` Doug Anderson 2013-02-15 0:21 ` [PATCH v2 3/3] ARM: dts: Add sbs-battery " Doug Anderson 2013-02-15 0:21 ` Doug Anderson 2013-02-15 16:39 ` [PATCH v2 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver Stephen Warren 2013-02-15 16:39 ` Stephen Warren [not found] ` <511E64C0.9090500-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2013-02-15 17:25 ` Doug Anderson [not found] ` <CAD=FV=W9WwSsid_KqtDRmAkFXnneRXu5zcakDB3t4hLhOpuCtw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2013-02-15 17:38 ` Stephen Warren 2013-02-15 17:44 ` Mark Brown 2013-02-15 17:44 ` Mark Brown [not found] ` <20130215174425.GF22283-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> 2013-02-15 18:57 ` Doug Anderson 2013-02-15 19:46 ` [PATCH v3 " Doug Anderson 2013-02-15 19:46 ` Doug Anderson 2013-02-15 19:46 ` [PATCH v3 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson 2013-02-15 19:46 ` Doug Anderson 2013-03-05 23:48 ` Naveen Krishna Ch 2013-03-05 23:48 ` Naveen Krishna Ch 2013-03-13 7:30 ` Kukjin Kim 2013-03-13 7:30 ` Kukjin Kim 2013-03-13 15:14 ` Doug Anderson 2013-03-13 15:14 ` Doug Anderson 2013-02-15 19:46 ` [PATCH v3 3/3] ARM: dts: Add sbs-battery " Doug Anderson 2013-02-15 19:46 ` Doug Anderson 2013-03-05 23:49 ` Naveen Krishna Ch 2013-03-05 23:49 ` Naveen Krishna Ch 2013-02-15 21:31 ` [PATCH v3 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver Stephen Warren 2013-03-11 16:05 ` Doug Anderson 2013-03-11 16:05 ` Doug Anderson 2013-03-13 16:36 ` [PATCH v4 " Doug Anderson 2013-03-13 16:36 ` Doug Anderson 2013-03-13 16:36 ` [PATCH v4 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson 2013-03-13 16:36 ` Doug Anderson 2013-03-13 16:36 ` [PATCH v4 3/3] ARM: dts: Add sbs-battery " Doug Anderson 2013-03-13 16:36 ` Doug Anderson 2013-03-13 16:53 ` [PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver Stephen Warren 2013-03-13 16:53 ` Stephen Warren 2013-03-13 16:59 ` Doug Anderson 2013-03-13 16:59 ` Doug Anderson 2013-03-13 17:29 ` Stephen Warren 2013-03-13 17:29 ` Stephen Warren 2013-04-08 10:26 ` Wolfram Sang 2013-04-08 10:26 ` Wolfram Sang [not found] ` <20130408102617.GC3496-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2013-04-09 20:26 ` Doug Anderson [not found] ` <1363192583-26363-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2013-03-26 20:23 ` Doug Anderson [not found] ` <20130329115821.GC6359@the-dreams.de> [not found] ` <20130329115821.GC6359-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2013-03-29 18:28 ` Doug Anderson [not found] ` <20130403191938.GA7875@the-dreams.de> [not found] ` <20130403191938.GA7875-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2013-04-05 19:37 ` Simon Glass 2013-04-05 20:03 ` Stephen Warren 2013-04-05 20:03 ` Stephen Warren 2013-04-06 18:30 ` Guenter Roeck 2013-04-06 20:11 ` Wolfram Sang 2013-04-07 18:10 ` Guenter Roeck 2013-04-08 9:55 ` Wolfram Sang 2013-04-08 9:55 ` Wolfram Sang 2013-04-09 20:12 ` [PATCH v5 1/3] i2c: mux: Add i2c-arb-gpio-challenge " Doug Anderson 2013-04-09 20:12 ` [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson 2013-04-09 20:12 ` Doug Anderson 2013-04-09 20:12 ` [PATCH v5 3/3] ARM: dts: Add sbs-battery " Doug Anderson 2013-04-09 20:12 ` Doug Anderson 2013-04-09 21:34 ` [PATCH v5 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver Doug Anderson 2013-04-09 21:34 ` Doug Anderson 2013-04-09 21:34 ` [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson 2013-04-09 21:34 ` Doug Anderson 2013-04-10 10:59 ` Kukjin Kim 2013-04-10 10:59 ` Kukjin Kim 2013-04-10 11:02 ` Wolfram Sang 2013-04-10 11:02 ` Wolfram Sang 2013-04-10 14:12 ` Kukjin Kim 2013-04-10 14:12 ` Kukjin Kim 2013-04-09 21:34 ` [PATCH v5 3/3] ARM: dts: Add sbs-battery " Doug Anderson 2013-04-09 21:34 ` Doug Anderson 2013-04-16 9:36 ` [PATCH v5 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver Wolfram Sang 2013-04-16 9:36 ` Wolfram Sang 2013-04-16 9:44 ` Peter Korsgaard 2013-04-16 9:44 ` Peter Korsgaard 2013-04-16 13:38 ` Guenter Roeck 2013-04-16 15:42 ` Stephen Warren [this message] 2013-04-16 15:42 ` Stephen Warren [not found] ` <20130416093633.GC16978-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2013-04-16 16:25 ` Doug Anderson 2013-04-16 16:29 ` [PATCH v6 " Doug Anderson 2013-04-16 16:29 ` [PATCH v6 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow Doug Anderson 2013-04-16 16:29 ` Doug Anderson 2013-04-16 16:35 ` Olof Johansson 2013-04-16 16:35 ` Olof Johansson 2013-04-16 16:29 ` [PATCH v6 3/3] ARM: dts: Add sbs-battery " Doug Anderson 2013-04-16 16:29 ` Doug Anderson 2013-04-16 16:36 ` Olof Johansson 2013-04-16 16:36 ` Olof Johansson 2013-04-16 16:34 ` [PATCH v6 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver Olof Johansson 2013-04-17 9:34 ` Wolfram Sang [not found] ` <20130417093424.GC4508-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2013-04-17 13:57 ` Olof Johansson 2013-04-17 16:35 ` Olof Johansson 2013-04-16 16:45 ` Guenter Roeck 2013-04-16 16:45 ` Guenter Roeck [not found] ` <20130416164512.GB27488-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> 2013-04-16 16:51 ` Doug Anderson 2013-04-17 9:32 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=516D7156.3050807@wwwdotorg.org \ --to=swarren@wwwdotorg.org \ --cc=ben-linux@fluff.org \ --cc=ben.dooks@codethink.co.uk \ --cc=bhushan.r@samsung.com \ --cc=broonie@opensource.wolfsonmicro.com \ --cc=ch.naveen@samsung.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=dianders@chromium.org \ --cc=djkurtz@chromium.org \ --cc=girish.shivananjappa@linaro.org \ --cc=grant.likely@secretlab.ca \ --cc=guenter.roeck@ericsson.com \ --cc=kgene.kim@samsung.com \ --cc=khali@linux-fr.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=olof@lixom.net \ --cc=peter.korsgaard@barco.com \ --cc=prashanth.g@samsung.com \ --cc=rob.herring@calxeda.com \ --cc=rob@landley.net \ --cc=sjg@chromium.org \ --cc=sreekumar.c@samsung.com \ --cc=swarren@nvidia.com \ --cc=u.kleine-koenig@pengutronix.de \ --cc=wsa@the-dreams.de \ --cc=yuvaraj.cd@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.