From: Stephen Warren <swarren@wwwdotorg.org>
To: Jongsung Kim <neidhard.kim@lge.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
jslaby@suse.cz, linux-serial@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rpi-kernel@lists.infradead.org"
<linux-rpi-kernel@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: PL011: add support for extended FIFO-size of PL011-r1p5
Date: Mon, 13 May 2013 23:56:16 -0600 [thread overview]
Message-ID: <5191D200.3040604@wwwdotorg.org> (raw)
In-Reply-To: <007301ce375e$bcf6d6b0$36e48410$@lge.com>
On 04/12/2013 03:18 AM, Jongsung Kim wrote:
> The latest r1p5-revision of the ARM PL011 UART has 32-byte FIFOs, while all
> earlier ones have 16-byte FIFOs. This patch suggests a way to set the
> FIFO-size correctly & flexibly by using a
> function(vendor_data::get_fifosize) rather than using the
> vendor_data::fifosize variable. The function takes the UARTPeriphID, and
> returns the correct size.
This change (now part of 3.10-rc1) breaks the serial port on the BCM2835
ARM SoC (part of the Raspberry Pi). Sorry for not noticing this earlier;
a combination of my vacation and laziness I guess.
For reference, the AMBA periphid of the UART device there is 0x00341011.
The nibble "3" is the revision being tested in:
> +static unsigned int get_fifosize_arm(unsigned int periphid)
> +{
> + unsigned int rev = (periphid >> 20) & 0xf;
> + return rev < 3 ? 16 : 32;
> +}
Should that be <= not <, or is there just something more wrong in the
patch or bcm2835 HW? I wonder how r1p5 maps to 3 in the test above.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: PL011: add support for extended FIFO-size of PL011-r1p5
Date: Mon, 13 May 2013 23:56:16 -0600 [thread overview]
Message-ID: <5191D200.3040604@wwwdotorg.org> (raw)
In-Reply-To: <007301ce375e$bcf6d6b0$36e48410$@lge.com>
On 04/12/2013 03:18 AM, Jongsung Kim wrote:
> The latest r1p5-revision of the ARM PL011 UART has 32-byte FIFOs, while all
> earlier ones have 16-byte FIFOs. This patch suggests a way to set the
> FIFO-size correctly & flexibly by using a
> function(vendor_data::get_fifosize) rather than using the
> vendor_data::fifosize variable. The function takes the UARTPeriphID, and
> returns the correct size.
This change (now part of 3.10-rc1) breaks the serial port on the BCM2835
ARM SoC (part of the Raspberry Pi). Sorry for not noticing this earlier;
a combination of my vacation and laziness I guess.
For reference, the AMBA periphid of the UART device there is 0x00341011.
The nibble "3" is the revision being tested in:
> +static unsigned int get_fifosize_arm(unsigned int periphid)
> +{
> + unsigned int rev = (periphid >> 20) & 0xf;
> + return rev < 3 ? 16 : 32;
> +}
Should that be <= not <, or is there just something more wrong in the
patch or bcm2835 HW? I wonder how r1p5 maps to 3 in the test above.
next prev parent reply other threads:[~2013-05-14 5:56 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 9:18 [PATCH] ARM: PL011: add support for extended FIFO-size of PL011-r1p5 Jongsung Kim
2013-04-12 9:18 ` Jongsung Kim
2013-04-19 12:58 ` Russell King - ARM Linux
2013-05-14 5:56 ` Stephen Warren [this message]
2013-05-14 5:56 ` Stephen Warren
2013-05-14 5:56 ` Stephen Warren
2013-05-14 7:15 ` Jongsung Kim
2013-05-14 7:15 ` Jongsung Kim
2013-05-14 7:15 ` Jongsung Kim
2013-05-14 21:03 ` Stephen Warren
2013-05-14 21:03 ` Stephen Warren
2013-05-14 22:50 ` Russell King - ARM Linux
2013-05-14 22:50 ` Russell King - ARM Linux
2013-05-15 1:00 ` Jongsung Kim
2013-05-15 1:00 ` Jongsung Kim
2013-05-15 1:00 ` Jongsung Kim
2013-05-15 4:59 ` Stephen Warren
2013-05-15 4:59 ` Stephen Warren
2013-05-15 9:37 ` Russell King - ARM Linux
2013-05-15 9:37 ` Russell King - ARM Linux
2013-05-16 13:26 ` Jongsung Kim
2013-05-16 13:26 ` Jongsung Kim
2013-05-16 13:26 ` Jongsung Kim
2013-05-21 1:39 ` Jongsung Kim
2013-05-21 1:39 ` Jongsung Kim
2013-05-21 1:39 ` Jongsung Kim
2013-05-21 2:12 ` Stephen Warren
2013-05-21 2:12 ` Stephen Warren
2013-05-21 6:02 ` [PATCH] ARM: bcm2835: override the HW UART periphid Jongsung Kim
2013-05-21 6:02 ` Jongsung Kim
2013-05-21 6:07 ` Jongsung Kim
2013-05-21 6:07 ` Jongsung Kim
2013-05-21 6:07 ` Jongsung Kim
2013-05-21 9:00 ` Gordon Hollingworth
2013-05-21 9:00 ` Gordon Hollingworth
2013-05-21 9:00 ` Gordon Hollingworth
2013-05-21 16:34 ` Stephen Warren
2013-05-21 16:34 ` Stephen Warren
2013-05-22 1:43 ` Stephen Warren
2013-05-22 1:43 ` Stephen Warren
2013-05-22 1:52 ` Jongsung Kim
2013-05-22 1:52 ` Jongsung Kim
2013-05-22 1:52 ` Jongsung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5191D200.3040604@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=neidhard.kim@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.