From: Benoit Cousson <bcousson@baylibre.com> To: Pavel Machek <pavel@ucw.cz> Cc: Javier Martinez Canillas <martinez.javier@gmail.com>, Aaro Koskinen <aaro.koskinen@iki.fi>, Tony Lindgren <tony@atomide.com>, pali.rohar@gmail.com, kernel list <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-omap@vger.kernel.org Subject: Re: [PATCH v3] N900: add device tree Date: Tue, 13 Aug 2013 16:06:15 +0200 [thread overview] Message-ID: <520A3D57.1020906@baylibre.com> (raw) In-Reply-To: <20130813133636.GA12364@amd.pavel.ucw.cz> On 13/08/2013 15:36, Pavel Machek wrote: > Hi! > >> I finally got released by the aliens. It took longer than expected >> and beside a small scar on the back of my neck, I feel pretty OK. > > Scars on neck sound scary... > >> The order should not matter at all in DT, it should be a static >> representation of the HW, so there is probably something wrong in >> the code that make the device creation order important. > > I understand that there's something wrong with the code, but it turned > out not to be easy to debug. Yes, it will have to be debugged some > day, but it happens with old code, too, so it is actually orthogonal > to device tree. > >> Beside my comments and the ones from Javier, it looks good. >> If you can repost ASAP, I'll take it right after. >> It will be the first one in the list. > > Thanks, here you go. Thanks. I've just applied it after adding the prefix "ARM: dts:" to the subject. Regards, Benoit > Pavel > > --- > > This adds device tree with neccessary support to boot with functional > video (on both emulator and real N900 device). > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> > > --- > > From v1: Aaro wants just GPLv2, so I did that. I re-enabled parts that > can be enabled on 3.10, and tested it on that kernel. > > From v2: spelling, improved comments. Tested on 3.11-rc (0ed4402). > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index a0f2365..c48b1ef 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -162,6 +162,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \ > omap3-devkit8000.dtb \ > omap3-beagle-xm.dtb \ > omap3-evm.dtb \ > + omap3-n900.dtb \ > omap3-tobi.dtb \ > omap3-igep0020.dtb \ > omap3-igep0030.dtb \ > diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts > new file mode 100644 > index 0000000..7ff90f8 > --- /dev/null > +++ b/arch/arm/boot/dts/omap3-n900.dts > @@ -0,0 +1,92 @@ > +/* > + * Copyright (C) 2013 Pavel Machek <pavel@ucw.cz> > + * Copyright 2013 Aaro Koskinen <aaro.koskinen@iki.fi> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 (or later) as > + * published by the Free Software Foundation. > + */ > + > +/dts-v1/; > + > +#include "omap34xx.dtsi" > + > +/ { > + model = "Nokia N900"; > + compatible = "nokia,omap3-n900", "ti,omap3"; > + > + cpus { > + cpu@0 { > + cpu0-supply = <&vcc>; > + }; > + }; > + > + memory { > + device_type = "memory"; > + reg = <0x80000000 0x10000000>; /* 256 MB */ > + }; > + > +}; > + > +&i2c1 { > + clock-frequency = <2200000>; > + > + twl: twl@48 { > + reg = <0x48>; > + interrupts = <7>; /* SYS_NIRQ cascaded to intc */ > + interrupt-parent = <&intc>; > + }; > +}; > + > +#include "twl4030.dtsi" > + > +&twl_gpio { > + ti,pullups = <0x0>; > + ti,pulldowns = <0x03ff3f>; /* BIT(0..5) | BIT(8..17) */ > +}; > + > +&i2c2 { > + clock-frequency = <400000>; > +}; > + > +&i2c3 { > + clock-frequency = <100000>; > +}; > + > +&mmc1 { > + status = "disabled"; > +}; > + > +&mmc2 { > + status = "disabled"; > +}; > + > +&mmc3 { > + status = "disabled"; > +}; > + > +&mcspi1 { > + /* > + * For some reason, touchscreen is necessary for screen to work at > + * all on real hw. It works well without it on emulator. > + * > + * Also... order in the device tree actually matters here. > + */ > + tsc2005@0 { > + compatible = "tsc2005"; > + spi-max-frequency = <6000000>; > + reg = <0>; > + }; > + mipid@2 { > + compatible = "acx565akm"; > + spi-max-frequency = <6000000>; > + reg = <2>; > + }; > +}; > + > +&usb_otg_hs { > + interface-type = <0>; > + usb-phy = <&usb2_phy>; > + mode = <2>; > + power = <50>; > +}; >
WARNING: multiple messages have this Message-ID (diff)
From: bcousson@baylibre.com (Benoit Cousson) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3] N900: add device tree Date: Tue, 13 Aug 2013 16:06:15 +0200 [thread overview] Message-ID: <520A3D57.1020906@baylibre.com> (raw) In-Reply-To: <20130813133636.GA12364@amd.pavel.ucw.cz> On 13/08/2013 15:36, Pavel Machek wrote: > Hi! > >> I finally got released by the aliens. It took longer than expected >> and beside a small scar on the back of my neck, I feel pretty OK. > > Scars on neck sound scary... > >> The order should not matter at all in DT, it should be a static >> representation of the HW, so there is probably something wrong in >> the code that make the device creation order important. > > I understand that there's something wrong with the code, but it turned > out not to be easy to debug. Yes, it will have to be debugged some > day, but it happens with old code, too, so it is actually orthogonal > to device tree. > >> Beside my comments and the ones from Javier, it looks good. >> If you can repost ASAP, I'll take it right after. >> It will be the first one in the list. > > Thanks, here you go. Thanks. I've just applied it after adding the prefix "ARM: dts:" to the subject. Regards, Benoit > Pavel > > --- > > This adds device tree with neccessary support to boot with functional > video (on both emulator and real N900 device). > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> > > --- > > From v1: Aaro wants just GPLv2, so I did that. I re-enabled parts that > can be enabled on 3.10, and tested it on that kernel. > > From v2: spelling, improved comments. Tested on 3.11-rc (0ed4402). > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index a0f2365..c48b1ef 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -162,6 +162,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \ > omap3-devkit8000.dtb \ > omap3-beagle-xm.dtb \ > omap3-evm.dtb \ > + omap3-n900.dtb \ > omap3-tobi.dtb \ > omap3-igep0020.dtb \ > omap3-igep0030.dtb \ > diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts > new file mode 100644 > index 0000000..7ff90f8 > --- /dev/null > +++ b/arch/arm/boot/dts/omap3-n900.dts > @@ -0,0 +1,92 @@ > +/* > + * Copyright (C) 2013 Pavel Machek <pavel@ucw.cz> > + * Copyright 2013 Aaro Koskinen <aaro.koskinen@iki.fi> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 (or later) as > + * published by the Free Software Foundation. > + */ > + > +/dts-v1/; > + > +#include "omap34xx.dtsi" > + > +/ { > + model = "Nokia N900"; > + compatible = "nokia,omap3-n900", "ti,omap3"; > + > + cpus { > + cpu at 0 { > + cpu0-supply = <&vcc>; > + }; > + }; > + > + memory { > + device_type = "memory"; > + reg = <0x80000000 0x10000000>; /* 256 MB */ > + }; > + > +}; > + > +&i2c1 { > + clock-frequency = <2200000>; > + > + twl: twl at 48 { > + reg = <0x48>; > + interrupts = <7>; /* SYS_NIRQ cascaded to intc */ > + interrupt-parent = <&intc>; > + }; > +}; > + > +#include "twl4030.dtsi" > + > +&twl_gpio { > + ti,pullups = <0x0>; > + ti,pulldowns = <0x03ff3f>; /* BIT(0..5) | BIT(8..17) */ > +}; > + > +&i2c2 { > + clock-frequency = <400000>; > +}; > + > +&i2c3 { > + clock-frequency = <100000>; > +}; > + > +&mmc1 { > + status = "disabled"; > +}; > + > +&mmc2 { > + status = "disabled"; > +}; > + > +&mmc3 { > + status = "disabled"; > +}; > + > +&mcspi1 { > + /* > + * For some reason, touchscreen is necessary for screen to work at > + * all on real hw. It works well without it on emulator. > + * > + * Also... order in the device tree actually matters here. > + */ > + tsc2005 at 0 { > + compatible = "tsc2005"; > + spi-max-frequency = <6000000>; > + reg = <0>; > + }; > + mipid at 2 { > + compatible = "acx565akm"; > + spi-max-frequency = <6000000>; > + reg = <2>; > + }; > +}; > + > +&usb_otg_hs { > + interface-type = <0>; > + usb-phy = <&usb2_phy>; > + mode = <2>; > + power = <50>; > +}; >
next prev parent reply other threads:[~2013-08-13 14:06 UTC|newest] Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-06-09 1:59 N900 device tree conversion: how to do first step Pavel Machek 2013-06-09 1:59 ` Pavel Machek 2013-06-09 9:24 ` Pali Rohár 2013-06-09 9:24 ` Pali Rohár 2013-06-09 16:47 ` Pavel Machek 2013-06-09 16:47 ` Pavel Machek 2013-06-09 17:03 ` Pali Rohár 2013-06-09 17:03 ` Pali Rohár 2013-06-09 17:03 ` Pali Rohár 2013-06-09 17:30 ` Pavel Machek 2013-06-09 17:30 ` Pavel Machek 2013-06-09 20:11 ` Aaro Koskinen 2013-06-09 20:11 ` Aaro Koskinen 2013-06-13 13:26 ` Pavel Machek 2013-06-13 13:26 ` Pavel Machek 2013-06-13 14:10 ` Tony Lindgren 2013-06-13 14:10 ` Tony Lindgren 2013-06-13 14:28 ` Pavel Machek 2013-06-13 14:28 ` Pavel Machek 2013-06-13 14:57 ` Tony Lindgren 2013-06-13 14:57 ` Tony Lindgren 2013-06-13 15:52 ` Pavel Machek 2013-06-13 15:52 ` Pavel Machek 2013-06-13 16:14 ` Tony Lindgren 2013-06-13 16:14 ` Tony Lindgren 2013-06-13 23:08 ` Pavel Machek 2013-06-13 23:08 ` Pavel Machek 2013-06-14 5:56 ` Tony Lindgren 2013-06-14 5:56 ` Tony Lindgren 2013-06-14 21:28 ` Pavel Machek 2013-06-14 21:28 ` Pavel Machek 2013-06-17 11:10 ` Tony Lindgren 2013-06-17 11:10 ` Tony Lindgren 2013-06-27 12:12 ` N900 device tree conversion: next steps Pavel Machek 2013-07-01 14:03 ` [PATCH] N900: fix operation on emulator Pavel Machek 2013-07-01 14:03 ` Pavel Machek 2013-07-01 18:22 ` Sergei Shtylyov 2013-07-01 18:22 ` Sergei Shtylyov 2013-07-01 18:22 ` Sergei Shtylyov 2013-07-01 19:51 ` Pavel Machek 2013-07-01 19:51 ` Pavel Machek 2013-07-01 20:00 ` Sergei Shtylyov 2013-07-01 20:00 ` Sergei Shtylyov 2013-07-01 20:53 ` Pavel Machek 2013-07-01 20:53 ` Pavel Machek 2013-07-01 21:15 ` [PATCH] N900: enable N900-specific drivers even if device tree is enabled Pavel Machek 2013-07-01 21:15 ` Pavel Machek 2013-07-04 11:47 ` Tony Lindgren 2013-07-04 11:47 ` Tony Lindgren 2013-07-01 21:17 ` [PATCH] N900: add device tree Pavel Machek 2013-07-01 21:17 ` Pavel Machek 2013-07-04 17:19 ` Aaro Koskinen 2013-07-04 17:19 ` Aaro Koskinen 2013-07-04 20:21 ` Pavel Machek 2013-07-04 20:21 ` Pavel Machek 2013-07-04 20:32 ` Aaro Koskinen 2013-07-04 20:32 ` Aaro Koskinen 2013-07-13 12:17 ` [PATCH v2] " Pavel Machek 2013-07-13 12:17 ` Pavel Machek 2013-07-14 22:28 ` Aaro Koskinen 2013-07-14 22:28 ` Aaro Koskinen 2013-07-28 13:44 ` Pavel Machek 2013-07-28 13:44 ` Pavel Machek 2013-08-01 23:43 ` Pavel Machek 2013-08-01 23:43 ` Pavel Machek 2013-08-10 11:09 ` Pavel Machek 2013-08-10 11:09 ` Pavel Machek 2013-08-10 11:09 ` Pavel Machek 2013-08-10 11:27 ` [PATCH] ARM: dts: omap3 / n900 support, Benoit please take me (was Re: [PATCH v2] N900: add device tree) Pavel Machek 2013-08-10 11:27 ` Pavel Machek 2013-08-10 11:46 ` [PATCH v2] N900: add device tree Belisko Marek 2013-08-10 11:46 ` Belisko Marek 2013-08-10 20:29 ` Jiri Kosina 2013-08-10 20:29 ` Jiri Kosina 2013-08-11 0:55 ` OMAP device tree maintainance (was Re: [PATCH v2] N900: add device tree) Pavel Machek 2013-08-11 0:55 ` Pavel Machek 2013-08-11 11:50 ` [PATCH v2] N900: add device tree Javier Martinez Canillas 2013-08-11 11:50 ` Javier Martinez Canillas 2013-08-11 13:47 ` Pavel Machek 2013-08-11 13:47 ` Pavel Machek 2013-08-11 13:47 ` Pavel Machek 2013-08-12 7:37 ` Tony Lindgren 2013-08-12 7:37 ` Tony Lindgren 2013-08-12 7:36 ` Tony Lindgren 2013-08-12 7:36 ` Tony Lindgren 2013-08-11 15:02 ` Javier Martinez Canillas 2013-08-11 15:02 ` Javier Martinez Canillas 2013-08-13 10:50 ` Benoit Cousson 2013-08-13 10:50 ` Benoit Cousson 2013-08-13 13:36 ` [PATCH v3] " Pavel Machek 2013-08-13 13:36 ` Pavel Machek 2013-08-13 14:06 ` Benoit Cousson [this message] 2013-08-13 14:06 ` Benoit Cousson 2013-06-26 15:14 ` N900 device tree conversion: first step Pavel Machek 2013-07-19 18:14 ` N900 device tree conversion: how to do " Sebastian Reichel 2013-07-19 18:14 ` Sebastian Reichel 2013-07-19 18:14 ` Sebastian Reichel 2013-07-28 13:37 ` Pavel Machek 2013-07-28 13:37 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=520A3D57.1020906@baylibre.com \ --to=bcousson@baylibre.com \ --cc=aaro.koskinen@iki.fi \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=martinez.javier@gmail.com \ --cc=pali.rohar@gmail.com \ --cc=pavel@ucw.cz \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.