All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	Russell King <linux@arm.linux.org.uk>,
	linux-acpi@vger.kernel.org, drbd-user@lists.linbit.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	codalist@coda.cs.cmu.edu, linux-mtd@lists.infradead.org,
	Jan Kara <jack@suse.com>,
	linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org,
	Tony Luck <tony.luck@intel.com>, Boris Petkov <bp@suse.de>
Subject: Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()
Date: Mon, 09 Nov 2015 22:48:37 +0100	[thread overview]
Message-ID: <5253459.IxnqkcU2vL@vostro.rjw.lan> (raw)
In-Reply-To: <1447070170-8512-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>

On Monday, November 09, 2015 08:56:10 PM Tetsuo Handa wrote:
> There are many locations that do
> 
>   if (memory_was_allocated_by_vmalloc)
>     vfree(ptr);
>   else
>     kfree(ptr);
> 
> but kvfree() can handle both kmalloc()ed memory and vmalloc()ed memory
> using is_vmalloc_addr(). Unless callers have special reasons, we can
> replace this branch with kvfree(). Please check and reply if you found
> problems.

ACK for the ACPI changes (and CCing Tony and Boris for the heads-up as they
are way more famailiar with the APEI code than I am).

Thanks,
Rafael

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	Russell King <linux@arm.linux.org.uk>,
	linux-acpi@vger.kernel.org, drbd-user@lists.linbit.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	codalist@TELEMANN.coda.cs.cmu.edu, linux-mtd@lists.infradead.org,
	Jan Kara <jack@suse.com>,
	linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org,
	Tony Luck <tony.luck@intel.com>, Boris Petkov <bp@suse.de>
Subject: Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()
Date: Mon, 09 Nov 2015 22:48:37 +0100	[thread overview]
Message-ID: <5253459.IxnqkcU2vL@vostro.rjw.lan> (raw)
In-Reply-To: <1447070170-8512-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>

On Monday, November 09, 2015 08:56:10 PM Tetsuo Handa wrote:
> There are many locations that do
> 
>   if (memory_was_allocated_by_vmalloc)
>     vfree(ptr);
>   else
>     kfree(ptr);
> 
> but kvfree() can handle both kmalloc()ed memory and vmalloc()ed memory
> using is_vmalloc_addr(). Unless callers have special reasons, we can
> replace this branch with kvfree(). Please check and reply if you found
> problems.

ACK for the ACPI changes (and CCing Tony and Boris for the heads-up as they
are way more famailiar with the APEI code than I am).

Thanks,
Rafael


WARNING: multiple messages have this Message-ID (diff)
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	Russell King <linux@arm.linux.org.uk>,
	linux-acpi@vger.kernel.org, drbd-user@lists.linbit.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	codalist@coda.cs.cmu.edu, linux-mtd@lists.infradead.org,
	Jan Kara <jack@suse.com>,
	linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org,
	Tony Luck <tony.luck@intel.com>, Boris Petkov <bp@suse.de>
Subject: Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()
Date: Mon, 09 Nov 2015 22:48:37 +0100	[thread overview]
Message-ID: <5253459.IxnqkcU2vL@vostro.rjw.lan> (raw)
In-Reply-To: <1447070170-8512-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>

On Monday, November 09, 2015 08:56:10 PM Tetsuo Handa wrote:
> There are many locations that do
> 
>   if (memory_was_allocated_by_vmalloc)
>     vfree(ptr);
>   else
>     kfree(ptr);
> 
> but kvfree() can handle both kmalloc()ed memory and vmalloc()ed memory
> using is_vmalloc_addr(). Unless callers have special reasons, we can
> replace this branch with kvfree(). Please check and reply if you found
> problems.

ACK for the ACPI changes (and CCing Tony and Boris for the heads-up as they
are way more famailiar with the APEI code than I am).

Thanks,
Rafael

  parent reply	other threads:[~2015-11-09 21:48 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09 11:56 [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree() Tetsuo Handa
2015-11-09 11:56 ` Tetsuo Handa
2015-11-09 11:56 ` Tetsuo Handa
2015-11-09 11:56 ` Tetsuo Handa
2015-11-09 12:11 ` Jan Kara
2015-11-09 12:11   ` Jan Kara
2015-11-09 12:11   ` Jan Kara
2015-11-09 16:26   ` David Miller
2015-11-09 16:26     ` David Miller
2015-11-09 16:26     ` David Miller
2015-11-09 16:07 ` Russell King - ARM Linux
2015-11-09 16:07   ` Russell King - ARM Linux
2015-11-09 16:07   ` Russell King - ARM Linux
2015-11-09 16:07   ` Russell King - ARM Linux
2015-11-09 20:41 ` Dilger, Andreas
2015-11-09 20:41   ` Dilger, Andreas
2015-11-09 20:41   ` Dilger, Andreas
2015-11-09 21:48 ` Rafael J. Wysocki [this message]
2015-11-09 21:48   ` Rafael J. Wysocki
2015-11-09 21:48   ` Rafael J. Wysocki
2015-11-09 23:25   ` Luck, Tony
2015-11-09 23:25     ` Luck, Tony
2015-11-10 13:34 ` [DRBD-user] " Lars Ellenberg
2015-11-10 13:34   ` Lars Ellenberg
2015-11-19  0:23 ` David Rientjes
2015-11-19  0:23   ` David Rientjes
2015-11-19  0:23   ` David Rientjes
  -- strict thread matches above, loose matches on Subject: below --
2015-11-07 11:44 Tetsuo Handa
2015-11-07 11:44 ` Tetsuo Handa
2015-11-07 18:12 ` Joe Perches
2015-11-07 18:12   ` Joe Perches
2015-11-07 20:05 ` Andy Shevchenko
2015-11-07 20:05   ` Andy Shevchenko
2015-11-07 20:13   ` Andy Shevchenko
2015-11-07 20:13     ` Andy Shevchenko
2015-11-08  5:04     ` Tetsuo Handa
2015-11-08  5:04       ` Tetsuo Handa
2015-11-08  5:30       ` Sergey Senozhatsky
2015-11-08  5:30         ` Sergey Senozhatsky
2015-11-08 20:11       ` Andy Shevchenko
2015-11-08 20:11         ` Andy Shevchenko
2015-11-09 10:48 ` Michal Hocko
2015-11-09 10:48   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5253459.IxnqkcU2vL@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=akpm@linux-foundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=bp@suse.de \
    --cc=codalist@coda.cs.cmu.edu \
    --cc=drbd-user@lists.linbit.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jack@suse.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.