From: Vignesh Raghavendra <vigneshr@ti.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Linus Walleij <linus.walleij@linaro.org> Cc: <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>, Bryan Brattlof <bb@ti.com> Subject: Re: [PATCH 2/4] dt-bindings: pinctrl: k3: Introduce pinmux definitions for AM62A Date: Thu, 1 Sep 2022 11:02:12 +0530 [thread overview] Message-ID: <528ea531-dd6b-c147-8e22-3a4e41d97fe4@ti.com> (raw) In-Reply-To: <4001e0eb-f370-7bf4-89d0-ceed6d22e492@linaro.org> On 30/08/22 15:23, Krzysztof Kozlowski wrote: > On 29/08/2022 11:21, Vignesh Raghavendra wrote: >> Add pinctrl macros for AM62AX SoCs. These macro definitions are similar >> to that of previous platforms, but adding new definitions to avoid any >> naming confusions in the SoC dts files. >> >> checkpatch insists the following error exists: >> ERROR: Macros with complex values should be enclosed in parentheses >> >> However, we do not need parentheses enclosing the values for this >> macro as we do intend it to generate two separate values as has been >> done for other similar platforms. >> >> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> >> --- >> include/dt-bindings/pinctrl/k3.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/dt-bindings/pinctrl/k3.h b/include/dt-bindings/pinctrl/k3.h >> index a5204ab91d3e..97cd2e39efa4 100644 >> --- a/include/dt-bindings/pinctrl/k3.h >> +++ b/include/dt-bindings/pinctrl/k3.h >> @@ -44,4 +44,6 @@ >> #define AM62X_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> #define AM62X_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> >> +#define AM62AX_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> +#define AM62AX_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) > > Alphabetical order, so maybe before AM642? > These macros are ordered chronologically, will add a patch to reorder alphabetically to avoid confusion. > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Best regards, > Krzysztof -- Regards Vignesh
WARNING: multiple messages have this Message-ID (diff)
From: Vignesh Raghavendra <vigneshr@ti.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Linus Walleij <linus.walleij@linaro.org> Cc: <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>, Bryan Brattlof <bb@ti.com> Subject: Re: [PATCH 2/4] dt-bindings: pinctrl: k3: Introduce pinmux definitions for AM62A Date: Thu, 1 Sep 2022 11:02:12 +0530 [thread overview] Message-ID: <528ea531-dd6b-c147-8e22-3a4e41d97fe4@ti.com> (raw) In-Reply-To: <4001e0eb-f370-7bf4-89d0-ceed6d22e492@linaro.org> On 30/08/22 15:23, Krzysztof Kozlowski wrote: > On 29/08/2022 11:21, Vignesh Raghavendra wrote: >> Add pinctrl macros for AM62AX SoCs. These macro definitions are similar >> to that of previous platforms, but adding new definitions to avoid any >> naming confusions in the SoC dts files. >> >> checkpatch insists the following error exists: >> ERROR: Macros with complex values should be enclosed in parentheses >> >> However, we do not need parentheses enclosing the values for this >> macro as we do intend it to generate two separate values as has been >> done for other similar platforms. >> >> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> >> --- >> include/dt-bindings/pinctrl/k3.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/dt-bindings/pinctrl/k3.h b/include/dt-bindings/pinctrl/k3.h >> index a5204ab91d3e..97cd2e39efa4 100644 >> --- a/include/dt-bindings/pinctrl/k3.h >> +++ b/include/dt-bindings/pinctrl/k3.h >> @@ -44,4 +44,6 @@ >> #define AM62X_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> #define AM62X_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> >> +#define AM62AX_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) >> +#define AM62AX_MCU_IOPAD(pa, val, muxmode) (((pa) & 0x1fff)) ((val) | (muxmode)) > > Alphabetical order, so maybe before AM642? > These macros are ordered chronologically, will add a patch to reorder alphabetically to avoid confusion. > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Best regards, > Krzysztof -- Regards Vignesh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-01 5:32 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-29 8:21 [PATCH 0/4] arm64: dts: ti: Add support for AM62A family of SoCs Vignesh Raghavendra 2022-08-29 8:21 ` Vignesh Raghavendra 2022-08-29 8:21 ` [PATCH 1/4] dt-bindings: arm: ti: Add bindings for AM62A7 SoC Vignesh Raghavendra 2022-08-29 8:21 ` Vignesh Raghavendra 2022-08-30 9:52 ` Krzysztof Kozlowski 2022-08-30 9:52 ` Krzysztof Kozlowski 2022-09-01 5:30 ` Vignesh Raghavendra 2022-09-01 5:30 ` Vignesh Raghavendra 2022-08-29 8:21 ` [PATCH 2/4] dt-bindings: pinctrl: k3: Introduce pinmux definitions for AM62A Vignesh Raghavendra 2022-08-29 8:21 ` Vignesh Raghavendra 2022-08-30 9:53 ` Krzysztof Kozlowski 2022-08-30 9:53 ` Krzysztof Kozlowski 2022-09-01 5:32 ` Vignesh Raghavendra [this message] 2022-09-01 5:32 ` Vignesh Raghavendra 2022-08-31 13:37 ` Linus Walleij 2022-08-31 13:37 ` Linus Walleij 2022-08-29 8:21 ` [PATCH 3/4] arm64: dts: ti: Introduce AM62A7 family of SoCs Vignesh Raghavendra 2022-08-29 8:21 ` Vignesh Raghavendra 2022-08-30 9:56 ` Krzysztof Kozlowski 2022-08-30 9:56 ` Krzysztof Kozlowski 2022-09-01 5:39 ` Vignesh Raghavendra 2022-09-01 5:39 ` Vignesh Raghavendra 2022-08-29 8:22 ` [PATCH 4/4] arm64: dts: ti: Add support for AM62A7-SK Vignesh Raghavendra 2022-08-29 8:22 ` Vignesh Raghavendra 2022-08-30 9:57 ` Krzysztof Kozlowski 2022-08-30 9:57 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=528ea531-dd6b-c147-8e22-3a4e41d97fe4@ti.com \ --to=vigneshr@ti.com \ --cc=bb@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=kristo@kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nm@ti.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.