All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Puranjay Mohan <p-mohan@ti.com>, linux-kernel@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com,
	krzysztof.kozlowski+dt@linaro.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, nm@ti.com, ssantosh@kernel.org,
	s-anna@ti.com, linux-arm-kernel@lists.infradead.org,
	rogerq@kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com,
	kishon@ti.com, robh+dt@kernel.org, afd@ti.com, andrew@lunn.ch
Subject: Re: [PATCH v2 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver
Date: Tue, 31 May 2022 06:11:24 -0700	[thread overview]
Message-ID: <529649b4-a597-9304-0df6-1b1e577df38c@infradead.org> (raw)
In-Reply-To: <20220531095108.21757-3-p-mohan@ti.com>

Hi--

On 5/31/22 02:51, Puranjay Mohan wrote:
> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index fb30bc5d56cb..500d0591ad2a 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -182,4 +182,19 @@ config CPMAC
>  	help
>  	  TI AR7 CPMAC Ethernet support
>  
> +config TI_ICSSG_PRUETH
> +	tristate "TI Gigabit PRU Ethernet driver"
> +	select PHYLIB
> +
> +	depends on PRU_REMOTEPROC
> +	depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER
> +	help
> +	  Support dual Gigabit Ethernet ports over the ICSSG PRU Subsystem

	End the sentence above with a period ('.').

> +	  This subsystem is available starting with the AM65 platform.
> +
> +	  This driver requires firmware binaries which will run on the PRUs
> +	  to support the ethernet operation. Currently, it supports Ethernet

	Be consistent:   ethernet                       or          Ethernet

> +	  with 1G and 100M link speed.

-- 
~Randy

WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: Puranjay Mohan <p-mohan@ti.com>, linux-kernel@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com,
	krzysztof.kozlowski+dt@linaro.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, nm@ti.com, ssantosh@kernel.org,
	s-anna@ti.com, linux-arm-kernel@lists.infradead.org,
	rogerq@kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com,
	kishon@ti.com, robh+dt@kernel.org, afd@ti.com, andrew@lunn.ch
Subject: Re: [PATCH v2 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver
Date: Tue, 31 May 2022 06:11:24 -0700	[thread overview]
Message-ID: <529649b4-a597-9304-0df6-1b1e577df38c@infradead.org> (raw)
In-Reply-To: <20220531095108.21757-3-p-mohan@ti.com>

Hi--

On 5/31/22 02:51, Puranjay Mohan wrote:
> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index fb30bc5d56cb..500d0591ad2a 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -182,4 +182,19 @@ config CPMAC
>  	help
>  	  TI AR7 CPMAC Ethernet support
>  
> +config TI_ICSSG_PRUETH
> +	tristate "TI Gigabit PRU Ethernet driver"
> +	select PHYLIB
> +
> +	depends on PRU_REMOTEPROC
> +	depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER
> +	help
> +	  Support dual Gigabit Ethernet ports over the ICSSG PRU Subsystem

	End the sentence above with a period ('.').

> +	  This subsystem is available starting with the AM65 platform.
> +
> +	  This driver requires firmware binaries which will run on the PRUs
> +	  to support the ethernet operation. Currently, it supports Ethernet

	Be consistent:   ethernet                       or          Ethernet

> +	  with 1G and 100M link speed.

-- 
~Randy

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-05-31 13:11 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31  9:51 [PATCH v2 0/2] Introduce ICSSG based ethernet Driver Puranjay Mohan
2022-05-31  9:51 ` Puranjay Mohan
2022-05-31  9:51 ` [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings Puranjay Mohan
2022-05-31  9:51   ` Puranjay Mohan
2022-05-31 10:08   ` Krzysztof Kozlowski
2022-05-31 10:08     ` Krzysztof Kozlowski
2022-05-31 11:27     ` Puranjay Mohan
2022-05-31 11:27       ` Puranjay Mohan
2022-05-31 11:48       ` Krzysztof Kozlowski
2022-05-31 11:48         ` Krzysztof Kozlowski
2022-05-31 11:59         ` Puranjay Mohan
2022-05-31 11:59           ` Puranjay Mohan
2022-05-31 12:01           ` Krzysztof Kozlowski
2022-05-31 12:01             ` Krzysztof Kozlowski
2022-06-01  4:28             ` Puranjay Mohan
2022-06-01  4:28               ` Puranjay Mohan
2022-06-05 15:11       ` Andrew Lunn
2022-06-05 15:11         ` Andrew Lunn
2022-11-04  7:28     ` Md Danish Anwar
2022-11-04  7:28       ` Md Danish Anwar
2022-11-04 12:57       ` Krzysztof Kozlowski
2022-11-04 12:57         ` Krzysztof Kozlowski
2022-05-31 13:21   ` Rob Herring
2022-05-31 13:21     ` Rob Herring
2022-05-31  9:51 ` [PATCH v2 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver Puranjay Mohan
2022-05-31 10:20   ` Krzysztof Kozlowski
2022-05-31 10:20     ` Krzysztof Kozlowski
2022-05-31 11:23   ` Paolo Abeni
2022-05-31 11:23     ` Paolo Abeni
2022-11-04  8:29     ` Md Danish Anwar
2022-11-04  8:29       ` Md Danish Anwar
2022-05-31 13:11   ` Randy Dunlap [this message]
2022-05-31 13:11     ` Randy Dunlap
2022-06-05 15:37   ` Andrew Lunn
2022-06-05 15:37     ` Andrew Lunn
2022-11-04 10:26     ` Md Danish Anwar
2022-11-04 10:26       ` Md Danish Anwar
2022-06-05 16:24   ` Christophe JAILLET
2022-06-05 16:24     ` Christophe JAILLET
2022-11-04  9:50     ` Md Danish Anwar
2022-11-04  9:50       ` Md Danish Anwar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529649b4-a597-9304-0df6-1b1e577df38c@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=afd@ti.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=grygorii.strashko@ti.com \
    --cc=kishon@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=p-mohan@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=s-anna@ti.com \
    --cc=ssantosh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.