From: Paolo Bonzini <pbonzini@redhat.com> To: "Gabriel L. Somlo" <gsomlo@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com> Cc: Alex Williamson <alex.williamson@redhat.com>, Alexander Graf <agraf@suse.de>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "eddie.dong@intel.com" <eddie.dong@intel.com> Subject: Re: RFC: ioapic polarity vs. qemu os-x guest Date: Mon, 17 Feb 2014 19:06:11 +0100 [thread overview] Message-ID: <53024F93.3040709@redhat.com> (raw) In-Reply-To: <20140217180136.GQ29329@ERROL.INI.CMU.EDU> Il 17/02/2014 19:01, Gabriel L. Somlo ha scritto: > On Mon, Feb 17, 2014 at 12:57:00PM -0500, Gabriel L. Somlo wrote: >> On Sun, Feb 16, 2014 at 06:23:11PM +0200, Michael S. Tsirkin wrote: >>> Well there is a bigger issue: any interrupt with >>> multiple sources is broken. >>> >>> __kvm_irq_line_state does a logical OR of all sources, >>> before XOR with polarity. >>> >>> This makes no sense if polarity is active low. >> >> So, do you think something like this would make sense, to address >> active-low polarity in __kvm_irq_line_state ? >> (this would be independent of the subsequent xor in >> kvm_ioapic_set_irq()): > > Make that rather: > > -static inline int __kvm_irq_line_state(unsigned long *irq_state, > +static inline int __kvm_irq_line_state(unsigned long *irq_state, int polarity, > int irq_source_id, int level) > { > - /* Logical OR for level trig interrupt */ > if (level) > __set_bit(irq_source_id, irq_state); > else > __clear_bit(irq_source_id, irq_state); > > - return !!(*irq_state); > + if (polarity) { > + /* Logical AND for level trig interrupt, active-low */ > + return !~(*irq_state); This is ~*irq_state == 0, i.e. *irq_state == ~0. What if high-order bits of *irq_state are never used? That is, do you need to consider the maximum valid irq_source_id too? > + } else { > + /* Logical OR for level trig interrupt, active-high */ > + return !!(*irq_state); Better rewrite this as *irq_state != 0. Paolo > + } > } > > Thanks, and sorry for the noise :) > --Gabriel >
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com> To: "Gabriel L. Somlo" <gsomlo@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com> Cc: Alex Williamson <alex.williamson@redhat.com>, "eddie.dong@intel.com" <eddie.dong@intel.com>, Alexander Graf <agraf@suse.de>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org> Subject: Re: [Qemu-devel] RFC: ioapic polarity vs. qemu os-x guest Date: Mon, 17 Feb 2014 19:06:11 +0100 [thread overview] Message-ID: <53024F93.3040709@redhat.com> (raw) In-Reply-To: <20140217180136.GQ29329@ERROL.INI.CMU.EDU> Il 17/02/2014 19:01, Gabriel L. Somlo ha scritto: > On Mon, Feb 17, 2014 at 12:57:00PM -0500, Gabriel L. Somlo wrote: >> On Sun, Feb 16, 2014 at 06:23:11PM +0200, Michael S. Tsirkin wrote: >>> Well there is a bigger issue: any interrupt with >>> multiple sources is broken. >>> >>> __kvm_irq_line_state does a logical OR of all sources, >>> before XOR with polarity. >>> >>> This makes no sense if polarity is active low. >> >> So, do you think something like this would make sense, to address >> active-low polarity in __kvm_irq_line_state ? >> (this would be independent of the subsequent xor in >> kvm_ioapic_set_irq()): > > Make that rather: > > -static inline int __kvm_irq_line_state(unsigned long *irq_state, > +static inline int __kvm_irq_line_state(unsigned long *irq_state, int polarity, > int irq_source_id, int level) > { > - /* Logical OR for level trig interrupt */ > if (level) > __set_bit(irq_source_id, irq_state); > else > __clear_bit(irq_source_id, irq_state); > > - return !!(*irq_state); > + if (polarity) { > + /* Logical AND for level trig interrupt, active-low */ > + return !~(*irq_state); This is ~*irq_state == 0, i.e. *irq_state == ~0. What if high-order bits of *irq_state are never used? That is, do you need to consider the maximum valid irq_source_id too? > + } else { > + /* Logical OR for level trig interrupt, active-high */ > + return !!(*irq_state); Better rewrite this as *irq_state != 0. Paolo > + } > } > > Thanks, and sorry for the noise :) > --Gabriel >
next prev parent reply other threads:[~2014-02-17 18:47 UTC|newest] Thread overview: 155+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-01-08 20:02 [Qemu-devel] [PATCH] Add option to disable FDC from ISA bus and ACPI on i386 Gabriel L. Somlo 2014-01-08 20:38 ` Michael S. Tsirkin 2014-01-08 21:09 ` Gabriel L. Somlo 2014-01-15 11:13 ` Paolo Bonzini 2014-01-08 22:13 ` Paolo Bonzini 2014-01-08 23:39 ` Gabriel L. Somlo 2014-01-09 0:12 ` Alexander Graf 2014-01-09 1:51 ` Michael S. Tsirkin 2014-01-09 18:51 ` Gabriel L. Somlo 2014-01-09 20:12 ` Paolo Bonzini 2014-01-09 21:33 ` Michael S. Tsirkin 2014-01-09 21:58 ` Gabriel L. Somlo 2014-01-09 21:44 ` Gabriel L. Somlo 2014-01-10 12:37 ` Paolo Bonzini 2014-01-10 15:35 ` Gabriel L. Somlo 2014-01-10 16:13 ` Igor Mammedov 2014-01-17 21:10 ` [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP Gabriel L. Somlo 2014-01-20 11:58 ` Michael S. Tsirkin 2014-01-20 11:57 ` Paolo Bonzini 2014-01-20 12:08 ` Michael S. Tsirkin 2014-01-20 12:16 ` Paolo Bonzini 2014-01-20 18:54 ` Gabriel L. Somlo 2014-01-20 20:31 ` Michael S. Tsirkin 2014-01-20 21:25 ` Gabriel L. Somlo 2014-01-21 10:33 ` Paolo Bonzini 2014-01-21 11:02 ` Michael S. Tsirkin 2014-01-21 11:05 ` Paolo Bonzini 2014-01-21 11:44 ` Michael S. Tsirkin 2014-01-21 18:11 ` [Qemu-devel] [PATCH] ACPI: Add IRQ resource to HPET._CRS on Mac OS X Gabriel L. Somlo 2014-01-21 18:38 ` Michael S. Tsirkin 2014-01-24 16:46 ` Gabriel L. Somlo 2014-01-24 21:18 ` Alexander Graf 2014-01-25 0:09 ` Gabriel L. Somlo 2014-01-25 9:08 ` Alexander Graf 2014-01-27 22:51 ` Gabriel L. Somlo 2014-01-27 23:51 ` Alexander Graf 2014-01-28 16:45 ` [Qemu-devel] OSX guest support review Gabriel L. Somlo 2014-01-28 16:57 ` Michael S. Tsirkin 2014-01-29 14:17 ` Alexander Graf 2014-01-29 21:36 ` [Qemu-devel] OSX guest vs. kvm ioapic polarity Gabriel L. Somlo 2014-01-29 22:18 ` Michael S. Tsirkin 2014-01-30 14:18 ` Gabriel L. Somlo 2014-01-30 19:48 ` Michael S. Tsirkin 2014-01-30 20:21 ` Gabriel L. Somlo 2014-01-30 20:28 ` Michael S. Tsirkin 2014-01-30 20:33 ` Michael S. Tsirkin 2014-01-30 20:44 ` Gabriel L. Somlo 2014-02-11 18:23 ` RFC: ioapic polarity vs. qemu os-x guest Gabriel L. Somlo 2014-02-11 18:23 ` [Qemu-devel] " Gabriel L. Somlo 2014-02-11 19:54 ` Michael S. Tsirkin 2014-02-11 19:54 ` [Qemu-devel] " Michael S. Tsirkin 2014-02-11 21:35 ` Gabriel L. Somlo 2014-02-11 21:35 ` [Qemu-devel] " Gabriel L. Somlo 2014-02-14 21:13 ` Gabriel L. Somlo 2014-02-14 21:13 ` [Qemu-devel] " Gabriel L. Somlo 2014-02-14 21:21 ` Alexander Graf 2014-02-14 21:21 ` [Qemu-devel] " Alexander Graf 2014-02-14 22:06 ` Gabriel L. Somlo 2014-02-14 22:06 ` [Qemu-devel] " Gabriel L. Somlo 2014-02-14 22:13 ` Alexander Graf 2014-02-14 22:13 ` [Qemu-devel] " Alexander Graf 2014-02-16 11:18 ` Michael S. Tsirkin 2014-02-16 11:18 ` [Qemu-devel] " Michael S. Tsirkin 2014-02-16 11:41 ` Michael S. Tsirkin 2014-02-16 11:41 ` [Qemu-devel] " Michael S. Tsirkin 2014-02-16 14:47 ` Alex Williamson 2014-02-16 14:47 ` [Qemu-devel] " Alex Williamson 2014-02-16 16:23 ` Michael S. Tsirkin 2014-02-16 16:23 ` [Qemu-devel] " Michael S. Tsirkin 2014-02-17 17:57 ` Gabriel L. Somlo 2014-02-17 17:57 ` [Qemu-devel] " Gabriel L. Somlo 2014-02-17 18:01 ` Gabriel L. Somlo 2014-02-17 18:01 ` [Qemu-devel] " Gabriel L. Somlo 2014-02-17 18:06 ` Paolo Bonzini [this message] 2014-02-17 18:06 ` Paolo Bonzini 2014-02-17 19:38 ` Gabriel L. Somlo 2014-02-17 19:38 ` [Qemu-devel] " Gabriel L. Somlo 2014-02-18 0:58 ` Gabriel L. Somlo 2014-02-18 0:58 ` [Qemu-devel] " Gabriel L. Somlo 2014-02-27 17:05 ` [PATCH RFC] kvm: ignore apic polarity Michael S. Tsirkin 2014-02-27 17:05 ` [Qemu-devel] " Michael S. Tsirkin 2014-02-27 21:41 ` Gabriel L. Somlo 2014-02-27 21:41 ` [Qemu-devel] " Gabriel L. Somlo 2014-02-27 22:30 ` Paolo Bonzini 2014-02-27 22:30 ` [Qemu-devel] " Paolo Bonzini 2014-02-27 23:13 ` Gabriel L. Somlo 2014-02-27 23:13 ` [Qemu-devel] " Gabriel L. Somlo 2014-02-27 23:31 ` Paolo Bonzini 2014-02-27 23:31 ` [Qemu-devel] " Paolo Bonzini 2014-02-28 4:06 ` [RFC PATCH v2] kvm: x86: ignore ioapic polarity Gabriel L. Somlo 2014-02-28 4:06 ` [Qemu-devel] " Gabriel L. Somlo 2014-02-28 17:23 ` [Qemu-devel] [RFC PATCH] qemu: " Gabriel L. Somlo 2014-02-28 18:57 ` [Qemu-devel] [RFC PATCH v2] " Gabriel L. Somlo 2014-02-28 19:14 ` [Qemu-devel] [PATCH] qemu: x86: report lapic version as 0x14 instead of 0x11 Gabriel L. Somlo 2014-03-01 3:44 ` Alexander Graf 2014-03-01 4:25 ` Gabriel L. Somlo 2014-03-01 5:45 ` Alexander Graf 2014-03-01 14:46 ` Paolo Bonzini 2014-03-02 0:17 ` Gabriel L. Somlo 2014-03-02 8:56 ` Paolo Bonzini 2014-03-02 14:31 ` Michael S. Tsirkin 2014-03-02 16:02 ` Michael S. Tsirkin 2014-03-06 7:50 ` Michael S. Tsirkin 2014-03-02 14:52 ` [Qemu-devel] [RFC PATCH v2] qemu: x86: ignore ioapic polarity Michael S. Tsirkin 2014-03-02 16:15 ` Gabriel L. Somlo 2014-03-02 17:09 ` Michael S. Tsirkin 2014-03-06 7:45 ` Michael S. Tsirkin 2014-03-02 14:55 ` [RFC PATCH v2] kvm: " Michael S. Tsirkin 2014-03-02 14:55 ` [Qemu-devel] " Michael S. Tsirkin 2014-03-13 10:53 ` Paolo Bonzini 2014-03-13 10:53 ` [Qemu-devel] " Paolo Bonzini 2014-03-13 13:43 ` Gabriel L. Somlo 2014-03-13 13:43 ` [Qemu-devel] " Gabriel L. Somlo 2014-02-28 4:55 ` [PATCH RFC] kvm: ignore apic polarity Michael S. Tsirkin 2014-02-28 4:55 ` [Qemu-devel] " Michael S. Tsirkin 2014-02-28 8:10 ` Paolo Bonzini 2014-02-28 8:10 ` [Qemu-devel] " Paolo Bonzini 2014-02-28 8:11 ` Paolo Bonzini 2014-02-28 8:11 ` [Qemu-devel] " Paolo Bonzini 2014-03-01 5:03 ` Alex Williamson 2014-03-01 5:03 ` [Qemu-devel] " Alex Williamson 2014-02-16 11:34 ` RFC: ioapic polarity vs. qemu os-x guest Michael S. Tsirkin 2014-02-16 11:34 ` [Qemu-devel] " Michael S. Tsirkin 2014-02-16 15:12 ` Peter Maydell 2014-02-16 11:37 ` Michael S. Tsirkin 2014-02-16 11:37 ` [Qemu-devel] " Michael S. Tsirkin 2014-01-29 23:13 ` [Qemu-devel] OSX guest vs. kvm ioapic polarity Alexander Graf 2014-01-30 15:56 ` Gabriel L. Somlo 2014-01-28 20:40 ` [Qemu-devel] osx bootloader Gabriel L. Somlo 2014-01-28 22:51 ` BALATON Zoltan 2014-01-29 3:07 ` Gabriel L. Somlo 2014-01-29 11:29 ` BALATON Zoltan 2014-01-29 14:53 ` Gabriel L. Somlo 2014-01-29 15:00 ` Alexander Graf 2014-01-30 0:15 ` BALATON Zoltan 2014-02-01 17:43 ` BALATON Zoltan 2014-02-01 0:38 ` BALATON Zoltan 2014-02-01 10:07 ` Alexander Graf 2014-02-01 14:35 ` [Qemu-devel] OVMF with q35 (was: osx bootloader) BALATON Zoltan 2014-02-01 15:13 ` Alexander Graf 2014-02-01 17:38 ` BALATON Zoltan 2014-02-03 7:47 ` Gerd Hoffmann 2014-02-01 21:19 ` [Qemu-devel] osx bootloader Paolo Bonzini 2014-02-02 2:18 ` BALATON Zoltan 2014-01-29 12:10 ` BALATON Zoltan 2014-01-29 14:20 ` Alexander Graf 2014-01-21 11:38 ` [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP Michael S. Tsirkin 2014-01-20 20:23 ` Michael S. Tsirkin 2014-01-20 12:03 ` Igor Mammedov 2014-01-09 8:46 ` [Qemu-devel] [PATCH] Add option to disable FDC from ISA bus and ACPI on i386 Markus Armbruster 2014-01-09 10:24 ` Paolo Bonzini 2014-01-31 19:03 ` [Qemu-devel] [RFC PATCH v2] Add option to switch off FDC Gabriel L. Somlo 2014-01-31 19:39 ` Eric Blake 2014-02-02 13:47 ` Michael S. Tsirkin 2014-02-10 14:10 ` Marcel Apfelbaum
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=53024F93.3040709@redhat.com \ --to=pbonzini@redhat.com \ --cc=agraf@suse.de \ --cc=alex.williamson@redhat.com \ --cc=eddie.dong@intel.com \ --cc=gsomlo@gmail.com \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.