All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chung-Lin Tang <chunglin_tang@mentor.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Ley Foon Tan <lftan@altera.com>,
	Arnd Bergmann <arnd@arndb.de>
Cc: <linux-arch@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-doc@vger.kernel.org>,
	Chung-Lin Tang <cltang@CODESOURCERY.COM>
Subject: Re: [PATCH 00/28] nios2 Linux kernel port
Date: Mon, 21 Apr 2014 16:14:03 +0800	[thread overview]
Message-ID: <5354D34B.4030607@mentor.com> (raw)
In-Reply-To: <5354AD36.5090809@zytor.com>

On 14/4/21 1:31 PM, H. Peter Anvin wrote:
> On 04/20/2014 10:23 PM, Ley Foon Tan wrote:
>> On Sat, Apr 19, 2014 at 11:30 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> On Friday 18 April 2014, H. Peter Anvin wrote:
>>>> Did the generic headers ever get updated to match Linus' guidance that
>>>> any new architecture ports should use a 64-bit time_t?
>>>
>>> No, unfortunately not. With my rule that every architecture that gets
>>> added needs to clean up asm-generic some more, to make it easier to add
>>> the next one, we should probably do for nios2.
>>>
>>>         Arnd
>>
>> Can you give me the documentation on this new guidance and point me
>> any architecture have implemented this?
>> Thanks.
>>
> 
> We implemented it in the x32 ABI for x86.  In generic code this is keyed
> by COMPAT_USE_64BIT_TIME, but in your case it isn't actually a matter of
> compat, so it should be easier.
> 
> See this thread including the discussion about time_t:
> 
> https://lkml.org/lkml/2011/8/26/415
> 
> 	-hpa


I'm not sure why we need CONFIG_USE_64BIT_TIME? We don't have any
32-on-64 problems.

My understanding of what Arnd meant, was to clean up
asm-generic/posix_types.h such that for example, time_t should be
defined as a 'long long' type, which should be 64-bit almost everywhere.
At least AFAIK, that should work for all current asm-generic users.

Thanks,
Chung-Lin


WARNING: multiple messages have this Message-ID (diff)
From: Chung-Lin Tang <chunglin_tang@mentor.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Ley Foon Tan <lftan@altera.com>,
	Arnd Bergmann <arnd@arndb.de>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org,
	Chung-Lin Tang <cltang@CODESOURCERY.COM>
Subject: Re: [PATCH 00/28] nios2 Linux kernel port
Date: Mon, 21 Apr 2014 16:14:03 +0800	[thread overview]
Message-ID: <5354D34B.4030607@mentor.com> (raw)
In-Reply-To: <5354AD36.5090809@zytor.com>

On 14/4/21 1:31 PM, H. Peter Anvin wrote:
> On 04/20/2014 10:23 PM, Ley Foon Tan wrote:
>> On Sat, Apr 19, 2014 at 11:30 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> On Friday 18 April 2014, H. Peter Anvin wrote:
>>>> Did the generic headers ever get updated to match Linus' guidance that
>>>> any new architecture ports should use a 64-bit time_t?
>>>
>>> No, unfortunately not. With my rule that every architecture that gets
>>> added needs to clean up asm-generic some more, to make it easier to add
>>> the next one, we should probably do for nios2.
>>>
>>>         Arnd
>>
>> Can you give me the documentation on this new guidance and point me
>> any architecture have implemented this?
>> Thanks.
>>
> 
> We implemented it in the x32 ABI for x86.  In generic code this is keyed
> by COMPAT_USE_64BIT_TIME, but in your case it isn't actually a matter of
> compat, so it should be easier.
> 
> See this thread including the discussion about time_t:
> 
> https://lkml.org/lkml/2011/8/26/415
> 
> 	-hpa


I'm not sure why we need CONFIG_USE_64BIT_TIME? We don't have any
32-on-64 problems.

My understanding of what Arnd meant, was to clean up
asm-generic/posix_types.h such that for example, time_t should be
defined as a 'long long' type, which should be 64-bit almost everywhere.
At least AFAIK, that should work for all current asm-generic users.

Thanks,
Chung-Lin


  reply	other threads:[~2014-04-21  8:14 UTC|newest]

Thread overview: 166+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-18 12:26 [PATCH 00/28] nios2 Linux kernel port Ley Foon Tan
2014-04-18 12:26 ` Ley Foon Tan
2014-04-18 12:26 ` [PATCH 01/28] nios2: Build infrastructure Ley Foon Tan
2014-04-18 12:26   ` Ley Foon Tan
2014-04-18 14:35   ` Sam Ravnborg
2014-04-21  3:03     ` Ley Foon Tan
2014-04-21  3:03       ` Ley Foon Tan
2014-04-18 19:16   ` Paul Bolle
2014-04-21  5:02     ` Ley Foon Tan
2014-04-21  5:02       ` Ley Foon Tan
2014-04-18 19:41   ` Paul Bolle
2014-04-21  3:26     ` Ley Foon Tan
2014-04-21  3:26       ` Ley Foon Tan
2014-04-18 12:26 ` [PATCH 02/28] nios2: Assembly macros and definitions Ley Foon Tan
2014-04-18 12:26   ` Ley Foon Tan
2014-04-18 12:26 ` [PATCH 04/28] nios2: Exception handling Ley Foon Tan
2014-04-18 12:26   ` Ley Foon Tan
2014-04-22 10:57   ` Ezequiel Garcia
2014-04-22 11:08     ` Ley Foon Tan
2014-04-22 12:33   ` Arnd Bergmann
2014-04-23  2:47     ` Ley Foon Tan
2014-04-23  7:20       ` Geert Uytterhoeven
2014-04-23 12:23         ` Arnd Bergmann
2014-04-24  6:04           ` Ley Foon Tan
2014-04-18 12:26 ` [PATCH 06/28] nios2: Memory management Ley Foon Tan
2014-04-18 12:26   ` Ley Foon Tan
2014-04-22 14:24   ` Ezequiel Garcia
2014-04-22 15:14     ` Tobias Klauser
2014-04-22 15:35       ` Ezequiel Garcia
2014-04-22 16:01         ` Chung-Lin Tang
2014-04-22 16:01           ` Chung-Lin Tang
2014-04-22 16:27           ` Ezequiel Garcia
2014-04-22 16:36             ` Chung-Lin Tang
2014-04-22 16:36               ` Chung-Lin Tang
2014-04-22 16:24         ` Sam Ravnborg
2014-04-23  2:53           ` LF.Tan
2014-04-23  7:24           ` Geert Uytterhoeven
2014-04-18 12:26 ` [PATCH 08/28] nios2: MMU Fault handling Ley Foon Tan
2014-04-18 12:26   ` Ley Foon Tan
2014-04-22 14:30   ` Ezequiel Garcia
2014-04-24  6:42     ` Ley Foon Tan
2014-04-24 15:22       ` Ezequiel Garcia
2014-04-24 16:02         ` Ley Foon Tan
2014-04-24 16:18           ` Ezequiel Garcia
2014-04-24  7:18     ` Geert Uytterhoeven
2014-04-24  7:18       ` Geert Uytterhoeven
2014-04-24  7:18       ` Geert Uytterhoeven
2014-04-18 12:26 ` [PATCH 09/28] nios2: Page table management Ley Foon Tan
2014-04-18 12:26   ` Ley Foon Tan
2014-04-19 16:05   ` Pavel Machek
2014-04-22  8:09     ` Ley Foon Tan
2014-04-18 12:26 ` [PATCH 10/28] nios2: Process management Ley Foon Tan
2014-04-18 12:26   ` Ley Foon Tan
2014-04-18 12:26 ` [PATCH 11/28] nios2: Cache handling Ley Foon Tan
2014-04-18 12:26   ` Ley Foon Tan
2014-04-18 12:26 ` [PATCH 12/28] nios2: TLB handling Ley Foon Tan
2014-04-18 12:26   ` Ley Foon Tan
2014-04-18 12:26 ` [PATCH 13/28] nios2: Interrupt handling Ley Foon Tan
2014-04-18 12:26   ` Ley Foon Tan
2014-04-18 12:26 ` [PATCH 15/28] nios2: ELF definitions Ley Foon Tan
2014-04-18 12:26   ` Ley Foon Tan
2014-04-18 12:26 ` [PATCH 16/28] nios2: System calls handling Ley Foon Tan
2014-04-18 12:26   ` Ley Foon Tan
2014-04-19 16:09   ` Pavel Machek
2014-04-21 17:32     ` Ley Foon Tan
2014-04-21 17:52       ` Richard Weinberger
2014-04-21 20:48         ` Pavel Machek
2014-04-22  8:24           ` Ley Foon Tan
2014-04-21 20:46       ` Pavel Machek
2014-04-19 20:12   ` Geert Uytterhoeven
2014-04-21 17:23     ` Ley Foon Tan
2014-04-22 12:30   ` Arnd Bergmann
2014-04-24 16:23     ` Ley Foon Tan
2014-04-18 12:27 ` [PATCH 17/28] nios2: Signal handling support Ley Foon Tan
2014-04-18 12:27   ` Ley Foon Tan
2014-04-19 19:29   ` Richard Weinberger
2014-04-24 10:01     ` Ley Foon Tan
2014-04-24 10:07       ` Richard Weinberger
2014-04-24 10:13       ` Ley Foon Tan
2014-04-24 10:17         ` Richard Weinberger
2014-04-24 10:29           ` Ley Foon Tan
2014-04-24 10:39             ` Richard Weinberger
2014-04-24 10:46               ` Ley Foon Tan
2014-04-24 16:16                 ` Richard Weinberger
2014-04-18 12:27 ` [PATCH 18/28] nios2: Library functions Ley Foon Tan
2014-04-18 12:27   ` Ley Foon Tan
2014-04-18 12:27 ` [PATCH 19/28] nios2: Device tree support Ley Foon Tan
2014-04-18 12:27   ` Ley Foon Tan
2014-04-22 13:42   ` Arnd Bergmann
2014-04-23  6:52     ` Ley Foon Tan
2014-04-23  7:35       ` Arnd Bergmann
2014-04-23  9:52         ` Ley Foon Tan
2014-04-24 16:05     ` Ezequiel Garcia
2014-04-18 12:27 ` [PATCH 20/28] nios2: Time keeping Ley Foon Tan
2014-04-18 12:27   ` Ley Foon Tan
2014-04-22 13:44   ` Arnd Bergmann
2014-04-23  3:21     ` Ley Foon Tan
2014-04-18 12:27 ` [PATCH 21/28] nios2: Cpuinfo handling Ley Foon Tan
2014-04-18 12:27   ` Ley Foon Tan
2014-04-18 12:27 ` [PATCH 22/28] nios2: Miscellaneous header files Ley Foon Tan
2014-04-18 12:27   ` Ley Foon Tan
2014-04-18 12:27 ` [PATCH 23/28] nios2: Nios2 registers Ley Foon Tan
2014-04-18 12:27   ` Ley Foon Tan
2014-04-22 12:39   ` Tobias Klauser
2014-04-23  7:10     ` Ley Foon Tan
2014-04-23  8:00       ` Tobias Klauser
2014-04-18 12:27 ` [PATCH 24/28] nios2: Module support Ley Foon Tan
2014-04-18 12:27   ` Ley Foon Tan
2014-04-18 12:27 ` [PATCH 25/28] nios2: ptrace support Ley Foon Tan
2014-04-18 12:27   ` Ley Foon Tan
2014-04-25 23:52   ` Pedro Alves
2014-04-28  6:03     ` Ley Foon Tan
2014-04-18 12:27 ` [PATCH 26/28] Add ELF machine define for Nios2 Ley Foon Tan
2014-04-18 12:27   ` Ley Foon Tan
2014-04-18 12:27 ` [PATCH 27/28] MAINTAINERS: Add nios2 maintainer Ley Foon Tan
2014-04-18 12:27   ` Ley Foon Tan
2014-04-18 12:27 ` [PATCH 28/28] Documentation: Add documentation for Nios2 architecture Ley Foon Tan
2014-04-18 12:27   ` Ley Foon Tan
2014-04-22 12:28   ` Tobias Klauser
2014-04-23  7:48     ` Ley Foon Tan
2014-04-18 18:19 ` [PATCH 03/28] nios2: Kernel booting and initialization Ley Foon Tan
2014-04-18 18:19   ` Ley Foon Tan
2014-04-18 18:19   ` [PATCH 05/28] nios2: Traps exception handling Ley Foon Tan
2014-04-18 18:19     ` Ley Foon Tan
2014-04-22 14:28     ` Ezequiel Garcia
2014-04-23 10:07       ` Ley Foon Tan
2014-04-18 18:19   ` [PATCH 07/28] nios2: I/O Mapping Ley Foon Tan
2014-04-18 18:19     ` Ley Foon Tan
2014-04-22 13:59     ` Arnd Bergmann
2014-04-24  6:02       ` Ley Foon Tan
2014-04-24  7:43         ` Arnd Bergmann
2014-04-24 15:51           ` Ley Foon Tan
2014-05-02 10:37         ` Ley Foon Tan
2014-05-02 12:22           ` Arnd Bergmann
2014-05-05  7:13             ` Ley Foon Tan
2014-04-18 18:19   ` [PATCH 14/28] nios2: DMA mapping API Ley Foon Tan
2014-04-18 18:19     ` Ley Foon Tan
2014-04-22 13:52     ` Arnd Bergmann
2014-04-25 10:13       ` Ley Foon Tan
2014-04-25 10:33         ` Arnd Bergmann
2014-04-25 10:36           ` Ley Foon Tan
2014-04-18 20:48 ` [PATCH 00/28] nios2 Linux kernel port H. Peter Anvin
2014-04-19 15:30   ` Arnd Bergmann
2014-04-21  5:23     ` Ley Foon Tan
2014-04-21  5:31       ` H. Peter Anvin
2014-04-21  8:14         ` Chung-Lin Tang [this message]
2014-04-21  8:14           ` Chung-Lin Tang
2014-04-22 10:37         ` Ley Foon Tan
2014-04-22 10:56           ` Arnd Bergmann
2014-04-22 11:20             ` Ley Foon Tan
2014-04-22 14:48               ` Chung-Lin Tang
2014-04-23 17:59               ` Chung-Lin Tang
2014-04-23 17:59                 ` Chung-Lin Tang
2014-04-23 18:15                 ` Pinski, Andrew
2014-04-23 19:21                   ` H. Peter Anvin
2014-04-24  6:26                   ` Chung-Lin Tang
2014-04-24  8:55                     ` Chung-Lin Tang
2014-04-24 15:28                       ` Catalin Marinas
2014-04-24 18:37                         ` Chung-Lin Tang
2014-04-24 18:42                           ` Pinski, Andrew
2014-04-25  6:06                             ` Chung-Lin Tang
2014-04-25  8:37                               ` Pinski, Andrew
2014-04-25 13:19                                 ` Chung-Lin Tang
2014-04-25  8:49                               ` Geert Uytterhoeven
2014-04-18 16:49 Ley Foon Tan
2014-04-18 18:38 ` Ley Foon Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5354D34B.4030607@mentor.com \
    --to=chunglin_tang@mentor.com \
    --cc=arnd@arndb.de \
    --cc=cltang@CODESOURCERY.COM \
    --cc=hpa@zytor.com \
    --cc=lftan@altera.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.