All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <t.figa@samsung.com>
To: Chanho Park <chanho61.park@samsung.com>,
	kgene.kim@samsung.com, linux-samsung-soc@vger.kernel.org
Cc: k.debski@samsung.com, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/4] ARM: dts: exynos4: add exynos_usbphy node
Date: Thu, 24 Apr 2014 18:09:45 +0200	[thread overview]
Message-ID: <53593749.5020009@samsung.com> (raw)
In-Reply-To: <1397479700-15864-3-git-send-email-chanho61.park@samsung.com>

Hi Chanho,

On 14.04.2014 14:48, Chanho Park wrote:
> This patch enables a exynos_usbphy node for exynos4 SoCs.
> A exynos4x12 usb phy node is almost same with 4210's one
> except compatible string and pmu syscon.
>
> Cc: Tomasz Figa <t.figa@samsung.com>
> Cc: Kamil Debski <k.debski@samsung.com>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
>   arch/arm/boot/dts/exynos4.dtsi    | 10 ++++++++++
>   arch/arm/boot/dts/exynos4x12.dtsi |  5 +++++
>   2 files changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index e565b86..0e32d7f 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -278,6 +278,16 @@
>   		status = "disabled";
>   	};
>
> +	exynos_usbphy: exynos-usbphy@125B0000 {
> +		compatible = "samsung,exynos4210-usb2-phy";
> +		reg = <0x125B0000 0x100>;
> +		samsung,pmureg-phandle = <&pmu_reg>;
> +		clocks = <&clock 305>, <&clock 2>;

Please use clock macros from include/dt-bindings instead of numbers 
directly.

Best regards,
Tomasz

WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: dts: exynos4: add exynos_usbphy node
Date: Thu, 24 Apr 2014 18:09:45 +0200	[thread overview]
Message-ID: <53593749.5020009@samsung.com> (raw)
In-Reply-To: <1397479700-15864-3-git-send-email-chanho61.park@samsung.com>

Hi Chanho,

On 14.04.2014 14:48, Chanho Park wrote:
> This patch enables a exynos_usbphy node for exynos4 SoCs.
> A exynos4x12 usb phy node is almost same with 4210's one
> except compatible string and pmu syscon.
>
> Cc: Tomasz Figa <t.figa@samsung.com>
> Cc: Kamil Debski <k.debski@samsung.com>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
>   arch/arm/boot/dts/exynos4.dtsi    | 10 ++++++++++
>   arch/arm/boot/dts/exynos4x12.dtsi |  5 +++++
>   2 files changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index e565b86..0e32d7f 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -278,6 +278,16 @@
>   		status = "disabled";
>   	};
>
> +	exynos_usbphy: exynos-usbphy at 125B0000 {
> +		compatible = "samsung,exynos4210-usb2-phy";
> +		reg = <0x125B0000 0x100>;
> +		samsung,pmureg-phandle = <&pmu_reg>;
> +		clocks = <&clock 305>, <&clock 2>;

Please use clock macros from include/dt-bindings instead of numbers 
directly.

Best regards,
Tomasz

  reply	other threads:[~2014-04-24 16:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-14 12:48 [PATCH 0/4] Enable usbphy and hsotg for exynos4 Chanho Park
2014-04-14 12:48 ` Chanho Park
2014-04-14 12:48 ` [PATCH 1/4] ARM: dts: exynos4: add PMU syscon node Chanho Park
2014-04-14 12:48   ` Chanho Park
2014-04-24 16:07   ` Tomasz Figa
2014-04-24 16:07     ` Tomasz Figa
2014-04-25  8:05     ` Vikas Sajjan
2014-04-25  8:05       ` Vikas Sajjan
2014-04-25 23:52       ` Tomasz Figa
2014-04-25 23:52         ` Tomasz Figa
2014-04-26  2:33         ` Pankaj Dubey
2014-04-26  2:33           ` Pankaj Dubey
2014-04-14 12:48 ` [PATCH 2/4] ARM: dts: exynos4: add exynos_usbphy node Chanho Park
2014-04-14 12:48   ` Chanho Park
2014-04-24 16:09   ` Tomasz Figa [this message]
2014-04-24 16:09     ` Tomasz Figa
2014-04-14 12:48 ` [PATCH 3/4] ARM: dts: exynos4: add hsotg device node Chanho Park
2014-04-14 12:48   ` Chanho Park
2014-04-24 16:16   ` Tomasz Figa
2014-04-24 16:16     ` Tomasz Figa
2014-04-14 12:48 ` [PATCH 4/4] ARM: dts: exynos4412-trats2: enable usb nodes Chanho Park
2014-04-14 12:48   ` Chanho Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53593749.5020009@samsung.com \
    --to=t.figa@samsung.com \
    --cc=chanho61.park@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=k.debski@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.