From: David Marchand <david.marchand@6wind.com>
To: Stefan Hajnoczi <stefanha@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Henning Schild <henning.schild@siemens.com>,
Olivier MATZ <olivier.matz@6wind.com>, kvm <kvm@vger.kernel.org>,
qemu-devel <qemu-devel@nongnu.org>,
Linux Virtualization <virtualization@lists.linux-foundation.org>,
Vincent JARDIN <vincent.jardin@6wind.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
Subject: Re: [Qemu-devel] Why I advise against using ivshmem
Date: Wed, 18 Jun 2014 16:57:02 +0200 [thread overview]
Message-ID: <53A1A8BE.3000801__47674.236042849$1404408007$gmane$org@6wind.com> (raw)
In-Reply-To: <20140618104849.GH14030@stefanha-thinkpad.redhat.com>
Hello Stefan,
On 06/18/2014 12:48 PM, Stefan Hajnoczi wrote:
> One more thing to add to the list:
>
> static void ivshmem_read(void *opaque, const uint8_t * buf, int flags)
>
> The "flags" argument should be "size". Size should be checked before
> accessing buf.
You are welcome to send a fix and I will review it.
>
> Please also see the bug fixes in the following unapplied patch:
> "[PATCH] ivshmem: fix potential OOB r/w access (#2)" by Sebastian Krahmer
> https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03538.html
Thanks for the pointer. I'll check it.
--
David Marchand
next prev parent reply other threads:[~2014-06-18 14:57 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 16:48 Using virtio for inter-VM communication Henning Schild
2014-06-10 16:48 ` [Qemu-devel] " Henning Schild
2014-06-10 22:15 ` Vincent JARDIN
2014-06-10 22:15 ` Vincent JARDIN
2014-06-10 22:15 ` [Qemu-devel] " Vincent JARDIN
2014-06-12 6:48 ` Markus Armbruster
2014-06-12 6:48 ` Markus Armbruster
2014-06-12 6:48 ` [Qemu-devel] " Markus Armbruster
2014-06-12 7:44 ` Henning Schild
2014-06-12 7:44 ` [Qemu-devel] " Henning Schild
2014-06-12 9:31 ` Vincent JARDIN
2014-06-12 9:31 ` Vincent JARDIN
2014-06-12 9:31 ` [Qemu-devel] " Vincent JARDIN
2014-06-12 12:55 ` Markus Armbruster
2014-06-12 14:40 ` Why I advise against using ivshmem (was: [Qemu-devel] Using virtio for inter-VM communication) Markus Armbruster
2014-06-12 14:40 ` Markus Armbruster
2014-06-12 14:40 ` [Qemu-devel] Why I advise against using ivshmem (was: " Markus Armbruster
2014-06-12 16:02 ` Why I advise against using ivshmem Vincent JARDIN
2014-06-12 16:02 ` [Qemu-devel] " Vincent JARDIN
2014-06-12 16:54 ` Paolo Bonzini
2014-06-12 16:54 ` [Qemu-devel] " Paolo Bonzini
2014-06-13 8:46 ` Markus Armbruster
2014-06-13 9:26 ` Vincent JARDIN
2014-06-13 9:31 ` Jobin Raju George
2014-06-13 9:31 ` Jobin Raju George
2014-06-13 9:31 ` Jobin Raju George
2014-06-13 9:48 ` Olivier MATZ
2014-06-13 9:48 ` Olivier MATZ
2014-06-13 9:48 ` Olivier MATZ
2014-06-13 10:09 ` Paolo Bonzini
2014-06-13 13:41 ` Vincent JARDIN
2014-06-13 13:41 ` Vincent JARDIN
2014-06-13 13:41 ` Vincent JARDIN
2014-06-13 14:10 ` Paolo Bonzini
2014-06-13 14:10 ` Paolo Bonzini
2014-06-14 18:01 ` Vincent JARDIN
2014-06-14 18:01 ` Vincent JARDIN
2014-06-17 2:54 ` Stefan Hajnoczi
2014-06-17 9:03 ` David Marchand
2014-06-17 9:03 ` David Marchand
2014-06-17 9:44 ` Paolo Bonzini
2014-06-18 10:48 ` Stefan Hajnoczi
2014-06-18 10:48 ` Stefan Hajnoczi
2014-06-18 14:57 ` David Marchand [this message]
2014-06-18 14:57 ` David Marchand
2014-06-18 14:57 ` David Marchand
2014-06-18 15:10 ` Paolo Bonzini
2014-06-21 9:34 ` Stefan Hajnoczi
2014-06-26 20:02 ` Cam Macdonell
2014-06-26 20:02 ` Cam Macdonell
2014-06-18 15:01 ` Andreas Färber
2014-06-18 15:01 ` Andreas Färber
2014-06-19 8:25 ` David Marchand
2014-06-19 8:25 ` David Marchand
2014-06-19 8:25 ` David Marchand
2014-06-18 15:01 ` Andreas Färber
2014-06-30 11:10 ` Markus Armbruster
2014-06-30 11:10 ` Markus Armbruster
2014-06-30 11:10 ` Markus Armbruster
2014-06-18 10:51 ` Stefan Hajnoczi
2014-06-18 10:51 ` Stefan Hajnoczi
2014-06-18 14:58 ` David Marchand
2014-06-18 14:58 ` David Marchand
2014-06-18 14:58 ` David Marchand
2014-06-18 14:22 ` Claudio Fontana
2014-06-17 9:03 ` David Marchand
2014-06-13 9:29 ` Jobin Raju George
2014-06-13 9:29 ` [Qemu-devel] " Jobin Raju George
2014-06-13 9:29 ` Jobin Raju George
2014-06-12 16:02 ` Vincent JARDIN
2014-06-12 2:27 ` Using virtio for inter-VM communication Rusty Russell
2014-06-12 2:27 ` Rusty Russell
2014-06-12 2:27 ` [Qemu-devel] " Rusty Russell
2014-06-12 5:32 ` Jan Kiszka
2014-06-12 5:32 ` [Qemu-devel] " Jan Kiszka
2014-06-13 0:47 ` Rusty Russell
2014-06-13 0:47 ` [Qemu-devel] " Rusty Russell
2014-06-13 6:23 ` Jan Kiszka
2014-06-13 6:23 ` [Qemu-devel] " Jan Kiszka
2014-06-13 8:45 ` Paolo Bonzini
2014-06-13 8:45 ` [Qemu-devel] " Paolo Bonzini
2014-06-15 6:20 ` Jan Kiszka
2014-06-15 6:20 ` Jan Kiszka
2014-06-15 6:20 ` [Qemu-devel] " Jan Kiszka
2014-06-17 5:24 ` Paolo Bonzini
2014-06-17 5:24 ` [Qemu-devel] " Paolo Bonzini
2014-06-17 5:57 ` Jan Kiszka
2014-06-17 5:57 ` Jan Kiszka
2014-06-17 5:57 ` [Qemu-devel] " Jan Kiszka
2014-06-17 5:24 ` Paolo Bonzini
2014-06-12 5:32 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='53A1A8BE.3000801__47674.236042849$1404408007$gmane$org@6wind.com' \
--to=david.marchand@6wind.com \
--cc=henning.schild@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=olivier.matz@6wind.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=thomas.monjalon@6wind.com \
--cc=vincent.jardin@6wind.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.