All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: shmobile: Lager: Correct I2C bus for VDD MPU regulator
@ 2014-07-03  1:05 Khiem Nguyen
  2014-07-05 20:57 ` Magnus Damm
  0 siblings, 1 reply; 2+ messages in thread
From: Khiem Nguyen @ 2014-07-03  1:05 UTC (permalink / raw)
  To: linux-sh

I2C bus for VDD MPU regulator is IIC3, not I2C3.

Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
---
  arch/arm/boot/dts/r8a7790-lager.dts |   10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7790-lager.dts 
b/arch/arm/boot/dts/r8a7790-lager.dts
index 0890d47..a8f32d7 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -215,9 +215,9 @@
          renesas,function = "i2c2";
      };

-    i2c3_pins: i2c3 {
-        renesas,groups = "i2c3";
-        renesas,function = "i2c3";
+    iic3_pins: iic3 {
+        renesas,groups = "iic3";
+        renesas,function = "iic3";
      };
  };

@@ -353,9 +353,9 @@
      pinctrl-names = "default";
  };

-&i2c3 {
+&iic3 {
      pinctrl-names = "default";
-    pinctrl-0 = <&i2c3_pins>;
+    pinctrl-0 = <&iic3_pins>;
      status = "okay";

      vdd_dvfs: regulator@68 {
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: shmobile: Lager: Correct I2C bus for VDD MPU regulator
  2014-07-03  1:05 [PATCH] ARM: shmobile: Lager: Correct I2C bus for VDD MPU regulator Khiem Nguyen
@ 2014-07-05 20:57 ` Magnus Damm
  0 siblings, 0 replies; 2+ messages in thread
From: Magnus Damm @ 2014-07-05 20:57 UTC (permalink / raw)
  To: linux-sh

On Thu, Jul 3, 2014 at 3:05 AM, Khiem Nguyen
<khiem.nguyen.xt@renesas.com> wrote:
> I2C bus for VDD MPU regulator is IIC3, not I2C3.
>
> Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
> ---
>  arch/arm/boot/dts/r8a7790-lager.dts |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Hi Khiem-san,

Thanks for your patch. Can you please extend the commit message to
include the reason behind this patch?

From my side this looks like a software policy change. Unless I'm
mistaken both I2C3 and IIC3 share the same pins on the SoC, and
because of that it should be possible to access that particular I2C
bus already without any modification.

So please explain why you want to change this.

Cheers,

/ magnus

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-05 20:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-03  1:05 [PATCH] ARM: shmobile: Lager: Correct I2C bus for VDD MPU regulator Khiem Nguyen
2014-07-05 20:57 ` Magnus Damm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.