From: Jianqun <xjq@rock-chips.com> To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, Jianqun <jay.xu@rock-chips.com>, heiko@sntech.de, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.de, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Cc: huangtao@rock-chips.com, cf@rock-chips.com Subject: Re: [PATCH 4/5] ASoC: rockchip-i2s: fix registers' property of rockchip i2s controller Date: Sun, 14 Sep 2014 10:29:02 +0800 [thread overview] Message-ID: <5414FD6E.2050006@rock-chips.com> (raw) In-Reply-To: <5414AFA6.9060904@cogentembedded.com> 在 09/14/2014 04:57 AM, Sergei Shtylyov 写道: > Hello. > > On 9/13/2014 3:42 AM, Jianqun wrote: > >> Reference rockchip I2S controller TRM, modify some registers' property >> I2S_FIFOLR: read / write, but not volatile, not precious >> I2S_INTSR: read / write >> I2S_CLR: volatile, register value will be cleared by read > >> Test on RK3288 with max98090. > >> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> >> --- >> sound/soc/rockchip/rockchip_i2s.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > >> diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c >> index 1b9b404..6595383 100644 >> --- a/sound/soc/rockchip/rockchip_i2s.c >> +++ b/sound/soc/rockchip/rockchip_i2s.c > [...] >> @@ -385,8 +387,6 @@ static bool rockchip_i2s_volatile_reg(struct device *dev, unsigned int reg) >> static bool rockchip_i2s_precious_reg(struct device *dev, unsigned int reg) >> { >> switch (reg) { >> - case I2S_FIFOLR: >> - return true; >> default: >> return false; >> } > > Shouldn't this be folded into simple *return* false now? That is more reasonable, thank you. > > WBR, Sergei > > > > >
WARNING: multiple messages have this Message-ID (diff)
From: xjq@rock-chips.com (Jianqun) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/5] ASoC: rockchip-i2s: fix registers' property of rockchip i2s controller Date: Sun, 14 Sep 2014 10:29:02 +0800 [thread overview] Message-ID: <5414FD6E.2050006@rock-chips.com> (raw) In-Reply-To: <5414AFA6.9060904@cogentembedded.com> ? 09/14/2014 04:57 AM, Sergei Shtylyov ??: > Hello. > > On 9/13/2014 3:42 AM, Jianqun wrote: > >> Reference rockchip I2S controller TRM, modify some registers' property >> I2S_FIFOLR: read / write, but not volatile, not precious >> I2S_INTSR: read / write >> I2S_CLR: volatile, register value will be cleared by read > >> Test on RK3288 with max98090. > >> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> >> --- >> sound/soc/rockchip/rockchip_i2s.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > >> diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c >> index 1b9b404..6595383 100644 >> --- a/sound/soc/rockchip/rockchip_i2s.c >> +++ b/sound/soc/rockchip/rockchip_i2s.c > [...] >> @@ -385,8 +387,6 @@ static bool rockchip_i2s_volatile_reg(struct device *dev, unsigned int reg) >> static bool rockchip_i2s_precious_reg(struct device *dev, unsigned int reg) >> { >> switch (reg) { >> - case I2S_FIFOLR: >> - return true; >> default: >> return false; >> } > > Shouldn't this be folded into simple *return* false now? That is more reasonable, thank you. > > WBR, Sergei > > > > >
next prev parent reply other threads:[~2014-09-14 2:29 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-13 0:38 [PATCH 0/5] ASoC: rockchip-i2s: patches for rockchip i2s driver Jianqun 2014-09-13 0:38 ` Jianqun 2014-09-13 0:40 ` [PATCH 1/5] ASoC: rockchip-i2s: fix rockchip i2s defination more reasonable Jianqun 2014-09-13 0:40 ` Jianqun 2014-09-13 16:38 ` Mark Brown 2014-09-13 16:38 ` Mark Brown 2014-09-13 0:41 ` [PATCH 2/5] ASoC: rockchip-i2s: fix master mode set bit error Jianqun 2014-09-13 0:41 ` Jianqun 2014-09-13 16:35 ` Mark Brown 2014-09-13 16:35 ` Mark Brown 2014-09-13 16:35 ` Mark Brown 2014-09-14 2:06 ` Jianqun 2014-09-14 2:06 ` Jianqun 2014-09-14 2:06 ` Jianqun 2014-09-13 0:41 ` [PATCH 3/5] ASoC: rockchip-i2s: add dma data to snd_soc_dai Jianqun 2014-09-13 0:41 ` Jianqun 2014-09-13 16:38 ` Mark Brown 2014-09-13 16:38 ` Mark Brown 2014-09-13 0:42 ` [PATCH 4/5] ASoC: rockchip-i2s: fix registers' property of rockchip i2s controller Jianqun 2014-09-13 0:42 ` Jianqun 2014-09-13 16:36 ` Mark Brown 2014-09-13 16:36 ` Mark Brown 2014-09-14 2:20 ` Jianqun 2014-09-14 2:20 ` Jianqun 2014-09-13 20:57 ` Sergei Shtylyov 2014-09-13 20:57 ` Sergei Shtylyov 2014-09-14 2:29 ` Jianqun [this message] 2014-09-14 2:29 ` Jianqun 2014-09-14 18:53 ` Sergei Shtylyov 2014-09-14 18:53 ` Sergei Shtylyov 2014-09-13 0:43 ` [PATCH 5/5] ASoC: rockchip-i2s: enable "hclk" for rockchip I2S controller Jianqun 2014-09-13 0:43 ` Jianqun 2014-09-13 16:36 ` Mark Brown 2014-09-13 16:36 ` Mark Brown 2014-09-14 2:24 ` Jianqun 2014-09-14 2:24 ` Jianqun 2014-09-13 16:37 ` Mark Brown 2014-09-13 16:37 ` Mark Brown 2014-09-14 2:27 ` Jianqun 2014-09-14 2:27 ` Jianqun 2014-09-15 16:54 ` Mark Brown 2014-09-15 16:54 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5414FD6E.2050006@rock-chips.com \ --to=xjq@rock-chips.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=cf@rock-chips.com \ --cc=heiko@sntech.de \ --cc=huangtao@rock-chips.com \ --cc=jay.xu@rock-chips.com \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=perex@perex.cz \ --cc=sergei.shtylyov@cogentembedded.com \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.