* [PATCH 0/2] arm: shimobile: add HS-USB device node on r8a7790
@ 2014-10-02 8:04 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-02 8:04 UTC (permalink / raw)
To: horms, magnus.damm, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh, Yoshihiro Shimoda
This series is based on Simon's renesas.git branch and
renesas-devel-20141002-v3.17-rc7 tag. If we use the generic phy
driver for R-Car Gen2 (drivers/phy/phy-rcar-gen2.c), we can use
the HS-USB on lager.
Yoshihiro Shimoda (2):
arm: shimobile: r8a7790: add HS-USB device node
arm: shmobile: lager: enable HS-USB
arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
2 files changed, 15 insertions(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 44+ messages in thread
* [PATCH 0/2] arm: shimobile: add HS-USB device node on r8a7790
@ 2014-10-02 8:04 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-02 8:04 UTC (permalink / raw)
To: horms, magnus.damm, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh, Yoshihiro Shimoda
This series is based on Simon's renesas.git branch and
renesas-devel-20141002-v3.17-rc7 tag. If we use the generic phy
driver for R-Car Gen2 (drivers/phy/phy-rcar-gen2.c), we can use
the HS-USB on lager.
Yoshihiro Shimoda (2):
arm: shimobile: r8a7790: add HS-USB device node
arm: shmobile: lager: enable HS-USB
arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
2 files changed, 15 insertions(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 44+ messages in thread
* [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
[not found] ` <1412237073-1288-1-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
@ 2014-10-02 8:04 ` Yoshihiro Shimoda
2014-10-02 8:04 ` Yoshihiro Shimoda
1 sibling, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-02 8:04 UTC (permalink / raw)
To: horms-/R6kz+dDXgpPR4JQBCEnsQ, magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 2380fd5..fd9fc37 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -1314,4 +1314,14 @@
ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
};
};
+
+ hsusb: usb@e6590000 {
+ compatible = "renesas,usbhs-r8a7790";
+ reg = <0 0xe6590000 0 0x100>;
+ interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
+ renesas,buswait_bwait = <4>;
+ phys = <&usb0 1>;
+ phy-names = "usb";
+ };
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
@ 2014-10-02 8:04 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-02 8:04 UTC (permalink / raw)
To: horms-/R6kz+dDXgpPR4JQBCEnsQ, magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
---
arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 2380fd5..fd9fc37 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -1314,4 +1314,14 @@
ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
};
};
+
+ hsusb: usb@e6590000 {
+ compatible = "renesas,usbhs-r8a7790";
+ reg = <0 0xe6590000 0 0x100>;
+ interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
+ renesas,buswait_bwait = <4>;
+ phys = <&usb0 1>;
+ phy-names = "usb";
+ };
};
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 2/2] arm: shmobile: lager: enable HS-USB
[not found] ` <1412237073-1288-1-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
@ 2014-10-02 8:04 ` Yoshihiro Shimoda
2014-10-02 8:04 ` Yoshihiro Shimoda
1 sibling, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-02 8:04 UTC (permalink / raw)
To: horms-/R6kz+dDXgpPR4JQBCEnsQ, magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index 1698591..4badd0a 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -445,3 +445,8 @@
};
};
};
+
+&hsusb {
+ status = "okay";
+ renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
+};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 2/2] arm: shmobile: lager: enable HS-USB
@ 2014-10-02 8:04 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-02 8:04 UTC (permalink / raw)
To: horms-/R6kz+dDXgpPR4JQBCEnsQ, magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA, Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
---
arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index 1698591..4badd0a 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -445,3 +445,8 @@
};
};
};
+
+&hsusb {
+ status = "okay";
+ renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
+};
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
2014-10-02 8:04 ` Yoshihiro Shimoda
@ 2014-10-02 9:58 ` Sergei Shtylyov
-1 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-02 9:58 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
On 10/2/2014 12:04 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index 2380fd5..fd9fc37 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -1314,4 +1314,14 @@
> ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
> };
> };
> +
> + hsusb: usb@e6590000 {
> + compatible = "renesas,usbhs-r8a7790";
> + reg = <0 0xe6590000 0 0x100>;
> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
I don't see where are you handling this prop in the driver...
> + renesas,buswait_bwait = <4>;
This prop is named "renesas,buswait" now.
>" + phys = <&usb0 1>;
> + phy-names = "usb";
> + };
> };
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
@ 2014-10-02 9:58 ` Sergei Shtylyov
0 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-02 9:58 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
On 10/2/2014 12:04 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index 2380fd5..fd9fc37 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -1314,4 +1314,14 @@
> ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
> };
> };
> +
> + hsusb: usb@e6590000 {
> + compatible = "renesas,usbhs-r8a7790";
> + reg = <0 0xe6590000 0 0x100>;
> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
I don't see where are you handling this prop in the driver...
> + renesas,buswait_bwait = <4>;
This prop is named "renesas,buswait" now.
>" + phys = <&usb0 1>;
> + phy-names = "usb";
> + };
> };
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
2014-10-02 8:04 ` Yoshihiro Shimoda
@ 2014-10-02 9:59 ` Sergei Shtylyov
-1 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-02 9:59 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
On 10/2/2014 12:04 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index 2380fd5..fd9fc37 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -1314,4 +1314,14 @@
> ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
> };
> };
> +
> + hsusb: usb@e6590000 {
> + compatible = "renesas,usbhs-r8a7790";
> + reg = <0 0xe6590000 0 0x100>;
> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
> + renesas,buswait_bwait = <4>;
> + phys = <&usb0 1>;
> + phy-names = "usb";
You need.
status = "disabled";
since you're enabling the device node in the board .dts.
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
@ 2014-10-02 9:59 ` Sergei Shtylyov
0 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-02 9:59 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
On 10/2/2014 12:04 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index 2380fd5..fd9fc37 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -1314,4 +1314,14 @@
> ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
> };
> };
> +
> + hsusb: usb@e6590000 {
> + compatible = "renesas,usbhs-r8a7790";
> + reg = <0 0xe6590000 0 0x100>;
> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
> + renesas,buswait_bwait = <4>;
> + phys = <&usb0 1>;
> + phy-names = "usb";
You need.
status = "disabled";
since you're enabling the device node in the board .dts.
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
[not found] ` <542D21BD.8020709-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
@ 2014-10-02 11:40 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-02 11:40 UTC (permalink / raw)
To: Sergei Shtylyov, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
Hello.
(2014/10/02 18:58), Sergei Shtylyov wrote:
> On 10/2/2014 12:04 PM, Yoshihiro Shimoda wrote:
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>> index 2380fd5..fd9fc37 100644
>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>> @@ -1314,4 +1314,14 @@
>> ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
>> };
>> };
>> +
>> + hsusb: usb@e6590000 {
>> + compatible = "renesas,usbhs-r8a7790";
>> + reg = <0 0xe6590000 0 0x100>;
>> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
>
> I don't see where are you handling this prop in the driver...
Thank you for the point. I misunderstood this prop.
Since the driver is using pm_runtime functions, I thought that
this device node needs this prop.
So, I will remove this. And, I will also modify the Documentation.
>> + renesas,buswait_bwait = <4>;
>
> This prop is named "renesas,buswait" now.
Thank you for the point. I will fix it.
Best regards,
Yoshihiro Shimoda
>> " + phys = <&usb0 1>;
>> + phy-names = "usb";
>> + };
>> };
>
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
@ 2014-10-02 11:40 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-02 11:40 UTC (permalink / raw)
To: Sergei Shtylyov, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
Hello.
(2014/10/02 18:58), Sergei Shtylyov wrote:
> On 10/2/2014 12:04 PM, Yoshihiro Shimoda wrote:
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
>> ---
>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>> index 2380fd5..fd9fc37 100644
>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>> @@ -1314,4 +1314,14 @@
>> ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
>> };
>> };
>> +
>> + hsusb: usb@e6590000 {
>> + compatible = "renesas,usbhs-r8a7790";
>> + reg = <0 0xe6590000 0 0x100>;
>> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
>
> I don't see where are you handling this prop in the driver...
Thank you for the point. I misunderstood this prop.
Since the driver is using pm_runtime functions, I thought that
this device node needs this prop.
So, I will remove this. And, I will also modify the Documentation.
>> + renesas,buswait_bwait = <4>;
>
> This prop is named "renesas,buswait" now.
Thank you for the point. I will fix it.
Best regards,
Yoshihiro Shimoda
>> " + phys = <&usb0 1>;
>> + phy-names = "usb";
>> + };
>> };
>
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
[not found] ` <542D2214.9050803-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
@ 2014-10-02 11:41 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-02 11:41 UTC (permalink / raw)
To: Sergei Shtylyov, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
Hello.
(2014/10/02 18:59), Sergei Shtylyov wrote:
> On 10/2/2014 12:04 PM, Yoshihiro Shimoda wrote:
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>> index 2380fd5..fd9fc37 100644
>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>> @@ -1314,4 +1314,14 @@
>> ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
>> };
>> };
>> +
>> + hsusb: usb@e6590000 {
>> + compatible = "renesas,usbhs-r8a7790";
>> + reg = <0 0xe6590000 0 0x100>;
>> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
>> + renesas,buswait_bwait = <4>;
>> + phys = <&usb0 1>;
>> + phy-names = "usb";
>
> You need.
>
> status = "disabled";
>
> since you're enabling the device node in the board .dts.
Thank you for the point again.
I will add this.
Best regards,
Yoshihiro Shimoda
> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
@ 2014-10-02 11:41 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-02 11:41 UTC (permalink / raw)
To: Sergei Shtylyov, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
Hello.
(2014/10/02 18:59), Sergei Shtylyov wrote:
> On 10/2/2014 12:04 PM, Yoshihiro Shimoda wrote:
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
>> ---
>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>> index 2380fd5..fd9fc37 100644
>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>> @@ -1314,4 +1314,14 @@
>> ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
>> };
>> };
>> +
>> + hsusb: usb@e6590000 {
>> + compatible = "renesas,usbhs-r8a7790";
>> + reg = <0 0xe6590000 0 0x100>;
>> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
>> + renesas,buswait_bwait = <4>;
>> + phys = <&usb0 1>;
>> + phy-names = "usb";
>
> You need.
>
> status = "disabled";
>
> since you're enabling the device node in the board .dts.
Thank you for the point again.
I will add this.
Best regards,
Yoshihiro Shimoda
> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
2014-10-02 11:40 ` Yoshihiro Shimoda
@ 2014-10-02 12:08 ` Sergei Shtylyov
-1 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-02 12:08 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
Hello.
On 10/02/2014 03:40 PM, Yoshihiro Shimoda wrote:
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>>> index 2380fd5..fd9fc37 100644
>>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>>> @@ -1314,4 +1314,14 @@
>>> ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
>>> };
>>> };
>>> +
>>> + hsusb: usb@e6590000 {
>>> + compatible = "renesas,usbhs-r8a7790";
>>> + reg = <0 0xe6590000 0 0x100>;
>>> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
>> I don't see where are you handling this prop in the driver...
> Thank you for the point. I misunderstood this prop.
> Since the driver is using pm_runtime functions, I thought that
> this device node needs this prop.
Ah, I've overlooked the RPM related code. No need to remove the prop then.
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
@ 2014-10-02 12:08 ` Sergei Shtylyov
0 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-02 12:08 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
Hello.
On 10/02/2014 03:40 PM, Yoshihiro Shimoda wrote:
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
>>> index 2380fd5..fd9fc37 100644
>>> --- a/arch/arm/boot/dts/r8a7790.dtsi
>>> +++ b/arch/arm/boot/dts/r8a7790.dtsi
>>> @@ -1314,4 +1314,14 @@
>>> ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
>>> };
>>> };
>>> +
>>> + hsusb: usb@e6590000 {
>>> + compatible = "renesas,usbhs-r8a7790";
>>> + reg = <0 0xe6590000 0 0x100>;
>>> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
>> I don't see where are you handling this prop in the driver...
> Thank you for the point. I misunderstood this prop.
> Since the driver is using pm_runtime functions, I thought that
> this device node needs this prop.
Ah, I've overlooked the RPM related code. No need to remove the prop then.
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
[not found] ` <1412237073-1288-2-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
@ 2014-10-02 22:43 ` Sergei Shtylyov
0 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-02 22:43 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index 2380fd5..fd9fc37 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -1314,4 +1314,14 @@
> ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
> };
> };
> +
> + hsusb: usb@e6590000 {
> + compatible = "renesas,usbhs-r8a7790";
> + reg = <0 0xe6590000 0 0x100>;
> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
> + renesas,buswait_bwait = <4>;
> + phys = <&usb0 1>;
> + phy-names = "usb";
> + };
I think the better placement would be prior to USB PHY node, not at the
end of the file.
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
@ 2014-10-02 22:43 ` Sergei Shtylyov
0 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-02 22:43 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> ---
> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index 2380fd5..fd9fc37 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -1314,4 +1314,14 @@
> ssi9: ssi@9 { interrupts = <0 379 IRQ_TYPE_LEVEL_HIGH>; };
> };
> };
> +
> + hsusb: usb@e6590000 {
> + compatible = "renesas,usbhs-r8a7790";
> + reg = <0 0xe6590000 0 0x100>;
> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
> + renesas,buswait_bwait = <4>;
> + phys = <&usb0 1>;
> + phy-names = "usb";
> + };
I think the better placement would be prior to USB PHY node, not at the
end of the file.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
2014-10-02 8:04 ` Yoshihiro Shimoda
@ 2014-10-03 14:34 ` Sergei Shtylyov
-1 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-03 14:34 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
Hello.
On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
The subject has "shimobile" instead of "shmobile" on both this and R8A7791
patch. And capitalize "arm:" please on all the patches.
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
@ 2014-10-03 14:34 ` Sergei Shtylyov
0 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-03 14:34 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
Hello.
On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
The subject has "shimobile" instead of "shmobile" on both this and R8A7791
patch. And capitalize "arm:" please on all the patches.
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
[not found] ` <1412237073-1288-3-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
@ 2014-10-03 19:50 ` Sergei Shtylyov
0 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-03 19:50 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
> 1 file changed, 5 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index 1698591..4badd0a 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -445,3 +445,8 @@
> };
> };
> };
> +
> +&hsusb {
> + status = "okay";
> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
It's certainly active-high.
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
@ 2014-10-03 19:50 ` Sergei Shtylyov
0 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-03 19:50 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
> 1 file changed, 5 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index 1698591..4badd0a 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -445,3 +445,8 @@
> };
> };
> };
> +
> +&hsusb {
> + status = "okay";
> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
It's certainly active-high.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
2014-10-03 14:34 ` Sergei Shtylyov
@ 2014-10-06 0:49 ` Yoshihiro Shimoda
-1 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-06 0:49 UTC (permalink / raw)
To: Sergei Shtylyov, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
Hello.
(2014/10/03 23:34), Sergei Shtylyov wrote:
> Hello.
>
> On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> The subject has "shimobile" instead of "shmobile" on both this and R8A7791
> patch. And capitalize "arm:" please on all the patches.
Thank you for the point. I will fix it.
Best regards,
Yoshihiro Shimoda
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node
@ 2014-10-06 0:49 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-06 0:49 UTC (permalink / raw)
To: Sergei Shtylyov, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
Hello.
(2014/10/03 23:34), Sergei Shtylyov wrote:
> Hello.
>
> On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> The subject has "shimobile" instead of "shmobile" on both this and R8A7791
> patch. And capitalize "arm:" please on all the patches.
Thank you for the point. I will fix it.
Best regards,
Yoshihiro Shimoda
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
2014-10-03 19:50 ` Sergei Shtylyov
@ 2014-10-06 0:59 ` Yoshihiro Shimoda
-1 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-06 0:59 UTC (permalink / raw)
To: Sergei Shtylyov, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
Hello.
(2014/10/04 4:50), Sergei Shtylyov wrote:
> On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>> index 1698591..4badd0a 100644
>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>> @@ -445,3 +445,8 @@
>> };
>> };
>> };
>> +
>> +&hsusb {
>> + status = "okay";
>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>
> It's certainly active-high.
Since the current code has the following, we have to set the active_low...
However, the code is unreadable, I think. So, I will modify the code.
/* check GPIO determining if USB function should be enabled */
if (priv->dparam.enable_gpio) {
gpio_request_one(priv->dparam.enable_gpio, GPIOF_IN, NULL);
ret = !gpio_get_value(priv->dparam.enable_gpio);
gpio_free(priv->dparam.enable_gpio);
if (ret) {
dev_warn(&pdev->dev,
"USB function not selected (GPIO %d)\n",
priv->dparam.enable_gpio);
ret = -ENOTSUPP;
goto probe_end_mod_exit;
}
}
Best regards,
Yoshihiro Shimoda
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
@ 2014-10-06 0:59 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-06 0:59 UTC (permalink / raw)
To: Sergei Shtylyov, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
Hello.
(2014/10/04 4:50), Sergei Shtylyov wrote:
> On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>> index 1698591..4badd0a 100644
>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>> @@ -445,3 +445,8 @@
>> };
>> };
>> };
>> +
>> +&hsusb {
>> + status = "okay";
>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>
> It's certainly active-high.
Since the current code has the following, we have to set the active_low...
However, the code is unreadable, I think. So, I will modify the code.
/* check GPIO determining if USB function should be enabled */
if (priv->dparam.enable_gpio) {
gpio_request_one(priv->dparam.enable_gpio, GPIOF_IN, NULL);
ret = !gpio_get_value(priv->dparam.enable_gpio);
gpio_free(priv->dparam.enable_gpio);
if (ret) {
dev_warn(&pdev->dev,
"USB function not selected (GPIO %d)\n",
priv->dparam.enable_gpio);
ret = -ENOTSUPP;
goto probe_end_mod_exit;
}
}
Best regards,
Yoshihiro Shimoda
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
2014-10-06 0:59 ` Yoshihiro Shimoda
@ 2014-10-06 1:47 ` Simon Horman
-1 siblings, 0 replies; 44+ messages in thread
From: Simon Horman @ 2014-10-06 1:47 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Sergei Shtylyov, magnus.damm, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux, devicetree, linux-usb, linux-sh
On Mon, Oct 06, 2014 at 09:59:48AM +0900, Yoshihiro Shimoda wrote:
> Hello.
>
> (2014/10/04 4:50), Sergei Shtylyov wrote:
> > On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
> >
> >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >> ---
> >> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >
> >> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> >> index 1698591..4badd0a 100644
> >> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> >> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> >> @@ -445,3 +445,8 @@
> >> };
> >> };
> >> };
> >> +
> >> +&hsusb {
> >> + status = "okay";
> >> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
> >
> > It's certainly active-high.
>
> Since the current code has the following, we have to set the active_low...
> However, the code is unreadable, I think. So, I will modify the code.
It seems to me that would be best.
As far as possible the bindings and their use should
describe the hardware rather than the software.
> /* check GPIO determining if USB function should be enabled */
> if (priv->dparam.enable_gpio) {
> gpio_request_one(priv->dparam.enable_gpio, GPIOF_IN, NULL);
> ret = !gpio_get_value(priv->dparam.enable_gpio);
> gpio_free(priv->dparam.enable_gpio);
> if (ret) {
> dev_warn(&pdev->dev,
> "USB function not selected (GPIO %d)\n",
> priv->dparam.enable_gpio);
> ret = -ENOTSUPP;
> goto probe_end_mod_exit;
> }
> }
>
> Best regards,
> Yoshihiro Shimoda
>
> > WBR, Sergei
> >
>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
@ 2014-10-06 1:47 ` Simon Horman
0 siblings, 0 replies; 44+ messages in thread
From: Simon Horman @ 2014-10-06 1:47 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Sergei Shtylyov, magnus.damm, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, linux, devicetree, linux-usb, linux-sh
On Mon, Oct 06, 2014 at 09:59:48AM +0900, Yoshihiro Shimoda wrote:
> Hello.
>
> (2014/10/04 4:50), Sergei Shtylyov wrote:
> > On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
> >
> >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >> ---
> >> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >
> >> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> >> index 1698591..4badd0a 100644
> >> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> >> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> >> @@ -445,3 +445,8 @@
> >> };
> >> };
> >> };
> >> +
> >> +&hsusb {
> >> + status = "okay";
> >> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
> >
> > It's certainly active-high.
>
> Since the current code has the following, we have to set the active_low...
> However, the code is unreadable, I think. So, I will modify the code.
It seems to me that would be best.
As far as possible the bindings and their use should
describe the hardware rather than the software.
> /* check GPIO determining if USB function should be enabled */
> if (priv->dparam.enable_gpio) {
> gpio_request_one(priv->dparam.enable_gpio, GPIOF_IN, NULL);
> ret = !gpio_get_value(priv->dparam.enable_gpio);
> gpio_free(priv->dparam.enable_gpio);
> if (ret) {
> dev_warn(&pdev->dev,
> "USB function not selected (GPIO %d)\n",
> priv->dparam.enable_gpio);
> ret = -ENOTSUPP;
> goto probe_end_mod_exit;
> }
> }
>
> Best regards,
> Yoshihiro Shimoda
>
> > WBR, Sergei
> >
>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
2014-10-06 0:59 ` Yoshihiro Shimoda
@ 2014-10-06 10:32 ` Sergei Shtylyov
-1 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-06 10:32 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
Hello.
On 10/6/2014 4:59 AM, Yoshihiro Shimoda wrote:
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>>> index 1698591..4badd0a 100644
>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>>> @@ -445,3 +445,8 @@
>>> };
>>> };
>>> };
>>> +
>>> +&hsusb {
>>> + status = "okay";
>>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>> It's certainly active-high.
> Since the current code has the following, we have to set the active_low...
Exactly opposite conclusion follows from this code.
> However, the code is unreadable, I think. So, I will modify the code.
There's no dire need, I think.
> /* check GPIO determining if USB function should be enabled */
> if (priv->dparam.enable_gpio) {
> gpio_request_one(priv->dparam.enable_gpio, GPIOF_IN, NULL);
> ret = !gpio_get_value(priv->dparam.enable_gpio);
> gpio_free(priv->dparam.enable_gpio);
> if (ret) {
'ret' is non-zero here if gpio_get_value() returned 0, so 0 means "host"
and 1 means "gadget", i.e. GPIO is active-high.
> dev_warn(&pdev->dev,
> "USB function not selected (GPIO %d)\n",
> priv->dparam.enable_gpio);
> ret = -ENOTSUPP;
> goto probe_end_mod_exit;
> }
> }
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
@ 2014-10-06 10:32 ` Sergei Shtylyov
0 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-06 10:32 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
Hello.
On 10/6/2014 4:59 AM, Yoshihiro Shimoda wrote:
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>>> index 1698591..4badd0a 100644
>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>>> @@ -445,3 +445,8 @@
>>> };
>>> };
>>> };
>>> +
>>> +&hsusb {
>>> + status = "okay";
>>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>> It's certainly active-high.
> Since the current code has the following, we have to set the active_low...
Exactly opposite conclusion follows from this code.
> However, the code is unreadable, I think. So, I will modify the code.
There's no dire need, I think.
> /* check GPIO determining if USB function should be enabled */
> if (priv->dparam.enable_gpio) {
> gpio_request_one(priv->dparam.enable_gpio, GPIOF_IN, NULL);
> ret = !gpio_get_value(priv->dparam.enable_gpio);
> gpio_free(priv->dparam.enable_gpio);
> if (ret) {
'ret' is non-zero here if gpio_get_value() returned 0, so 0 means "host"
and 1 means "gadget", i.e. GPIO is active-high.
> dev_warn(&pdev->dev,
> "USB function not selected (GPIO %d)\n",
> priv->dparam.enable_gpio);
> ret = -ENOTSUPP;
> goto probe_end_mod_exit;
> }
> }
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
2014-10-02 8:04 ` Yoshihiro Shimoda
@ 2014-10-06 21:38 ` Sergei Shtylyov
-1 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-06 21:38 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
Hello.
On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
> 1 file changed, 5 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index 1698591..4badd0a 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -445,3 +445,8 @@
> };
> };
> };
> +
> +&hsusb {
> + status = "okay";
> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
> +};
Darn, this also misses the PinMux props... I was going to post v2 of these
patches but now would need to add that and retest... :-/
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
@ 2014-10-06 21:38 ` Sergei Shtylyov
0 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-06 21:38 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
Hello.
On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
> 1 file changed, 5 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index 1698591..4badd0a 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -445,3 +445,8 @@
> };
> };
> };
> +
> +&hsusb {
> + status = "okay";
> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
> +};
Darn, this also misses the PinMux props... I was going to post v2 of these
patches but now would need to add that and retest... :-/
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
[not found] ` <54330BC4.2050501-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
@ 2014-10-07 0:20 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-07 0:20 UTC (permalink / raw)
To: Sergei Shtylyov, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
Hello.
(2014/10/07 6:38), Sergei Shtylyov wrote:
> Hello.
>
> On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>> index 1698591..4badd0a 100644
>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>> @@ -445,3 +445,8 @@
>> };
>> };
>> };
>> +
>> +&hsusb {
>> + status = "okay";
>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>> +};
>
> Darn, this also misses the PinMux props... I was going to post v2 of these
> patches but now would need to add that and retest... :-/
I'm sorry for the my delayed work... I will submit v2 patches today.
By the way, I cannot understand that "this also misses the PinMux props".
According to the original "legacy" code in board-lager.c, it uses gpio5 18:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id6be7686caa05334ca8d52df157b373a41d8d9f1
Best regards,
Yoshihiro Shimoda
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
@ 2014-10-07 0:20 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-07 0:20 UTC (permalink / raw)
To: Sergei Shtylyov, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
Hello.
(2014/10/07 6:38), Sergei Shtylyov wrote:
> Hello.
>
> On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
>> ---
>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>> index 1698591..4badd0a 100644
>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>> @@ -445,3 +445,8 @@
>> };
>> };
>> };
>> +
>> +&hsusb {
>> + status = "okay";
>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>> +};
>
> Darn, this also misses the PinMux props... I was going to post v2 of these
> patches but now would need to add that and retest... :-/
I'm sorry for the my delayed work... I will submit v2 patches today.
By the way, I cannot understand that "this also misses the PinMux props".
According to the original "legacy" code in board-lager.c, it uses gpio5 18:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=36be7686caa05334ca8d52df157b373a41d8d9f1
Best regards,
Yoshihiro Shimoda
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
[not found] ` <5431E984.6000203-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
@ 2014-10-07 3:25 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-07 3:25 UTC (permalink / raw)
To: Sergei Shtylyov, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
Hello.
(2014/10/06 9:59), Yoshihiro Shimoda wrote:
> Hello.
>
> (2014/10/04 4:50), Sergei Shtylyov wrote:
>> On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
>>
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>
>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>>> index 1698591..4badd0a 100644
>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>>> @@ -445,3 +445,8 @@
>>> };
>>> };
>>> };
>>> +
>>> +&hsusb {
>>> + status = "okay";
>>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>>
>> It's certainly active-high.
>
> Since the current code has the following, we have to set the active_low...
> However, the code is unreadable, I think. So, I will modify the code.
>
> /* check GPIO determining if USB function should be enabled */
> if (priv->dparam.enable_gpio) {
> gpio_request_one(priv->dparam.enable_gpio, GPIOF_IN, NULL);
> ret = !gpio_get_value(priv->dparam.enable_gpio);
> gpio_free(priv->dparam.enable_gpio);
> if (ret) {
> dev_warn(&pdev->dev,
> "USB function not selected (GPIO %d)\n",
> priv->dparam.enable_gpio);
> ret = -ENOTSUPP;
> goto probe_end_mod_exit;
> }
> }
I am confusing about the gpio_get_value()...
In case of ARM, gpio_get_value() will call gpiod_get_raw_value() finally.
gpio_get_value() in arch/arm/include/asm/gpio.h
--> __gpio_get_value() in include/asm-generic/gpio.h
--> gpiod_get_raw_value() in drivers/gpio/gpiolib.c
The gpiod_get_raw_value() doesn't care of the GPIO_ACTIVE_{HIGH,LOW}.
So, should I add gpiod_is_active_low() or someting in the renesas_usbhs driver?
Or, Do I misunderstand something?
Best regards,
Yoshihiro Shimoda
> Best regards,
> Yoshihiro Shimoda
>
>> WBR, Sergei
>>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
@ 2014-10-07 3:25 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-07 3:25 UTC (permalink / raw)
To: Sergei Shtylyov, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
Hello.
(2014/10/06 9:59), Yoshihiro Shimoda wrote:
> Hello.
>
> (2014/10/04 4:50), Sergei Shtylyov wrote:
>> On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
>>
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
>>> ---
>>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>
>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>>> index 1698591..4badd0a 100644
>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>>> @@ -445,3 +445,8 @@
>>> };
>>> };
>>> };
>>> +
>>> +&hsusb {
>>> + status = "okay";
>>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>>
>> It's certainly active-high.
>
> Since the current code has the following, we have to set the active_low...
> However, the code is unreadable, I think. So, I will modify the code.
>
> /* check GPIO determining if USB function should be enabled */
> if (priv->dparam.enable_gpio) {
> gpio_request_one(priv->dparam.enable_gpio, GPIOF_IN, NULL);
> ret = !gpio_get_value(priv->dparam.enable_gpio);
> gpio_free(priv->dparam.enable_gpio);
> if (ret) {
> dev_warn(&pdev->dev,
> "USB function not selected (GPIO %d)\n",
> priv->dparam.enable_gpio);
> ret = -ENOTSUPP;
> goto probe_end_mod_exit;
> }
> }
I am confusing about the gpio_get_value()...
In case of ARM, gpio_get_value() will call gpiod_get_raw_value() finally.
gpio_get_value() in arch/arm/include/asm/gpio.h
--> __gpio_get_value() in include/asm-generic/gpio.h
--> gpiod_get_raw_value() in drivers/gpio/gpiolib.c
The gpiod_get_raw_value() doesn't care of the GPIO_ACTIVE_{HIGH,LOW}.
So, should I add gpiod_is_active_low() or someting in the renesas_usbhs driver?
Or, Do I misunderstand something?
Best regards,
Yoshihiro Shimoda
> Best regards,
> Yoshihiro Shimoda
>
>> WBR, Sergei
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
[not found] ` <54335D0E.6070606-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
@ 2014-10-07 7:03 ` Yoshihiro Shimoda
2014-10-07 9:46 ` Sergei Shtylyov
1 sibling, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-07 7:03 UTC (permalink / raw)
To: Sergei Shtylyov, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
Hello.
(2014/10/07 12:25), Yoshihiro Shimoda wrote:
> Hello.
>
> (2014/10/06 9:59), Yoshihiro Shimoda wrote:
>> Hello.
>>
>> (2014/10/04 4:50), Sergei Shtylyov wrote:
>>> On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
>>>
< snip >
>>>> +&hsusb {
>>>> + status = "okay";
>>>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>>>
>>> It's certainly active-high.
>>
>> Since the current code has the following, we have to set the active_low...
>> However, the code is unreadable, I think. So, I will modify the code.
>>
>> /* check GPIO determining if USB function should be enabled */
>> if (priv->dparam.enable_gpio) {
>> gpio_request_one(priv->dparam.enable_gpio, GPIOF_IN, NULL);
>> ret = !gpio_get_value(priv->dparam.enable_gpio);
>> gpio_free(priv->dparam.enable_gpio);
>> if (ret) {
>> dev_warn(&pdev->dev,
>> "USB function not selected (GPIO %d)\n",
>> priv->dparam.enable_gpio);
>> ret = -ENOTSUPP;
>> goto probe_end_mod_exit;
>> }
>> }
>
> I am confusing about the gpio_get_value()...
> In case of ARM, gpio_get_value() will call gpiod_get_raw_value() finally.
>
> gpio_get_value() in arch/arm/include/asm/gpio.h
> --> __gpio_get_value() in include/asm-generic/gpio.h
> --> gpiod_get_raw_value() in drivers/gpio/gpiolib.c
>
> The gpiod_get_raw_value() doesn't care of the GPIO_ACTIVE_{HIGH,LOW}.
> So, should I add gpiod_is_active_low() or someting in the renesas_usbhs driver?
> Or, Do I misunderstand something?
I looked at the gpio-keys driver, and then I understand the renesas_usbhs driver should
have the gpio flags from of_get_named_gpio_flags().
So, I will try to modify the renesas_usbhs driver.
Best regards,
Yoshihiro Shimoda
> Best regards,
> Yoshihiro Shimoda
>
>> Best regards,
>> Yoshihiro Shimoda
>>
>>> WBR, Sergei
>>>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
@ 2014-10-07 7:03 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-07 7:03 UTC (permalink / raw)
To: Sergei Shtylyov, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
Hello.
(2014/10/07 12:25), Yoshihiro Shimoda wrote:
> Hello.
>
> (2014/10/06 9:59), Yoshihiro Shimoda wrote:
>> Hello.
>>
>> (2014/10/04 4:50), Sergei Shtylyov wrote:
>>> On 10/02/2014 12:04 PM, Yoshihiro Shimoda wrote:
>>>
< snip >
>>>> +&hsusb {
>>>> + status = "okay";
>>>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>>>
>>> It's certainly active-high.
>>
>> Since the current code has the following, we have to set the active_low...
>> However, the code is unreadable, I think. So, I will modify the code.
>>
>> /* check GPIO determining if USB function should be enabled */
>> if (priv->dparam.enable_gpio) {
>> gpio_request_one(priv->dparam.enable_gpio, GPIOF_IN, NULL);
>> ret = !gpio_get_value(priv->dparam.enable_gpio);
>> gpio_free(priv->dparam.enable_gpio);
>> if (ret) {
>> dev_warn(&pdev->dev,
>> "USB function not selected (GPIO %d)\n",
>> priv->dparam.enable_gpio);
>> ret = -ENOTSUPP;
>> goto probe_end_mod_exit;
>> }
>> }
>
> I am confusing about the gpio_get_value()...
> In case of ARM, gpio_get_value() will call gpiod_get_raw_value() finally.
>
> gpio_get_value() in arch/arm/include/asm/gpio.h
> --> __gpio_get_value() in include/asm-generic/gpio.h
> --> gpiod_get_raw_value() in drivers/gpio/gpiolib.c
>
> The gpiod_get_raw_value() doesn't care of the GPIO_ACTIVE_{HIGH,LOW}.
> So, should I add gpiod_is_active_low() or someting in the renesas_usbhs driver?
> Or, Do I misunderstand something?
I looked at the gpio-keys driver, and then I understand the renesas_usbhs driver should
have the gpio flags from of_get_named_gpio_flags().
So, I will try to modify the renesas_usbhs driver.
Best regards,
Yoshihiro Shimoda
> Best regards,
> Yoshihiro Shimoda
>
>> Best regards,
>> Yoshihiro Shimoda
>>
>>> WBR, Sergei
>>>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
[not found] ` <543331C4.90608-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
@ 2014-10-07 9:42 ` Sergei Shtylyov
0 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-07 9:42 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
Hello.
On 10/7/2014 4:20 AM, Yoshihiro Shimoda wrote:
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>> ---
>>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>>> index 1698591..4badd0a 100644
>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>>> @@ -445,3 +445,8 @@
>>> };
>>> };
>>> };
>>> +
>>> +&hsusb {
>>> + status = "okay";
>>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>>> +};
>> Darn, this also misses the PinMux props... I was going to post v2 of these
>> patches but now would need to add that and retest... :-/
> I'm sorry for the my delayed work... I will submit v2 patches today.
> By the way, I cannot understand that "this also misses the PinMux props".
> According to the original "legacy" code in board-lager.c, it uses gpio5 18:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id6be7686caa05334ca8d52df157b373a41d8d9f1
Right. But there are also USB0 pins.
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
@ 2014-10-07 9:42 ` Sergei Shtylyov
0 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-07 9:42 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
Hello.
On 10/7/2014 4:20 AM, Yoshihiro Shimoda wrote:
>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
>>> ---
>>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>>> index 1698591..4badd0a 100644
>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>>> @@ -445,3 +445,8 @@
>>> };
>>> };
>>> };
>>> +
>>> +&hsusb {
>>> + status = "okay";
>>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>>> +};
>> Darn, this also misses the PinMux props... I was going to post v2 of these
>> patches but now would need to add that and retest... :-/
> I'm sorry for the my delayed work... I will submit v2 patches today.
> By the way, I cannot understand that "this also misses the PinMux props".
> According to the original "legacy" code in board-lager.c, it uses gpio5 18:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=36be7686caa05334ca8d52df157b373a41d8d9f1
Right. But there are also USB0 pins.
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
[not found] ` <54335D0E.6070606-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
@ 2014-10-07 9:46 ` Sergei Shtylyov
2014-10-07 9:46 ` Sergei Shtylyov
1 sibling, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-07 9:46 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
On 10/7/2014 7:25 AM, Yoshihiro Shimoda wrote:
>>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>>> ---
>>>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>>>> 1 file changed, 5 insertions(+)
>>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>>>> index 1698591..4badd0a 100644
>>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>>>> @@ -445,3 +445,8 @@
>>>> };
>>>> };
>>>> };
>>>> +
>>>> +&hsusb {
>>>> + status = "okay";
>>>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>>> It's certainly active-high.
>> Since the current code has the following, we have to set the active_low...
>> However, the code is unreadable, I think. So, I will modify the code.
>>
>> /* check GPIO determining if USB function should be enabled */
>> if (priv->dparam.enable_gpio) {
>> gpio_request_one(priv->dparam.enable_gpio, GPIOF_IN, NULL);
>> ret = !gpio_get_value(priv->dparam.enable_gpio);
>> gpio_free(priv->dparam.enable_gpio);
>> if (ret) {
>> dev_warn(&pdev->dev,
>> "USB function not selected (GPIO %d)\n",
>> priv->dparam.enable_gpio);
>> ret = -ENOTSUPP;
>> goto probe_end_mod_exit;
>> }
>> }
> I am confusing about the gpio_get_value()...
> In case of ARM, gpio_get_value() will call gpiod_get_raw_value() finally.
> gpio_get_value() in arch/arm/include/asm/gpio.h
> --> __gpio_get_value() in include/asm-generic/gpio.h
> --> gpiod_get_raw_value() in drivers/gpio/gpiolib.c
> The gpiod_get_raw_value() doesn't care of the GPIO_ACTIVE_{HIGH,LOW}.
> So, should I add gpiod_is_active_low() or someting in the renesas_usbhs driver?
Why do you still think it's active-low?!
> Or, Do I misunderstand something?
Look at the above code again.
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
@ 2014-10-07 9:46 ` Sergei Shtylyov
0 siblings, 0 replies; 44+ messages in thread
From: Sergei Shtylyov @ 2014-10-07 9:46 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms-/R6kz+dDXgpPR4JQBCEnsQ,
magnus.damm-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-sh-u79uwXL29TY76Z2rM5mHXA
On 10/7/2014 7:25 AM, Yoshihiro Shimoda wrote:
>>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
>>>> ---
>>>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>>>> 1 file changed, 5 insertions(+)
>>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>>>> index 1698591..4badd0a 100644
>>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>>>> @@ -445,3 +445,8 @@
>>>> };
>>>> };
>>>> };
>>>> +
>>>> +&hsusb {
>>>> + status = "okay";
>>>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>>> It's certainly active-high.
>> Since the current code has the following, we have to set the active_low...
>> However, the code is unreadable, I think. So, I will modify the code.
>>
>> /* check GPIO determining if USB function should be enabled */
>> if (priv->dparam.enable_gpio) {
>> gpio_request_one(priv->dparam.enable_gpio, GPIOF_IN, NULL);
>> ret = !gpio_get_value(priv->dparam.enable_gpio);
>> gpio_free(priv->dparam.enable_gpio);
>> if (ret) {
>> dev_warn(&pdev->dev,
>> "USB function not selected (GPIO %d)\n",
>> priv->dparam.enable_gpio);
>> ret = -ENOTSUPP;
>> goto probe_end_mod_exit;
>> }
>> }
> I am confusing about the gpio_get_value()...
> In case of ARM, gpio_get_value() will call gpiod_get_raw_value() finally.
> gpio_get_value() in arch/arm/include/asm/gpio.h
> --> __gpio_get_value() in include/asm-generic/gpio.h
> --> gpiod_get_raw_value() in drivers/gpio/gpiolib.c
> The gpiod_get_raw_value() doesn't care of the GPIO_ACTIVE_{HIGH,LOW}.
> So, should I add gpiod_is_active_low() or someting in the renesas_usbhs driver?
Why do you still think it's active-low?!
> Or, Do I misunderstand something?
Look at the above code again.
> Best regards,
> Yoshihiro Shimoda
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
2014-10-07 9:46 ` Sergei Shtylyov
@ 2014-10-07 11:01 ` Yoshihiro Shimoda
-1 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-07 11:01 UTC (permalink / raw)
To: Sergei Shtylyov, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
Hello.
(2014/10/07 18:46), Sergei Shtylyov wrote:
> On 10/7/2014 7:25 AM, Yoshihiro Shimoda wrote:
>
>>>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>>>> ---
>>>>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>>>>> 1 file changed, 5 insertions(+)
>
>>>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>>>>> index 1698591..4badd0a 100644
>>>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>>>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>>>>> @@ -445,3 +445,8 @@
>>>>> };
>>>>> };
>>>>> };
>>>>> +
>>>>> +&hsusb {
>>>>> + status = "okay";
>>>>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>
>>>> It's certainly active-high.
>
>>> Since the current code has the following, we have to set the active_low...
>>> However, the code is unreadable, I think. So, I will modify the code.
>>>
>>> /* check GPIO determining if USB function should be enabled */
>>> if (priv->dparam.enable_gpio) {
>>> gpio_request_one(priv->dparam.enable_gpio, GPIOF_IN, NULL);
>>> ret = !gpio_get_value(priv->dparam.enable_gpio);
>>> gpio_free(priv->dparam.enable_gpio);
>>> if (ret) {
>>> dev_warn(&pdev->dev,
>>> "USB function not selected (GPIO %d)\n",
>>> priv->dparam.enable_gpio);
>>> ret = -ENOTSUPP;
>>> goto probe_end_mod_exit;
>>> }
>>> }
>
>> I am confusing about the gpio_get_value()...
>> In case of ARM, gpio_get_value() will call gpiod_get_raw_value() finally.
>
>> gpio_get_value() in arch/arm/include/asm/gpio.h
>> --> __gpio_get_value() in include/asm-generic/gpio.h
>> --> gpiod_get_raw_value() in drivers/gpio/gpiolib.c
>
>> The gpiod_get_raw_value() doesn't care of the GPIO_ACTIVE_{HIGH,LOW}.
>> So, should I add gpiod_is_active_low() or someting in the renesas_usbhs driver?
>
> Why do you still think it's active-low?!
>
>> Or, Do I misunderstand something?
>
> Look at the above code again.
Thank you for the comment.
Finally, I understood this. I will not modify the driver and
I just change the "GPIO_ACTIVE_LOW" in the dts file to "GPIO_ACTIVE_HIGH"
because of your previous comment below:
>> 'ret' is non-zero here if gpio_get_value() returned 0, so 0 means "host"
>> and 1 means "gadget", i.e. GPIO is active-high.
Best regards,
Yoshihiro Shimoda
>> Best regards,
>> Yoshihiro Shimoda
>
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 2/2] arm: shmobile: lager: enable HS-USB
@ 2014-10-07 11:01 ` Yoshihiro Shimoda
0 siblings, 0 replies; 44+ messages in thread
From: Yoshihiro Shimoda @ 2014-10-07 11:01 UTC (permalink / raw)
To: Sergei Shtylyov, horms, magnus.damm, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux
Cc: devicetree, linux-usb, linux-sh
Hello.
(2014/10/07 18:46), Sergei Shtylyov wrote:
> On 10/7/2014 7:25 AM, Yoshihiro Shimoda wrote:
>
>>>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>>>> ---
>>>>> arch/arm/boot/dts/r8a7790-lager.dts | 5 +++++
>>>>> 1 file changed, 5 insertions(+)
>
>>>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
>>>>> index 1698591..4badd0a 100644
>>>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts
>>>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
>>>>> @@ -445,3 +445,8 @@
>>>>> };
>>>>> };
>>>>> };
>>>>> +
>>>>> +&hsusb {
>>>>> + status = "okay";
>>>>> + renesas,enable-gpio = <&gpio5 18 GPIO_ACTIVE_LOW>;
>
>>>> It's certainly active-high.
>
>>> Since the current code has the following, we have to set the active_low...
>>> However, the code is unreadable, I think. So, I will modify the code.
>>>
>>> /* check GPIO determining if USB function should be enabled */
>>> if (priv->dparam.enable_gpio) {
>>> gpio_request_one(priv->dparam.enable_gpio, GPIOF_IN, NULL);
>>> ret = !gpio_get_value(priv->dparam.enable_gpio);
>>> gpio_free(priv->dparam.enable_gpio);
>>> if (ret) {
>>> dev_warn(&pdev->dev,
>>> "USB function not selected (GPIO %d)\n",
>>> priv->dparam.enable_gpio);
>>> ret = -ENOTSUPP;
>>> goto probe_end_mod_exit;
>>> }
>>> }
>
>> I am confusing about the gpio_get_value()...
>> In case of ARM, gpio_get_value() will call gpiod_get_raw_value() finally.
>
>> gpio_get_value() in arch/arm/include/asm/gpio.h
>> --> __gpio_get_value() in include/asm-generic/gpio.h
>> --> gpiod_get_raw_value() in drivers/gpio/gpiolib.c
>
>> The gpiod_get_raw_value() doesn't care of the GPIO_ACTIVE_{HIGH,LOW}.
>> So, should I add gpiod_is_active_low() or someting in the renesas_usbhs driver?
>
> Why do you still think it's active-low?!
>
>> Or, Do I misunderstand something?
>
> Look at the above code again.
Thank you for the comment.
Finally, I understood this. I will not modify the driver and
I just change the "GPIO_ACTIVE_LOW" in the dts file to "GPIO_ACTIVE_HIGH"
because of your previous comment below:
>> 'ret' is non-zero here if gpio_get_value() returned 0, so 0 means "host"
>> and 1 means "gadget", i.e. GPIO is active-high.
Best regards,
Yoshihiro Shimoda
>> Best regards,
>> Yoshihiro Shimoda
>
> WBR, Sergei
>
^ permalink raw reply [flat|nested] 44+ messages in thread
end of thread, other threads:[~2014-10-07 11:01 UTC | newest]
Thread overview: 44+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-02 8:04 [PATCH 0/2] arm: shimobile: add HS-USB device node on r8a7790 Yoshihiro Shimoda
2014-10-02 8:04 ` Yoshihiro Shimoda
[not found] ` <1412237073-1288-1-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2014-10-02 8:04 ` [PATCH 1/2] arm: shimobile: r8a7790: add HS-USB device node Yoshihiro Shimoda
2014-10-02 8:04 ` Yoshihiro Shimoda
2014-10-02 9:58 ` Sergei Shtylyov
2014-10-02 9:58 ` Sergei Shtylyov
[not found] ` <542D21BD.8020709-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-10-02 11:40 ` Yoshihiro Shimoda
2014-10-02 11:40 ` Yoshihiro Shimoda
2014-10-02 12:08 ` Sergei Shtylyov
2014-10-02 12:08 ` Sergei Shtylyov
2014-10-02 9:59 ` Sergei Shtylyov
2014-10-02 9:59 ` Sergei Shtylyov
[not found] ` <542D2214.9050803-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-10-02 11:41 ` Yoshihiro Shimoda
2014-10-02 11:41 ` Yoshihiro Shimoda
[not found] ` <1412237073-1288-2-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2014-10-02 22:43 ` Sergei Shtylyov
2014-10-02 22:43 ` Sergei Shtylyov
2014-10-03 14:34 ` Sergei Shtylyov
2014-10-03 14:34 ` Sergei Shtylyov
2014-10-06 0:49 ` Yoshihiro Shimoda
2014-10-06 0:49 ` Yoshihiro Shimoda
2014-10-02 8:04 ` [PATCH 2/2] arm: shmobile: lager: enable HS-USB Yoshihiro Shimoda
2014-10-02 8:04 ` Yoshihiro Shimoda
[not found] ` <1412237073-1288-3-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2014-10-03 19:50 ` Sergei Shtylyov
2014-10-03 19:50 ` Sergei Shtylyov
2014-10-06 0:59 ` Yoshihiro Shimoda
2014-10-06 0:59 ` Yoshihiro Shimoda
2014-10-06 1:47 ` Simon Horman
2014-10-06 1:47 ` Simon Horman
2014-10-06 10:32 ` Sergei Shtylyov
2014-10-06 10:32 ` Sergei Shtylyov
[not found] ` <5431E984.6000203-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2014-10-07 3:25 ` Yoshihiro Shimoda
2014-10-07 3:25 ` Yoshihiro Shimoda
[not found] ` <54335D0E.6070606-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2014-10-07 7:03 ` Yoshihiro Shimoda
2014-10-07 7:03 ` Yoshihiro Shimoda
2014-10-07 9:46 ` Sergei Shtylyov
2014-10-07 9:46 ` Sergei Shtylyov
2014-10-07 11:01 ` Yoshihiro Shimoda
2014-10-07 11:01 ` Yoshihiro Shimoda
2014-10-06 21:38 ` Sergei Shtylyov
2014-10-06 21:38 ` Sergei Shtylyov
[not found] ` <54330BC4.2050501-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-10-07 0:20 ` Yoshihiro Shimoda
2014-10-07 0:20 ` Yoshihiro Shimoda
[not found] ` <543331C4.90608-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2014-10-07 9:42 ` Sergei Shtylyov
2014-10-07 9:42 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.