All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
@ 2014-11-26  0:13 ` Simon Horman
  0 siblings, 0 replies; 16+ messages in thread
From: Simon Horman @ 2014-11-26  0:13 UTC (permalink / raw)
  To: linux-arm-kernel

Update the size and names of flash partitions to match the
expectations of the loader which are as follows:

"loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
"user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
"flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]

["user"'s assumed breakdown]
U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB
Device tree     (0x0010_0000-0x0014_0000) 256KB
uImage          (0x0014_0000-0x0060_0000) 4.75MB

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

---

This replaces a patch that I previously posted, "shmobile: koelsch: Fix
flash partition label and size in device tree", which has the same aim but
does so for an older version of the loader which to my knowledge is not
found in the wild.

I plan to post a similar patch for Lager if this one goes well.

I have been informed that the flash layout should also be the same
for Alt (which currently does not have flash in its dts file in mainline).

Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree.
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index 990af16..9a4e714 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -451,14 +451,14 @@
 			reg = <0x00000000 0x00080000>;
 			read-only;
 		};
-		partition@80000 {
-			label = "bootenv";
-			reg = <0x00080000 0x00080000>;
+		partition@40000 {
+			label = "user";
+			reg = <0x00080000 0x00580000>;
 			read-only;
 		};
-		partition@100000 {
-			label = "data";
-			reg = <0x00100000 0x03f00000>;
+		partition@440000 {
+			label = "flash";
+			reg = <0x00600000 0x03a00000>;
 		};
 	};
 };
-- 
2.1.3


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
@ 2014-11-26  0:13 ` Simon Horman
  0 siblings, 0 replies; 16+ messages in thread
From: Simon Horman @ 2014-11-26  0:13 UTC (permalink / raw)
  To: linux-arm-kernel

Update the size and names of flash partitions to match the
expectations of the loader which are as follows:

"loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
"user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
"flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]

["user"'s assumed breakdown]
U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB
Device tree     (0x0010_0000-0x0014_0000) 256KB
uImage          (0x0014_0000-0x0060_0000) 4.75MB

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

---

This replaces a patch that I previously posted, "shmobile: koelsch: Fix
flash partition label and size in device tree", which has the same aim but
does so for an older version of the loader which to my knowledge is not
found in the wild.

I plan to post a similar patch for Lager if this one goes well.

I have been informed that the flash layout should also be the same
for Alt (which currently does not have flash in its dts file in mainline).

Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree.
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index 990af16..9a4e714 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -451,14 +451,14 @@
 			reg = <0x00000000 0x00080000>;
 			read-only;
 		};
-		partition at 80000 {
-			label = "bootenv";
-			reg = <0x00080000 0x00080000>;
+		partition at 40000 {
+			label = "user";
+			reg = <0x00080000 0x00580000>;
 			read-only;
 		};
-		partition at 100000 {
-			label = "data";
-			reg = <0x00100000 0x03f00000>;
+		partition at 440000 {
+			label = "flash";
+			reg = <0x00600000 0x03a00000>;
 		};
 	};
 };
-- 
2.1.3

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
  2014-11-26  0:13 ` Simon Horman
@ 2014-11-26 12:50   ` Sergei Shtylyov
  -1 siblings, 0 replies; 16+ messages in thread
From: Sergei Shtylyov @ 2014-11-26 12:50 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 11/26/2014 3:13 AM, Simon Horman wrote:

> Update the size and names of flash partitions to match the
> expectations of the loader which are as follows:

> "loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
> "user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
> "flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]

> ["user"'s assumed breakdown]
> U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB
> Device tree     (0x0010_0000-0x0014_0000) 256KB
> uImage          (0x0014_0000-0x0060_0000) 4.75MB

> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

> ---

> This replaces a patch that I previously posted, "shmobile: koelsch: Fix
> flash partition label and size in device tree", which has the same aim but
> does so for an older version of the loader which to my knowledge is not
> found in the wild.

> I plan to post a similar patch for Lager if this one goes well.

> I have been informed that the flash layout should also be the same
> for Alt (which currently does not have flash in its dts file in mainline).

> Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree.
> ---
>   arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)

> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> index 990af16..9a4e714 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -451,14 +451,14 @@
>   			reg = <0x00000000 0x00080000>;
>   			read-only;
>   		};
> -		partition@80000 {
> -			label = "bootenv";
> -			reg = <0x00080000 0x00080000>;
> +		partition@40000 {
> +			label = "user";
> +			reg = <0x00080000 0x00580000>;

    The "reg" prop doesn't match the <unit-address> pat of the name.

>   			read-only;
>   		};
> -		partition@100000 {
> -			label = "data";
> -			reg = <0x00100000 0x03f00000>;
> +		partition@440000 {
> +			label = "flash";
> +			reg = <0x00600000 0x03a00000>;

    Likewise.

[...]

WBR, Sergei


^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
@ 2014-11-26 12:50   ` Sergei Shtylyov
  0 siblings, 0 replies; 16+ messages in thread
From: Sergei Shtylyov @ 2014-11-26 12:50 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 11/26/2014 3:13 AM, Simon Horman wrote:

> Update the size and names of flash partitions to match the
> expectations of the loader which are as follows:

> "loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
> "user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
> "flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]

> ["user"'s assumed breakdown]
> U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB
> Device tree     (0x0010_0000-0x0014_0000) 256KB
> uImage          (0x0014_0000-0x0060_0000) 4.75MB

> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

> ---

> This replaces a patch that I previously posted, "shmobile: koelsch: Fix
> flash partition label and size in device tree", which has the same aim but
> does so for an older version of the loader which to my knowledge is not
> found in the wild.

> I plan to post a similar patch for Lager if this one goes well.

> I have been informed that the flash layout should also be the same
> for Alt (which currently does not have flash in its dts file in mainline).

> Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree.
> ---
>   arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)

> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> index 990af16..9a4e714 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -451,14 +451,14 @@
>   			reg = <0x00000000 0x00080000>;
>   			read-only;
>   		};
> -		partition at 80000 {
> -			label = "bootenv";
> -			reg = <0x00080000 0x00080000>;
> +		partition at 40000 {
> +			label = "user";
> +			reg = <0x00080000 0x00580000>;

    The "reg" prop doesn't match the <unit-address> pat of the name.

>   			read-only;
>   		};
> -		partition at 100000 {
> -			label = "data";
> -			reg = <0x00100000 0x03f00000>;
> +		partition at 440000 {
> +			label = "flash";
> +			reg = <0x00600000 0x03a00000>;

    Likewise.

[...]

WBR, Sergei

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
  2014-11-26 12:50   ` Sergei Shtylyov
@ 2014-11-28  0:27     ` Simon Horman
  -1 siblings, 0 replies; 16+ messages in thread
From: Simon Horman @ 2014-11-28  0:27 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Nov 26, 2014 at 03:50:45PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 11/26/2014 3:13 AM, Simon Horman wrote:
> 
> >Update the size and names of flash partitions to match the
> >expectations of the loader which are as follows:
> 
> >"loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
> >"user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
> >"flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]
> 
> >["user"'s assumed breakdown]
> >U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB
> >Device tree     (0x0010_0000-0x0014_0000) 256KB
> >uImage          (0x0014_0000-0x0060_0000) 4.75MB
> 
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> >---
> 
> >This replaces a patch that I previously posted, "shmobile: koelsch: Fix
> >flash partition label and size in device tree", which has the same aim but
> >does so for an older version of the loader which to my knowledge is not
> >found in the wild.
> 
> >I plan to post a similar patch for Lager if this one goes well.
> 
> >I have been informed that the flash layout should also be the same
> >for Alt (which currently does not have flash in its dts file in mainline).
> 
> >Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree.
> >---
> >  arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> >diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> >index 990af16..9a4e714 100644
> >--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> >+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> >@@ -451,14 +451,14 @@
> >  			reg = <0x00000000 0x00080000>;
> >  			read-only;
> >  		};
> >-		partition@80000 {
> >-			label = "bootenv";
> >-			reg = <0x00080000 0x00080000>;
> >+		partition@40000 {
> >+			label = "user";
> >+			reg = <0x00080000 0x00580000>;
> 
>    The "reg" prop doesn't match the <unit-address> pat of the name.

Are you suggesting this?

			reg = <0x00080000 0x00600000>;

> >  			read-only;
> >  		};
> >-		partition@100000 {
> >-			label = "data";
> >-			reg = <0x00100000 0x03f00000>;
> >+		partition@440000 {
> >+			label = "flash";
> >+			reg = <0x00600000 0x03a00000>;

And this?

			reg = <0x00600000 0x04000000>;

>    Likewise.
> 
> [...]
> 
> WBR, Sergei
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
@ 2014-11-28  0:27     ` Simon Horman
  0 siblings, 0 replies; 16+ messages in thread
From: Simon Horman @ 2014-11-28  0:27 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Nov 26, 2014 at 03:50:45PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 11/26/2014 3:13 AM, Simon Horman wrote:
> 
> >Update the size and names of flash partitions to match the
> >expectations of the loader which are as follows:
> 
> >"loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
> >"user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
> >"flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]
> 
> >["user"'s assumed breakdown]
> >U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB
> >Device tree     (0x0010_0000-0x0014_0000) 256KB
> >uImage          (0x0014_0000-0x0060_0000) 4.75MB
> 
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> >---
> 
> >This replaces a patch that I previously posted, "shmobile: koelsch: Fix
> >flash partition label and size in device tree", which has the same aim but
> >does so for an older version of the loader which to my knowledge is not
> >found in the wild.
> 
> >I plan to post a similar patch for Lager if this one goes well.
> 
> >I have been informed that the flash layout should also be the same
> >for Alt (which currently does not have flash in its dts file in mainline).
> 
> >Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree.
> >---
> >  arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> >diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> >index 990af16..9a4e714 100644
> >--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> >+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> >@@ -451,14 +451,14 @@
> >  			reg = <0x00000000 0x00080000>;
> >  			read-only;
> >  		};
> >-		partition at 80000 {
> >-			label = "bootenv";
> >-			reg = <0x00080000 0x00080000>;
> >+		partition at 40000 {
> >+			label = "user";
> >+			reg = <0x00080000 0x00580000>;
> 
>    The "reg" prop doesn't match the <unit-address> pat of the name.

Are you suggesting this?

			reg = <0x00080000 0x00600000>;

> >  			read-only;
> >  		};
> >-		partition at 100000 {
> >-			label = "data";
> >-			reg = <0x00100000 0x03f00000>;
> >+		partition at 440000 {
> >+			label = "flash";
> >+			reg = <0x00600000 0x03a00000>;

And this?

			reg = <0x00600000 0x04000000>;

>    Likewise.
> 
> [...]
> 
> WBR, Sergei
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
  2014-11-28  0:27     ` Simon Horman
@ 2014-11-28  8:34       ` Geert Uytterhoeven
  -1 siblings, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2014-11-28  8:34 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Simon,

On Fri, Nov 28, 2014 at 1:27 AM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Nov 26, 2014 at 03:50:45PM +0300, Sergei Shtylyov wrote:
>> On 11/26/2014 3:13 AM, Simon Horman wrote:
>>
>> >Update the size and names of flash partitions to match the
>> >expectations of the loader which are as follows:

Finally I had a closer look at this. Sorry that it took that long.

>> >"loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
>> >"user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
>> >"flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]
>>
>> >["user"'s assumed breakdown]
>> >U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB

KiB

You may want to split this explicitly in 256 KiB for U-boot, and 256 KiB for the
U-boot bootargs, to help people needing low-level recovery.

>> >Device tree     (0x0010_0000-0x0014_0000) 256KB

KiB

>> >uImage          (0x0014_0000-0x0060_0000) 4.75MB

Not zImage?

MiB

>> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>
>> >---
>>
>> >This replaces a patch that I previously posted, "shmobile: koelsch: Fix
>> >flash partition label and size in device tree", which has the same aim but
>> >does so for an older version of the loader which to my knowledge is not
>> >found in the wild.

Thanks, the new split makes sense to me.

>> >I plan to post a similar patch for Lager if this one goes well.
>>
>> >I have been informed that the flash layout should also be the same
>> >for Alt (which currently does not have flash in its dts file in mainline).
>>
>> >Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree.
>> >---
>> >  arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
>> >  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> >diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
>> >index 990af16..9a4e714 100644
>> >--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
>> >+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
>> >@@ -451,14 +451,14 @@
>> >                     reg = <0x00000000 0x00080000>;
>> >                     read-only;
>> >             };
>> >-            partition@80000 {
>> >-                    label = "bootenv";
>> >-                    reg = <0x00080000 0x00080000>;
>> >+            partition@40000 {
>> >+                    label = "user";
>> >+                    reg = <0x00080000 0x00580000>;
>>
>>    The "reg" prop doesn't match the <unit-address> pat of the name.

It's not the "reg" property that must match the "<unit-addres>", but the
other way around ;-)

> Are you suggesting this?
>
>                         reg = <0x00080000 0x00600000>;

No, that would change the size.

"reg = <0x00080000 ...>" means you must use "...@80000".

>> >                     read-only;
>> >             };
>> >-            partition@100000 {
>> >-                    label = "data";
>> >-                    reg = <0x00100000 0x03f00000>;
>> >+            partition@440000 {
>> >+                    label = "flash";
>> >+                    reg = <0x00600000 0x03a00000>;
>
> And this?
>
>                         reg = <0x00600000 0x04000000>;

"reg = <0x00600000 ...>" means you must use "...@600000".

>>    Likewise.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
@ 2014-11-28  8:34       ` Geert Uytterhoeven
  0 siblings, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2014-11-28  8:34 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Simon,

On Fri, Nov 28, 2014 at 1:27 AM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Nov 26, 2014 at 03:50:45PM +0300, Sergei Shtylyov wrote:
>> On 11/26/2014 3:13 AM, Simon Horman wrote:
>>
>> >Update the size and names of flash partitions to match the
>> >expectations of the loader which are as follows:

Finally I had a closer look at this. Sorry that it took that long.

>> >"loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
>> >"user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
>> >"flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]
>>
>> >["user"'s assumed breakdown]
>> >U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB

KiB

You may want to split this explicitly in 256 KiB for U-boot, and 256 KiB for the
U-boot bootargs, to help people needing low-level recovery.

>> >Device tree     (0x0010_0000-0x0014_0000) 256KB

KiB

>> >uImage          (0x0014_0000-0x0060_0000) 4.75MB

Not zImage?

MiB

>> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>
>> >---
>>
>> >This replaces a patch that I previously posted, "shmobile: koelsch: Fix
>> >flash partition label and size in device tree", which has the same aim but
>> >does so for an older version of the loader which to my knowledge is not
>> >found in the wild.

Thanks, the new split makes sense to me.

>> >I plan to post a similar patch for Lager if this one goes well.
>>
>> >I have been informed that the flash layout should also be the same
>> >for Alt (which currently does not have flash in its dts file in mainline).
>>
>> >Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree.
>> >---
>> >  arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
>> >  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> >diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
>> >index 990af16..9a4e714 100644
>> >--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
>> >+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
>> >@@ -451,14 +451,14 @@
>> >                     reg = <0x00000000 0x00080000>;
>> >                     read-only;
>> >             };
>> >-            partition at 80000 {
>> >-                    label = "bootenv";
>> >-                    reg = <0x00080000 0x00080000>;
>> >+            partition at 40000 {
>> >+                    label = "user";
>> >+                    reg = <0x00080000 0x00580000>;
>>
>>    The "reg" prop doesn't match the <unit-address> pat of the name.

It's not the "reg" property that must match the "<unit-addres>", but the
other way around ;-)

> Are you suggesting this?
>
>                         reg = <0x00080000 0x00600000>;

No, that would change the size.

"reg = <0x00080000 ...>" means you must use "... at 80000".

>> >                     read-only;
>> >             };
>> >-            partition at 100000 {
>> >-                    label = "data";
>> >-                    reg = <0x00100000 0x03f00000>;
>> >+            partition at 440000 {
>> >+                    label = "flash";
>> >+                    reg = <0x00600000 0x03a00000>;
>
> And this?
>
>                         reg = <0x00600000 0x04000000>;

"reg = <0x00600000 ...>" means you must use "... at 600000".

>>    Likewise.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
  2014-11-28  0:27     ` Simon Horman
@ 2014-11-28 11:09       ` Sergei Shtylyov
  -1 siblings, 0 replies; 16+ messages in thread
From: Sergei Shtylyov @ 2014-11-28 11:09 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 11/28/2014 3:27 AM, Simon Horman wrote:

>>> Update the size and names of flash partitions to match the
>>> expectations of the loader which are as follows:

>>> "loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
>>> "user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
>>> "flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]

>>> ["user"'s assumed breakdown]
>>> U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB
>>> Device tree     (0x0010_0000-0x0014_0000) 256KB
>>> uImage          (0x0014_0000-0x0060_0000) 4.75MB

>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

>>> ---

>>> This replaces a patch that I previously posted, "shmobile: koelsch: Fix
>>> flash partition label and size in device tree", which has the same aim but
>>> does so for an older version of the loader which to my knowledge is not
>>> found in the wild.

>>> I plan to post a similar patch for Lager if this one goes well.

>>> I have been informed that the flash layout should also be the same
>>> for Alt (which currently does not have flash in its dts file in mainline).

>>> Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree.
>>> ---
>>>   arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
>>>   1 file changed, 6 insertions(+), 6 deletions(-)

>>> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
>>> index 990af16..9a4e714 100644
>>> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
>>> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
>>> @@ -451,14 +451,14 @@
>>>   			reg = <0x00000000 0x00080000>;
>>>   			read-only;
>>>   		};
>>> -		partition@80000 {
>>> -			label = "bootenv";
>>> -			reg = <0x00080000 0x00080000>;
>>> +		partition@40000 {
>>> +			label = "user";
>>> +			reg = <0x00080000 0x00580000>;

>>     The "reg" prop doesn't match the <unit-address> pat of the name.

> Are you suggesting this?

> 			reg = <0x00080000 0x00600000>;

    No, I'm suggesting to change the <unit-address> part of the node name to 
match the offset in the "reg" property (given it's correct).

[...]

WBR, Sergei


^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
@ 2014-11-28 11:09       ` Sergei Shtylyov
  0 siblings, 0 replies; 16+ messages in thread
From: Sergei Shtylyov @ 2014-11-28 11:09 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 11/28/2014 3:27 AM, Simon Horman wrote:

>>> Update the size and names of flash partitions to match the
>>> expectations of the loader which are as follows:

>>> "loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
>>> "user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
>>> "flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]

>>> ["user"'s assumed breakdown]
>>> U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB
>>> Device tree     (0x0010_0000-0x0014_0000) 256KB
>>> uImage          (0x0014_0000-0x0060_0000) 4.75MB

>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

>>> ---

>>> This replaces a patch that I previously posted, "shmobile: koelsch: Fix
>>> flash partition label and size in device tree", which has the same aim but
>>> does so for an older version of the loader which to my knowledge is not
>>> found in the wild.

>>> I plan to post a similar patch for Lager if this one goes well.

>>> I have been informed that the flash layout should also be the same
>>> for Alt (which currently does not have flash in its dts file in mainline).

>>> Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree.
>>> ---
>>>   arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
>>>   1 file changed, 6 insertions(+), 6 deletions(-)

>>> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
>>> index 990af16..9a4e714 100644
>>> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
>>> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
>>> @@ -451,14 +451,14 @@
>>>   			reg = <0x00000000 0x00080000>;
>>>   			read-only;
>>>   		};
>>> -		partition at 80000 {
>>> -			label = "bootenv";
>>> -			reg = <0x00080000 0x00080000>;
>>> +		partition at 40000 {
>>> +			label = "user";
>>> +			reg = <0x00080000 0x00580000>;

>>     The "reg" prop doesn't match the <unit-address> pat of the name.

> Are you suggesting this?

> 			reg = <0x00080000 0x00600000>;

    No, I'm suggesting to change the <unit-address> part of the node name to 
match the offset in the "reg" property (given it's correct).

[...]

WBR, Sergei

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
  2014-11-28  8:34       ` Geert Uytterhoeven
@ 2014-12-01  0:30         ` Simon Horman
  -1 siblings, 0 replies; 16+ messages in thread
From: Simon Horman @ 2014-12-01  0:30 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Nov 28, 2014 at 09:34:05AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Nov 28, 2014 at 1:27 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Nov 26, 2014 at 03:50:45PM +0300, Sergei Shtylyov wrote:
> >> On 11/26/2014 3:13 AM, Simon Horman wrote:
> >>
> >> >Update the size and names of flash partitions to match the
> >> >expectations of the loader which are as follows:
> 
> Finally I had a closer look at this. Sorry that it took that long.
> 
> >> >"loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
> >> >"user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
> >> >"flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]
> >>
> >> >["user"'s assumed breakdown]
> >> >U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB
> 
> KiB
> 
> You may want to split this explicitly in 256 KiB for U-boot, and 256 KiB for the
> U-boot bootargs, to help people needing low-level recovery.

Are you suggesting 4 partitions or just an adjustment of the assumption
documented in the changelog?

> >> >Device tree     (0x0010_0000-0x0014_0000) 256KB
> 
> KiB
> 
> >> >uImage          (0x0014_0000-0x0060_0000) 4.75MB
> 
> Not zImage?

I think we can change this documentation without any runtime effect :^)

> 
> MiB
> 
> >> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >>
> >> >---
> >>
> >> >This replaces a patch that I previously posted, "shmobile: koelsch: Fix
> >> >flash partition label and size in device tree", which has the same aim but
> >> >does so for an older version of the loader which to my knowledge is not
> >> >found in the wild.
> 
> Thanks, the new split makes sense to me.

Great!

> >> >I plan to post a similar patch for Lager if this one goes well.
> >>
> >> >I have been informed that the flash layout should also be the same
> >> >for Alt (which currently does not have flash in its dts file in mainline).
> >>
> >> >Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree.
> >> >---
> >> >  arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
> >> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >>
> >> >diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> >> >index 990af16..9a4e714 100644
> >> >--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> >> >+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> >> >@@ -451,14 +451,14 @@
> >> >                     reg = <0x00000000 0x00080000>;
> >> >                     read-only;
> >> >             };
> >> >-            partition@80000 {
> >> >-                    label = "bootenv";
> >> >-                    reg = <0x00080000 0x00080000>;
> >> >+            partition@40000 {
> >> >+                    label = "user";
> >> >+                    reg = <0x00080000 0x00580000>;
> >>
> >>    The "reg" prop doesn't match the <unit-address> pat of the name.
> 
> It's not the "reg" property that must match the "<unit-addres>", but the
> other way around ;-)
> 
> > Are you suggesting this?
> >
> >                         reg = <0x00080000 0x00600000>;
> 
> No, that would change the size.
> 
> "reg = <0x00080000 ...>" means you must use "...@80000".

Thanks, got it.

> >> >                     read-only;
> >> >             };
> >> >-            partition@100000 {
> >> >-                    label = "data";
> >> >-                    reg = <0x00100000 0x03f00000>;
> >> >+            partition@440000 {
> >> >+                    label = "flash";
> >> >+                    reg = <0x00600000 0x03a00000>;
> >
> > And this?
> >
> >                         reg = <0x00600000 0x04000000>;
> 
> "reg = <0x00600000 ...>" means you must use "...@600000".
> 
> >>    Likewise.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
@ 2014-12-01  0:30         ` Simon Horman
  0 siblings, 0 replies; 16+ messages in thread
From: Simon Horman @ 2014-12-01  0:30 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Nov 28, 2014 at 09:34:05AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Nov 28, 2014 at 1:27 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Nov 26, 2014 at 03:50:45PM +0300, Sergei Shtylyov wrote:
> >> On 11/26/2014 3:13 AM, Simon Horman wrote:
> >>
> >> >Update the size and names of flash partitions to match the
> >> >expectations of the loader which are as follows:
> 
> Finally I had a closer look at this. Sorry that it took that long.
> 
> >> >"loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
> >> >"user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
> >> >"flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]
> >>
> >> >["user"'s assumed breakdown]
> >> >U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB
> 
> KiB
> 
> You may want to split this explicitly in 256 KiB for U-boot, and 256 KiB for the
> U-boot bootargs, to help people needing low-level recovery.

Are you suggesting 4 partitions or just an adjustment of the assumption
documented in the changelog?

> >> >Device tree     (0x0010_0000-0x0014_0000) 256KB
> 
> KiB
> 
> >> >uImage          (0x0014_0000-0x0060_0000) 4.75MB
> 
> Not zImage?

I think we can change this documentation without any runtime effect :^)

> 
> MiB
> 
> >> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >>
> >> >---
> >>
> >> >This replaces a patch that I previously posted, "shmobile: koelsch: Fix
> >> >flash partition label and size in device tree", which has the same aim but
> >> >does so for an older version of the loader which to my knowledge is not
> >> >found in the wild.
> 
> Thanks, the new split makes sense to me.

Great!

> >> >I plan to post a similar patch for Lager if this one goes well.
> >>
> >> >I have been informed that the flash layout should also be the same
> >> >for Alt (which currently does not have flash in its dts file in mainline).
> >>
> >> >Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree.
> >> >---
> >> >  arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
> >> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >>
> >> >diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> >> >index 990af16..9a4e714 100644
> >> >--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> >> >+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> >> >@@ -451,14 +451,14 @@
> >> >                     reg = <0x00000000 0x00080000>;
> >> >                     read-only;
> >> >             };
> >> >-            partition at 80000 {
> >> >-                    label = "bootenv";
> >> >-                    reg = <0x00080000 0x00080000>;
> >> >+            partition at 40000 {
> >> >+                    label = "user";
> >> >+                    reg = <0x00080000 0x00580000>;
> >>
> >>    The "reg" prop doesn't match the <unit-address> pat of the name.
> 
> It's not the "reg" property that must match the "<unit-addres>", but the
> other way around ;-)
> 
> > Are you suggesting this?
> >
> >                         reg = <0x00080000 0x00600000>;
> 
> No, that would change the size.
> 
> "reg = <0x00080000 ...>" means you must use "... at 80000".

Thanks, got it.

> >> >                     read-only;
> >> >             };
> >> >-            partition at 100000 {
> >> >-                    label = "data";
> >> >-                    reg = <0x00100000 0x03f00000>;
> >> >+            partition at 440000 {
> >> >+                    label = "flash";
> >> >+                    reg = <0x00600000 0x03a00000>;
> >
> > And this?
> >
> >                         reg = <0x00600000 0x04000000>;
> 
> "reg = <0x00600000 ...>" means you must use "... at 600000".
> 
> >>    Likewise.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
  2014-11-28 11:09       ` Sergei Shtylyov
@ 2014-12-01  0:31         ` Simon Horman
  -1 siblings, 0 replies; 16+ messages in thread
From: Simon Horman @ 2014-12-01  0:31 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Nov 28, 2014 at 02:09:02PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 11/28/2014 3:27 AM, Simon Horman wrote:
> 
> >>>Update the size and names of flash partitions to match the
> >>>expectations of the loader which are as follows:
> 
> >>>"loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
> >>>"user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
> >>>"flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]
> 
> >>>["user"'s assumed breakdown]
> >>>U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB
> >>>Device tree     (0x0010_0000-0x0014_0000) 256KB
> >>>uImage          (0x0014_0000-0x0060_0000) 4.75MB
> 
> >>>Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> >>>---
> 
> >>>This replaces a patch that I previously posted, "shmobile: koelsch: Fix
> >>>flash partition label and size in device tree", which has the same aim but
> >>>does so for an older version of the loader which to my knowledge is not
> >>>found in the wild.
> 
> >>>I plan to post a similar patch for Lager if this one goes well.
> 
> >>>I have been informed that the flash layout should also be the same
> >>>for Alt (which currently does not have flash in its dts file in mainline).
> 
> >>>Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree.
> >>>---
> >>>  arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
> >>>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> >>>diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> >>>index 990af16..9a4e714 100644
> >>>--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> >>>+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> >>>@@ -451,14 +451,14 @@
> >>>  			reg = <0x00000000 0x00080000>;
> >>>  			read-only;
> >>>  		};
> >>>-		partition@80000 {
> >>>-			label = "bootenv";
> >>>-			reg = <0x00080000 0x00080000>;
> >>>+		partition@40000 {
> >>>+			label = "user";
> >>>+			reg = <0x00080000 0x00580000>;
> 
> >>    The "reg" prop doesn't match the <unit-address> pat of the name.
> 
> >Are you suggesting this?
> 
> >			reg = <0x00080000 0x00600000>;
> 
>    No, I'm suggesting to change the <unit-address> part of the node name to
> match the offset in the "reg" property (given it's correct).

Thanks, got it.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
@ 2014-12-01  0:31         ` Simon Horman
  0 siblings, 0 replies; 16+ messages in thread
From: Simon Horman @ 2014-12-01  0:31 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Nov 28, 2014 at 02:09:02PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 11/28/2014 3:27 AM, Simon Horman wrote:
> 
> >>>Update the size and names of flash partitions to match the
> >>>expectations of the loader which are as follows:
> 
> >>>"loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
> >>>"user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
> >>>"flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]
> 
> >>>["user"'s assumed breakdown]
> >>>U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB
> >>>Device tree     (0x0010_0000-0x0014_0000) 256KB
> >>>uImage          (0x0014_0000-0x0060_0000) 4.75MB
> 
> >>>Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> >>>---
> 
> >>>This replaces a patch that I previously posted, "shmobile: koelsch: Fix
> >>>flash partition label and size in device tree", which has the same aim but
> >>>does so for an older version of the loader which to my knowledge is not
> >>>found in the wild.
> 
> >>>I plan to post a similar patch for Lager if this one goes well.
> 
> >>>I have been informed that the flash layout should also be the same
> >>>for Alt (which currently does not have flash in its dts file in mainline).
> 
> >>>Based on the renesas-devel-20141125-v3.18-rc6 tag of my renesas tree.
> >>>---
> >>>  arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
> >>>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> >>>diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
> >>>index 990af16..9a4e714 100644
> >>>--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> >>>+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> >>>@@ -451,14 +451,14 @@
> >>>  			reg = <0x00000000 0x00080000>;
> >>>  			read-only;
> >>>  		};
> >>>-		partition at 80000 {
> >>>-			label = "bootenv";
> >>>-			reg = <0x00080000 0x00080000>;
> >>>+		partition at 40000 {
> >>>+			label = "user";
> >>>+			reg = <0x00080000 0x00580000>;
> 
> >>    The "reg" prop doesn't match the <unit-address> pat of the name.
> 
> >Are you suggesting this?
> 
> >			reg = <0x00080000 0x00600000>;
> 
>    No, I'm suggesting to change the <unit-address> part of the node name to
> match the offset in the "reg" property (given it's correct).

Thanks, got it.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
  2014-12-01  0:30         ` Simon Horman
@ 2014-12-01  8:05           ` Geert Uytterhoeven
  -1 siblings, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2014-12-01  8:05 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Simon,

On Mon, Dec 1, 2014 at 1:30 AM, Simon Horman <horms@verge.net.au> wrote:
> On Fri, Nov 28, 2014 at 09:34:05AM +0100, Geert Uytterhoeven wrote:
>> On Fri, Nov 28, 2014 at 1:27 AM, Simon Horman <horms@verge.net.au> wrote:
>> > On Wed, Nov 26, 2014 at 03:50:45PM +0300, Sergei Shtylyov wrote:
>> >> On 11/26/2014 3:13 AM, Simon Horman wrote:
>> >> >"loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
>> >> >"user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
>> >> >"flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]
>> >>
>> >> >["user"'s assumed breakdown]
>> >> >U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB
>>
>> KiB
>>
>> You may want to split this explicitly in 256 KiB for U-boot, and 256 KiB for the
>> U-boot bootargs, to help people needing low-level recovery.
>
> Are you suggesting 4 partitions or just an adjustment of the assumption
> documented in the changelog?

Just the documentation.

I thought about having more partitions, though. But the two 256 KiB
blocks are just
two erase blocks.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size
@ 2014-12-01  8:05           ` Geert Uytterhoeven
  0 siblings, 0 replies; 16+ messages in thread
From: Geert Uytterhoeven @ 2014-12-01  8:05 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Simon,

On Mon, Dec 1, 2014 at 1:30 AM, Simon Horman <horms@verge.net.au> wrote:
> On Fri, Nov 28, 2014 at 09:34:05AM +0100, Geert Uytterhoeven wrote:
>> On Fri, Nov 28, 2014 at 1:27 AM, Simon Horman <horms@verge.net.au> wrote:
>> > On Wed, Nov 26, 2014 at 03:50:45PM +0300, Sergei Shtylyov wrote:
>> >> On 11/26/2014 3:13 AM, Simon Horman wrote:
>> >> >"loader"---0x0000_0000-0x0008_0000 [loader program (readonly)]
>> >> >"user"  ---0x0008_0000-0x0060_0000 [U-Boot + bootargs + dt + uImage (readonly)]
>> >> >"flash" ---0x0060_0000-0x0400_0000 [filesystem and free (read/write)]
>> >>
>> >> >["user"'s assumed breakdown]
>> >> >U-boot+ bootargs(0x0008_0000-0x0010_0000) 512KB
>>
>> KiB
>>
>> You may want to split this explicitly in 256 KiB for U-boot, and 256 KiB for the
>> U-boot bootargs, to help people needing low-level recovery.
>
> Are you suggesting 4 partitions or just an adjustment of the assumption
> documented in the changelog?

Just the documentation.

I thought about having more partitions, though. But the two 256 KiB
blocks are just
two erase blocks.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2014-12-01  8:05 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-26  0:13 [PATCH] ARM: shmobile: dts: koelsch: Fix flash partition label and size Simon Horman
2014-11-26  0:13 ` Simon Horman
2014-11-26 12:50 ` Sergei Shtylyov
2014-11-26 12:50   ` Sergei Shtylyov
2014-11-28  0:27   ` Simon Horman
2014-11-28  0:27     ` Simon Horman
2014-11-28  8:34     ` Geert Uytterhoeven
2014-11-28  8:34       ` Geert Uytterhoeven
2014-12-01  0:30       ` Simon Horman
2014-12-01  0:30         ` Simon Horman
2014-12-01  8:05         ` Geert Uytterhoeven
2014-12-01  8:05           ` Geert Uytterhoeven
2014-11-28 11:09     ` Sergei Shtylyov
2014-11-28 11:09       ` Sergei Shtylyov
2014-12-01  0:31       ` Simon Horman
2014-12-01  0:31         ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.