From: Stefan Wahren <stefan.wahren@i2se.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Shawn Guo <shawn.guo@linaro.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Marek Vasut <marex@denx.de>
Subject: Re: [PATCH RFC 2/3] power: mxs_power: add driver for mxs power subsystem
Date: Thu, 22 Jan 2015 09:08:04 +0100 [thread overview]
Message-ID: <54C0AFE4.3020701@i2se.com> (raw)
In-Reply-To: <20150121230148.GJ13715@earth.universe>
Hi Sebastian,
[add Marek]
Am 22.01.2015 um 00:01 schrieb Sebastian Reichel:
> Hi Stefan,
>
> Sorry for the big delay.
a late answer is better than no answer :)
>
> On Thu, Nov 20, 2014 at 08:14:36PM +0000, Stefan Wahren wrote:
>> This patch adds a minimal driver for the Freescale i.MX23, i.MX28
>> power subsystem. It's required to trigger the probing of the underlying
>> drivers like on-chip regulators. Additionally the drivers supports
>> the configuration of the DC-DC clock frequency to avoid possible
>> interferences.
> I would expect PLL to be board specific and part of DT. Why is it
> specified as parameter?
I think the switching frequency of the DC-DC belongs to the
configuration and don't describe how the hardware is connected. But i
don't have a problem to change it into a DT property.
Does a common property name exists for the switching frequency or would
it be vendor specific?
> Apart from that the driver/patch looks fine to me.
In the meantime i made some bugfixes on these patches. Now i think it
would be better to integrate the on-chip regulator driver into the patch
series. That would clarify the function of the power driver.
> -- Sebastian
Best regards
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: stefan.wahren@i2se.com (Stefan Wahren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 2/3] power: mxs_power: add driver for mxs power subsystem
Date: Thu, 22 Jan 2015 09:08:04 +0100 [thread overview]
Message-ID: <54C0AFE4.3020701@i2se.com> (raw)
In-Reply-To: <20150121230148.GJ13715@earth.universe>
Hi Sebastian,
[add Marek]
Am 22.01.2015 um 00:01 schrieb Sebastian Reichel:
> Hi Stefan,
>
> Sorry for the big delay.
a late answer is better than no answer :)
>
> On Thu, Nov 20, 2014 at 08:14:36PM +0000, Stefan Wahren wrote:
>> This patch adds a minimal driver for the Freescale i.MX23, i.MX28
>> power subsystem. It's required to trigger the probing of the underlying
>> drivers like on-chip regulators. Additionally the drivers supports
>> the configuration of the DC-DC clock frequency to avoid possible
>> interferences.
> I would expect PLL to be board specific and part of DT. Why is it
> specified as parameter?
I think the switching frequency of the DC-DC belongs to the
configuration and don't describe how the hardware is connected. But i
don't have a problem to change it into a DT property.
Does a common property name exists for the switching frequency or would
it be vendor specific?
> Apart from that the driver/patch looks fine to me.
In the meantime i made some bugfixes on these patches. Now i think it
would be better to integrate the on-chip regulator driver into the patch
series. That would clarify the function of the power driver.
> -- Sebastian
Best regards
Stefan
next prev parent reply other threads:[~2015-01-22 8:08 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 20:14 [PATCH RFC 0/3] power: mxs_power: add driver for mxs power subsystem Stefan Wahren
2014-11-20 20:14 ` Stefan Wahren
2014-11-20 20:14 ` [PATCH RFC 1/3] DT: add binding " Stefan Wahren
2014-11-20 20:14 ` Stefan Wahren
2014-11-20 20:14 ` [PATCH RFC 2/3] power: mxs_power: add driver " Stefan Wahren
2014-11-20 20:14 ` Stefan Wahren
2015-01-21 23:01 ` Sebastian Reichel
2015-01-21 23:01 ` Sebastian Reichel
2015-01-22 8:08 ` Stefan Wahren [this message]
2015-01-22 8:08 ` Stefan Wahren
2015-01-22 9:37 ` Sébastien SZYMANSKI
2015-01-22 9:37 ` Sébastien SZYMANSKI
2015-01-22 9:48 ` Stefan Wahren
2015-01-22 9:48 ` Stefan Wahren
[not found] ` <54C0AFE4.3020701-eS4NqCHxEME@public.gmane.org>
2015-01-25 15:04 ` Sebastian Reichel
2015-01-25 15:04 ` Sebastian Reichel
[not found] ` <20150125150431.GE2719-SfvFxonMDyemK9LvCR3Hrw@public.gmane.org>
2015-01-26 19:46 ` Stefan Wahren
2015-01-26 19:46 ` Stefan Wahren
2015-01-27 0:16 ` Mark Brown
2015-01-27 0:16 ` Mark Brown
2015-01-27 18:35 ` Stefan Wahren
2015-01-27 18:35 ` Stefan Wahren
[not found] ` <1954124242.301697.1422383709733.JavaMail.open-xchange-h4m1HHXQYNE54XbDmwzAWMgmgJlYmuWJ@public.gmane.org>
2015-01-27 19:43 ` Mark Brown
2015-01-27 19:43 ` Mark Brown
2015-01-28 22:22 ` Stefan Wahren
2015-01-28 22:22 ` Stefan Wahren
2015-01-28 22:59 ` Sebastian Reichel
2015-01-28 22:59 ` Sebastian Reichel
[not found] ` <20150128225937.GA12749-SfvFxonMDyemK9LvCR3Hrw@public.gmane.org>
2015-02-03 20:41 ` Stefan Wahren
2015-02-03 20:41 ` Stefan Wahren
2015-02-20 10:57 ` Stefan Wahren
2015-02-20 10:57 ` Stefan Wahren
[not found] ` <1766258118.893447.1424429861770.JavaMail.open-xchange-h4m1HHXQYNGvCDav5jC2oMgmgJlYmuWJ@public.gmane.org>
2015-02-23 15:38 ` Sebastian Reichel
2015-02-23 15:38 ` Sebastian Reichel
2015-02-26 19:20 ` Stefan Wahren
2015-02-26 19:20 ` Stefan Wahren
2014-11-20 20:14 ` [PATCH RFC 3/3] ARM: dts: enable power subsystem for i.MX28 Stefan Wahren
2014-11-20 20:14 ` Stefan Wahren
2014-11-20 21:32 ` Fabio Estevam
2014-11-20 21:32 ` Fabio Estevam
2014-11-20 22:57 ` Stefan Wahren
2014-11-20 22:57 ` Stefan Wahren
2014-11-21 13:55 ` Fabio Estevam
2014-11-21 13:55 ` Fabio Estevam
2014-11-26 10:26 ` [PATCH RFC 0/3] power: mxs_power: add driver for mxs power subsystem Stefan Wahren
2014-11-26 10:26 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C0AFE4.3020701@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=festevam@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=marex@denx.de \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.