All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: <vinod.koul@intel.com>, <tony@atomide.com>,
	<grant.likely@linaro.org>, <dmaengine@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <robh+dt@kernel.org>,
	<nm@ti.com>
Subject: Re: [PATCH v3 5/7] dmaengine: omap-dma: Take DMA request number from DT if it is available
Date: Tue, 31 Mar 2015 17:47:25 +0300	[thread overview]
Message-ID: <551AB37D.1090104@ti.com> (raw)
In-Reply-To: <20150327202446.GB4027@n2100.arm.linux.org.uk>

On 03/27/2015 10:24 PM, Russell King - ARM Linux wrote:
> On Fri, Mar 27, 2015 at 02:26:51PM +0200, Peter Ujfalusi wrote:
>> +	if (!pdev->dev.of_node || of_property_read_u32(pdev->dev.of_node,
>> +						       "dma-requests",
>> +						       &od->dma_requests)) {
>> +		dev_info(&pdev->dev,
>> +			 "Missing dma-requests property, using %u.\n",
>> +			 OMAP_SDMA_REQUESTS);
>> +		od->dma_requests = OMAP_SDMA_REQUESTS;
>> +	}
> 
> Are all OMAPs including OMAP1 being converted to DT?  If not, don't
> introduce noisy printks for which a platform can't do anything about.
> Think about this please - if there's no of_node, then why complain
> about a missing OF property?

Yes, you are perfectly right on this. Will fix it up.

Thanks,
Péter

WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: vinod.koul@intel.com, tony@atomide.com, grant.likely@linaro.org,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
	nm@ti.com
Subject: Re: [PATCH v3 5/7] dmaengine: omap-dma: Take DMA request number from DT if it is available
Date: Tue, 31 Mar 2015 17:47:25 +0300	[thread overview]
Message-ID: <551AB37D.1090104@ti.com> (raw)
In-Reply-To: <20150327202446.GB4027@n2100.arm.linux.org.uk>

On 03/27/2015 10:24 PM, Russell King - ARM Linux wrote:
> On Fri, Mar 27, 2015 at 02:26:51PM +0200, Peter Ujfalusi wrote:
>> +	if (!pdev->dev.of_node || of_property_read_u32(pdev->dev.of_node,
>> +						       "dma-requests",
>> +						       &od->dma_requests)) {
>> +		dev_info(&pdev->dev,
>> +			 "Missing dma-requests property, using %u.\n",
>> +			 OMAP_SDMA_REQUESTS);
>> +		od->dma_requests = OMAP_SDMA_REQUESTS;
>> +	}
> 
> Are all OMAPs including OMAP1 being converted to DT?  If not, don't
> introduce noisy printks for which a platform can't do anything about.
> Think about this please - if there's no of_node, then why complain
> about a missing OF property?

Yes, you are perfectly right on this. Will fix it up.

Thanks,
Péter

WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/7] dmaengine: omap-dma: Take DMA request number from DT if it is available
Date: Tue, 31 Mar 2015 17:47:25 +0300	[thread overview]
Message-ID: <551AB37D.1090104@ti.com> (raw)
In-Reply-To: <20150327202446.GB4027@n2100.arm.linux.org.uk>

On 03/27/2015 10:24 PM, Russell King - ARM Linux wrote:
> On Fri, Mar 27, 2015 at 02:26:51PM +0200, Peter Ujfalusi wrote:
>> +	if (!pdev->dev.of_node || of_property_read_u32(pdev->dev.of_node,
>> +						       "dma-requests",
>> +						       &od->dma_requests)) {
>> +		dev_info(&pdev->dev,
>> +			 "Missing dma-requests property, using %u.\n",
>> +			 OMAP_SDMA_REQUESTS);
>> +		od->dma_requests = OMAP_SDMA_REQUESTS;
>> +	}
> 
> Are all OMAPs including OMAP1 being converted to DT?  If not, don't
> introduce noisy printks for which a platform can't do anything about.
> Think about this please - if there's no of_node, then why complain
> about a missing OF property?

Yes, you are perfectly right on this. Will fix it up.

Thanks,
P?ter

  reply	other threads:[~2015-03-31 14:49 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 12:26 [PATCH v3 0/7] dmaengine/dra7x: DMA router (crossbar support) Peter Ujfalusi
2015-03-27 12:26 ` Peter Ujfalusi
2015-03-27 12:26 ` Peter Ujfalusi
2015-03-27 12:26 ` [PATCH v3 1/7] dmaengine: of_dma: Support for DMA routers Peter Ujfalusi
2015-03-27 12:26   ` Peter Ujfalusi
2015-03-27 12:26   ` Peter Ujfalusi
2015-03-28  1:44   ` Arnd Bergmann
2015-03-28  1:44     ` Arnd Bergmann
2015-03-31 16:48     ` Peter Ujfalusi
2015-03-31 16:48       ` Peter Ujfalusi
2015-03-31 16:48       ` Peter Ujfalusi
2015-03-27 12:26 ` [PATCH v3 2/7] Documentation: devicetree: dma: Binding documentation for TI DMA crossbar Peter Ujfalusi
2015-03-27 12:26   ` Peter Ujfalusi
2015-03-27 12:26   ` Peter Ujfalusi
2015-03-27 12:26 ` [PATCH v3 3/7] dmaengine: Add driver for TI DMA crossbar on DRA7x Peter Ujfalusi
2015-03-27 12:26   ` Peter Ujfalusi
2015-03-27 12:26   ` Peter Ujfalusi
2015-03-27 12:26 ` [PATCH v3 4/7] dmaengine: omap-dma: Use defines for dma channels and request count Peter Ujfalusi
2015-03-27 12:26   ` Peter Ujfalusi
2015-03-27 12:26   ` Peter Ujfalusi
2015-03-27 12:26 ` [PATCH v3 5/7] dmaengine: omap-dma: Take DMA request number from DT if it is available Peter Ujfalusi
2015-03-27 12:26   ` Peter Ujfalusi
2015-03-27 12:26   ` Peter Ujfalusi
2015-03-27 20:24   ` Russell King - ARM Linux
2015-03-27 20:24     ` Russell King - ARM Linux
2015-03-31 14:47     ` Peter Ujfalusi [this message]
2015-03-31 14:47       ` Peter Ujfalusi
2015-03-31 14:47       ` Peter Ujfalusi
2015-03-27 12:26 ` [PATCH v3 6/7] dmaengine: omap-dma: Remove mapping between virtual channels and requests Peter Ujfalusi
2015-03-27 12:26   ` Peter Ujfalusi
2015-03-27 12:26   ` Peter Ujfalusi
2015-03-27 20:22   ` Russell King - ARM Linux
2015-03-27 20:22     ` Russell King - ARM Linux
2015-03-31 15:44     ` Peter Ujfalusi
2015-03-31 15:44       ` Peter Ujfalusi
2015-03-31 15:44       ` Peter Ujfalusi
2015-03-27 12:26 ` [PATCH v3 7/7] ARM: DTS: dra7x: Integrate sDMA crossbar Peter Ujfalusi
2015-03-27 12:26   ` Peter Ujfalusi
2015-03-27 12:26   ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551AB37D.1090104@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.