From: Jon Masters <jcm@redhat.com> To: Loc Ho <lho@apm.com>, dougthompson@xmission.com, bp@alien8.de, mchehab@osg.samsung.com, robh+dt@kernel.org, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk Cc: devicetree@vger.kernel.org, patches@apm.com, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org Subject: Re: [PATCH v8 1/5] arm64: Enable EDAC on ARM64 Date: Wed, 06 May 2015 00:10:03 -0400 [thread overview] Message-ID: <5549941B.7060400@redhat.com> (raw) In-Reply-To: <1430884947-16787-2-git-send-email-lho@apm.com> Hi Loc, Great to see v8 of the patches :) A comment below. On 05/06/2015 12:02 AM, Loc Ho wrote: > Add an stub atomic_scrub function and enable EDAC for arm64. > +/* > + * ECC atomic, DMA, SMP and interrupt safe scrub function. > + */ nit: I expect you'll still get a little push back on that (similar to last time) because it doesn't actually implement anything, so while it is "safe" it's only because it's empty :) Might be better to indicate that those are the features it is supposed to have when implemented. > +static inline void atomic_scrub(void *va, u32 size) > +{ > + /* Stub function for now until an ARM64 HW has a way to test it. */ > + WARN_ONCE(1, "not implemented"); > +} That's great and seems to address the previous comment from v7. Thanks, Jon.
WARNING: multiple messages have this Message-ID (diff)
From: jcm@redhat.com (Jon Masters) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v8 1/5] arm64: Enable EDAC on ARM64 Date: Wed, 06 May 2015 00:10:03 -0400 [thread overview] Message-ID: <5549941B.7060400@redhat.com> (raw) In-Reply-To: <1430884947-16787-2-git-send-email-lho@apm.com> Hi Loc, Great to see v8 of the patches :) A comment below. On 05/06/2015 12:02 AM, Loc Ho wrote: > Add an stub atomic_scrub function and enable EDAC for arm64. > +/* > + * ECC atomic, DMA, SMP and interrupt safe scrub function. > + */ nit: I expect you'll still get a little push back on that (similar to last time) because it doesn't actually implement anything, so while it is "safe" it's only because it's empty :) Might be better to indicate that those are the features it is supposed to have when implemented. > +static inline void atomic_scrub(void *va, u32 size) > +{ > + /* Stub function for now until an ARM64 HW has a way to test it. */ > + WARN_ONCE(1, "not implemented"); > +} That's great and seems to address the previous comment from v7. Thanks, Jon.
next prev parent reply other threads:[~2015-05-06 4:10 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-06 4:02 [PATCH v8 0/4] edac: Add APM X-Gene SoC memory controller EDAC driver Loc Ho 2015-05-06 4:02 ` Loc Ho [not found] ` <1430884947-16787-1-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org> 2015-05-06 4:02 ` [PATCH v8 1/5] arm64: Enable EDAC on ARM64 Loc Ho 2015-05-06 4:02 ` Loc Ho [not found] ` <1430884947-16787-2-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org> 2015-05-06 4:02 ` [PATCH v8 2/5] MAINTAINERS: Add entry for APM X-Gene SoC EDAC driver Loc Ho 2015-05-06 4:02 ` Loc Ho [not found] ` <1430884947-16787-3-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org> 2015-05-06 4:02 ` [PATCH v8 3/5] Documentation: Add documentation for the APM X-Gene SoC EDAC DTS binding Loc Ho 2015-05-06 4:02 ` Loc Ho [not found] ` <1430884947-16787-4-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org> 2015-05-06 4:02 ` [PATCH v8 4/5] edac: Add APM X-Gene SoC memory controller EDAC driver Loc Ho 2015-05-06 4:02 ` Loc Ho [not found] ` <1430884947-16787-5-git-send-email-lho-qTEPVZfXA3Y@public.gmane.org> 2015-05-06 4:02 ` [PATCH v8 5/5] arm64: Add APM X-Gene SoC memory controller EDAC DTS entries Loc Ho 2015-05-06 4:02 ` Loc Ho 2015-05-06 4:10 ` Jon Masters [this message] 2015-05-06 4:10 ` [PATCH v8 1/5] arm64: Enable EDAC on ARM64 Jon Masters 2015-05-06 8:41 ` [PATCH v8 0/4] edac: Add APM X-Gene SoC memory controller EDAC driver Borislav Petkov 2015-05-06 8:41 ` Borislav Petkov 2015-05-06 17:00 ` Loc Ho [not found] ` <CAPw-ZT=LepJr2Smjy81yhcTANdMRw99x1vR9rMoYsnHW_P3HPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-05-06 17:12 ` Borislav Petkov 2015-05-06 17:12 ` Borislav Petkov [not found] ` <20150506171242.GG22949-fF5Pk5pvG8Y@public.gmane.org> 2015-05-06 18:17 ` Loc Ho 2015-05-06 18:17 ` Loc Ho 2015-05-06 8:52 ` Arnd Bergmann 2015-05-06 8:52 ` Arnd Bergmann 2015-05-06 18:12 ` Loc Ho 2015-05-06 18:12 ` Loc Ho [not found] ` <CAPw-ZTkuZWNM9D_wJRfQq009KeL1coyYKXhqhWV+FWW6C=xRiA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-05-06 18:29 ` Borislav Petkov 2015-05-06 18:29 ` Borislav Petkov [not found] ` <20150506182900.GI22949-fF5Pk5pvG8Y@public.gmane.org> 2015-05-06 18:43 ` Loc Ho 2015-05-06 18:43 ` Loc Ho [not found] ` <CAPw-ZTmJ8C3KmujZJN1z21S3LFQ-TRouUeAjN0Y02HOTKAG1_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-05-06 19:50 ` Arnd Bergmann 2015-05-06 19:50 ` Arnd Bergmann 2015-05-11 22:29 ` Loc Ho 2015-05-11 22:29 ` Loc Ho
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5549941B.7060400@redhat.com \ --to=jcm@redhat.com \ --cc=bp@alien8.de \ --cc=devicetree@vger.kernel.org \ --cc=dougthompson@xmission.com \ --cc=ijc+devicetree@hellion.org.uk \ --cc=lho@apm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-edac@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@osg.samsung.com \ --cc=patches@apm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.