All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juri Lelli <juri.lelli@arm.com>
To: Doug Smythies <dsmythies@telus.net>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"'Ingo Molnar'" <mingo@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: On resume from suspend only CPU 0 comes back on-line [REGRESSION][BISECTED]
Date: Thu, 14 May 2015 16:01:44 +0100	[thread overview]
Message-ID: <5554B8D8.8090006@arm.com> (raw)
In-Reply-To: <004801d08e54$20d5bd60$62813820$@net>

Hi Doug,

On 14/05/15 15:41, Doug Smythies wrote:
> As of, or about, Kernel 4.1RC1 on resume from suspend only CPU 0 comes back on-line.
> The issue persists through Kernel 4.1RC3.
> This is on my test computer with an i7-2600K.
> I do not normally use suspend on this computer, but was doing so while working on a bug report.
> 
> The kernel was bisected, and this is the result:
> 

Does commit 533445c6e533 "sched/core: Fix regression in
cpuset_cpu_inactive() for suspend" on tip/sched/core
fix the bug?

Thanks,

- Juri

> 3c18d447b3b36a8d3c90dc37dfbd363cdb685d0a is the first bad commit
> commit 3c18d447b3b36a8d3c90dc37dfbd363cdb685d0a
> Author: Juri Lelli <juri.lelli@arm.com>
> Date:   Tue Mar 31 09:53:37 2015 +0100
> 
>     sched/core: Check for available DL bandwidth in cpuset_cpu_inactive()
> 
>     Hotplug operations are destructive w.r.t. cpusets. In case such an
>     operation is performed on a CPU belonging to an exlusive cpuset, the
>     DL bandwidth information associated with the corresponding root
>     domain is gone even if the operation fails (in sched_cpu_inactive()).
> 
>     For this reason we need to move the check we currently have in
>     sched_cpu_inactive() to cpuset_cpu_inactive() to prevent useless
>     cpusets reconfiguration in the CPU_DOWN_FAILED path.
> 
>     Signed-off-by: Juri Lelli <juri.lelli@arm.com>
>     Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>     Cc: Juri Lelli <juri.lelli@gmail.com>
>     Link: http://lkml.kernel.org/r/1427792017-7356-2-git-send-email-juri.lelli@arm.com
>     Signed-off-by: Ingo Molnar <mingo@kernel.org>
> 
> :040000 040000 10f8d81afdc8e625f8e6720883d3eb42c28d452b c08264528890941bad35d5d4cc134c03f259c534 M      kernel
> 
> Since I sometimes mess up using git bisect, and end up at some random result,
> the above was double checked manually:
> 
> 3c18d447b3b36a8d3c90dc37dfbd363cdb685d0a has the issue.
> 4cd57f97135840f637431c92380c8da3edbe44ed (the previous commit) does not have the issue.
> 
> 


  reply	other threads:[~2015-05-14 15:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 14:41 On resume from suspend only CPU 0 comes back on-line [REGRESSION][BISECTED] Doug Smythies
2015-05-14 15:01 ` Juri Lelli [this message]
2015-05-14 17:48   ` Ingo Molnar
2015-05-14 22:12     ` Doug Smythies
2015-05-15  6:51       ` Ingo Molnar
2015-05-15  8:50       ` Juri Lelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5554B8D8.8090006@arm.com \
    --to=juri.lelli@arm.com \
    --cc=dsmythies@telus.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.