From: Yakir Yang <ykk@rock-chips.com> To: Krzysztof Kozlowski <k.kozlowski@samsung.com>, Heiko Stuebner <heiko@sntech.de>, Thierry Reding <treding@nvidia.com>, Jingoo Han <jingoohan1@gmail.com>, Inki Dae <inki.dae@samsung.com>, joe@perches.com, Kukjin Kim <kgene@kernel.org>, Mark Yao <mark.yao@rock-chips.com> Cc: Russell King <rmk+kernel@arm.linux.org.uk>, djkurtz@chromium.com, dianders@chromium.com, seanpaul@chromium.com, ajaynumb@gmail.com, Andrzej Hajda <a.hajda@samsung.com>, Kyungmin Park <kyungmin.park@samsung.com>, David Airlie <airlied@linux.ie>, Gustavo Padovan <gustavo.padovan@collabora.co.uk>, Andy Yan <andy.yan@rock-chips.com>, Kumar Gala <galak@codeaurora.org>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Kishon Vijay Abraham I <kishon@ti.com>, architt@codeaurora.org, robherring2@gmail.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 01/16] drm: exynos/dp: fix code style Date: Thu, 03 Sep 2015 13:33:27 +0800 [thread overview] Message-ID: <55E7DBA7.90504@rock-chips.com> (raw) In-Reply-To: <55E7D5EB.1060505@samsung.com> Hi Krzysztof, 在 09/03/2015 01:08 PM, Krzysztof Kozlowski 写道: > On 03.09.2015 14:04, Yakir Yang wrote: >> Hi Krzysztof, >> >> 在 09/03/2015 08:21 AM, Krzysztof Kozlowski 写道: >>> On 01.09.2015 14:46, Yakir Yang wrote: >>>> After run "checkpatch.pl -f --subjective" command, I see there >>>> are lots of alignment problem in exynos_dp driver, so let just >>>> fix them. >>> Hi, >>> >>> Warnings from checkpatch are not a reason for a commit. Reason for a >>> commit could be for example an unreadable code, violation of >>> coding-style leading to decrease in code maintainability or just >>> improving the code readability so it will be easier to review and >>> maintain it. >>> >>> You do not make commits because some tool tells you that. We do not >>> listen to machines :) ... If that would be the case, the commit could be >>> made automatically, without human interaction. Such automated commit >>> could be even easily tested by the machine by comparing object files. >>> >>> Especially that you enabled "subjective" rule. This is not a valid >>> motivation for a commit. >>> >>> Please rephrase this to sensible reason and convince that change is >>> worth the effort. >> Oh, nice, thanks for your remind. I would rephrase the commit. >> >>>> - Take Romain suggest, rebase on linux-next branch >>> That comment seems unrelated to the commit. Please remove it. >> Done, >> >>>> Signed-off-by: Yakir Yang <ykk@rock-chips.com> >>>> --- >>>> Changes in v4: None >>>> Changes in v3: None >>>> Changes in v2: >>>> - Take Joe Preches advise, improved commit message more readable, and >>>> avoid using some uncommon style like bellow: >>>> - retval = exynos_dp_read_bytes_from_i2c(... >>>> ...) >>>> + retval = >>>> + exynos_dp_read_bytes_from_i2c(......); >>>> >>>> drivers/gpu/drm/exynos/exynos_dp_core.c | 226 >>>> ++++++++++++++++---------------- >>>> drivers/gpu/drm/exynos/exynos_dp_core.h | 54 ++++---- >>>> drivers/gpu/drm/exynos/exynos_dp_reg.c | 106 +++++++-------- >>>> 3 files changed, 188 insertions(+), 198 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c >>>> b/drivers/gpu/drm/exynos/exynos_dp_core.c >>>> index d66ade0..266f7f7 100644 >>>> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c >>>> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c >>>> @@ -115,8 +115,8 @@ static int exynos_dp_read_edid(struct >>>> exynos_dp_device *dp) >>>> /* Read Extension Flag, Number of 128-byte EDID extension >>>> blocks */ >>>> retval = exynos_dp_read_byte_from_i2c(dp, I2C_EDID_DEVICE_ADDR, >>>> - EDID_EXTENSION_FLAG, >>>> - &extend_block); >>>> + EDID_EXTENSION_FLAG, >>>> + &extend_block); >>>> if (retval) >>>> return retval; >>>> @@ -124,10 +124,11 @@ static int exynos_dp_read_edid(struct >>>> exynos_dp_device *dp) >>>> dev_dbg(dp->dev, "EDID data includes a single extension!\n"); >>>> /* Read EDID data */ >>>> - retval = exynos_dp_read_bytes_from_i2c(dp, >>>> I2C_EDID_DEVICE_ADDR, >>>> - EDID_HEADER_PATTERN, >>>> - EDID_BLOCK_LENGTH, >>>> - &edid[EDID_HEADER_PATTERN]); >>>> + retval = exynos_dp_read_bytes_from_i2c( >>>> + dp, I2C_EDID_DEVICE_ADDR, >>>> + EDID_HEADER_PATTERN, >>>> + EDID_BLOCK_LENGTH, >>>> + &edid[EDID_HEADER_PATTERN]); >>>> if (retval != 0) { >>>> dev_err(dp->dev, "EDID Read failed!\n"); >>>> return -EIO; >>>> @@ -139,11 +140,11 @@ static int exynos_dp_read_edid(struct >>>> exynos_dp_device *dp) >>>> } >>>> /* Read additional EDID data */ >>>> - retval = exynos_dp_read_bytes_from_i2c(dp, >>>> - I2C_EDID_DEVICE_ADDR, >>>> - EDID_BLOCK_LENGTH, >>>> - EDID_BLOCK_LENGTH, >>>> - &edid[EDID_BLOCK_LENGTH]); >>>> + retval = exynos_dp_read_bytes_from_i2c( >>>> + dp, I2C_EDID_DEVICE_ADDR, >>>> + EDID_BLOCK_LENGTH, >>>> + EDID_BLOCK_LENGTH, >>>> + &edid[EDID_BLOCK_LENGTH]); >>>> if (retval != 0) { >>>> dev_err(dp->dev, "EDID Read failed!\n"); >>>> return -EIO; >>>> @@ -155,24 +156,22 @@ static int exynos_dp_read_edid(struct >>>> exynos_dp_device *dp) >>>> } >>>> exynos_dp_read_byte_from_dpcd(dp, DP_TEST_REQUEST, >>>> - &test_vector); >>>> + &test_vector); >>>> if (test_vector & DP_TEST_LINK_EDID_READ) { >>>> - exynos_dp_write_byte_to_dpcd(dp, >>>> - DP_TEST_EDID_CHECKSUM, >>>> + exynos_dp_write_byte_to_dpcd( >>>> + dp, DP_TEST_EDID_CHECKSUM, >>>> edid[EDID_BLOCK_LENGTH + EDID_CHECKSUM]); >>>> - exynos_dp_write_byte_to_dpcd(dp, >>>> - DP_TEST_RESPONSE, >>>> + exynos_dp_write_byte_to_dpcd( >>>> + dp, DP_TEST_RESPONSE, >>>> DP_TEST_EDID_CHECKSUM_WRITE); >>> To me, missing argument after opening parenthesis, looks worse. I would >>> prefer: >>> >>> exynos_dp_write_byte_to_dpcd(dp, >>> >>> Why you moved the 'dp' argument to new line? >> Hmm... Just like style tool indicate, no more warning after >> that change. >> >> For now, I would like to follow the original style, just improved >> some obvious style problem. :-) > What was the checkpatch warning that said 'dp' has to move to new line? > I tried this and I don't see it. checkpatch haven't remind me that put dp to new line would fix this warning, this just come from my experiments. And I works, no more warnings from checkpatch, so I toke this style. - Yakir > Best regards, > Krzysztof > > > >
WARNING: multiple messages have this Message-ID (diff)
From: ykk@rock-chips.com (Yakir Yang) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 01/16] drm: exynos/dp: fix code style Date: Thu, 03 Sep 2015 13:33:27 +0800 [thread overview] Message-ID: <55E7DBA7.90504@rock-chips.com> (raw) In-Reply-To: <55E7D5EB.1060505@samsung.com> Hi Krzysztof, ? 09/03/2015 01:08 PM, Krzysztof Kozlowski ??: > On 03.09.2015 14:04, Yakir Yang wrote: >> Hi Krzysztof, >> >> ? 09/03/2015 08:21 AM, Krzysztof Kozlowski ??: >>> On 01.09.2015 14:46, Yakir Yang wrote: >>>> After run "checkpatch.pl -f --subjective" command, I see there >>>> are lots of alignment problem in exynos_dp driver, so let just >>>> fix them. >>> Hi, >>> >>> Warnings from checkpatch are not a reason for a commit. Reason for a >>> commit could be for example an unreadable code, violation of >>> coding-style leading to decrease in code maintainability or just >>> improving the code readability so it will be easier to review and >>> maintain it. >>> >>> You do not make commits because some tool tells you that. We do not >>> listen to machines :) ... If that would be the case, the commit could be >>> made automatically, without human interaction. Such automated commit >>> could be even easily tested by the machine by comparing object files. >>> >>> Especially that you enabled "subjective" rule. This is not a valid >>> motivation for a commit. >>> >>> Please rephrase this to sensible reason and convince that change is >>> worth the effort. >> Oh, nice, thanks for your remind. I would rephrase the commit. >> >>>> - Take Romain suggest, rebase on linux-next branch >>> That comment seems unrelated to the commit. Please remove it. >> Done, >> >>>> Signed-off-by: Yakir Yang <ykk@rock-chips.com> >>>> --- >>>> Changes in v4: None >>>> Changes in v3: None >>>> Changes in v2: >>>> - Take Joe Preches advise, improved commit message more readable, and >>>> avoid using some uncommon style like bellow: >>>> - retval = exynos_dp_read_bytes_from_i2c(... >>>> ...) >>>> + retval = >>>> + exynos_dp_read_bytes_from_i2c(......); >>>> >>>> drivers/gpu/drm/exynos/exynos_dp_core.c | 226 >>>> ++++++++++++++++---------------- >>>> drivers/gpu/drm/exynos/exynos_dp_core.h | 54 ++++---- >>>> drivers/gpu/drm/exynos/exynos_dp_reg.c | 106 +++++++-------- >>>> 3 files changed, 188 insertions(+), 198 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c >>>> b/drivers/gpu/drm/exynos/exynos_dp_core.c >>>> index d66ade0..266f7f7 100644 >>>> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c >>>> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c >>>> @@ -115,8 +115,8 @@ static int exynos_dp_read_edid(struct >>>> exynos_dp_device *dp) >>>> /* Read Extension Flag, Number of 128-byte EDID extension >>>> blocks */ >>>> retval = exynos_dp_read_byte_from_i2c(dp, I2C_EDID_DEVICE_ADDR, >>>> - EDID_EXTENSION_FLAG, >>>> - &extend_block); >>>> + EDID_EXTENSION_FLAG, >>>> + &extend_block); >>>> if (retval) >>>> return retval; >>>> @@ -124,10 +124,11 @@ static int exynos_dp_read_edid(struct >>>> exynos_dp_device *dp) >>>> dev_dbg(dp->dev, "EDID data includes a single extension!\n"); >>>> /* Read EDID data */ >>>> - retval = exynos_dp_read_bytes_from_i2c(dp, >>>> I2C_EDID_DEVICE_ADDR, >>>> - EDID_HEADER_PATTERN, >>>> - EDID_BLOCK_LENGTH, >>>> - &edid[EDID_HEADER_PATTERN]); >>>> + retval = exynos_dp_read_bytes_from_i2c( >>>> + dp, I2C_EDID_DEVICE_ADDR, >>>> + EDID_HEADER_PATTERN, >>>> + EDID_BLOCK_LENGTH, >>>> + &edid[EDID_HEADER_PATTERN]); >>>> if (retval != 0) { >>>> dev_err(dp->dev, "EDID Read failed!\n"); >>>> return -EIO; >>>> @@ -139,11 +140,11 @@ static int exynos_dp_read_edid(struct >>>> exynos_dp_device *dp) >>>> } >>>> /* Read additional EDID data */ >>>> - retval = exynos_dp_read_bytes_from_i2c(dp, >>>> - I2C_EDID_DEVICE_ADDR, >>>> - EDID_BLOCK_LENGTH, >>>> - EDID_BLOCK_LENGTH, >>>> - &edid[EDID_BLOCK_LENGTH]); >>>> + retval = exynos_dp_read_bytes_from_i2c( >>>> + dp, I2C_EDID_DEVICE_ADDR, >>>> + EDID_BLOCK_LENGTH, >>>> + EDID_BLOCK_LENGTH, >>>> + &edid[EDID_BLOCK_LENGTH]); >>>> if (retval != 0) { >>>> dev_err(dp->dev, "EDID Read failed!\n"); >>>> return -EIO; >>>> @@ -155,24 +156,22 @@ static int exynos_dp_read_edid(struct >>>> exynos_dp_device *dp) >>>> } >>>> exynos_dp_read_byte_from_dpcd(dp, DP_TEST_REQUEST, >>>> - &test_vector); >>>> + &test_vector); >>>> if (test_vector & DP_TEST_LINK_EDID_READ) { >>>> - exynos_dp_write_byte_to_dpcd(dp, >>>> - DP_TEST_EDID_CHECKSUM, >>>> + exynos_dp_write_byte_to_dpcd( >>>> + dp, DP_TEST_EDID_CHECKSUM, >>>> edid[EDID_BLOCK_LENGTH + EDID_CHECKSUM]); >>>> - exynos_dp_write_byte_to_dpcd(dp, >>>> - DP_TEST_RESPONSE, >>>> + exynos_dp_write_byte_to_dpcd( >>>> + dp, DP_TEST_RESPONSE, >>>> DP_TEST_EDID_CHECKSUM_WRITE); >>> To me, missing argument after opening parenthesis, looks worse. I would >>> prefer: >>> >>> exynos_dp_write_byte_to_dpcd(dp, >>> >>> Why you moved the 'dp' argument to new line? >> Hmm... Just like style tool indicate, no more warning after >> that change. >> >> For now, I would like to follow the original style, just improved >> some obvious style problem. :-) > What was the checkpatch warning that said 'dp' has to move to new line? > I tried this and I don't see it. checkpatch haven't remind me that put dp to new line would fix this warning, this just come from my experiments. And I works, no more warnings from checkpatch, so I toke this style. - Yakir > Best regards, > Krzysztof > > > >
next prev parent reply other threads:[~2015-09-03 5:33 UTC|newest] Thread overview: 370+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-09-01 5:46 [PATCH v4 0/16] Add Analogix Core Display Port Driver Yakir Yang 2015-09-01 5:46 ` Yakir Yang 2015-09-01 5:46 ` [PATCH v4 01/16] drm: exynos/dp: fix code style Yakir Yang 2015-09-01 5:46 ` Yakir Yang 2015-09-03 0:21 ` Krzysztof Kozlowski 2015-09-03 0:21 ` Krzysztof Kozlowski 2015-09-03 5:04 ` Yakir Yang 2015-09-03 5:04 ` Yakir Yang 2015-09-03 5:08 ` Krzysztof Kozlowski 2015-09-03 5:08 ` Krzysztof Kozlowski 2015-09-03 5:33 ` Yakir Yang [this message] 2015-09-03 5:33 ` Yakir Yang 2015-09-03 5:57 ` Joe Perches 2015-09-03 5:57 ` Joe Perches 2015-09-03 5:57 ` Joe Perches 2015-09-06 1:33 ` Yakir Yang 2015-09-06 1:33 ` Yakir Yang 2015-09-06 1:33 ` Yakir Yang 2015-09-01 5:49 ` [PATCH v4 02/16] drm: exynos/dp: convert to drm bridge mode Yakir Yang 2015-09-01 5:49 ` Yakir Yang 2015-09-01 5:49 ` [PATCH v4 03/16] drm: bridge: analogix/dp: split exynos dp driver to bridge dir Yakir Yang 2015-09-01 5:49 ` Yakir Yang 2015-09-01 20:46 ` Heiko Stuebner 2015-09-01 20:46 ` Heiko Stuebner 2015-09-01 20:46 ` Heiko Stuebner 2015-09-02 1:45 ` Yakir Yang 2015-09-02 1:45 ` Yakir Yang 2015-09-04 21:06 ` Rob Herring 2015-09-04 21:06 ` Rob Herring 2015-09-04 21:06 ` Rob Herring 2015-09-04 21:29 ` Heiko Stuebner 2015-09-04 21:29 ` Heiko Stuebner 2015-09-04 21:29 ` Heiko Stuebner 2015-09-07 8:11 ` Thierry Reding 2015-09-07 8:11 ` Thierry Reding 2015-09-07 8:11 ` Thierry Reding 2015-09-02 14:50 ` Emil Velikov 2015-09-02 14:50 ` Emil Velikov 2015-09-02 14:50 ` Emil Velikov 2015-09-03 3:55 ` Yakir Yang 2015-09-03 3:55 ` Yakir Yang 2015-09-03 3:55 ` Yakir Yang 2015-09-03 0:58 ` Krzysztof Kozlowski 2015-09-03 0:58 ` Krzysztof Kozlowski 2015-09-03 5:30 ` Yakir Yang 2015-09-03 5:30 ` Yakir Yang 2015-09-04 0:41 ` Krzysztof Kozlowski 2015-09-04 0:41 ` Krzysztof Kozlowski 2015-09-06 7:49 ` Yakir Yang 2015-09-06 7:49 ` Yakir Yang 2015-09-07 0:22 ` Krzysztof Kozlowski 2015-09-07 0:22 ` Krzysztof Kozlowski 2015-09-07 0:22 ` Krzysztof Kozlowski 2015-09-07 2:27 ` Yakir Yang 2015-09-07 2:27 ` Yakir Yang 2015-09-01 5:52 ` [PATCH v4 04/16] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count Yakir Yang 2015-09-01 5:52 ` Yakir Yang 2015-09-01 5:55 ` [PATCH v4 05/16] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & colorimetry Yakir Yang 2015-09-01 5:55 ` Yakir Yang 2015-09-03 8:04 ` Krzysztof Kozlowski 2015-09-03 8:04 ` Krzysztof Kozlowski 2015-09-06 2:00 ` Yakir Yang 2015-09-06 2:00 ` Yakir Yang 2015-09-06 2:00 ` Yakir Yang 2015-09-01 5:58 ` [PATCH v4 06/16] Documentation: drm/bridge: add document for analogix_dp Yakir Yang 2015-09-01 5:58 ` Yakir Yang 2015-09-01 6:01 ` [PATCH v4 07/16] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver Yakir Yang 2015-09-01 6:01 ` Yakir Yang 2015-09-03 0:01 ` Krzysztof Kozlowski 2015-09-03 0:01 ` Krzysztof Kozlowski 2015-09-03 4:51 ` Yakir Yang 2015-09-01 6:01 ` [PATCH v4 08/16] drm: rockchip/dp: add rockchip platform dp driver Yakir Yang 2015-09-01 6:01 ` Yakir Yang 2015-09-01 6:01 ` Yakir Yang 2015-09-01 14:24 ` Heiko Stuebner 2015-09-01 14:24 ` Heiko Stuebner 2015-09-01 14:24 ` Heiko Stuebner 2015-09-01 14:48 ` Yakir Yang 2015-09-01 14:48 ` Yakir Yang 2015-09-01 21:00 ` Heiko Stuebner 2015-09-01 21:00 ` Heiko Stuebner 2015-09-01 21:00 ` Heiko Stuebner 2015-09-02 1:52 ` Yakir Yang 2015-09-02 1:52 ` Yakir Yang 2015-09-01 6:01 ` [PATCH v4 09/16] drm: rockchip: add bpc and color mode setting Yakir Yang 2015-09-01 6:01 ` Yakir Yang 2015-09-01 6:01 ` Yakir Yang 2015-09-01 21:00 ` Heiko Stuebner 2015-09-01 21:00 ` Heiko Stuebner 2015-09-01 21:00 ` Heiko Stuebner 2015-09-02 2:06 ` Yakir Yang 2015-09-02 2:06 ` Yakir Yang 2015-09-02 8:34 ` Thierry Reding 2015-09-02 8:34 ` Thierry Reding 2015-09-02 10:02 ` Yakir Yang 2015-09-02 10:02 ` Yakir Yang 2015-09-03 8:38 ` Thierry Reding 2015-09-03 8:38 ` Thierry Reding 2015-09-06 2:06 ` Yakir Yang 2015-09-06 2:06 ` Yakir Yang 2015-09-01 6:04 ` [PATCH v4 10/16] phy: Add driver for rockchip Display Port PHY Yakir Yang 2015-09-01 6:04 ` Yakir Yang 2015-09-01 6:04 ` Yakir Yang 2015-09-01 16:51 ` Heiko Stuebner 2015-09-01 16:51 ` Heiko Stuebner 2015-09-01 16:51 ` Heiko Stuebner 2015-09-01 20:58 ` Heiko Stuebner 2015-09-01 20:58 ` Heiko Stuebner 2015-09-01 20:58 ` Heiko Stuebner 2015-09-02 1:46 ` Yakir Yang 2015-09-02 1:46 ` Yakir Yang 2015-09-02 1:02 ` Yakir Yang 2015-09-02 1:02 ` Yakir Yang 2015-09-02 13:27 ` Rob Herring 2015-09-02 13:27 ` Rob Herring 2015-09-02 13:27 ` Rob Herring 2015-09-03 3:25 ` Yakir Yang 2015-09-03 3:25 ` Yakir Yang 2015-09-03 3:25 ` Yakir Yang 2015-09-03 13:52 ` Heiko Stuebner 2015-09-03 13:52 ` Heiko Stuebner 2015-09-03 13:52 ` Heiko Stuebner 2015-09-06 4:09 ` Yakir Yang 2015-09-06 4:09 ` Yakir Yang 2015-09-01 6:07 ` [PATCH v4 11/16] drm: bridge: analogix/dp: add platform device type support Yakir Yang 2015-09-01 6:07 ` Yakir Yang 2015-09-04 0:36 ` Krzysztof Kozlowski 2015-09-04 0:36 ` Krzysztof Kozlowski 2015-09-06 4:07 ` Yakir Yang 2015-09-06 4:07 ` Yakir Yang 2015-09-06 23:55 ` Krzysztof Kozlowski 2015-09-06 23:55 ` Krzysztof Kozlowski 2015-09-07 1:47 ` Yakir Yang 2015-09-01 6:09 ` [PATCH v4 12/16] drm: bridge: analogix/dp: add some rk3288 special registers setting Yakir Yang 2015-09-01 6:09 ` Yakir Yang 2015-09-01 6:11 ` [PATCH v4 13/16] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288 Yakir Yang 2015-09-01 6:11 ` Yakir Yang 2015-09-01 6:14 ` [PATCH v4 14/16] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang 2015-09-01 6:14 ` Yakir Yang 2015-09-02 20:17 ` Rob Herring 2015-09-02 20:17 ` Rob Herring 2015-09-02 20:17 ` Rob Herring 2015-09-03 4:27 ` Yakir Yang 2015-09-03 4:27 ` Yakir Yang 2015-09-03 4:27 ` Yakir Yang 2015-09-03 9:04 ` Thierry Reding 2015-09-03 9:04 ` Thierry Reding 2015-09-03 9:04 ` Thierry Reding 2015-09-04 10:20 ` Russell King - ARM Linux 2015-09-04 10:20 ` Russell King - ARM Linux 2015-09-04 10:20 ` Russell King - ARM Linux 2015-09-07 9:01 ` Thierry Reding 2015-09-07 9:01 ` Thierry Reding 2015-09-07 9:01 ` Thierry Reding 2015-09-06 3:59 ` Yakir Yang 2015-09-06 3:59 ` Yakir Yang 2015-09-07 8:20 ` Thierry Reding 2015-09-07 8:20 ` Thierry Reding 2015-09-07 8:20 ` Thierry Reding 2015-09-21 9:10 ` Yakir Yang 2015-09-04 21:46 ` Rob Herring 2015-09-04 21:46 ` Rob Herring 2015-09-04 21:46 ` Rob Herring 2015-09-06 8:20 ` Yakir Yang 2015-09-06 8:20 ` Yakir Yang 2015-09-06 8:20 ` Yakir Yang 2015-09-07 8:39 ` Thierry Reding 2015-09-07 8:39 ` Thierry Reding 2015-09-07 8:39 ` Thierry Reding 2015-09-03 8:47 ` Thierry Reding 2015-09-03 8:47 ` Thierry Reding 2015-09-03 8:47 ` Thierry Reding 2015-09-03 21:55 ` Rob Herring 2015-09-03 21:55 ` Rob Herring 2015-09-03 21:55 ` Rob Herring 2015-09-04 10:01 ` Thierry Reding 2015-09-04 10:01 ` Thierry Reding 2015-09-04 10:01 ` Thierry Reding 2015-09-01 6:17 ` [PATCH v4 15/16] drm: bridge: analogix/dp: move hpd detect to connector detect function Yakir Yang 2015-09-01 6:17 ` Yakir Yang 2015-09-01 6:20 ` [PATCH v4 16/16] drm: bridge: analogix/dp: add edid modes parse in get_modes method Yakir Yang 2015-09-01 6:20 ` Yakir Yang 2015-09-01 6:20 ` Yakir Yang 2015-09-01 21:47 ` [PATCH v4 0/16] Add Analogix Core Display Port Driver Heiko Stuebner 2015-09-01 21:47 ` Heiko Stuebner 2015-09-01 21:47 ` Heiko Stuebner 2015-09-02 2:15 ` Yakir Yang 2015-09-02 2:15 ` Yakir Yang 2015-09-21 8:45 ` Yakir Yang 2015-09-21 9:15 ` Thierry Reding 2015-09-21 9:15 ` Thierry Reding 2015-09-21 10:27 ` Yakir Yang 2015-09-21 10:27 ` Yakir Yang 2015-09-21 11:22 ` Thierry Reding 2015-09-21 11:22 ` Thierry Reding 2015-09-21 11:43 ` Yakir Yang 2015-09-22 7:20 ` [PATCH v5 0/17] " Yakir Yang 2015-09-22 7:20 ` Yakir Yang 2015-09-22 7:26 ` [PATCH v5 01/17] drm: exynos: dp: convert to drm bridge mode Yakir Yang 2015-09-22 7:26 ` Yakir Yang 2015-09-22 7:29 ` [PATCH v5 02/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory Yakir Yang 2015-09-22 7:29 ` Yakir Yang 2015-09-30 5:17 ` Krzysztof Kozlowski 2015-09-30 5:17 ` Krzysztof Kozlowski 2015-09-30 6:48 ` Yakir Yang 2015-09-30 6:48 ` Yakir Yang 2015-09-30 6:48 ` Yakir Yang 2015-09-22 7:34 ` [PATCH v5 03/17] drm: bridge: analogix/dp: fix some obvious code style Yakir Yang 2015-09-22 7:34 ` Yakir Yang 2015-09-30 5:22 ` Krzysztof Kozlowski 2015-09-30 5:22 ` Krzysztof Kozlowski 2015-09-30 6:52 ` Yakir Yang 2015-09-30 6:52 ` Yakir Yang 2015-09-22 7:35 ` [PATCH v5 04/17] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count Yakir Yang 2015-09-22 7:35 ` Yakir Yang 2015-09-22 7:35 ` Yakir Yang 2015-09-22 7:37 ` [PATCH v5 05/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range Yakir Yang 2015-09-22 7:37 ` Yakir Yang 2015-09-22 7:37 ` Yakir Yang 2015-09-30 5:32 ` Krzysztof Kozlowski 2015-09-30 5:32 ` Krzysztof Kozlowski 2015-09-30 5:32 ` Krzysztof Kozlowski 2015-09-30 7:19 ` Yakir Yang 2015-09-30 7:34 ` Krzysztof Kozlowski 2015-09-30 7:34 ` Krzysztof Kozlowski 2015-09-30 8:20 ` Yakir Yang 2015-09-30 8:26 ` Krzysztof Kozlowski 2015-09-30 8:26 ` Krzysztof Kozlowski 2015-09-30 8:26 ` Krzysztof Kozlowski 2015-09-30 9:39 ` Yakir Yang 2015-09-30 9:39 ` Yakir Yang 2015-09-22 7:40 ` [PATCH v5 06/17] Documentation: drm/bridge: add document for analogix_dp Yakir Yang 2015-09-22 7:40 ` Yakir Yang 2015-09-22 7:43 ` [PATCH v5 07/17] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver Yakir Yang 2015-09-22 7:43 ` Yakir Yang 2015-09-30 5:39 ` Krzysztof Kozlowski 2015-09-30 5:39 ` Krzysztof Kozlowski 2015-09-30 7:20 ` Yakir Yang 2015-09-30 7:20 ` Yakir Yang 2015-09-30 7:20 ` Yakir Yang 2015-09-22 7:45 ` [PATCH v5 08/17] drm: rockchip: dp: add rockchip platform dp driver Yakir Yang 2015-09-22 7:45 ` Yakir Yang 2015-09-22 7:48 ` [PATCH v5 09/17] Documentation: drm/bridge: add document for analogix_dp Yakir Yang 2015-09-22 7:48 ` Yakir Yang 2015-09-22 7:48 ` [PATCH v5 10/17] phy: Add driver for rockchip Display Port PHY Yakir Yang 2015-09-22 7:48 ` Yakir Yang 2015-09-22 7:51 ` [PATCH v5 11/17] Documentation: phy: add document for rockchip dp phy Yakir Yang 2015-09-22 7:51 ` Yakir Yang 2015-09-22 7:55 ` [PATCH v5 12/17] drm: rockchip: vop: add bpc and color mode setting Yakir Yang 2015-09-22 7:55 ` Yakir Yang 2015-09-22 7:55 ` Yakir Yang 2015-09-22 7:57 ` [PATCH v5 13/17] drm: bridge: analogix/dp: add some rk3288 special registers setting Yakir Yang 2015-09-22 7:57 ` Yakir Yang 2015-09-22 8:00 ` [PATCH v5 14/17] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288 Yakir Yang 2015-09-22 8:00 ` Yakir Yang 2015-09-22 8:02 ` [PATCH v5 15/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang 2015-09-22 8:02 ` Yakir Yang 2015-09-22 8:05 ` [PATCH v5 16/17] drm: bridge: analogix/dp: move hpd detect to connector detect function Yakir Yang 2015-09-22 8:05 ` Yakir Yang 2015-09-22 8:05 ` Yakir Yang 2015-09-22 8:07 ` [PATCH v5 17/17] drm: bridge: analogix/dp: add edid modes parse in get_modes method Yakir Yang 2015-09-22 8:07 ` Yakir Yang 2015-09-22 8:07 ` Yakir Yang 2015-10-07 6:25 ` [PATCH v5 0/17] Add Analogix Core Display Port Driver Yakir Yang 2015-10-07 6:25 ` Yakir Yang 2015-10-07 8:46 ` Javier Martinez Canillas 2015-10-07 8:46 ` Javier Martinez Canillas 2015-10-07 9:02 ` Yakir Yang 2015-10-07 9:02 ` Yakir Yang 2015-10-07 9:26 ` Javier Martinez Canillas 2015-10-07 9:26 ` Javier Martinez Canillas 2015-10-07 11:05 ` Yakir Yang 2015-10-07 11:25 ` Javier Martinez Canillas 2015-10-07 11:25 ` Javier Martinez Canillas 2015-10-08 0:40 ` Yakir Yang 2015-10-08 0:40 ` Yakir Yang 2015-10-10 14:31 ` Yakir Yang 2015-10-10 14:31 ` Yakir Yang 2015-10-10 14:31 ` Yakir Yang 2015-10-13 9:21 ` Javier Martinez Canillas 2015-10-13 9:21 ` Javier Martinez Canillas 2015-10-13 9:21 ` Javier Martinez Canillas 2015-10-13 13:50 ` Yakir Yang 2015-10-13 13:50 ` Yakir Yang 2015-10-14 8:18 ` Javier Martinez Canillas 2015-10-14 8:18 ` Javier Martinez Canillas 2015-10-14 8:18 ` Javier Martinez Canillas 2015-10-10 15:35 ` [PATCH v6 " Yakir Yang 2015-10-10 15:35 ` Yakir Yang 2015-10-10 15:38 ` [PATCH v6 01/17] drm: exynos: dp: convert to drm bridge mode Yakir Yang 2015-10-10 15:38 ` Yakir Yang 2015-10-10 15:39 ` [PATCH v6 02/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory Yakir Yang 2015-10-10 15:39 ` Yakir Yang 2015-10-10 15:41 ` [PATCH v6 03/17] drm: bridge: analogix/dp: fix some obvious code style Yakir Yang 2015-10-10 15:41 ` Yakir Yang 2015-10-10 15:43 ` [PATCH v6 04/17] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count Yakir Yang 2015-10-10 15:43 ` Yakir Yang 2015-10-10 15:43 ` Yakir Yang 2015-10-10 15:46 ` [PATCH v6 05/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range Yakir Yang 2015-10-10 15:46 ` Yakir Yang 2015-10-12 0:37 ` Yakir Yang 2015-10-12 0:37 ` Yakir Yang 2015-10-12 0:49 ` Krzysztof Kozlowski 2015-10-12 0:49 ` Krzysztof Kozlowski 2015-10-12 0:49 ` Krzysztof Kozlowski 2015-10-12 2:43 ` Yakir Yang 2015-10-12 2:43 ` Yakir Yang 2015-10-12 3:51 ` Krzysztof Kozlowski 2015-10-12 3:51 ` Krzysztof Kozlowski 2015-10-12 4:09 ` Yakir Yang 2015-10-12 4:09 ` Yakir Yang 2015-10-12 4:09 ` Yakir Yang 2015-10-12 4:16 ` Krzysztof Kozlowski 2015-10-12 4:16 ` Krzysztof Kozlowski 2015-10-10 15:49 ` [PATCH v6 06/17] Documentation: drm/bridge: add document for analogix_dp Yakir Yang 2015-10-10 15:49 ` Yakir Yang 2015-10-10 15:49 ` [PATCH v6 07/17] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver Yakir Yang 2015-10-10 15:49 ` Yakir Yang 2015-10-10 15:51 ` [PATCH v6 08/17] drm: rockchip: dp: add rockchip platform dp driver Yakir Yang 2015-10-10 15:51 ` Yakir Yang 2015-10-10 15:53 ` [PATCH v6 09/17] Documentation: drm/bridge: add document for analogix_dp Yakir Yang 2015-10-10 15:53 ` Yakir Yang 2015-10-10 15:53 ` Yakir Yang 2015-10-10 15:55 ` [PATCH v6 10/17] phy: Add driver for rockchip Display Port PHY Yakir Yang 2015-10-10 15:55 ` Yakir Yang 2015-10-12 15:02 ` Kishon Vijay Abraham I 2015-10-12 15:02 ` Kishon Vijay Abraham I 2015-10-12 15:02 ` Kishon Vijay Abraham I 2015-10-12 16:18 ` Heiko Stübner 2015-10-12 16:18 ` Heiko Stübner 2015-10-12 16:18 ` Heiko Stübner 2015-10-13 1:20 ` Yakir Yang 2015-10-13 1:20 ` Yakir Yang 2015-10-10 15:58 ` [PATCH v6 11/17] Documentation: phy: add document for rockchip dp phy Yakir Yang 2015-10-10 15:58 ` Yakir Yang 2015-10-12 22:28 ` Kishon Vijay Abraham I 2015-10-12 22:28 ` Kishon Vijay Abraham I 2015-10-12 22:28 ` Kishon Vijay Abraham I 2015-10-13 1:21 ` Yakir Yang 2015-10-13 1:21 ` Yakir Yang 2015-10-10 16:00 ` [PATCH v6 12/17] drm: rockchip: vop: add bpc and color mode setting Yakir Yang 2015-10-10 16:00 ` Yakir Yang 2015-10-10 16:05 ` [PATCH v6 13/17] drm: bridge: analogix/dp: add some rk3288 special registers setting Yakir Yang 2015-10-10 16:05 ` Yakir Yang 2015-10-10 16:05 ` Yakir Yang 2015-10-10 16:05 ` [PATCH v6 14/17] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288 Yakir Yang 2015-10-10 16:05 ` Yakir Yang 2015-10-10 16:05 ` [PATCH v6 15/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang 2015-10-10 16:05 ` Yakir Yang 2015-10-10 16:05 ` [PATCH v6 16/17] drm: bridge: analogix/dp: move hpd detect to connector detect function Yakir Yang 2015-10-10 16:05 ` Yakir Yang 2015-10-10 16:06 ` [PATCH v6 17/17] drm: bridge: analogix/dp: add edid modes parse in get_modes method Yakir Yang 2015-10-10 16:06 ` Yakir Yang 2015-10-12 4:29 ` [PATCH v7 05/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range Yakir Yang 2015-10-12 4:29 ` Yakir Yang 2015-10-12 6:54 ` Krzysztof Kozlowski 2015-10-12 6:54 ` Krzysztof Kozlowski 2015-10-12 7:20 ` Yakir Yang 2015-10-12 7:20 ` Yakir Yang 2015-10-12 7:20 ` Yakir Yang 2015-10-19 10:40 ` [PATCH v6 0/17] Add Analogix Core Display Port Driver Javier Martinez Canillas 2015-10-19 10:40 ` Javier Martinez Canillas 2015-10-19 10:40 ` Javier Martinez Canillas 2015-10-20 2:10 ` Yakir Yang 2015-10-20 2:10 ` Yakir Yang 2015-10-20 9:48 ` Javier Martinez Canillas 2015-10-20 9:48 ` Javier Martinez Canillas 2015-10-20 9:48 ` Javier Martinez Canillas 2015-10-20 11:40 ` Yakir Yang 2015-10-20 11:40 ` Yakir Yang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55E7DBA7.90504@rock-chips.com \ --to=ykk@rock-chips.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=ajaynumb@gmail.com \ --cc=andy.yan@rock-chips.com \ --cc=architt@codeaurora.org \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.com \ --cc=djkurtz@chromium.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=galak@codeaurora.org \ --cc=gustavo.padovan@collabora.co.uk \ --cc=heiko@sntech.de \ --cc=ijc+devicetree@hellion.org.uk \ --cc=inki.dae@samsung.com \ --cc=jingoohan1@gmail.com \ --cc=joe@perches.com \ --cc=k.kozlowski@samsung.com \ --cc=kgene@kernel.org \ --cc=kishon@ti.com \ --cc=kyungmin.park@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mark.yao@rock-chips.com \ --cc=pawel.moll@arm.com \ --cc=rmk+kernel@arm.linux.org.uk \ --cc=robh+dt@kernel.org \ --cc=robherring2@gmail.com \ --cc=seanpaul@chromium.com \ --cc=treding@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.