From: Jon Hunter <jonathanh@nvidia.com>
To: "Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>
Cc: Vidya Sagar <vidyas@nvidia.com>,
Bjorn Helgaas <helgaas@kernel.org>,
jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com,
treding@nvidia.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, kthota@nvidia.com,
mmaddireddy@nvidia.com, sagar.tv@gmail.com
Subject: Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging
Date: Wed, 14 Sep 2022 16:11:42 +0100 [thread overview]
Message-ID: <55fb64f0-7fe7-7938-9852-0ce389050f09@nvidia.com> (raw)
In-Reply-To: <YyHqxGw6ADmJUTEv@rocinante>
On 14/09/2022 15:52, Krzysztof Wilczyński wrote:
> Hello,
>
>>> Perhaps it makes sense to make this a dev_dbg() over dev_info(), especially
>>> since it appears that this information is of more use to the developer (who
>>> most likely has the suitable log level set anyway), and given that there is
>>> no way to reliably detect a presence in a slot on some platforms, this
>>> might otherwise, add to the other messages that normal users don't pay
>>> attention to usually - if this is not to be treated as an error.
>>>
>>
>> No, this is clearly not a debug message. As I quoted above, the link up
>> can fail due to an issue with PHY also. In that case, user has to see
>> the log to debug/report the issue.
>
> Apologies! I missed that. Thank you!
>
>> So, either dev_info() or dev_err().
>
> So, there is nothing to do here, then. This stays as dev_err() as per the
> change from:
>
> 14c4ad125cf9 ("PCI: dwc: Log link speed and width if it comes up")
I am not sure I agree. There is a similar change here ...
commit 4b16a8227907118e011fb396022da671a52b2272
Author: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Date: Tue Jun 18 23:32:06 2019 +0530
PCI: tegra: Change link retry log level to debug
If we have a way to determine if a card/device is connected then dev_err
is appropriate, but if not then dev_dbg/info are appropriate IMO.
Jon
--
nvpublic
next prev parent reply other threads:[~2022-09-14 15:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 10:12 [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging Vidya Sagar
2022-09-13 16:51 ` Manivannan Sadhasivam
2022-09-13 17:00 ` Jon Hunter
2022-09-13 20:07 ` Bjorn Helgaas
2022-09-14 6:24 ` Manivannan Sadhasivam
2022-09-14 11:02 ` Vidya Sagar
2022-09-14 11:18 ` Manivannan Sadhasivam
2022-09-14 11:25 ` Jon Hunter
2022-09-14 11:43 ` Manivannan Sadhasivam
2022-09-14 11:52 ` Jon Hunter
2022-09-14 12:44 ` Krzysztof Wilczyński
2022-09-14 13:45 ` Manivannan Sadhasivam
2022-09-14 14:52 ` Krzysztof Wilczyński
2022-09-14 15:11 ` Jon Hunter [this message]
2022-09-15 14:16 ` Rob Herring
2022-09-15 14:52 ` Manivannan Sadhasivam
2022-09-26 10:29 ` Vidya Sagar
2022-10-03 11:25 ` Vidya Sagar
2022-10-04 12:53 ` Rob Herring
2022-10-10 6:02 ` Vidya Sagar
2022-10-26 18:06 ` Rob Herring
2022-10-27 9:39 ` Lorenzo Pieralisi
2022-10-27 11:03 ` Manivannan Sadhasivam
2022-09-14 6:12 ` Manivannan Sadhasivam
2022-09-15 10:44 ` Manivannan Sadhasivam
2022-10-18 6:21 ` Jon Hunter
2022-10-18 16:43 ` Bjorn Helgaas
2022-10-26 11:39 ` Jon Hunter
2022-10-26 12:33 ` Lorenzo Pieralisi
2022-10-27 9:55 ` Ben Dooks
2022-10-27 11:05 ` Manivannan Sadhasivam
2022-11-10 15:40 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55fb64f0-7fe7-7938-9852-0ce389050f09@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=helgaas@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=kthota@nvidia.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mmaddireddy@nvidia.com \
--cc=robh@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=treding@nvidia.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.