From: Jon Hunter <jonathanh@nvidia.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Vidya Sagar <vidyas@nvidia.com>
Cc: jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
lpieralisi@kernel.org, robh@kernel.org, kw@linux.com,
bhelgaas@google.com, treding@nvidia.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com
Subject: Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging
Date: Tue, 13 Sep 2022 18:00:30 +0100 [thread overview]
Message-ID: <b1c243b0-2e6e-3254-eff0-a5276020a320@nvidia.com> (raw)
In-Reply-To: <20220913165159.GH25849@workstation>
On 13/09/2022 17:51, Manivannan Sadhasivam wrote:
> On Tue, Sep 13, 2022 at 03:42:37PM +0530, Vidya Sagar wrote:
>> Some of the platforms (like Tegra194 and Tegra234) have open slots and
>> not having an endpoint connected to the slot is not an error.
>> So, changing the macro from dev_err to dev_info to log the event.
>>
>
> But the link up not happening is an actual error and -ETIMEDOUT is being
> returned. So I don't think the log severity should be changed.
Yes it is an error in the sense it is a timeout, but reporting an error
because nothing is attached to a PCI slot seems a bit noisy. Please note
that a similar change was made by the following commit and it also seems
appropriate here ...
commit 4b16a8227907118e011fb396022da671a52b2272
Author: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Date: Tue Jun 18 23:32:06 2019 +0530
PCI: tegra: Change link retry log level to debug
BTW, we check for error messages in the dmesg output and this is a new
error seen as of Linux v6.0 and so this was flagged in a test. We can
ignore the error, but in this case it seem more appropriate to make this
a info or debug level print.
Jon
--
nvpublic
next prev parent reply other threads:[~2022-09-13 17:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 10:12 [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging Vidya Sagar
2022-09-13 16:51 ` Manivannan Sadhasivam
2022-09-13 17:00 ` Jon Hunter [this message]
2022-09-13 20:07 ` Bjorn Helgaas
2022-09-14 6:24 ` Manivannan Sadhasivam
2022-09-14 11:02 ` Vidya Sagar
2022-09-14 11:18 ` Manivannan Sadhasivam
2022-09-14 11:25 ` Jon Hunter
2022-09-14 11:43 ` Manivannan Sadhasivam
2022-09-14 11:52 ` Jon Hunter
2022-09-14 12:44 ` Krzysztof Wilczyński
2022-09-14 13:45 ` Manivannan Sadhasivam
2022-09-14 14:52 ` Krzysztof Wilczyński
2022-09-14 15:11 ` Jon Hunter
2022-09-15 14:16 ` Rob Herring
2022-09-15 14:52 ` Manivannan Sadhasivam
2022-09-26 10:29 ` Vidya Sagar
2022-10-03 11:25 ` Vidya Sagar
2022-10-04 12:53 ` Rob Herring
2022-10-10 6:02 ` Vidya Sagar
2022-10-26 18:06 ` Rob Herring
2022-10-27 9:39 ` Lorenzo Pieralisi
2022-10-27 11:03 ` Manivannan Sadhasivam
2022-09-14 6:12 ` Manivannan Sadhasivam
2022-09-15 10:44 ` Manivannan Sadhasivam
2022-10-18 6:21 ` Jon Hunter
2022-10-18 16:43 ` Bjorn Helgaas
2022-10-26 11:39 ` Jon Hunter
2022-10-26 12:33 ` Lorenzo Pieralisi
2022-10-27 9:55 ` Ben Dooks
2022-10-27 11:05 ` Manivannan Sadhasivam
2022-11-10 15:40 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1c243b0-2e6e-3254-eff0-a5276020a320@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kthota@nvidia.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mmaddireddy@nvidia.com \
--cc=robh@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=treding@nvidia.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.