From: Mark Kettenis <mark.kettenis@xs4all.nl> To: Marc Zyngier <maz@kernel.org> Cc: devicetree@vger.kernel.org, alyssa@rosenzweig.io, kettenis@openbsd.org, tglx@linutronix.de, robh+dt@kernel.org, marcan@marcan.st, bhelgaas@google.com, nsaenz@kernel.org, jim2101024@gmail.com, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, daire.mcnamara@microchip.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH v4 4/4] arm64: apple: Add PCIe node Date: Mon, 13 Sep 2021 20:35:23 +0200 (CEST) [thread overview] Message-ID: <5614581066cc67fa@bloch.sibelius.xs4all.nl> (raw) In-Reply-To: <871r5tcwhp.wl-maz@kernel.org> (message from Marc Zyngier on Sun, 12 Sep 2021 22:30:42 +0100) > Date: Sun, 12 Sep 2021 22:30:42 +0100 > From: Marc Zyngier <maz@kernel.org> Hi Marc, > On Fri, 27 Aug 2021 18:15:29 +0100, > Mark Kettenis <mark.kettenis@xs4all.nl> wrote: > > > > From: Mark Kettenis <kettenis@openbsd.org> > > > > Add node corresponding to the apcie,t8103 node in the > > Apple device tree for the Mac mini (M1, 2020). > > > > Clock references and DART (IOMMU) references are left out at the > > moment and will be added once the appropriate bindings have been > > settled upon. > > > > Signed-off-by: Mark Kettenis <kettenis@openbsd.org> > > --- > > arch/arm64/boot/dts/apple/t8103.dtsi | 63 ++++++++++++++++++++++++++++ > > 1 file changed, 63 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi > > index 503a76fc30e6..6e4677bdef44 100644 > > --- a/arch/arm64/boot/dts/apple/t8103.dtsi > > +++ b/arch/arm64/boot/dts/apple/t8103.dtsi > > @@ -214,5 +214,68 @@ pinctrl_smc: pinctrl@23e820000 { > > <AIC_IRQ 396 IRQ_TYPE_LEVEL_HIGH>, > > <AIC_IRQ 397 IRQ_TYPE_LEVEL_HIGH>; > > }; > > + > > + pcie0: pcie@690000000 { > > + compatible = "apple,t8103-pcie", "apple,pcie"; > > + device_type = "pci"; > > + > > + reg = <0x6 0x90000000 0x0 0x1000000>, > > + <0x6 0x80000000 0x0 0x4000>, > > Only exposing 16kB for the 'rc' crashes the Linux driver as it tries > to configure the port ref-clock configurations, which live much > higher: > > #define CORE_LANE_CFG(port) (0x84000 + 0x4000 * (port)) > > Previous versions of the binding had this region as 1MB, which made > things work. Oops. When I formalized the binding, I looked at the Apple DT and used the sizes from there. And didn't notice that this wasn't sufficient since U-Boot doesn't actually use the size of the region to create a mapping like an actual OS would do. It is somewhat unclear how big the regions really are, but as marcan noted at some point in the past the sizes in the Apple DT seem to be somewhat inconsistent so religiously following what is done there may not make sense. So I'll fix this in v5 (also in the example in the DT binding). Corellium uses 1MB, which makes more sense unless we break up the block into multiple ranges. > > + <0x6 0x81000000 0x0 0x8000>, > > + <0x6 0x82000000 0x0 0x8000>, > > + <0x6 0x83000000 0x0 0x8000>; > > These used to be 16kB, and are now twice as much. Didn't cause any > issue with the Linux driver, but I wonder what trigger either change. 0x8000 is what the Apple DT uses. Since we don't have authorative documentation for the chip we have to make some guesses here. I suspect we should try to keep the sizes as small as possible while sticking to sizes of 2^n? Then it probably makes sense to use 0x4000 for these ranges. Cheers, Mark
WARNING: multiple messages have this Message-ID (diff)
From: Mark Kettenis <mark.kettenis@xs4all.nl> To: Marc Zyngier <maz@kernel.org> Cc: devicetree@vger.kernel.org, alyssa@rosenzweig.io, kettenis@openbsd.org, tglx@linutronix.de, robh+dt@kernel.org, marcan@marcan.st, bhelgaas@google.com, nsaenz@kernel.org, jim2101024@gmail.com, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, daire.mcnamara@microchip.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH v4 4/4] arm64: apple: Add PCIe node Date: Mon, 13 Sep 2021 20:35:23 +0200 (CEST) [thread overview] Message-ID: <5614581066cc67fa@bloch.sibelius.xs4all.nl> (raw) In-Reply-To: <871r5tcwhp.wl-maz@kernel.org> (message from Marc Zyngier on Sun, 12 Sep 2021 22:30:42 +0100) > Date: Sun, 12 Sep 2021 22:30:42 +0100 > From: Marc Zyngier <maz@kernel.org> Hi Marc, > On Fri, 27 Aug 2021 18:15:29 +0100, > Mark Kettenis <mark.kettenis@xs4all.nl> wrote: > > > > From: Mark Kettenis <kettenis@openbsd.org> > > > > Add node corresponding to the apcie,t8103 node in the > > Apple device tree for the Mac mini (M1, 2020). > > > > Clock references and DART (IOMMU) references are left out at the > > moment and will be added once the appropriate bindings have been > > settled upon. > > > > Signed-off-by: Mark Kettenis <kettenis@openbsd.org> > > --- > > arch/arm64/boot/dts/apple/t8103.dtsi | 63 ++++++++++++++++++++++++++++ > > 1 file changed, 63 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi > > index 503a76fc30e6..6e4677bdef44 100644 > > --- a/arch/arm64/boot/dts/apple/t8103.dtsi > > +++ b/arch/arm64/boot/dts/apple/t8103.dtsi > > @@ -214,5 +214,68 @@ pinctrl_smc: pinctrl@23e820000 { > > <AIC_IRQ 396 IRQ_TYPE_LEVEL_HIGH>, > > <AIC_IRQ 397 IRQ_TYPE_LEVEL_HIGH>; > > }; > > + > > + pcie0: pcie@690000000 { > > + compatible = "apple,t8103-pcie", "apple,pcie"; > > + device_type = "pci"; > > + > > + reg = <0x6 0x90000000 0x0 0x1000000>, > > + <0x6 0x80000000 0x0 0x4000>, > > Only exposing 16kB for the 'rc' crashes the Linux driver as it tries > to configure the port ref-clock configurations, which live much > higher: > > #define CORE_LANE_CFG(port) (0x84000 + 0x4000 * (port)) > > Previous versions of the binding had this region as 1MB, which made > things work. Oops. When I formalized the binding, I looked at the Apple DT and used the sizes from there. And didn't notice that this wasn't sufficient since U-Boot doesn't actually use the size of the region to create a mapping like an actual OS would do. It is somewhat unclear how big the regions really are, but as marcan noted at some point in the past the sizes in the Apple DT seem to be somewhat inconsistent so religiously following what is done there may not make sense. So I'll fix this in v5 (also in the example in the DT binding). Corellium uses 1MB, which makes more sense unless we break up the block into multiple ranges. > > + <0x6 0x81000000 0x0 0x8000>, > > + <0x6 0x82000000 0x0 0x8000>, > > + <0x6 0x83000000 0x0 0x8000>; > > These used to be 16kB, and are now twice as much. Didn't cause any > issue with the Linux driver, but I wonder what trigger either change. 0x8000 is what the Apple DT uses. Since we don't have authorative documentation for the chip we have to make some guesses here. I suspect we should try to keep the sizes as small as possible while sticking to sizes of 2^n? Then it probably makes sense to use 0x4000 for these ranges. Cheers, Mark _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-13 18:35 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-27 17:15 [PATCH v4 0/4] Apple M1 PCIe DT bindings Mark Kettenis 2021-08-27 17:15 ` Mark Kettenis 2021-08-27 17:15 ` [PATCH v4 1/4] dt-bindings: interrupt-controller: Convert MSI controller to json-schema Mark Kettenis 2021-08-27 17:15 ` Mark Kettenis 2021-08-27 19:15 ` Mark Kettenis 2021-08-27 19:15 ` Mark Kettenis 2021-08-31 21:04 ` Rob Herring 2021-08-31 21:04 ` Rob Herring 2021-08-31 20:57 ` Rob Herring 2021-08-31 20:57 ` Rob Herring 2021-09-01 10:56 ` Mark Kettenis 2021-09-01 10:56 ` Mark Kettenis 2021-08-31 20:58 ` Rob Herring 2021-08-31 20:58 ` Rob Herring 2021-08-27 17:15 ` [PATCH v4 2/4] dt-bindings: interrupt-controller: msi: Add msi-ranges property Mark Kettenis 2021-08-27 17:15 ` Mark Kettenis 2021-08-31 21:16 ` Rob Herring 2021-08-31 21:16 ` Rob Herring 2021-09-21 17:52 ` Mark Kettenis 2021-09-21 17:52 ` Mark Kettenis 2021-08-27 17:15 ` [PATCH v4 3/4] dt-bindings: pci: Add DT bindings for apple,pcie Mark Kettenis 2021-08-27 17:15 ` Mark Kettenis 2021-08-27 17:58 ` Alyssa Rosenzweig 2021-08-27 17:58 ` Alyssa Rosenzweig 2021-08-27 18:22 ` Mark Kettenis 2021-08-27 18:22 ` Mark Kettenis 2021-08-31 21:21 ` Rob Herring 2021-08-31 21:21 ` Rob Herring 2021-09-01 11:29 ` Mark Kettenis 2021-09-01 11:29 ` Mark Kettenis 2021-09-12 20:13 ` Marc Zyngier 2021-09-12 20:13 ` Marc Zyngier 2021-09-13 20:55 ` Rob Herring 2021-09-13 20:55 ` Rob Herring 2021-08-27 17:15 ` [PATCH v4 4/4] arm64: apple: Add PCIe node Mark Kettenis 2021-08-27 17:15 ` Mark Kettenis 2021-08-27 17:59 ` Alyssa Rosenzweig 2021-08-27 17:59 ` Alyssa Rosenzweig 2021-08-27 18:24 ` Mark Kettenis 2021-08-27 18:24 ` Mark Kettenis 2021-08-27 20:09 ` Alyssa Rosenzweig 2021-08-27 20:09 ` Alyssa Rosenzweig 2021-08-30 11:37 ` Marc Zyngier 2021-08-30 11:37 ` Marc Zyngier 2021-08-30 14:57 ` Mark Kettenis 2021-08-30 14:57 ` Mark Kettenis 2021-08-30 20:40 ` Marc Zyngier 2021-08-30 20:40 ` Marc Zyngier 2021-08-30 15:57 ` Rob Herring 2021-08-30 15:57 ` Rob Herring 2021-08-30 20:20 ` Marc Zyngier 2021-08-30 20:20 ` Marc Zyngier 2021-09-12 21:30 ` Marc Zyngier 2021-09-12 21:30 ` Marc Zyngier 2021-09-13 18:35 ` Mark Kettenis [this message] 2021-09-13 18:35 ` Mark Kettenis 2021-09-21 11:01 ` [PATCH v4 0/4] Apple M1 PCIe DT bindings Marc Zyngier 2021-09-21 11:01 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5614581066cc67fa@bloch.sibelius.xs4all.nl \ --to=mark.kettenis@xs4all.nl \ --cc=alyssa@rosenzweig.io \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=bhelgaas@google.com \ --cc=daire.mcnamara@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=jim2101024@gmail.com \ --cc=kettenis@openbsd.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=marcan@marcan.st \ --cc=maz@kernel.org \ --cc=nsaenz@kernel.org \ --cc=robh+dt@kernel.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.