* [PATCH linux dev-4.10] spi-nor: aspeed-smc: Fix flash window size message
@ 2017-05-04 2:34 Joel Stanley
2017-05-04 6:01 ` Cédric Le Goater
2017-05-04 11:52 ` Andrew Jeffery
0 siblings, 2 replies; 5+ messages in thread
From: Joel Stanley @ 2017-05-04 2:34 UTC (permalink / raw)
To: openbmc, Cédric Le Goater
When booting we see something like this:
aspeed-smc 1e620000.flash-controller: Using IRQ 17
aspeed-smc 1e620000.flash-controller: DMA support disabled.
aspeed-smc 1e620000.flash-controller: mx25l25635e (32768 Kbytes)
aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000- 0x22000000 ] 32MB
aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000- 0x2a000000 ] 128MB
The lack of space after the first hex number haunts me every time I
boot a BMC.
With this fix we see the pleasingly symmetrical:
aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000 - 0x22000000 ] 32MB
aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000 - 0x2a000000 ] 128MB
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
drivers/mtd/spi-nor/aspeed-smc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
index 875b029198fc..23622bf62b6b 100644
--- a/drivers/mtd/spi-nor/aspeed-smc.c
+++ b/drivers/mtd/spi-nor/aspeed-smc.c
@@ -709,7 +709,7 @@ static u32 chip_set_segment(struct aspeed_smc_chip *chip, u32 cs, u32 start,
size = end - start;
}
- dev_info(chip->nor.dev, "CE%d window [ 0x%.8x- 0x%.8x ] %dMB",
+ dev_info(chip->nor.dev, "CE%d window [ 0x%.8x - 0x%.8x ] %dMB",
cs, start, end, size >> 20);
return size;
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH linux dev-4.10] spi-nor: aspeed-smc: Fix flash window size message
2017-05-04 2:34 [PATCH linux dev-4.10] spi-nor: aspeed-smc: Fix flash window size message Joel Stanley
@ 2017-05-04 6:01 ` Cédric Le Goater
2017-05-04 11:52 ` Andrew Jeffery
1 sibling, 0 replies; 5+ messages in thread
From: Cédric Le Goater @ 2017-05-04 6:01 UTC (permalink / raw)
To: Joel Stanley, openbmc
On 05/04/2017 04:34 AM, Joel Stanley wrote:
> When booting we see something like this:
>
> aspeed-smc 1e620000.flash-controller: Using IRQ 17
> aspeed-smc 1e620000.flash-controller: DMA support disabled.
> aspeed-smc 1e620000.flash-controller: mx25l25635e (32768 Kbytes)
> aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000- 0x22000000 ] 32MB
> aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000- 0x2a000000 ] 128MB
>
> The lack of space after the first hex number haunts me every time I
> boot a BMC.
>
> With this fix we see the pleasingly symmetrical:
>
> aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000 - 0x22000000 ] 32MB
> aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000 - 0x2a000000 ] 128MB
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Acked-by: Cédric Le Goater <clg@kaod.org>
yes. I have changed that also in the patches sent to mainline,
plus a couple of other things. I will send a refreshing patch
when they are merged.
Cheers,
C.
> ---
> drivers/mtd/spi-nor/aspeed-smc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
> index 875b029198fc..23622bf62b6b 100644
> --- a/drivers/mtd/spi-nor/aspeed-smc.c
> +++ b/drivers/mtd/spi-nor/aspeed-smc.c
> @@ -709,7 +709,7 @@ static u32 chip_set_segment(struct aspeed_smc_chip *chip, u32 cs, u32 start,
> size = end - start;
> }
>
> - dev_info(chip->nor.dev, "CE%d window [ 0x%.8x- 0x%.8x ] %dMB",
> + dev_info(chip->nor.dev, "CE%d window [ 0x%.8x - 0x%.8x ] %dMB",
> cs, start, end, size >> 20);
>
> return size;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH linux dev-4.10] spi-nor: aspeed-smc: Fix flash window size message
2017-05-04 2:34 [PATCH linux dev-4.10] spi-nor: aspeed-smc: Fix flash window size message Joel Stanley
2017-05-04 6:01 ` Cédric Le Goater
@ 2017-05-04 11:52 ` Andrew Jeffery
2017-05-04 12:13 ` Cédric Le Goater
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Jeffery @ 2017-05-04 11:52 UTC (permalink / raw)
To: Joel Stanley, openbmc, Cédric Le Goater
[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]
On Thu, 2017-05-04 at 12:04 +0930, Joel Stanley wrote:
> When booting we see something like this:
>
> aspeed-smc 1e620000.flash-controller: Using IRQ 17
> aspeed-smc 1e620000.flash-controller: DMA support disabled.
> aspeed-smc 1e620000.flash-controller: mx25l25635e (32768 Kbytes)
> aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000- 0x22000000 ] 32MB
> aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000- 0x2a000000 ] 128MB
>
> The lack of space after the first hex number haunts me every time I
> boot a BMC.
>
> With this fix we see the pleasingly symmetrical:
>
> aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000 - 0x22000000 ] 32MB
> aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000 - 0x2a000000 ] 128MB
>
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/mtd/spi-nor/aspeed-smc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
> index 875b029198fc..23622bf62b6b 100644
> --- a/drivers/mtd/spi-nor/aspeed-smc.c
> +++ b/drivers/mtd/spi-nor/aspeed-smc.c
> @@ -709,7 +709,7 @@ static u32 chip_set_segment(struct aspeed_smc_chip *chip, u32 cs, u32 start,
> > size = end - start;
> > }
>
> > - dev_info(chip->nor.dev, "CE%d window [ 0x%.8x- 0x%.8x ] %dMB",
> > + dev_info(chip->nor.dev, "CE%d window [ 0x%.8x - 0x%.8x ] %dMB",
> cs, start, end, size >> 20);
NAK! I want *no* spaces!
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
>
> > return size;
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH linux dev-4.10] spi-nor: aspeed-smc: Fix flash window size message
2017-05-04 11:52 ` Andrew Jeffery
@ 2017-05-04 12:13 ` Cédric Le Goater
2017-05-04 12:59 ` Andrew Jeffery
0 siblings, 1 reply; 5+ messages in thread
From: Cédric Le Goater @ 2017-05-04 12:13 UTC (permalink / raw)
To: Andrew Jeffery, Joel Stanley, openbmc
On 05/04/2017 01:52 PM, Andrew Jeffery wrote:
> On Thu, 2017-05-04 at 12:04 +0930, Joel Stanley wrote:
>> When booting we see something like this:
>>
>> aspeed-smc 1e620000.flash-controller: Using IRQ 17
>> aspeed-smc 1e620000.flash-controller: DMA support disabled.
>> aspeed-smc 1e620000.flash-controller: mx25l25635e (32768 Kbytes)
>> aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000- 0x22000000 ] 32MB
>> aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000- 0x2a000000 ] 128MB
>>
>> The lack of space after the first hex number haunts me every time I
>> boot a BMC.
>>
>> With this fix we see the pleasingly symmetrical:
>>
>> aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000 - 0x22000000 ] 32MB
>> aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000 - 0x2a000000 ] 128MB
>>
>>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>> ---
>> drivers/mtd/spi-nor/aspeed-smc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
>> index 875b029198fc..23622bf62b6b 100644
>> --- a/drivers/mtd/spi-nor/aspeed-smc.c
>> +++ b/drivers/mtd/spi-nor/aspeed-smc.c
>> @@ -709,7 +709,7 @@ static u32 chip_set_segment(struct aspeed_smc_chip *chip, u32 cs, u32 start,
>>> size = end - start;
>>> }
>>
>>> - dev_info(chip->nor.dev, "CE%d window [ 0x%.8x- 0x%.8x ] %dMB",
>>> + dev_info(chip->nor.dev, "CE%d window [ 0x%.8x - 0x%.8x ] %dMB",
>> cs, start, end, size >> 20);
>
> NAK! I want *no* spaces!
>
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
ah ! as you wish, I have no strong feeling on the format :)
Cheers,
C.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH linux dev-4.10] spi-nor: aspeed-smc: Fix flash window size message
2017-05-04 12:13 ` Cédric Le Goater
@ 2017-05-04 12:59 ` Andrew Jeffery
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Jeffery @ 2017-05-04 12:59 UTC (permalink / raw)
To: Cédric Le Goater, Joel Stanley, openbmc
[-- Attachment #1: Type: text/plain, Size: 2035 bytes --]
On Thu, 2017-05-04 at 14:13 +0200, Cédric Le Goater wrote:
> On 05/04/2017 01:52 PM, Andrew Jeffery wrote:
> > On Thu, 2017-05-04 at 12:04 +0930, Joel Stanley wrote:
> > > When booting we see something like this:
> > >
> > > aspeed-smc 1e620000.flash-controller: Using IRQ 17
> > > aspeed-smc 1e620000.flash-controller: DMA support disabled.
> > > aspeed-smc 1e620000.flash-controller: mx25l25635e (32768 Kbytes)
> > > aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000- 0x22000000 ] 32MB
> > > aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000- 0x2a000000 ] 128MB
> > >
> > > The lack of space after the first hex number haunts me every time I
> > > boot a BMC.
> > >
> > > With this fix we see the pleasingly symmetrical:
> > >
> > > aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000 - 0x22000000 ] 32MB
> > > aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000 - 0x2a000000 ] 128MB
> > >
> > > > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > >
> > > ---
> > > drivers/mtd/spi-nor/aspeed-smc.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
> > > index 875b029198fc..23622bf62b6b 100644
> > > --- a/drivers/mtd/spi-nor/aspeed-smc.c
> > > +++ b/drivers/mtd/spi-nor/aspeed-smc.c
> > > @@ -709,7 +709,7 @@ static u32 chip_set_segment(struct aspeed_smc_chip *chip, u32 cs, u32 start,
> > > > > > > > size = end - start;
> > > > }
> > >
> > >
> > > > > > > > - dev_info(chip->nor.dev, "CE%d window [ 0x%.8x- 0x%.8x ] %dMB",
> > > > + dev_info(chip->nor.dev, "CE%d window [ 0x%.8x - 0x%.8x ] %dMB",
> > >
> > > cs, start, end, size >> 20);
> >
> > NAK! I want *no* spaces!
> >
> > Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
>
> ah ! as you wish, I have no strong feeling on the format :)
Sorry, that was a stupid bikeshed joke. I'm happy that someone's done
anything with it :)
Andrew
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-04 12:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-04 2:34 [PATCH linux dev-4.10] spi-nor: aspeed-smc: Fix flash window size message Joel Stanley
2017-05-04 6:01 ` Cédric Le Goater
2017-05-04 11:52 ` Andrew Jeffery
2017-05-04 12:13 ` Cédric Le Goater
2017-05-04 12:59 ` Andrew Jeffery
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.