* [U-Boot] [PATCH] usb:ci_udc: Remove ULPI setting for i.MX OTG controller
@ 2015-11-05 3:17 Ye.Li
2015-11-05 5:10 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Ye.Li @ 2015-11-05 3:17 UTC (permalink / raw)
To: u-boot
All the i.MX6, i.MX23 and i.MX28 OTG controllers only support UTMI interface.
Set to ULPI is not correct, even the controller will reject this
setting in PORTSC register.
Signed-off-by: Ye.Li <B37916@freescale.com>
---
drivers/usb/gadget/ci_udc.c | 12 ------------
1 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c
index 1ba5054..cb35982 100644
--- a/drivers/usb/gadget/ci_udc.c
+++ b/drivers/usb/gadget/ci_udc.c
@@ -1018,18 +1018,6 @@ int usb_gadget_register_driver(struct usb_gadget_driver *driver)
return ret;
ret = ci_udc_probe();
-#if defined(CONFIG_USB_EHCI_MX6) || defined(CONFIG_USB_EHCI_MXS)
- /*
- * FIXME: usb_lowlevel_init()->ehci_hcd_init() should be doing all
- * HW-specific initialization, e.g. ULPI-vs-UTMI PHY selection
- */
- if (!ret) {
- struct ci_udc *udc = (struct ci_udc *)controller.ctrl->hcor;
-
- /* select ULPI phy */
- writel(PTS(PTS_ENABLE) | PFSC, &udc->portsc);
- }
-#endif
ret = driver->bind(&controller.gadget);
if (ret) {
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] usb:ci_udc: Remove ULPI setting for i.MX OTG controller
2015-11-05 3:17 [U-Boot] [PATCH] usb:ci_udc: Remove ULPI setting for i.MX OTG controller Ye.Li
@ 2015-11-05 5:10 ` Marek Vasut
2015-11-09 7:58 ` Li Ye-B37916
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2015-11-05 5:10 UTC (permalink / raw)
To: u-boot
On Thursday, November 05, 2015 at 04:17:38 AM, Ye.Li wrote:
> All the i.MX6, i.MX23 and i.MX28 OTG controllers only support UTMI
> interface. Set to ULPI is not correct, even the controller will reject
> this
> setting in PORTSC register.
>
> Signed-off-by: Ye.Li <B37916@freescale.com>
> ---
> drivers/usb/gadget/ci_udc.c | 12 ------------
> 1 files changed, 0 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c
> index 1ba5054..cb35982 100644
> --- a/drivers/usb/gadget/ci_udc.c
> +++ b/drivers/usb/gadget/ci_udc.c
> @@ -1018,18 +1018,6 @@ int usb_gadget_register_driver(struct
> usb_gadget_driver *driver) return ret;
>
> ret = ci_udc_probe();
You're now dropping the error handling for this function, that's really not
good, so I cannot accept the patch. But the current error handling looks
totally broken. So the solution I would propose here is to fix the error
handling for ci_udc_probe() here instead of outright removing the code. What
do you think ?
> -#if defined(CONFIG_USB_EHCI_MX6) || defined(CONFIG_USB_EHCI_MXS)
> - /*
> - * FIXME: usb_lowlevel_init()->ehci_hcd_init() should be doing all
> - * HW-specific initialization, e.g. ULPI-vs-UTMI PHY selection
> - */
> - if (!ret) {
> - struct ci_udc *udc = (struct ci_udc *)controller.ctrl->hcor;
> -
> - /* select ULPI phy */
> - writel(PTS(PTS_ENABLE) | PFSC, &udc->portsc);
> - }
> -#endif
>
> ret = driver->bind(&controller.gadget);
> if (ret) {
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] usb:ci_udc: Remove ULPI setting for i.MX OTG controller
2015-11-05 5:10 ` Marek Vasut
@ 2015-11-09 7:58 ` Li Ye-B37916
0 siblings, 0 replies; 3+ messages in thread
From: Li Ye-B37916 @ 2015-11-09 7:58 UTC (permalink / raw)
To: u-boot
On 11/5/2015 1:10 PM, Marek Vasut wrote:
> On Thursday, November 05, 2015 at 04:17:38 AM, Ye.Li wrote:
>> All the i.MX6, i.MX23 and i.MX28 OTG controllers only support UTMI
>> interface. Set to ULPI is not correct, even the controller will reject
>> this
>> setting in PORTSC register.
>>
>> Signed-off-by: Ye.Li <B37916@freescale.com>
>> ---
>> drivers/usb/gadget/ci_udc.c | 12 ------------
>> 1 files changed, 0 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c
>> index 1ba5054..cb35982 100644
>> --- a/drivers/usb/gadget/ci_udc.c
>> +++ b/drivers/usb/gadget/ci_udc.c
>> @@ -1018,18 +1018,6 @@ int usb_gadget_register_driver(struct
>> usb_gadget_driver *driver) return ret;
>>
>> ret = ci_udc_probe();
> You're now dropping the error handling for this function, that's really not
> good, so I cannot accept the patch. But the current error handling looks
> totally broken. So the solution I would propose here is to fix the error
> handling for ci_udc_probe() here instead of outright removing the code. What
> do you think ?
I will add a error handling in v2 patch. Thanks.
>
>> -#if defined(CONFIG_USB_EHCI_MX6) || defined(CONFIG_USB_EHCI_MXS)
>> - /*
>> - * FIXME: usb_lowlevel_init()->ehci_hcd_init() should be doing all
>> - * HW-specific initialization, e.g. ULPI-vs-UTMI PHY selection
>> - */
>> - if (!ret) {
>> - struct ci_udc *udc = (struct ci_udc *)controller.ctrl->hcor;
>> -
>> - /* select ULPI phy */
>> - writel(PTS(PTS_ENABLE) | PFSC, &udc->portsc);
>> - }
>> -#endif
>>
>> ret = driver->bind(&controller.gadget);
>> if (ret) {
> Best regards,
> Marek Vasut
Best regards,
Ye Li
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-09 7:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-05 3:17 [U-Boot] [PATCH] usb:ci_udc: Remove ULPI setting for i.MX OTG controller Ye.Li
2015-11-05 5:10 ` Marek Vasut
2015-11-09 7:58 ` Li Ye-B37916
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.