All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
	Simon Horman <horms@verge.net.au>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH v2 01/10] i2c: rcar: make sure clocks are on when doing clock calculation
Date: Thu, 12 Nov 2015 19:16:48 +0000	[thread overview]
Message-ID: <5644E5A0.9040504@cogentembedded.com> (raw)
In-Reply-To: <1447338715-9955-2-git-send-email-wsa@the-dreams.de>

Hello.

On 11/12/2015 05:31 PM, Wolfram Sang wrote:

> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> When calculating the bus speed, the clock should be on, of course. Most
> bootloaders left them on, so this went unnoticed so far.

    s/them/it/.

> Move the ioremapping out of this clock-enabled-block and prepare for
> adding hw initialization there, too.
>
> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

[...]

MBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
	Simon Horman <horms@verge.net.au>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH v2 01/10] i2c: rcar: make sure clocks are on when doing clock calculation
Date: Thu, 12 Nov 2015 22:16:48 +0300	[thread overview]
Message-ID: <5644E5A0.9040504@cogentembedded.com> (raw)
In-Reply-To: <1447338715-9955-2-git-send-email-wsa@the-dreams.de>

Hello.

On 11/12/2015 05:31 PM, Wolfram Sang wrote:

> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> When calculating the bus speed, the clock should be on, of course. Most
> bootloaders left them on, so this went unnoticed so far.

    s/them/it/.

> Move the ioremapping out of this clock-enabled-block and prepare for
> adding hw initialization there, too.
>
> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

[...]

MBR, Sergei


  reply	other threads:[~2015-11-12 19:16 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-12 14:31 [PATCH v2 00/10] i2c: rcar: tackle race conditions in the driver Wolfram Sang
2015-11-12 14:31 ` Wolfram Sang
2015-11-12 14:31 ` [PATCH v2 01/10] i2c: rcar: make sure clocks are on when doing clock calculation Wolfram Sang
2015-11-12 14:31   ` Wolfram Sang
2015-11-12 19:16   ` Sergei Shtylyov [this message]
2015-11-12 19:16     ` Sergei Shtylyov
2015-11-12 14:31 ` [PATCH v2 02/10] i2c: rcar: rework hw init Wolfram Sang
2015-11-12 14:31   ` Wolfram Sang
2015-11-12 14:31 ` [PATCH v2 03/10] i2c: rcar: remove unused IOERROR state Wolfram Sang
2015-11-12 14:31   ` Wolfram Sang
2015-11-12 14:31 ` [PATCH v2 04/10] i2c: rcar: remove spinlock Wolfram Sang
2015-11-12 14:31   ` Wolfram Sang
2015-11-12 15:04   ` Sergei Shtylyov
2015-11-12 15:04     ` Sergei Shtylyov
2015-11-12 15:52     ` Wolfram Sang
2015-11-12 15:52       ` Wolfram Sang
2015-11-12 14:31 ` [PATCH v2 05/10] i2c: rcar: refactor setup of a msg Wolfram Sang
2015-11-12 14:31   ` Wolfram Sang
2015-11-16 21:02   ` Laurent Pinchart
2015-11-16 21:02     ` Laurent Pinchart
2015-11-17  7:00     ` Wolfram Sang
2015-11-17  7:00       ` Wolfram Sang
2015-11-17  7:38       ` Laurent Pinchart
2015-11-17  7:38         ` Laurent Pinchart
2015-11-18  7:31         ` Wolfram Sang
2015-11-18  7:31           ` Wolfram Sang
2015-11-18  2:18       ` Magnus Damm
2015-11-18  2:18         ` Magnus Damm
2015-11-18  6:45         ` Laurent Pinchart
2015-11-18  6:45           ` Laurent Pinchart
2015-11-18  8:07         ` Wolfram Sang
2015-11-18  8:07           ` Wolfram Sang
2015-11-18  8:17           ` Magnus Damm
2015-11-18  8:17             ` Magnus Damm
2015-11-12 14:31 ` [PATCH v2 06/10] i2c: rcar: init new messages in irq Wolfram Sang
2015-11-12 14:31   ` Wolfram Sang
2015-11-13  2:12 ` [PATCH v2 00/10] i2c: rcar: tackle race conditions in the driver Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5644E5A0.9040504@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=kuninori.morimoto.gx@gmail.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=wsa@the-dreams.de \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.