All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: linux-mips@linux-mips.org
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] MIPS: Add arch CDMM definitions and probing
Date: Thu, 29 Jan 2015 00:16:38 +0100	[thread overview]
Message-ID: <5668659.y0L0n9UuOk@radagast> (raw)
In-Reply-To: <alpine.LFD.2.11.1501280253280.28301@eddie.linux-mips.org>

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

Hi Maciej,

On Wednesday 28 January 2015 23:09:17 Maciej W. Rozycki wrote:
> On Tue, 27 Jan 2015, James Hogan wrote:
> 
> > diff --git a/arch/mips/include/asm/cpu.h b/arch/mips/include/asm/cpu.h
> > index 33866fce4d63..2086372fa72a 100644
> > --- a/arch/mips/include/asm/cpu.h
> > +++ b/arch/mips/include/asm/cpu.h
> > @@ -370,6 +370,7 @@ enum cpu_type_enum {
> >  #define MIPS_CPU_RIXIEX		0x200000000ull /* CPU has unique exception codes for {Read, Execute}-Inhibit exceptions */
> >  #define MIPS_CPU_MAAR		0x400000000ull /* MAAR(I) registers are present */
> >  #define MIPS_CPU_FRE		0x800000000ull /* FRE & UFE bits implemented */
> > +#define MIPS_CPU_CDMM		0x10000000000ll /* CPU has Common Device Memory Map */
> 
>  Is it a typo here: 0x10000000000ll vs 0x1000000000ull?

Yes, it would appear so. Well spotted!

Thanks
James

> 
>   Maciej
> 

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-01-29  1:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27 21:16 [PATCH 0/3] Add MIPS CDMM bus support James Hogan
2015-01-27 21:16 ` James Hogan
2015-01-27 21:16 ` [PATCH 1/3] MIPS: Add arch CDMM definitions and probing James Hogan
2015-01-27 21:16   ` James Hogan
2015-01-28 23:09   ` Maciej W. Rozycki
2015-01-28 23:16     ` James Hogan [this message]
2015-01-27 21:16 ` [PATCH 2/3] MIPS: Add CDMM bus support James Hogan
2015-01-27 21:16   ` James Hogan
2015-01-27 21:16 ` [PATCH 3/3] MIPS: Malta: Implement mips_cdmm_phys_base() James Hogan
2015-01-27 21:16   ` James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5668659.y0L0n9UuOk@radagast \
    --to=james.hogan@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.