* patch about "don't reset vcpu_info on a cancelled suspend"
@ 2015-12-29 5:49 Ouyangzhaowei (Charles)
2016-01-04 11:54 ` [Xen-devel] " David Vrabel
2016-01-04 11:54 ` David Vrabel
0 siblings, 2 replies; 6+ messages in thread
From: Ouyangzhaowei (Charles) @ 2015-12-29 5:49 UTC (permalink / raw)
To: david.vrabel
Cc: linux-kernel, xen-devel, Zhaojun (Euler),
jinjian, boris.ostrovsky, konrad.wilk
Hi David,
This patch has been applied to for-linus-4.1b, and we wonder if this patch will be applied to linux kernel, or does
it still needs more test to apply to linux kernel?
thanks
On 2015.5.28 19:07, David Vrabel wrote:
>> vcpu_info would be reset to wrong place on canceled suspend on PVOPS VM which has multi-cpu
>>
>> The hypervisor continues assuming that vcpu_info is stored in per-cpu data which was set up by xen_vcpu_setup(),
>> while on canceled suspend, the call to xen_hvm_init_shared_info() will make the guest think that vcpu_info
>> is in the shared page. This will cause non-boot cpus keep checking a wrong vcpu_info address and can not handle
>> irqs any more after suspend canceled, for example after we do "xl save -c/restore", PVOPS VM can not be resumed
>> as the cpus can not finish their irqs.
>>
>>
>> Signed-off-by: Charles Ouyang <ouyangzhaowei [at] huawei>
>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky [at] oracle>
>> Reviewed-by: David Vrabel <david.vrabel [at] citrix>
>
> 1. I don't think I offered a reviewed-by tag for this patch
> 2. You did not Cc the xen-devel mailing list on this patch.
> 3. The patch is white-space damaged.
> 4. The commit message has lines longer than ~72 chars.
>
> But I've applied this to for-linus-4.1b anyway, thanks.
>
> David
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] patch about "don't reset vcpu_info on a cancelled suspend"
2015-12-29 5:49 patch about "don't reset vcpu_info on a cancelled suspend" Ouyangzhaowei (Charles)
@ 2016-01-04 11:54 ` David Vrabel
2016-01-07 1:43 ` Ouyangzhaowei (Charles)
2016-01-07 1:43 ` [Xen-devel] " Ouyangzhaowei (Charles)
2016-01-04 11:54 ` David Vrabel
1 sibling, 2 replies; 6+ messages in thread
From: David Vrabel @ 2016-01-04 11:54 UTC (permalink / raw)
To: Ouyangzhaowei (Charles), david.vrabel
Cc: linux-kernel, Zhaojun (Euler), xen-devel, boris.ostrovsky, jinjian
On 29/12/15 05:49, Ouyangzhaowei (Charles) wrote:
> Hi David,
>
> This patch has been applied to for-linus-4.1b, and we wonder if this patch will be applied to linux kernel, or does
> it still needs more test to apply to linux kernel?
Sorry, it looks like I forgot to send a pull request for this patch.
I'd applied it to for-linus-4.5 and tagged it for stable.
David
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: patch about "don't reset vcpu_info on a cancelled suspend"
2015-12-29 5:49 patch about "don't reset vcpu_info on a cancelled suspend" Ouyangzhaowei (Charles)
2016-01-04 11:54 ` [Xen-devel] " David Vrabel
@ 2016-01-04 11:54 ` David Vrabel
1 sibling, 0 replies; 6+ messages in thread
From: David Vrabel @ 2016-01-04 11:54 UTC (permalink / raw)
To: Ouyangzhaowei (Charles), david.vrabel
Cc: xen-devel, boris.ostrovsky, jinjian, linux-kernel, Zhaojun (Euler)
On 29/12/15 05:49, Ouyangzhaowei (Charles) wrote:
> Hi David,
>
> This patch has been applied to for-linus-4.1b, and we wonder if this patch will be applied to linux kernel, or does
> it still needs more test to apply to linux kernel?
Sorry, it looks like I forgot to send a pull request for this patch.
I'd applied it to for-linus-4.5 and tagged it for stable.
David
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] patch about "don't reset vcpu_info on a cancelled suspend"
2016-01-04 11:54 ` [Xen-devel] " David Vrabel
2016-01-07 1:43 ` Ouyangzhaowei (Charles)
@ 2016-01-07 1:43 ` Ouyangzhaowei (Charles)
1 sibling, 0 replies; 6+ messages in thread
From: Ouyangzhaowei (Charles) @ 2016-01-07 1:43 UTC (permalink / raw)
To: David Vrabel
Cc: linux-kernel, Zhaojun (Euler), xen-devel, boris.ostrovsky, jinjian
On 2016/1/4 19:54, David Vrabel wrote:
> On 29/12/15 05:49, Ouyangzhaowei (Charles) wrote:
>> Hi David,
>>
>> This patch has been applied to for-linus-4.1b, and we wonder if this patch will be applied to linux kernel, or does
>> it still needs more test to apply to linux kernel?
>
> Sorry, it looks like I forgot to send a pull request for this patch.
> I'd applied it to for-linus-4.5 and tagged it for stable.
OK, thanks!
>
> David
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: patch about "don't reset vcpu_info on a cancelled suspend"
2016-01-04 11:54 ` [Xen-devel] " David Vrabel
@ 2016-01-07 1:43 ` Ouyangzhaowei (Charles)
2016-01-07 1:43 ` [Xen-devel] " Ouyangzhaowei (Charles)
1 sibling, 0 replies; 6+ messages in thread
From: Ouyangzhaowei (Charles) @ 2016-01-07 1:43 UTC (permalink / raw)
To: David Vrabel
Cc: xen-devel, boris.ostrovsky, jinjian, linux-kernel, Zhaojun (Euler)
On 2016/1/4 19:54, David Vrabel wrote:
> On 29/12/15 05:49, Ouyangzhaowei (Charles) wrote:
>> Hi David,
>>
>> This patch has been applied to for-linus-4.1b, and we wonder if this patch will be applied to linux kernel, or does
>> it still needs more test to apply to linux kernel?
>
> Sorry, it looks like I forgot to send a pull request for this patch.
> I'd applied it to for-linus-4.5 and tagged it for stable.
OK, thanks!
>
> David
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* patch about "don't reset vcpu_info on a cancelled suspend"
@ 2015-12-29 5:49 Ouyangzhaowei (Charles)
0 siblings, 0 replies; 6+ messages in thread
From: Ouyangzhaowei (Charles) @ 2015-12-29 5:49 UTC (permalink / raw)
To: david.vrabel
Cc: linux-kernel, Zhaojun (Euler), xen-devel, boris.ostrovsky, jinjian
Hi David,
This patch has been applied to for-linus-4.1b, and we wonder if this patch will be applied to linux kernel, or does
it still needs more test to apply to linux kernel?
thanks
On 2015.5.28 19:07, David Vrabel wrote:
>> vcpu_info would be reset to wrong place on canceled suspend on PVOPS VM which has multi-cpu
>>
>> The hypervisor continues assuming that vcpu_info is stored in per-cpu data which was set up by xen_vcpu_setup(),
>> while on canceled suspend, the call to xen_hvm_init_shared_info() will make the guest think that vcpu_info
>> is in the shared page. This will cause non-boot cpus keep checking a wrong vcpu_info address and can not handle
>> irqs any more after suspend canceled, for example after we do "xl save -c/restore", PVOPS VM can not be resumed
>> as the cpus can not finish their irqs.
>>
>>
>> Signed-off-by: Charles Ouyang <ouyangzhaowei [at] huawei>
>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky [at] oracle>
>> Reviewed-by: David Vrabel <david.vrabel [at] citrix>
>
> 1. I don't think I offered a reviewed-by tag for this patch
> 2. You did not Cc the xen-devel mailing list on this patch.
> 3. The patch is white-space damaged.
> 4. The commit message has lines longer than ~72 chars.
>
> But I've applied this to for-linus-4.1b anyway, thanks.
>
> David
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-07 1:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-29 5:49 patch about "don't reset vcpu_info on a cancelled suspend" Ouyangzhaowei (Charles)
2016-01-04 11:54 ` [Xen-devel] " David Vrabel
2016-01-07 1:43 ` Ouyangzhaowei (Charles)
2016-01-07 1:43 ` [Xen-devel] " Ouyangzhaowei (Charles)
2016-01-04 11:54 ` David Vrabel
-- strict thread matches above, loose matches on Subject: below --
2015-12-29 5:49 Ouyangzhaowei (Charles)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.