From: Tero Kristo <t-kristo@ti.com> To: Tony Lindgren <tony@atomide.com>, Russell King - ARM Linux <linux@arm.linux.org.uk> Cc: Geert Uytterhoeven <geert@linux-m68k.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>, linux-clk <linux-clk@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [RFC 6/9] clk: ti: add support for omap4 module clocks Date: Mon, 4 Jan 2016 21:15:36 +0200 [thread overview] Message-ID: <568AC4D8.2060509@ti.com> (raw) In-Reply-To: <20160104162853.GA12777@atomide.com> On 01/04/2016 06:37 PM, Tony Lindgren wrote: > * Russell King - ARM Linux <linux@arm.linux.org.uk> [160104 06:43]: >> On Mon, Jan 04, 2016 at 03:27:57PM +0200, Tero Kristo wrote: >>> On 01/04/2016 12:21 PM, Geert Uytterhoeven wrote: >>>> FWIW, there are small loops with just a cpu_relax() in various clock drivers >>>> under drivers/clk/shmobile/. >>> >>> Just did a quick profiling round, and the clk_enable/disable delay loops >>> take anything from 0...1500ns, most typically consuming some 400-600ns. So, >>> based on this, dropping the udelay and adding cpu_relax instead looks like a >>> good change. I just verified that changing the udelay to cpu_relax works >>> fine also, I just need to change the bail-out period to be something sane. >> >> Was that profiling done with lockdep/lock debugging enabled or disabled? omap2plus_defconfig, so lockdep was enabled. The profiling was done around the while {} block though, which should not have any locks within it (except for the SCM clocks, which may explain some of the higher latency numbers seen.) > And also the thing to check from the hw folks is what all do these clkctrl > bits really control. If they group together the OCP clock and an extra > functional clock for some devices the delays could be larger. Does it matter really? The latencies are only imposed to the device in question, and lets face it, the same latencies are there already with the hwmod implementation. This series moves the implementation under clock driver with as less modifications as possible to avoid any problems. > In general, I think we need to get rid of pm_runtime_irq_safe usage to > allow clocks to sleep properly. The other option is to allow toggling > pm_runtime_irq_safe but that probably gets super messy. That is something not to be done with this set though. -Tero
WARNING: multiple messages have this Message-ID (diff)
From: t-kristo@ti.com (Tero Kristo) To: linux-arm-kernel@lists.infradead.org Subject: [RFC 6/9] clk: ti: add support for omap4 module clocks Date: Mon, 4 Jan 2016 21:15:36 +0200 [thread overview] Message-ID: <568AC4D8.2060509@ti.com> (raw) In-Reply-To: <20160104162853.GA12777@atomide.com> On 01/04/2016 06:37 PM, Tony Lindgren wrote: > * Russell King - ARM Linux <linux@arm.linux.org.uk> [160104 06:43]: >> On Mon, Jan 04, 2016 at 03:27:57PM +0200, Tero Kristo wrote: >>> On 01/04/2016 12:21 PM, Geert Uytterhoeven wrote: >>>> FWIW, there are small loops with just a cpu_relax() in various clock drivers >>>> under drivers/clk/shmobile/. >>> >>> Just did a quick profiling round, and the clk_enable/disable delay loops >>> take anything from 0...1500ns, most typically consuming some 400-600ns. So, >>> based on this, dropping the udelay and adding cpu_relax instead looks like a >>> good change. I just verified that changing the udelay to cpu_relax works >>> fine also, I just need to change the bail-out period to be something sane. >> >> Was that profiling done with lockdep/lock debugging enabled or disabled? omap2plus_defconfig, so lockdep was enabled. The profiling was done around the while {} block though, which should not have any locks within it (except for the SCM clocks, which may explain some of the higher latency numbers seen.) > And also the thing to check from the hw folks is what all do these clkctrl > bits really control. If they group together the OCP clock and an extra > functional clock for some devices the delays could be larger. Does it matter really? The latencies are only imposed to the device in question, and lets face it, the same latencies are there already with the hwmod implementation. This series moves the implementation under clock driver with as less modifications as possible to avoid any problems. > In general, I think we need to get rid of pm_runtime_irq_safe usage to > allow clocks to sleep properly. The other option is to allow toggling > pm_runtime_irq_safe but that probably gets super messy. That is something not to be done with this set though. -Tero
next prev parent reply other threads:[~2016-01-04 19:15 UTC|newest] Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-18 13:58 [RFC 0/9] ARM: OMAP4: hwmod clkctrl conversion to DT + clock driver Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 13:58 ` [RFC 1/9] ARM: OMAP2+: omap_device: create clock alias purely from DT data Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 15:16 ` Tony Lindgren 2015-12-18 15:16 ` Tony Lindgren 2015-12-18 13:58 ` [RFC 2/9] ARM: OMAP2+: hwmod: initialize main clocks directly from DT Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 13:58 ` [RFC 3/9] clk: ti: remove un-used definitions from public clk_hw_omap struct Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 13:58 ` [RFC 4/9] clk: ti: mux: export mux clock APIs locally Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 13:58 ` [RFC 5/9] dt-bindings: clk: ti: Document module clock type Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 13:58 ` [RFC 6/9] clk: ti: add support for omap4 module clocks Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 15:36 ` Tony Lindgren 2015-12-18 15:36 ` Tony Lindgren 2016-01-01 5:48 ` Michael Turquette 2016-01-01 5:48 ` Michael Turquette 2016-01-01 5:48 ` Michael Turquette 2016-01-04 7:36 ` Tero Kristo 2016-01-04 7:36 ` Tero Kristo 2016-01-04 7:36 ` Tero Kristo 2016-01-04 10:21 ` Geert Uytterhoeven 2016-01-04 10:21 ` Geert Uytterhoeven 2016-01-04 10:21 ` Geert Uytterhoeven 2016-01-04 13:27 ` Tero Kristo 2016-01-04 13:27 ` Tero Kristo 2016-01-04 14:42 ` Russell King - ARM Linux 2016-01-04 14:42 ` Russell King - ARM Linux 2016-01-04 16:37 ` Tony Lindgren 2016-01-04 16:37 ` Tony Lindgren 2016-01-04 19:15 ` Tero Kristo [this message] 2016-01-04 19:15 ` Tero Kristo 2016-01-05 1:23 ` Michael Turquette 2016-01-05 1:23 ` Michael Turquette 2016-01-05 1:23 ` Michael Turquette 2016-01-05 1:29 ` Michael Turquette 2016-01-05 1:29 ` Michael Turquette 2016-01-05 1:29 ` Michael Turquette 2015-12-18 13:58 ` [RFC 7/9] ARM: dts: omap4: add hwmod " Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 13:58 ` Tero Kristo 2015-12-18 15:06 ` Tony Lindgren 2015-12-18 15:06 ` Tony Lindgren 2015-12-18 13:59 ` [RFC 8/9] ARM: OMAP4: hwmod_data: use module clocks from DT Tero Kristo 2015-12-18 13:59 ` Tero Kristo 2015-12-18 13:59 ` Tero Kristo 2015-12-18 15:11 ` Tony Lindgren 2015-12-18 15:11 ` Tony Lindgren 2015-12-18 13:59 ` [RFC 9/9] clk: ti: omap4: update clock aliases to reflect new module clocks Tero Kristo 2015-12-18 13:59 ` Tero Kristo 2015-12-18 13:59 ` Tero Kristo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=568AC4D8.2060509@ti.com \ --to=t-kristo@ti.com \ --cc=geert@linux-m68k.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=mturquette@baylibre.com \ --cc=sboyd@codeaurora.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.