From: Javier Martinez Canillas <javier@osg.samsung.com> To: Laxman Dewangan <ldewangan@nvidia.com>, lee.jones@linaro.org, alexandre.belloni@free-electrons.com, k.kozlowski@samsung.com Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [PATCH V2 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally Date: Wed, 3 Feb 2016 09:56:42 -0300 [thread overview] Message-ID: <56B1F90A.6030105@osg.samsung.com> (raw) In-Reply-To: <1454491848-26551-6-git-send-email-ldewangan@nvidia.com> Hello Laxman, On 02/03/2016 06:30 AM, Laxman Dewangan wrote: > To make RTC block of MAX77686/MAX77802 as independent driver, > move the registration of i2c device, regmap for register access > and irq_chip for interrupt support inside the RTC driver. > Removed the same initialisation from MFD driver. > > Having this change will allow to reuse this driver for different > PMIC/devices from Maxim Semiconductor if they kept same RTC IP on > different PMIC. Some of examples as PMIC MAX77620, MAX20024 where > same RTC IP used and hence driver for these chips will use this > driver only for RTC support. > > Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> > CC: Javier Martinez Canillas <javier@osg.samsung.com> > [snip] > > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c > index ab1f2cd..10984c4 100644 > --- a/drivers/rtc/rtc-max77686.c > +++ b/drivers/rtc/rtc-max77686.c > @@ -12,6 +12,7 @@ > * > */ > > +#include <linux/i2c.h> > #include <linux/slab.h> > #include <linux/rtc.h> > #include <linux/delay.h> > @@ -22,6 +23,9 @@ > #include <linux/irqdomain.h> > #include <linux/regmap.h> > > +#define MAX77686_I2C_ADDR_RTC (0x0C >> 1) > +#define INVALID_I2C_ADDR (-1) > + Maybe call it MAX77686_INVALID_I2C_ADDR for consistency? The patch looks good modulo the issues pointed out by Krzysztof, so after fixing these feel free to add: Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Since you are going to re-spin another version, I'll wait for that to test. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javier@osg.samsung.com> To: Laxman Dewangan <ldewangan@nvidia.com>, lee.jones@linaro.org, alexandre.belloni@free-electrons.com, k.kozlowski@samsung.com Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: [rtc-linux] Re: [PATCH V2 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally Date: Wed, 3 Feb 2016 09:56:42 -0300 [thread overview] Message-ID: <56B1F90A.6030105@osg.samsung.com> (raw) In-Reply-To: <1454491848-26551-6-git-send-email-ldewangan@nvidia.com> Hello Laxman, On 02/03/2016 06:30 AM, Laxman Dewangan wrote: > To make RTC block of MAX77686/MAX77802 as independent driver, > move the registration of i2c device, regmap for register access > and irq_chip for interrupt support inside the RTC driver. > Removed the same initialisation from MFD driver. > > Having this change will allow to reuse this driver for different > PMIC/devices from Maxim Semiconductor if they kept same RTC IP on > different PMIC. Some of examples as PMIC MAX77620, MAX20024 where > same RTC IP used and hence driver for these chips will use this > driver only for RTC support. > > Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> > CC: Javier Martinez Canillas <javier@osg.samsung.com> > [snip] > > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c > index ab1f2cd..10984c4 100644 > --- a/drivers/rtc/rtc-max77686.c > +++ b/drivers/rtc/rtc-max77686.c > @@ -12,6 +12,7 @@ > * > */ > > +#include <linux/i2c.h> > #include <linux/slab.h> > #include <linux/rtc.h> > #include <linux/delay.h> > @@ -22,6 +23,9 @@ > #include <linux/irqdomain.h> > #include <linux/regmap.h> > > +#define MAX77686_I2C_ADDR_RTC (0x0C >> 1) > +#define INVALID_I2C_ADDR (-1) > + Maybe call it MAX77686_INVALID_I2C_ADDR for consistency? The patch looks good modulo the issues pointed out by Krzysztof, so after fixing these feel free to add: Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Since you are going to re-spin another version, I'll wait for that to test. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-02-03 12:57 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-03 9:30 [PATCH V2 0/5] rtc: max77686: make max77686 rtc driver as IP driver Laxman Dewangan 2016-02-03 9:30 ` [rtc-linux] " Laxman Dewangan 2016-02-03 9:30 ` [PATCH V2 1/5] rtc: max77686: fix checkpatch error Laxman Dewangan 2016-02-03 9:30 ` [rtc-linux] " Laxman Dewangan 2016-02-03 9:30 ` [PATCH V2 2/5] rtc: max77686: use rtc regmap to access RTC registers Laxman Dewangan 2016-02-03 9:30 ` [rtc-linux] " Laxman Dewangan 2016-02-03 9:30 ` [PATCH V2 3/5] rtc: max77686: avoid reference of parent device info multiple palces Laxman Dewangan 2016-02-03 9:30 ` [rtc-linux] " Laxman Dewangan 2016-02-03 12:45 ` Javier Martinez Canillas 2016-02-03 12:45 ` [rtc-linux] " Javier Martinez Canillas 2016-02-03 9:30 ` [PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc i2c client Laxman Dewangan 2016-02-03 9:30 ` [rtc-linux] " Laxman Dewangan 2016-02-03 10:19 ` Krzysztof Kozlowski 2016-02-03 10:19 ` [rtc-linux] " Krzysztof Kozlowski 2016-02-03 12:47 ` Javier Martinez Canillas 2016-02-03 12:47 ` [rtc-linux] " Javier Martinez Canillas 2016-02-03 9:30 ` [PATCH V2 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally Laxman Dewangan 2016-02-03 9:30 ` [rtc-linux] " Laxman Dewangan 2016-02-03 10:45 ` Krzysztof Kozlowski 2016-02-03 10:45 ` [rtc-linux] " Krzysztof Kozlowski 2016-02-03 11:22 ` Krzysztof Kozlowski 2016-02-03 11:22 ` [rtc-linux] " Krzysztof Kozlowski 2016-02-03 13:13 ` Laxman Dewangan 2016-02-03 13:13 ` [rtc-linux] " Laxman Dewangan 2016-02-03 12:56 ` Javier Martinez Canillas [this message] 2016-02-03 12:56 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56B1F90A.6030105@osg.samsung.com \ --to=javier@osg.samsung.com \ --cc=alexandre.belloni@free-electrons.com \ --cc=cw00.choi@samsung.com \ --cc=k.kozlowski@samsung.com \ --cc=ldewangan@nvidia.com \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rtc-linux@googlegroups.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.